validators 2.5.3 → 2.5.4

data/lib/validators/version.rb

@@ -2,7 +2,7 @@ module Validators
   module Version
     MAJOR = 2
     MINOR = 5
-    PATCH = 3
+    PATCH = 4
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/test/test_helper.rb

@@ -0,0 +1,41 @@
+require "simplecov"
+SimpleCov.start
+
+require "bundler/setup"
+require "active_record"
+require "validators"
+require "active_support/all"
+
+require "minitest/utils"
+require "minitest/autorun"
+
+Time.zone = "America/Sao_Paulo"
+TLDs = Validators::TLD.all.sample(50)
+DISPOSABLE_EMAILS = Validators::DisposableHostnames.all.sample(50)
+
+Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each {|f| require f }
+
+ActiveRecord::Base.establish_connection adapter: "sqlite3", database: ":memory:"
+load "schema.rb"
+
+I18n.enforce_available_locales = false
+I18n.load_path << File.dirname(__FILE__) + "/support/translations.yml"
+
+module Minitest
+  class Test
+    setup do
+      I18n.locale = :en
+      Time.zone = "America/Sao_Paulo"
+
+      ActiveRecord::Base.descendants.each do |model|
+        next if %w[ActiveRecord::InternalMetadata ActiveRecord::SchemaMigration].include?(model.name)
+
+        model.delete_all
+
+        Object.class_eval { remove_const model.name if const_defined?(model.name) }
+      end
+
+      load File.dirname(__FILE__) + "/support/models.rb"
+    end
+  end
+end

data/test/validators/disposable_email_test.rb

@@ -0,0 +1,23 @@
+require "test_helper"
+
+class DisposableEmailTest < Minitest::Test
+  DISPOSABLE_EMAILS.each do |domain|
+    test "rejects disposable e-mail (#{domain})" do
+      User.validates_email_format_of :email
+
+      user = User.new(email: "user@#{domain}")
+      user.valid?
+
+      assert_includes user.errors[:email], I18n.t("activerecord.errors.messages.disposable_email")
+    end
+  end
+
+  test "accepts disposable e-mail" do
+    User.validates_email_format_of :email, disposable: true
+
+    user = User.new(email: "user@mailinator.com")
+    user.valid?
+
+    assert user.errors[:email].empty?
+  end
+end

data/test/validators/ip_test.rb

@@ -0,0 +1,21 @@
+require "test_helper"
+
+class IpTest < Minitest::Test
+  VALID_IPV4.each do |ip|
+    test "accepts #{ip.inspect} as ip address (v4)" do
+      assert Validators::Ip.v4?(ip)
+    end
+  end
+
+  VALID_IPV6.each do |ip|
+    test "accepts #{ip.inspect} as ip address (v6)" do
+      assert Validators::Ip.v6?(ip)
+    end
+  end
+
+  (VALID_IPV4 + VALID_IPV6).each do |ip|
+    test "accepts #{ip.inspect} as ip address" do
+      assert Validators::Ip.valid?(ip)
+    end
+  end
+end

data/{spec/validators/validates_cnpj_format_of_spec.rb → test/validators/validates_cnpj_format_of_test.rb}

@@ -1,6 +1,6 @@
-require "spec_helper"
+require "test_helper"
 
-describe ".validates_cnpj_format_of" do
+class ValidatesCnpjFormatOfTest < Minitest::Test
   let(:model) { Class.new {
     def self.name
       "User"
@@ -11,33 +11,33 @@ describe ".validates_cnpj_format_of" do
     attr_accessor :document
   } }
 
-  it "requires valid CNPJ" do
+  test "requires valid CNPJ" do
     record = model.new(document: "invalid")
     record.valid?
 
-    expect(record.errors[:document]).not_to be_empty
+    refute record.errors[:document].empty?
   end
 
-  it "accepts formatted CNPJ" do
+  test "accepts formatted CNPJ" do
     record = model.new(document: CNPJ.generate(true))
     record.valid?
 
-    expect(record.errors[:document]).to be_empty
+    assert record.errors[:document].empty?
   end
 
-  it "accepts stripped CNPJ" do
+  test "accepts stripped CNPJ" do
     record = model.new(document: CNPJ.generate)
     record.valid?
 
-    expect(record.errors[:document]).to be_empty
+    assert record.errors[:document].empty?
   end
 
-  it "sets translated error message" do
+  test "sets translated error message" do
     I18n.locale = "pt-BR"
 
     record = model.new
     record.valid?
 
-    expect(record.errors[:document]).to include("não é um CNPJ válido")
+    assert_includes record.errors[:document], "não é um CNPJ válido"
   end
 end

data/{spec/validators/validates_cpf_format_of_spec.rb → test/validators/validates_cpf_format_of_test.rb}

@@ -1,6 +1,6 @@
-require "spec_helper"
+require "test_helper"
 
-describe ".validates_cpf_format_of" do
+class ValidatesCpfFormatOfTest < Minitest::Test
   let(:model) { Class.new {
     def self.name
       "User"
@@ -11,33 +11,33 @@ describe ".validates_cpf_format_of" do
     attr_accessor :document
   } }
 
-  it "requires valid CPF" do
+  test "requires valid CPF" do
     record = model.new(document: "invalid")
     record.valid?
 
-    expect(record.errors[:document]).not_to be_empty
+    refute record.errors[:document].empty?
   end
 
-  it "accepts formatted CPF" do
+  test "accepts formatted CPF" do
     record = model.new(document: CPF.generate(true))
     record.valid?
 
-    expect(record.errors[:document]).to be_empty
+    assert record.errors[:document].empty?
   end
 
-  it "accepts stripped CPF" do
+  test "accepts stripped CPF" do
     record = model.new(document: CPF.generate)
     record.valid?
 
-    expect(record.errors[:document]).to be_empty
+    assert record.errors[:document].empty?
   end
 
-  it "sets translated error message" do
+  test "sets translated error message" do
     I18n.locale = "pt-BR"
 
     record = model.new
     record.valid?
 
-    expect(record.errors[:document]).to include("não é um CPF válido")
+    assert_includes record.errors[:document], "não é um CPF válido"
   end
 end

data/test/validators/validates_datetime/after_option_test.rb

@@ -0,0 +1,75 @@
+require "test_helper"
+
+class ValidatesDatetimeAfterOptionTest < Minitest::Test
+  let(:user) { User.new }
+
+  test "rejects when date is set to before :after option" do
+    future_date = 1.week.from_now
+    User.validates_datetime :registered_at, :after => future_date
+    user.registered_at = Time.now
+
+    refute user.valid?
+    assert_includes user.errors[:registered_at], "needs to be after #{I18n.l(future_date)}"
+  end
+
+  test "accepts when date is set accordingly to the :after option" do
+    User.validates_datetime :registered_at, :after => 1.week.from_now
+    user.registered_at = 2.weeks.from_now
+
+    assert user.valid?
+  end
+
+  test "validates using today as date" do
+    User.validates_datetime :registered_at, :after => :today
+
+    user.registered_at = Time.now
+    refute user.valid?
+
+    user.registered_at = Date.today
+    refute user.valid?
+
+    user.registered_at = Date.tomorrow
+    assert user.valid?
+
+    user.registered_at = 1.day.from_now
+    assert user.valid?
+  end
+
+  test "validates using now as date" do
+    User.validates_datetime :registered_at, :after => :now
+
+    user.registered_at = Time.now
+    refute user.valid?
+
+    user.registered_at = Date.today
+    refute user.valid?
+
+    user.registered_at = Date.tomorrow
+    assert user.valid?
+
+    user.registered_at = 1.day.from_now
+    assert user.valid?
+  end
+
+  test "validates using method as date" do
+    User.validates_datetime :starts_at
+    User.validates_datetime :ends_at, :after => :starts_at, :if => :starts_at?
+
+    user.starts_at = nil
+    user.ends_at = Time.now
+
+    refute user.valid?
+    assert user.errors[:ends_at].empty?
+
+    user.starts_at = Time.parse("Apr 26 2010")
+    user.ends_at = Time.parse("Apr 25 2010")
+
+    refute user.valid?
+    assert_includes user.errors[:ends_at], "needs to be after #{I18n.l(Time.parse("Apr 26 2010"))}"
+
+    user.starts_at = Time.now
+    user.ends_at = 1.hour.from_now
+
+    assert user.valid?
+  end
+end

data/test/validators/validates_datetime/before_option_test.rb

@@ -0,0 +1,20 @@
+require "test_helper"
+
+class ValidatesDatetimeBeforeOptionTest < Minitest::Test
+  let(:user) { User.new }
+
+  test "rejects when date is set to after :before option" do
+    User.validates_datetime :registered_at, :before => 1.week.ago
+    user.registered_at = Time.now
+
+    refute user.valid?
+    assert_includes user.errors[:registered_at], "needs to be before #{I18n.l(1.week.ago)}"
+  end
+
+  test "accepts when date is set accordingly to the :before option" do
+    User.validates_datetime :registered_at, :before => 1.week.ago
+    user.registered_at = 2.weeks.ago
+
+    assert user.valid?
+  end
+end

data/test/validators/validates_datetime/defaults_test.rb

@@ -0,0 +1,37 @@
+require "test_helper"
+
+class ValidatesDatetimeDefaultsTest < Minitest::Test
+  let(:user) { User.new }
+
+  setup do
+    User.validates_datetime :registered_at
+    User.validates :birthday, :datetime => true
+  end
+
+  VALID_DATES.each do |date|
+    test "accepts #{date.inspect} as valid date" do
+      user.registered_at = date
+      user.birthday = date
+
+      assert user.valid?
+    end
+  end
+
+  INVALID_DATES.each do |date|
+    test "rejects #{date.inspect} as valid date" do
+      user.registered_at = date
+      user.birthday = date
+
+      refute user.valid?
+      refute user.errors[:registered_at].empty?
+      refute user.errors[:birthday].empty?
+    end
+  end
+
+  test "includes default error message" do
+    user.registered_at = nil
+
+    refute user.valid?
+    assert_includes user.errors[:registered_at], "is not a valid date"
+  end
+end

data/test/validators/validates_email_format_of_test.rb

@@ -0,0 +1,76 @@
+require "test_helper"
+
+class ValidatesEmailFormatOfTest < Minitest::Test
+  setup do
+    User.validates_email_format_of :email, :corporate_email, :allow_blank => false
+    Buyer.validates_email_format_of :email, :message => "is not a valid e-mail"
+    Person.validates :email, :email => true
+  end
+
+  VALID_EMAILS.each do |email|
+    test "accepts #{email.inspect} as a valid email" do
+      user = User.new(:email => email, :corporate_email => email)
+      assert user.valid?
+
+      user = Person.new(:email => email)
+      assert user.valid?
+    end
+  end
+
+  INVALID_EMAILS.each do |email|
+    test "rejects #{email.inspect} as a valid email" do
+      user = User.new(:email => "invalid", :corporate_email => "invalid")
+      refute user.valid?
+
+      user = Person.new(:email => "invalid")
+      refute user.valid?
+    end
+  end
+
+  test "uses default error message" do
+    user = User.new(:email => "invalid")
+
+    refute user.valid?
+    assert_includes user.errors[:email], "is not a valid address"
+  end
+
+  test "rejects nil value" do
+    user = User.new(:email => nil)
+
+    refute user.valid?
+    refute user.errors[:email].empty?
+  end
+
+  test "rejects empty value" do
+    user = User.new(:email => "")
+
+    refute user.valid?
+    refute user.errors[:email].empty?
+  end
+
+  test "validates multiple attributes" do
+    user = User.new(:corporate_email => "invalid")
+
+    refute user.valid?
+    assert_includes user.errors[:corporate_email], "is not a valid address"
+  end
+
+  test "uses custom error message as :message options" do
+    buyer = Buyer.new(:email => "invalid")
+
+    refute buyer.valid?
+    assert_includes buyer.errors[:email], "is not a valid e-mail"
+  end
+
+  test "uses I18n string as error message [pt-BR]" do
+    I18n.locale = :'pt-BR'
+    user = User.new(:email => "invalid")
+
+    refute user.valid?
+    assert_includes user.errors[:email], "não parece ser um e-mail válido"
+  end
+
+  test "defines alias method" do
+    assert User.respond_to?(:validates_email)
+  end
+end

data/test/validators/validates_hostname_format_of/with_tld_validation_test.rb

@@ -0,0 +1,25 @@
+require "test_helper"
+
+class WithTldValidationTest < Minitest::Test
+  test "rejects invalid TLD" do
+    server = ServerWithTLD.new("example.xy")
+    refute server.valid?
+  end
+
+  test "rejects only host label" do
+    server = ServerWithTLD.new("com")
+    refute server.valid?
+  end
+
+  TLDs.each do |tld|
+    test "accepts #{tld} as TLD" do
+      server = ServerWithTLD.new("example.#{tld}")
+      assert server.valid?
+    end
+  end
+
+  test "accepts example.com.br" do
+    server = ServerWithTLD.new("example.com.br")
+    assert server.valid?
+  end
+end

data/test/validators/validates_hostname_format_of/without_tld_validation_test.rb

@@ -0,0 +1,27 @@
+require "test_helper"
+
+class WithoutTldValidationTest < Minitest::Test
+  VALID_HOSTNAMES.each do |host|
+    test "accepts #{host}" do
+      server = ServerWithoutTLD.new(host)
+      assert server.valid?
+    end
+  end
+
+  INVALID_HOSTNAMES.each do |host|
+    test "rejects #{host}" do
+      server = ServerWithoutTLD.new(host)
+      refute server.valid?
+    end
+  end
+
+  test "rejects nil hostname" do
+    server = ServerWithoutTLD.new(nil)
+    refute server.valid?
+  end
+
+  test "rejects blank hostname" do
+    server = ServerWithoutTLD.new("")
+    refute server.valid?
+  end
+end

data/test/validators/validates_ip_address/ipv4_test.rb

@@ -0,0 +1,20 @@
+require "test_helper"
+
+class Ipv4Test < Minitest::Test
+  let(:user) { User.new }
+
+  test "is valid" do
+    User.validates_ip_address :url, :only => :v4
+    user.url = "192.168.1.2"
+
+    assert user.valid?
+  end
+
+  test "is invalid" do
+    User.validates_ip_address :url, :only => :v4
+    user.url = "FE80:0000:0000:0000:0202:B3FF:FE1E:8329"
+
+    refute user.valid?
+    assert_includes user.errors[:url], "is not a valid IPv4 address"
+  end
+end

data/test/validators/validates_ip_address/ipv6_test.rb

@@ -0,0 +1,20 @@
+require "test_helper"
+
+class Ipv6Test < Minitest::Test
+  let(:user) { User.new }
+
+  test "is valid" do
+    User.validates_ip_address :url, :only => :v6
+    user.url = "FE80:0000:0000:0000:0202:B3FF:FE1E:8329"
+
+    assert user.valid?
+  end
+
+  test "is invalid" do
+    User.validates_ip_address :url, :only => :v6
+    user.url = "192.168.1.2"
+
+    refute user.valid?
+    assert_includes user.errors[:url], "is not a valid IPv6 address"
+  end
+end

data/test/validators/validates_ip_address_test.rb

@@ -0,0 +1,33 @@
+require "test_helper"
+
+class ValidatesIpAddressTest < Minitest::Test
+  let(:user) { User.new }
+
+  test "is valid with IPv4" do
+    User.validates_ip_address :url
+    user.url = "192.168.1.2"
+
+    assert user.valid?
+  end
+
+  test "is valid with IPv6" do
+    User.validates_ip_address :url
+    user.url = "FE80:0000:0000:0000:0202:B3FF:FE1E:8329"
+
+    assert user.valid?
+  end
+
+  test "allows blank values" do
+    User.validates_ip_address :url, :allow_blank => true
+    user.url = ""
+
+    assert user.valid?
+  end
+
+  test "allows nil values" do
+    User.validates_ip_address :url, :allow_nil => true
+    user.url = nil
+
+    assert user.valid?
+  end
+end

data/test/validators/validates_ownership_of_test.rb

@@ -0,0 +1,65 @@
+require "test_helper"
+
+class ValidatesOwnershipOfTest < Minitest::Test
+  let(:user) { User.create! }
+  let(:another_user) { User.create! }
+  let(:category) { Category.create!(:user => user) }
+  let(:another_category) { Category.create!(:user => another_user) }
+  let(:task) { Task.new(:user => user, :category => category) }
+
+  setup do
+    user
+    another_user
+    category
+    another_category
+    task
+
+    Task.validates_ownership_of :category, :with => :user
+  end
+
+  test "is valid when record is owned by the correct user" do
+    assert task.valid?
+  end
+
+  test "is invalid when record is owned by a different user" do
+    task.category = another_category
+    refute task.valid?
+  end
+
+  test "raises error without :with option" do
+    assert_raises(ArgumentError) { Task.validates_ownership_of :category }
+  end
+
+  test "raises error when :with options is not a valid type" do
+    assert_raises(ArgumentError) { Task.validates_ownership_of :category, :with => user }
+  end
+
+  test "is invalid when owner is not present" do
+    task.user = nil
+    refute task.valid?
+  end
+
+  test "is invalid when attribute owner is not present" do
+    task.category.user = nil
+    refute task.valid?
+  end
+
+  test "is valid when both owners are nil" do
+    task.category.user = nil
+    task.user = nil
+
+    assert task.valid?
+  end
+
+  test "is valid when attribute is nil" do
+    task.category = nil
+    assert task.valid?
+  end
+
+  test "sets error message" do
+    task.user = nil
+
+    refute task.valid?
+    assert_includes task.errors[:category], "is not associated with your user"
+  end
+end

data/test/validators/validates_ssh_private_key/bits_test.rb

@@ -0,0 +1,44 @@
+require "test_helper"
+
+class BitsTest < Minitest::Test
+  let(:model) { Class.new {
+    def self.name
+      "User"
+    end
+
+    include ActiveModel::Model
+    validates_ssh_private_key :key, bits: 2048
+    attr_accessor :key
+  } }
+
+  test "accepts bits equals to required" do
+    record = model.new(key: SSHKey.generate(bits: 2048).private_key)
+    record.valid?
+
+    assert record.errors[:key].empty?
+  end
+
+  test "accepts bits greater than required" do
+    record = model.new(key: SSHKey.generate(bits: 4096).private_key)
+    record.valid?
+
+    assert record.errors[:key].empty?
+  end
+
+  test "rejects invalid bits" do
+    record = model.new(key: SSHKey.generate(bits: 1024).private_key)
+    record.valid?
+
+    refute record.errors[:key].empty?
+  end
+
+  test "sets translated error message" do
+    I18n.locale = "pt-BR"
+    message = "precisa ter pelo menos 2048 bits; a sua chave tem 1024 bits"
+
+    record = model.new(key: SSHKey.generate(bits: 1024).private_key)
+    record.valid?
+
+    assert_includes record.errors[:key], message
+  end
+end