validators 2.4.2 → 2.5.0

data/lib/validators/disposable_hostnames.rb

@@ -0,0 +1,9 @@
+module Validators
+  class DisposableHostnames
+    FILE_PATH = File.expand_path("../../../data/disposable.json", __FILE__)
+
+    def self.all
+      @tld ||= JSON.load(File.read(FILE_PATH))
+    end
+  end
+end

data/lib/validators/tld.rb

@@ -1,9 +1,9 @@
 module Validators
   class TLD
-    TLD_FILE_PATH = File.expand_path('../../../data/tld.txt', __FILE__)
+    FILE_PATH = File.expand_path("../../../data/tld.json", __FILE__)
 
     def self.all
-      @tld ||= File.read(TLD_FILE_PATH).lines.map(&:chomp)
+      @tld ||= JSON.load(File.read(FILE_PATH))
     end
 
     def self.host_with_valid_tld?(host)

data/lib/validators/validates_email_format_of.rb

@@ -2,9 +2,16 @@ module ActiveModel
   module Validations
     class EmailValidator < EachValidator
       def validate_each(record, attribute, value)
+        allow_disposable = options.fetch(:disposable, false)
+
         return if value.blank? && options[:allow_blank]
         return if value.nil? && options[:allow_nil]
 
+        validate_email_format(record, attribute, value, options)
+        validate_disposable_email(record, attribute, value, options) unless allow_disposable
+      end
+
+      def validate_email_format(record, attribute, value, options)
         if value.to_s !~ Validators::EMAIL_FORMAT
           record.errors.add(
             attribute, :invalid_email,
@@ -12,6 +19,15 @@ module ActiveModel
           )
         end
       end
+
+      def validate_disposable_email(record, attribute, value, options)
+        hostname = value.to_s.split("@").last
+
+        record.errors.add(
+          attribute, :disposable_email,
+          :value => value
+        ) if Validators::DisposableHostnames.all.include?(hostname)
+      end
     end
 
     module ClassMethods

data/lib/validators/version.rb

@@ -1,8 +1,8 @@
 module Validators
   module Version
     MAJOR = 2
-    MINOR = 4
-    PATCH = 2
+    MINOR = 5
+    PATCH = 0
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/lib/validators.rb

@@ -1,7 +1,10 @@
+require "json"
+
 module Validators
   require "validators/constants"
   require "validators/ip"
   require "validators/tld"
+  require "validators/disposable_hostnames"
   require "validators/validates_datetime"
   require "validators/validates_ip_address"
   require "validators/validates_email_format_of"

data/spec/spec_helper.rb

@@ -7,7 +7,8 @@ require "validators"
 require "active_support/all"
 
 Time.zone = "America/Sao_Paulo"
-TLDs = Validators::TLD.all.sample(100)
+TLDs = Validators::TLD.all.sample(50)
+DISPOSABLE_EMAILS = Validators::DisposableHostnames.all.sample(50)
 
 Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each {|f| require f}
 

data/spec/support/translations.yml

@@ -14,6 +14,7 @@ en:
         invalid_owner: "is not associated with your user"
         invalid_cpf: "is not a valid CPF"
         invalid_cnpj: "is not a valid CNPJ"
+        disposable_email: "is not allowed (high-bounce domain)"
 
   activemodel:
     <<: *activerecord

data/spec/validators/disposable_email_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+describe ".validates_email_format_of" do
+  context "when using disposable e-mail" do
+    before do
+      User.validates_email_format_of :email
+    end
+
+    DISPOSABLE_EMAILS.each do |domain|
+      it "rejects disposable e-mail (#{domain})" do
+        user = User.new(email: "user@#{domain}")
+        user.valid?
+
+        expect(user.errors[:email]).to include(I18n.t('activerecord.errors.messages.disposable_email'))
+      end
+    end
+  end
+
+  context "disable disposable e-mail" do
+    before do
+      User.validates_email_format_of :email, disposable: true
+    end
+
+    it "accepts e-mail" do
+      user = User.new(email: "user@mailinator.com")
+      user.valid?
+
+      expect(user.errors[:email]).to be_empty
+    end
+  end
+end

data/spec/validators/validates_email_format_of_spec.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 require "spec_helper"
 
 describe ".validates_email_format_of" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validators
 version: !ruby/object:Gem::Version
-  version: 2.4.2
+  version: 2.5.0
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-01 00:00:00.000000000 Z
+date: 2015-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -133,12 +133,13 @@ files:
 - ".rspec"
 - ".travis.yml"
 - Gemfile
-- Gemfile.lock
 - README.md
 - Rakefile
-- data/tld.txt
+- data/disposable.json
+- data/tld.json
 - lib/validators.rb
 - lib/validators/constants.rb
+- lib/validators/disposable_hostnames.rb
 - lib/validators/ip.rb
 - lib/validators/tld.rb
 - lib/validators/validates_cnpj_format_of.rb
@@ -161,6 +162,7 @@ files:
 - spec/support/models.rb
 - spec/support/translations.yml
 - spec/support/urls.rb
+- spec/validators/disposable_email_spec.rb
 - spec/validators/ip_spec.rb
 - spec/validators/validates_cnpj_format_of_spec.rb
 - spec/validators/validates_cpf_format_of_spec.rb
@@ -206,6 +208,7 @@ test_files:
 - spec/support/models.rb
 - spec/support/translations.yml
 - spec/support/urls.rb
+- spec/validators/disposable_email_spec.rb
 - spec/validators/ip_spec.rb
 - spec/validators/validates_cnpj_format_of_spec.rb
 - spec/validators/validates_cpf_format_of_spec.rb

data/Gemfile.lock

@@ -1,94 +0,0 @@
-PATH
-  remote: .
-  specs:
-    validators (2.4.2)
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    activemodel (4.2.1)
-      activesupport (= 4.2.1)
-      builder (~> 3.1)
-    activerecord (4.2.1)
-      activemodel (= 4.2.1)
-      activesupport (= 4.2.1)
-      arel (~> 6.0)
-    activesupport (4.2.1)
-      i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
-      minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
-      tzinfo (~> 1.1)
-    arel (6.0.0)
-    awesome_print (1.6.1)
-    builder (3.2.2)
-    byebug (4.0.4)
-      columnize (= 0.9.0)
-    codeclimate-test-reporter (0.4.7)
-      simplecov (>= 0.7.1, < 1.0.0)
-    coderay (1.1.0)
-    columnize (0.9.0)
-    cpf_cnpj (0.2.1)
-    diff-lcs (1.2.5)
-    docile (1.1.5)
-    i18n (0.7.0)
-    json (1.8.2)
-    method_source (0.8.2)
-    minitest (5.5.1)
-    multi_json (1.11.0)
-    pry (0.10.1)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    pry-byebug (3.1.0)
-      byebug (~> 4.0)
-      pry (~> 0.10)
-    pry-meta (0.0.10)
-      awesome_print
-      pry
-      pry-byebug
-      pry-remote
-    pry-remote (0.1.8)
-      pry (~> 0.9)
-      slop (~> 3.0)
-    rake (10.4.2)
-    rspec (3.2.0)
-      rspec-core (~> 3.2.0)
-      rspec-expectations (~> 3.2.0)
-      rspec-mocks (~> 3.2.0)
-    rspec-core (3.2.2)
-      rspec-support (~> 3.2.0)
-    rspec-expectations (3.2.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.2.0)
-    rspec-mocks (3.2.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.2.0)
-    rspec-support (3.2.2)
-    simplecov (0.9.2)
-      docile (~> 1.1.0)
-      multi_json (~> 1.0)
-      simplecov-html (~> 0.9.0)
-    simplecov-html (0.9.0)
-    slop (3.6.0)
-    sqlite3 (1.3.10)
-    sqlite3-ruby (1.3.3)
-      sqlite3 (>= 1.3.3)
-    sshkey (1.6.1)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
-      thread_safe (~> 0.1)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activerecord (>= 3.0)
-  codeclimate-test-reporter
-  cpf_cnpj
-  pry-meta
-  rake
-  rspec
-  sqlite3-ruby
-  sshkey
-  validators!