validator-nric 0.0.2 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f3d2261299c9420bd15c70344beee9816fcfa6a2
-  data.tar.gz: 4de48ec5f800036bb0b03d789e4f6db96903a31c
+SHA256:
+  metadata.gz: cec0caa9bd7fb0e495c18a1fea4ebb1632f694af52a2e5a442b42f790ba170aa
+  data.tar.gz: 5b9b3a5c5fda09703e61daad09ae1c0abbe683fd5ce66b02cda40f6d7fee210d
 SHA512:
-  metadata.gz: 8f1b4f96be687f9257aa076b12c334af8a67fb992b356bd09092ad47bd8c669099aa6697522ac00ab3d063dce25857fd9fc3e890e052e03e1f098063b87dd95d
-  data.tar.gz: 594a8c6e2a3b833ac89f3e74313fec00161dedc258b9ac4ba29282e751a5a4825b91d7fbdc65dc94b8f868b74c5e4606aa882368c1910ca6a94360fe2854a7db
+  metadata.gz: a520bd88808ecb03e86db1412280d8b54e37449d12cc2530bad900df3f1dfa95f322d995d62367152af457aeacb958765cfe1c0e275d411d1001fb9f45c23f9f
+  data.tar.gz: 7fcc78da566007b736b2c182f9e3b22d6b725f1f5001c76f9ba3dad32d690d51becdd5f6c9ecd4dc20ebadf785ec0dfcf2b56e0b040fa876d15cd2dd7c5f2f9f

data/.rubocop.yml

@@ -5,3 +5,6 @@ AllCops:
 
 Documentation:
   Enabled: false
+
+Metrics/BlockLength:
+  Max: 50

data/lib/validator/nric/version.rb

@@ -1,5 +1,5 @@
 module Validator
   module Nric
-    VERSION = '0.0.2'
+    VERSION = '0.0.4'.freeze
   end
 end

data/lib/validator/nric.rb

@@ -12,21 +12,23 @@ module Validator
     module_function
 
     # The multiplier for each individual digit
-    WEIGHT = [2, 7, 6, 5, 4, 3, 2]
+    WEIGHT = [2, 7, 6, 5, 4, 3, 2].freeze
 
     # Century prefix lookup tables
     #
     # S - Born before 2000. S is the 19th alphabet denoting (1900 - 1999)
     # T - Born in 2000 and beyong. (2000 - 2099??)
     # F - Foreigners with pass issued before 2000
-    # G - Foreigners with pass issued after 2000
+    # G - Foreigners with pass issued between 2000 and 2022
+    # M - Foreigners with pass issued after 2022
     #
     # Notice the it is backward of ABCDEFGHIZJ
     # For T and G, there is a shift of 4 places
-    S_TABLE = %w(J Z I H G F E D C B A)
-    T_TABLE = %w(G F E D C B A J Z I H)
-    F_TABLE = %w(X W U T R Q P N M L K)
-    G_TABLE = %w(R Q P N M L K X W U T)
+    S_TABLE = %w(J Z I H G F E D C B A).freeze
+    T_TABLE = %w(G F E D C B A J Z I H).freeze
+    F_TABLE = %w(X W U T R Q P N M L K).freeze
+    G_TABLE = %w(R Q P N M L K X W U T).freeze
+    M_TABLE = %w(T R Q P N J L K X W U).freeze
 
     def mod(value)
       ic_array = value.each_char.map(&:to_i)
@@ -39,8 +41,8 @@ module Validator
 
     def check(nric)
       return false if nric.nil? || nric.size != 9
-      nric.upcase!
-      return false unless %w(S T F G).include?(nric[0])
+      nric = nric.upcase
+      return false unless %w(S T F G M).include?(nric[0])
 
       century_prefix = nric[0, 1]
       ic_number = nric[1, 7]

data/spec/spec_helper.rb

@@ -87,5 +87,4 @@ RSpec.configure do |config|
   # test failures related to randomization by passing the same `--seed` value
   # as the one that triggered the failure.
   Kernel.srand config.seed
-
 end

data/spec/validator/nric_spec.rb

@@ -1,5 +1,4 @@
 RSpec.describe Validator::Nric do
-
   describe 'check' do
     it 'returns false if nric is nil' do
       expect(subject.check(nil)).to be false
@@ -13,6 +12,13 @@ RSpec.describe Validator::Nric do
       expect(subject.check('111111111')).to be false
       expect(subject.check('XXXXXXXXX')).to be false
     end
+
+    it 'validates M series' do # taken from https://samliew.com/nric-generator
+      %w(M1987714T M1818317R M1090782Q M1803902P M1530517N M6193641J
+         M5140500L M7357583K M8721122X M1081075W M1954378U).each do |value|
+        expect(subject.check(value)).to be true
+      end
+    end
   end
 
   describe 'mod' do
@@ -40,5 +46,4 @@ RSpec.describe Validator::Nric do
       expect(subject.lookup('S', 10)).to eq 'A'
     end
   end
-
 end

data/validator-nric.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.7'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.1'
+  spec.add_development_dependency 'bundler', '~> 2'
+  spec.add_development_dependency 'rake', '~> 13'
+  spec.add_development_dependency 'rspec', '~> 3'
   spec.add_development_dependency 'rubocop'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validator-nric
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - mech
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-12-11 00:00:00.000000000 Z
+date: 2023-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -90,7 +90,7 @@ homepage: https://github.com/mech/validator-nric
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -105,12 +105,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.2
-signing_key: 
+rubygems_version: 3.3.18
+signing_key:
 specification_version: 4
 summary: Validates Singapore NRIC
 test_files:
 - spec/spec_helper.rb
 - spec/validator/nric_spec.rb
-has_rdoc: