validation_auditor 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8664c5178740a633a0bb4aaa9a45759f42d89172
-  data.tar.gz: 30bfae7d982876df10bed64f044e6b23f7c8fb97
+  metadata.gz: df3fdbc82541c85c7c13bddebe3a18a4a7b8d50e
+  data.tar.gz: 698944970c971bf99d30eeec61782f75496e6c3d
 SHA512:
-  metadata.gz: 230cc22ca8f65f389fd187f78f41a126e0dae8270a2f9d019b2ca9d8f52792c705c8e0a9e7041f0aaccbd703dcdc401b91f765366e3a58e65ee677d4e9130583
-  data.tar.gz: 94dbfbff65772ff7a50b9d275db2365f07bfc4caf3122808ebcc9127bf024bb6ebc2f8db29bbe4d928e6923056ebe3fda055c4bc85534b8f0cc00d9cf08edf2f
+  metadata.gz: bf9fd4135a3a550911658e1670a1bfa16080503dbca7a683c0da183da04553149cb4a0d65267430dd2267b2e1a3e525ff659b88eeea7328e42dbdba7e5cae96a
+  data.tar.gz: 0b93eba5ec3321b8fb09cf5b9e31ea695312a9daf08a31ceb637a083649c770a618b17f555d6adf4a299cbf18185154ca3c7ee63a543eda015de669724417352

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## validation_auditor 0.2.1 (Sep 5, 2014) ##
+
+* When cleaning params to save them as yaml, also clean each element of arrays.
+
 ## validation_auditor 0.2.0 (Jul 23, 2014) ##
 
 * Respect the filter_parameters configuration from Rails.

data/lib/validation_auditor.rb

@@ -41,18 +41,20 @@ module ValidationAuditor
     end
 
     # Clean parameters before storing them in the database.
-    def self.clean_params(params)
-      cleaned_params = {}
-      params.each do |k, v|
-        cleaned_params[k] = if v.is_a? Hash
-                              clean_params(v) # clean params recursively.
-                            elsif v.is_a? ActionDispatch::Http::UploadedFile
-                              v.inspect # UploadedFiles cannot be yaml-serialized, so, we replace them with a string.
-                            else
-                              v
-                            end
+    def self.clean_params(param)
+      if param.is_a? Hash
+        cleaned_params = {}
+        param.each do |k, v|
+          cleaned_params[k] = clean_params(v) # clean each value
+        end
+        cleaned_params
+      elsif param.is_a? Array
+        param.map { |v| clean_params(v) } # clean each value
+      elsif param.is_a? ActionDispatch::Http::UploadedFile
+        param.inspect # UploadedFiles cannot be yaml-serialized, so, we replace them with a string.
+      else
+        param
       end
-      cleaned_params
     end
   end
 

data/lib/validation_auditor/version.rb

@@ -2,5 +2,5 @@
 # Copyright © 2014, Watu
 
 module ValidationAuditor
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/test/controller_test.rb

@@ -40,9 +40,11 @@ class ControllerTest < ActionController::TestCase
   end
 
   should "clean params" do
-    cleaned_params = ValidationAuditor::Controller.clean_params({name: "John Doe", deep: {structure: {with: {file: ActionDispatch::Http::UploadedFile.new(tempfile: Tempfile.new("test.txt"))}}}})
+    cleaned_params = ValidationAuditor::Controller.clean_params({name: "John Doe", deep: {structure: {with: {file: ActionDispatch::Http::UploadedFile.new(tempfile: Tempfile.new("test.txt")), and_files: [ActionDispatch::Http::UploadedFile.new(tempfile: Tempfile.new("test.txt"))]}}}})
     assert_equal "John Doe", cleaned_params[:name]
     assert cleaned_params[:deep][:structure][:with][:file].is_a? String
+    assert cleaned_params[:deep][:structure][:with][:and_files].is_a? Array
+    assert cleaned_params[:deep][:structure][:with][:and_files].first.is_a? String
   end
 
   should "not create a validation audit due to no validation failing when creating a new record" do
@@ -65,7 +67,7 @@ class ControllerTest < ActionController::TestCase
 
   should "create a validation audit even when an uploaded file is in the params" do
     assert_difference "ValidationAuditor::ValidationAudit.count" => +1 do
-      post :create, audited_record: {name: "John Doe"}, deep: {structure: {with: {file: ActionDispatch::Http::UploadedFile.new(tempfile: Tempfile.new("test.txt"))}}} # Missing email and a deep structure with a file in it.
+      post :create, audited_record: {name: "John Doe"}, deep: {structure: {with: {file: ActionDispatch::Http::UploadedFile.new(tempfile: Tempfile.new("test.txt")), and_files: [ActionDispatch::Http::UploadedFile.new(tempfile: Tempfile.new("test.txt"))]}}} # Missing email and a deep structure with a file in it.
     end
     audit = ValidationAuditor::ValidationAudit.order(:id).last
     assert_nil audit.record # New records cannot be referenced because they don't exist...

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validation_auditor
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - J. Pablo Fernández
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-23 00:00:00.000000000 Z
+date: 2014-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord