validation_auditor 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 411fc2578c6e75c4dd673dcaf450b9d983afee48
-  data.tar.gz: d43b3a6365daf49c9ab70203ea90e5dc4fcaa9b8
+  metadata.gz: 8664c5178740a633a0bb4aaa9a45759f42d89172
+  data.tar.gz: 30bfae7d982876df10bed64f044e6b23f7c8fb97
 SHA512:
-  metadata.gz: ed77c23dc4170250a96ab8affc6d9893dc7283418d494a21600d567cd9c1fb941364bf5746e9fe57a214c170f9295c95eda7abf269cd524b8451559e95ff519c
-  data.tar.gz: 8e0ccfef2d9faf289a1a896574ae9bf5eb50686f39938478ce1bb55e70e30a14ea2f98d46bfc03e94a50e829f07941e004129abba548b657cb70ae4d5026f747
+  metadata.gz: 230cc22ca8f65f389fd187f78f41a126e0dae8270a2f9d019b2ca9d8f52792c705c8e0a9e7041f0aaccbd703dcdc401b91f765366e3a58e65ee677d4e9130583
+  data.tar.gz: 94dbfbff65772ff7a50b9d275db2365f07bfc4caf3122808ebcc9127bf024bb6ebc2f8db29bbe4d928e6923056ebe3fda055c4bc85534b8f0cc00d9cf08edf2f

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## validation_auditor 0.2.0 (Jul 23, 2014) ##
+
+* Respect the filter_parameters configuration from Rails.
+
 ## validation_auditor 0.1.1 (Jul 23, 2014) ##
 
 * Don't crash in the presence of file uploads when reporting validation errors.

data/lib/validation_auditor.rb

@@ -78,7 +78,7 @@ module ValidationAuditor
         end
         if ValidationAuditor::Controller.request.present?
           request = ValidationAuditor::Controller.request
-          va.params = ValidationAuditor::Controller.clean_params(request.params)
+          va.params = ValidationAuditor::Controller.clean_params(request.filtered_parameters)
           va.url = request.url
           va.user_agent = request.env["HTTP_USER_AGENT"]
         end

data/lib/validation_auditor/version.rb

@@ -2,5 +2,5 @@
 # Copyright © 2014, Watu
 
 module ValidationAuditor
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/test/controller_test.rb

@@ -73,6 +73,21 @@ class ControllerTest < ActionController::TestCase
     assert_equal audit.data["name"], "John Doe"
     assert_nil audit.data["email"]
     assert_equal ["can't be blank"], audit.failures[:email]
+    assert audit.params["deep"]["structure"]["with"]["file"].is_a? String
+  end
+
+  should "not include filtered params in validation audits" do
+    assert_difference "ValidationAuditor::ValidationAudit.count" => +1 do
+      @request.env["action_dispatch.parameter_filter"] = [:password]
+      post :create, audited_record: {name: "John Doe"}, password: "secret" # Missing email and a password that should be filtered.
+    end
+    audit = ValidationAuditor::ValidationAudit.order(:id).last
+    assert_nil audit.record # New records cannot be referenced because they don't exist...
+    assert_equal "AuditedRecord", audit.record_type # but we still record the name.
+    assert_equal audit.data["name"], "John Doe"
+    assert_nil audit.data["email"]
+    assert_equal ["can't be blank"], audit.failures[:email]
+    assert_not_equal "secret", audit.params["password"]
   end
 
   context "With a record" do

data/validation_auditor.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.required_ruby_version = ">= 1.9.3"
   spec.add_dependency "activerecord", "> 3.2.0"
   spec.add_dependency "actionpack", "> 3.2.0"
   spec.add_dependency "railties", "> 3.2.0"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: validation_auditor
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - J. Pablo Fernández
@@ -90,7 +90,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="