validates_type 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 095e33afbb9a0aebd616f77ee2be6a6c6f44598b
-  data.tar.gz: 27aa41f31c5dd6935ce8ccc41c5fde70ac54844f
+  metadata.gz: f49fb46c37a3674822b3d22fa2419aaf4c0fe481
+  data.tar.gz: dea07a48bc5642340721e3503423de1c4b7fe9e1
 SHA512:
-  metadata.gz: e4996fa85a21db804072016958f327f6831e9a4dd34c9702b483467f62411d713b5cbb034a53eb5e309674751eb8a8e6a51f5f988337412c46429e44e703d5de
-  data.tar.gz: 0ba9a4f043b605d20bed49fc6b7a6d78c77614d34af5bdd20cf9f60f5b851332a015c0c0acbaae252a3123cc9bf265bf9b1bd25a3e20179d46af64d1618cfe57
+  metadata.gz: 18aada637c9cb2671fa7c1be8ff377f867df2802740b7022f2e548bc0a5958094e0de0576f98c41e1a6e758ddb78289d3cf07e672dbe70e4e64ba8cc5bf1a0d2
+  data.tar.gz: 4455148f55376189879f6e899de21447deeca450baa7cc5fd0b55b2dcf565ef4d9f06f48d6847fe3ad9426e04d78724cdeaeb8d6b1e3a06e3bce03f627466415

data/README.md

@@ -31,6 +31,12 @@ class Foo < ActiveRecord::Base
 
   # validate that attribute :thing is a Float or nil
   validates_type :thing, :float, allow_nil: true
+
+  # validate that attribute :when is a Time
+  validates_type :when, :time
+
+  # validate that attribute :birthday is a Date or blank
+  validates_type :birthday, :date, allow_blank: true
 end
 ```
 
@@ -88,3 +94,5 @@ end
 - `:integer`
 - `:string`
 - `:symbol`
+- `:time`
+- `:date`

data/lib/validates_type.rb

@@ -62,9 +62,11 @@ module ActiveModel
       #           to raise an error or the actual error to raise
       #   return: custom error, ActiveModel::StrictValidationFailed, or nil
       def options_error(strict_error)
+        return if strict_error.nil?
+
         if strict_error == true
           ActiveModel::StrictValidationFailed
-        elsif strict_error.try(:ancestors).try(:include?, Exception)
+        elsif strict_error.ancestors.include?(Exception)
           strict_error
         end
       end
@@ -88,6 +90,8 @@ module ActiveModel
           :integer => Integer,
           :string  => String,
           :symbol  => Symbol,
+          :time    => Time,
+          :date    => Date,
         }[symbol] || fail(ValidatesType::UnsupportedType,
                           "Unsupported type #{ symbol.to_s.camelize } given for validates_type.")
       end
@@ -113,6 +117,8 @@ module ActiveModel
       #   - :integer
       #   - :string
       #   - :symbol
+      #   - :time
+      #   - :date
       #
       # class Foo
       #   include ActiveModel::Validations

data/spec/active_model/types_spec.rb

@@ -188,6 +188,58 @@ describe 'ValidatesType' do
       end
     end
 
+    describe 'Date' do
+
+      subject { ActiveModel::TypeValidationTestClass.set_accessor_and_long_validator(:date) }
+
+      context 'field value is a Date' do
+        let(:value) { Date.new }
+
+        specify do
+          expect(subject).to be_valid
+        end
+      end
+
+      context 'field value is not a Date' do
+        let(:value) { :foo }
+        specify do
+          expect(subject).to_not be_valid
+        end
+
+        specify do
+          subject.validate
+          expect(subject.errors).to_not be_empty
+          expect(subject.errors.messages[:attribute][0]).to match(/is expected to be a Date and is not/)
+        end
+      end
+    end
+
+    describe 'Time' do
+
+      subject { ActiveModel::TypeValidationTestClass.set_accessor_and_long_validator(:time) }
+
+      context 'field value is a Time' do
+        let(:value) { Time.new }
+
+        specify do
+          expect(subject).to be_valid
+        end
+      end
+
+      context 'field value is not a Time' do
+        let(:value) { 123456 }
+        specify do
+          expect(subject).to_not be_valid
+        end
+
+        specify do
+          subject.validate
+          expect(subject.errors).to_not be_empty
+          expect(subject.errors.messages[:attribute][0]).to match(/is expected to be a Time and is not/)
+        end
+      end
+    end
+
     context 'passing in a custom message' do
       subject { ActiveModel::TypeValidationTestClass.set_accessor_and_long_validator(:string, message: 'is not a String!') }
 

data/spec/activerecord/types_spec.rb

@@ -7,7 +7,7 @@ describe 'ValidatesType' do
     end
 
     describe 'Array' do
-      ->(column_type){ drop_and_create_column_with_type(column_type) }.call(:string)
+      drop_and_create_column_with_type(:string)
 
       subject { TypeValidationTest.set_accessor_and_long_validator(:array) }
 
@@ -48,7 +48,7 @@ describe 'ValidatesType' do
     end
 
     describe 'Boolean' do
-      ->(column_type){ drop_and_create_column_with_type(column_type) }.call(:boolean)
+      drop_and_create_column_with_type(:boolean)
 
       subject { TypeValidationTest.set_accessor_and_long_validator(:boolean) }
 
@@ -89,7 +89,7 @@ describe 'ValidatesType' do
     end
 
     describe 'Float' do
-      ->(column_type){ drop_and_create_column_with_type(column_type) }.call(:float)
+      drop_and_create_column_with_type(:float)
 
       subject { TypeValidationTest.set_accessor_and_long_validator(:float) }
 
@@ -130,7 +130,7 @@ describe 'ValidatesType' do
     end
 
     describe 'Hash' do
-      ->(column_type){ drop_and_create_column_with_type(column_type) }.call(:string)
+      drop_and_create_column_with_type(:string)
 
       subject { TypeValidationTest.set_accessor_and_long_validator(:hash) }
 
@@ -171,7 +171,7 @@ describe 'ValidatesType' do
     end
 
     describe 'Integer' do
-      ->(column_type){ drop_and_create_column_with_type(column_type) }.call(:integer)
+      drop_and_create_column_with_type(:integer)
 
       subject { TypeValidationTest.set_accessor_and_long_validator(:integer) }
 
@@ -212,7 +212,7 @@ describe 'ValidatesType' do
     end
 
     describe 'String' do
-      ->(column_type){ drop_and_create_column_with_type(column_type) }.call(:string)
+      drop_and_create_column_with_type(:string)
 
       subject { TypeValidationTest.set_accessor_and_long_validator(:string) }
 
@@ -252,7 +252,7 @@ describe 'ValidatesType' do
     end
 
     describe 'Symbol' do
-      ->(column_type){ drop_and_create_column_with_type(column_type) }.call(:string)
+      drop_and_create_column_with_type(:string)
 
       subject { TypeValidationTest.set_accessor_and_long_validator(:symbol) }
 
@@ -290,6 +290,60 @@ describe 'ValidatesType' do
         end
       end
     end
+
+    describe 'Date' do
+      drop_and_create_column_with_type(:string)
+
+      subject { TypeValidationTest.set_accessor_and_long_validator(:date) }
+
+      context 'field value is a Date' do
+        let(:value) { Date.new }
+
+        specify do
+          expect(subject).to be_valid
+        end
+      end
+
+      context 'field value is not a Date' do
+        let(:value) { :foo }
+        specify do
+          expect(subject).to_not be_valid
+        end
+
+        specify do
+          subject.validate
+          expect(subject.errors).to_not be_empty
+          expect(subject.errors.messages[:test_attribute][0]).to match(/is expected to be a Date and is not/)
+        end
+      end
+    end
+
+    describe 'Time' do
+      drop_and_create_column_with_type(:string)
+
+      subject { TypeValidationTest.set_accessor_and_long_validator(:time) }
+
+      context 'field value is a Time' do
+        let(:value) { Time.new }
+
+        specify do
+          expect(subject).to be_valid
+        end
+      end
+
+      context 'field value is not a Time' do
+        let(:value) { 123456 }
+        specify do
+          expect(subject).to_not be_valid
+        end
+
+        specify do
+          subject.validate
+          expect(subject.errors).to_not be_empty
+          expect(subject.errors.messages[:test_attribute][0]).to match(/is expected to be a Time and is not/)
+        end
+      end
+    end
   end
 
   context 'unsupported types' do

data/validates_type.gemspec

@@ -6,7 +6,7 @@ Gem::Specification.new do |s|
   s.name          = 'validates_type'
   s.version       = ValidatesType::VERSION
   s.summary       = %q{Type validation for ActiveModel/ActiveRecord attributes}
-  s.description   = %q{}
+  s.description   = %q{This library helps validate attributes to specific types in the same way that ActiveModel valiations work. Able to chain additional modifiers to each validation.}
   s.authors       = ['Jake Yesbeck']
   s.email         = 'yesbeckjs@gmail.com'
   s.homepage      = 'http://rubygems.org/gems/validates_type'
@@ -16,6 +16,8 @@ Gem::Specification.new do |s|
   s.files         = `git ls-files`.split("\n")
   s.test_files    = s.files.grep(/^spec\//)
 
+  s.required_ruby_version = '>= 1.8.7'
+
   s.add_dependency 'ruby-boolean', '>= 1.0.0'
   s.add_dependency 'activemodel', '>= 3.0.0'
 

data/version.rb

@@ -1,3 +1,3 @@
 module ValidatesType
-  VERSION = '0.0.1'.freeze
+  VERSION = '0.1.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validates_type
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Jake Yesbeck
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-07 00:00:00.000000000 Z
+date: 2015-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-boolean
@@ -122,7 +122,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ''
+description: This library helps validate attributes to specific types in the same
+  way that ActiveModel valiations work. Able to chain additional modifiers to each
+  validation.
 email: yesbeckjs@gmail.com
 executables: []
 extensions: []
@@ -161,7 +163,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.8.7
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="