validates_timeliness 5.0.0 → 5.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a87264d54db8505c8dcbeff59eda9c7e091d07942c97de3f34e7f9fc2f465c8
-  data.tar.gz: 504d91a6c0af936ffd864180c4e174521598c13f4c7774966b86808138e6fc51
+  metadata.gz: 6c7247761bf59a4add26640ddb732b6bdf816312be3083e972976062d4a43459
+  data.tar.gz: ab777d06c23790afbbc56a6a5a173fb8ea98034f52e9903d996c77a20e415574
 SHA512:
-  metadata.gz: 335b52bbbd66dd0a2e0a5ca1db25637eb2afb9007418d5a035342de756f391325170ec62fce16f422d30f80ffdf0b2f12e7fdb3fbbcecfb82d3ebbed2e6e2b25
-  data.tar.gz: cc3000300065dac0b74164ce5491f541fd338fa7649a6a0da722ae4179de48a7c46ec1f6c47aee2a91769058e0e7e2a2565d1d0b1b3c29d8495f5a9814d94041
+  metadata.gz: fde85a854481b993e1353a092a5340a62c2c299e2a8f75c8802f334203673e05a64e5323d8af6b1cd3e9c8bd2c8a0b8c6c78dd160aa6630eda7bfb06e10f4166
+  data.tar.gz: 5d202ab44a0397c7fbacac804c0bd2e52fdb37c8db672d22340681d01ce70a95a735d6e85e65f0d7ac72c0b6cbbcd159cf3fb715c566dff544e93436b40d103a

data/CHANGELOG.rdoc

@@ -1,4 +1,8 @@
-= [UNRELEASED]
+= 5.0.1 [2023-01-12]
+* Ensure Date value is converted to time in zone for zone aware attributes
+* Use ActiveSupport #change method to zero out usec
+
+= 5.0.0 [2021-04-03]
 * Fix DateTimeSelect extension support (AquisTech)
 * Relaxed Timeliness dependency version which allows for >= 0.4.0 with
   threadsafety fix for use_us_formats and use_euro_formats for hot switching

data/lib/validates_timeliness/converter.rb

@@ -19,12 +19,13 @@ module ValidatesTimeliness
       when :date
         value.to_date
       when :datetime
-        value.is_a?(Time) ? value : value.to_time
+        value.is_a?(Time) ? value : (time_zone_aware? ? value.in_time_zone : value.to_time)
       else
         value
       end
+
       if ignore_usec && value.is_a?(Time)
-        Timeliness::Parser.make_time(Array(value).reverse[4..9], (:current if time_zone_aware?))
+        value.change(usec: 0)
       else
         value
       end

data/lib/validates_timeliness/helper_methods.rb

@@ -20,7 +20,7 @@ module ActiveModel
 
       def timeliness_validation_for(attr_names, type=nil)
         options = _merge_attributes(attr_names)
-        options.update(:type => type) if type
+        options.update(type: type) if type
         validates_with TimelinessValidator, options
       end
     end

data/lib/validates_timeliness/version.rb

@@ -1,3 +1,3 @@
 module ValidatesTimeliness
-  VERSION = '5.0.0'
+  VERSION = '5.0.1'
 end

data/spec/validates_timeliness/converter_spec.rb

@@ -59,30 +59,61 @@ RSpec.describe ValidatesTimeliness::Converter do
 
     describe "for datetime type" do
       let(:type) { :datetime }
-      let(:time_zone_aware) { true }
 
-      it "should return Date as Time value" do
-        expect(type_cast_value(Date.new(2010, 1, 1))).to eq(Time.local(2010, 1, 1, 0, 0, 0))
+      it 'should return nil for invalid value types' do
+        expect(type_cast_value(12)).to eq(nil)
       end
 
-      it "should return same Time value" do
-        value = Time.utc(2010, 1, 1, 12, 34, 56)
-        expect(type_cast_value(Time.utc(2010, 1, 1, 12, 34, 56))).to eq(value)
-      end
+      context "time zone aware" do
+        let(:time_zone_aware) { true }
 
-      it "should return as Time with same component values" do
-        expect(type_cast_value(DateTime.civil_from_format(:utc, 2010, 1, 1, 12, 34, 56))).to eq(Time.utc(2010, 1, 1, 12, 34, 56))
-      end
+        around { |example|
+          Time.use_zone("Perth", &example)
+        }
+
+        it "should return Date as Time value" do
+          Time.use_zone('London') do
+            result = type_cast_value(Date.new(2010, 1, 1))
+            expected = Time.zone.local(2010, 1, 1, 0, 0, 0)
+
+            expect(result).to eq(expected)
+            expect(result.zone).to eq(expected.zone)
+          end
+        end
+
+        it "should return same Time value" do
+          value = Time.utc(2010, 1, 1, 12, 34, 56)
+          expect(type_cast_value(value)).to eq(value)
+        end
+
+        it "should return as Time with same component values" do
+          expect(type_cast_value(DateTime.civil_from_format(:utc, 2010, 1, 1, 12, 34, 56))).to eq(Time.utc(2010, 1, 1, 12, 34, 56))
+        end
 
-      it "should return same Time in correct zone if timezone aware" do
-        value = Time.utc(2010, 1, 1, 12, 34, 56)
-        result = type_cast_value(value)
-        expect(result).to eq(Time.zone.local(2010, 1, 1, 23, 34, 56))
-        expect(result.zone).to eq('AEDT')
+        it "should return same Time in correct zone if timezone aware" do
+          value = Time.utc(2010, 1, 1, 12, 34, 56)
+          result = type_cast_value(value)
+
+          expect(result).to eq(Time.zone.local(2010, 1, 1, 20, 34, 56))
+          expect(result.zone).to eq('AWST')
+        end
       end
 
-      it 'should return nil for invalid value types' do
-        expect(type_cast_value(12)).to eq(nil)
+      context "not time zone aware" do
+        let(:time_zone_aware) { false }
+
+        it "should return Date as Time value" do
+          expect(type_cast_value(Date.new(2010, 1, 1))).to eq(Time.local(2010, 1, 1, 0, 0, 0))
+        end
+
+        it "should return same Time value" do
+          value = Time.utc(2010, 1, 1, 12, 34, 56)
+          expect(type_cast_value(Time.utc(2010, 1, 1, 12, 34, 56))).to eq(value)
+        end
+
+        it "should return as Time with same component values" do
+          expect(type_cast_value(DateTime.civil_from_format(:utc, 2010, 1, 1, 12, 34, 56))).to eq(Time.utc(2010, 1, 1, 12, 34, 56))
+        end
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validates_timeliness
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.1
 platform: ruby
 authors:
 - Adam Meehan
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-02 00:00:00.000000000 Z
+date: 2023-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: timeliness
@@ -103,7 +103,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Date and time validation plugin for Rails which allows custom formats