validates_timeliness 2.3.2 → 3.0.0.beta

data/spec/validates_timeliness/attribute_methods_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe ValidatesTimeliness::AttributeMethods do
+  it 'should define _timeliness_raw_value_for instance method' do
+    Person.instance_methods.should include('_timeliness_raw_value_for')
+  end
+  
+  context "attribute write method" do
+    class EmployeeCopy < ActiveRecord::Base
+      set_table_name 'employees'
+      validates_datetime :birth_datetime
+    end
+
+    it 'should cache attribute raw value' do
+      r = EmployeeCopy.new
+      r.birth_datetime = date_string = '2010-01-01'
+      r._timeliness_raw_value_for(:birth_datetime).should == date_string
+    end
+  end
+
+  context "before_type_cast method" do
+    it 'should be defined on class if ORM supports it' do
+      Employee.instance_methods(false).should include("birth_datetime_before_type_cast")
+    end
+
+    it 'should not be defined if ORM does not support it' do
+      Person.instance_methods(false).should_not include("birth_datetime_before_type_cast")
+    end
+
+    it 'should return original value' do
+      r = Employee.new
+      r.birth_datetime = date_string = '2010-01-01'
+      r.birth_datetime_before_type_cast.should == date_string
+    end
+  end
+end

data/spec/validates_timeliness/conversion_spec.rb

@@ -0,0 +1,204 @@
+require 'spec_helper'
+
+describe ValidatesTimeliness::Conversion do
+  include ValidatesTimeliness::Conversion
+
+  before do
+    Timecop.freeze(Time.mktime(2010, 1, 1, 0, 0, 0))
+  end
+
+  describe "#type_cast_value" do
+    let(:options) { Hash.new }
+
+    describe "for date type" do
+      it "should return same value for date value" do
+        type_cast_value(Date.new(2010, 1, 1), :date).should == Date.new(2010, 1, 1)
+      end
+
+      it "should return date part of time value" do
+        type_cast_value(Time.mktime(2010, 1, 1, 0, 0, 0), :date).should == Date.new(2010, 1, 1)
+      end
+
+      it "should return date part of datetime value" do
+        type_cast_value(DateTime.new(2010, 1, 1, 0, 0, 0), :date).should == Date.new(2010, 1, 1)
+      end
+    end
+
+    describe "for time type" do
+      it "should return same value for time value matching dummy date part" do
+        type_cast_value(Time.utc(2000, 1, 1, 0, 0, 0), :time).should == Time.utc(2000, 1, 1, 0, 0, 0)
+      end
+
+      it "should return dummy time value with same time part for time value with different date" do
+        type_cast_value(Time.utc(2010, 1, 1, 0, 0, 0), :time).should == Time.utc(2000, 1, 1, 0, 0, 0)
+      end
+
+      it "should return dummy time only for date value" do
+        type_cast_value(Date.new(2010, 1, 1), :time).should == Time.utc(2000, 1, 1, 0, 0, 0)
+      end
+
+      it "should return dummy date with time part for datetime value" do
+        type_cast_value(DateTime.civil_from_format(:utc, 2010, 1, 1, 12, 34, 56), :time).should == Time.utc(2000, 1, 1, 12, 34, 56)
+      end
+    end
+
+    describe "for datetime type" do
+      it "should return Date as Time value" do
+        type_cast_value(Date.new(2010, 1, 1), :datetime).should == Time.local_time(2010, 1, 1, 0, 0, 0)
+      end
+
+      it "should return same Time value" do
+        value = Time.utc(2010, 1, 1, 12, 34, 56)
+        type_cast_value(Time.utc(2010, 1, 1, 12, 34, 56), :datetime).should == value
+      end
+
+      it "should return as Time with same component values" do
+        type_cast_value(DateTime.civil_from_format(:utc, 2010, 1, 1, 12, 34, 56), :datetime).should == Time.utc(2010, 1, 1, 12, 34, 56)
+      end
+
+      it "should return same Time in correct zone if timezone aware" do
+        @timezone_aware = true
+        value = Time.utc(2010, 1, 1, 12, 34, 56)
+        result = type_cast_value(value, :datetime)
+        result.should == Time.zone.local(2010, 1, 1, 23, 34, 56)
+        result.zone.should == 'EST'
+      end
+    end
+
+    describe "ignore_usec option" do
+      let(:options) { {:ignore_usec => true} }
+
+      it "should ignore usec on time values when evaluated" do
+        value = Time.utc(2010, 1, 1, 12, 34, 56, 10000)
+        type_cast_value(value, :datetime).should == Time.utc(2010, 1, 1, 12, 34, 56)
+      end
+
+      it "should ignore usec and return time in correct zone if timezone aware" do
+        @timezone_aware = true
+        value = Time.utc(2010, 1, 1, 12, 34, 56, 10000)
+        result = type_cast_value(value, :datetime)
+        result.should == Time.zone.local(2010, 1, 1, 23, 34, 56)
+        result.zone.should == 'EST'
+      end
+    end
+  end
+
+  describe "#dummy_time" do
+    it 'should return Time with dummy date values but same time components' do
+      dummy_time(Time.utc(2010, 11, 22, 12, 34, 56)).should == Time.utc(2000, 1, 1, 12, 34, 56)
+    end
+
+    it 'should return same value for Time which already has dummy date values' do
+      dummy_time(Time.utc(2000, 1, 1, 12, 34, 56)).should == Time.utc(2000, 1, 1, 12, 34, 56)
+    end
+
+    it 'should return time component values shifted to current zone if timezone aware' do
+      @timezone_aware = true
+      dummy_time(Time.utc(2000, 1, 1, 12, 34, 56)).should == Time.zone.local(2000, 1, 1, 23, 34, 56)
+    end
+
+    it 'should return base dummy time value for Date value' do
+      dummy_time(Date.new(2010, 11, 22)).should == Time.utc(2000, 1, 1, 0, 0, 0)
+    end
+
+    describe "with custom dummy date" do
+      before(:all) do
+        @@original_dummy_date = ValidatesTimeliness.dummy_date_for_time_type
+        ValidatesTimeliness.dummy_date_for_time_type = [2010, 1, 1] 
+      end
+
+      it 'should return dummy time with custom dummy date' do
+        dummy_time(Time.utc(1999, 11, 22, 12, 34, 56)).should == Time.utc(2010, 1, 1, 12, 34, 56)
+      end
+
+      after(:all) do
+        ValidatesTimeliness.dummy_date_for_time_type = @@original_dummy_date
+      end
+    end
+  end
+
+  describe "#evaluate_option_value" do
+    let(:person) { Person.new }
+
+    it 'should return Date object as is' do
+      value = Date.new(2010,1,1)
+      evaluate_option_value(value, person).should == value
+    end
+
+    it 'should return Time object as is' do
+      value = Time.mktime(2010,1,1)
+      evaluate_option_value(value, person).should == value
+    end
+
+    it 'should return DateTime object as is' do
+      value = DateTime.new(2010,1,1,0,0,0)
+      evaluate_option_value(value, person).should == value
+    end
+
+    it 'should return Time value returned from proc with 0 arity' do
+      value = Time.mktime(2010,1,1)
+      evaluate_option_value(lambda { value }, person).should == value
+    end
+
+    it 'should return Time value returned by record attribute call in proc arity of 1' do
+      value = Time.mktime(2010,1,1)
+      person.birth_time = value
+      evaluate_option_value(lambda {|r| r.birth_time }, person).should == value
+    end
+
+    it 'should return Time value for attribute method symbol which returns Time' do
+      value = Time.mktime(2010,1,1)
+      person.birth_time = value
+      evaluate_option_value(:birth_time, person).should == value
+    end
+
+    it 'should return Time value is default zone from string time value' do
+      value = '2010-01-01 12:00:00'
+      evaluate_option_value(value, person).should == Time.utc(2010,1,1,12,0,0)
+    end
+
+    it 'should return Time value is current zone from string time value if timezone aware' do
+      @timezone_aware = true
+      value = '2010-01-01 12:00:00'
+      evaluate_option_value(value, person).should == Time.zone.local(2010,1,1,12,0,0)
+    end
+
+    it 'should return Time value in default zone from proc which returns string time' do
+      value = '2010-01-01 12:00:00'
+      evaluate_option_value(lambda { value }, person).should == Time.utc(2010,1,1,12,0,0)
+    end
+
+    it 'should return Time value in default zone for attribute method symbol which returns string time value' do
+      value = '2010-01-01 12:00:00'
+      person.birth_time = value
+      evaluate_option_value(:birth_time, person).should == Time.utc(2010,1,1,12,0,0)
+    end
+
+    it 'should return Time value in current zone attribute method symbol which returns string time value if timezone aware' do
+      @timezone_aware = true
+      value = '2010-01-01 12:00:00'
+      person.birth_time = value
+      evaluate_option_value(:birth_time, person).should == Time.zone.local(2010,1,1,12,0,0)
+    end
+
+    context "restriction shorthand" do
+      before do
+        Timecop.freeze(Time.mktime(2010, 1, 1, 0, 0, 0))
+      end
+
+      it 'should evaluate :now as current time' do
+        evaluate_option_value(:now, person).should == Time.now
+      end
+
+      it 'should evaluate :today as current time' do
+        evaluate_option_value(:today, person).should == Date.today
+      end
+
+      it 'should not use shorthand if symbol if is record method' do
+        time = 1.day.from_now
+        person.stub!(:now).and_return(time)
+        evaluate_option_value(:now, person).should == time
+      end
+    end
+  end
+end

data/spec/validates_timeliness/extensions/date_time_select_spec.rb

@@ -0,0 +1,178 @@
+require 'spec_helper'
+
+describe ValidatesTimeliness::Extensions::DateTimeSelect do
+  include ActionView::Helpers::DateHelper
+
+  attr_reader :employee, :params
+
+  before do
+    @employee = Employee.new
+    @params = {}
+  end
+
+  describe "datetime_select" do
+    it "should use param values when attribute is nil" do
+      params["employee"] = {
+        "birth_datetime(1i)" => 2009,
+        "birth_datetime(2i)" => 2,
+        "birth_datetime(3i)" => 29,
+        "birth_datetime(4i)" => 12,
+        "birth_datetime(5i)" => 13,
+        "birth_datetime(6i)" => 14,
+      }
+      employee.birth_datetime = nil
+      output = datetime_select(:employee, :birth_datetime, :include_blank => true, :include_seconds => true)
+      output.should have_tag('select[id=employee_birth_datetime_1i] option[selected=selected]', '2009')
+      output.should have_tag('select[id=employee_birth_datetime_2i] option[selected=selected]', 'February')
+      output.should have_tag('select[id=employee_birth_datetime_3i] option[selected=selected]', '29')
+      output.should have_tag('select[id=employee_birth_datetime_4i] option[selected=selected]', '12')
+      output.should have_tag('select[id=employee_birth_datetime_5i] option[selected=selected]', '13')
+      output.should have_tag('select[id=employee_birth_datetime_6i] option[selected=selected]', '14')
+    end
+
+    it "should override object values and use params if present" do
+      params["employee"] = {
+        "birth_datetime(1i)" => 2009,
+        "birth_datetime(2i)" => 2,
+        "birth_datetime(3i)" => 29,
+        "birth_datetime(4i)" => 12,
+        "birth_datetime(5i)" => 13,
+        "birth_datetime(6i)" => 14,
+      }
+      employee.birth_datetime = "2010-01-01 15:16:17"
+      output = datetime_select(:employee, :birth_datetime, :include_blank => true, :include_seconds => true)
+      output.should have_tag('select[id=employee_birth_datetime_1i] option[selected=selected]', '2009')
+      output.should have_tag('select[id=employee_birth_datetime_2i] option[selected=selected]', 'February')
+      output.should have_tag('select[id=employee_birth_datetime_3i] option[selected=selected]', '29')
+      output.should have_tag('select[id=employee_birth_datetime_4i] option[selected=selected]', '12')
+      output.should have_tag('select[id=employee_birth_datetime_5i] option[selected=selected]', '13')
+      output.should have_tag('select[id=employee_birth_datetime_6i] option[selected=selected]', '14')
+    end
+
+    it "should use attribute values from object if no params" do
+      employee.birth_datetime = "2009-01-02 12:13:14"
+      output = datetime_select(:employee, :birth_datetime, :include_blank => true, :include_seconds => true)
+      output.should have_tag('select[id=employee_birth_datetime_1i] option[selected=selected]', '2009')
+      output.should have_tag('select[id=employee_birth_datetime_2i] option[selected=selected]', 'January')
+      output.should have_tag('select[id=employee_birth_datetime_3i] option[selected=selected]', '2')
+      output.should have_tag('select[id=employee_birth_datetime_4i] option[selected=selected]', '12')
+      output.should have_tag('select[id=employee_birth_datetime_5i] option[selected=selected]', '13')
+      output.should have_tag('select[id=employee_birth_datetime_6i] option[selected=selected]', '14')
+    end
+
+    it "should use attribute values if params does not contain attribute params" do
+      employee.birth_datetime = "2009-01-02 12:13:14"
+      params["employee"] = { }
+      output = datetime_select(:employee, :birth_datetime, :include_blank => true, :include_seconds => true)
+      output.should have_tag('select[id=employee_birth_datetime_1i] option[selected=selected]', '2009')
+      output.should have_tag('select[id=employee_birth_datetime_2i] option[selected=selected]', 'January')
+      output.should have_tag('select[id=employee_birth_datetime_3i] option[selected=selected]', '2')
+      output.should have_tag('select[id=employee_birth_datetime_4i] option[selected=selected]', '12')
+      output.should have_tag('select[id=employee_birth_datetime_5i] option[selected=selected]', '13')
+      output.should have_tag('select[id=employee_birth_datetime_6i] option[selected=selected]', '14')
+    end
+
+    it "should not select values when attribute value is nil and has no param values" do
+      employee.birth_datetime = nil
+      output = datetime_select(:employee, :birth_datetime, :include_blank => true, :include_seconds => true)
+      output.should_not have_tag('select[id=employee_birth_datetime_1i] option[selected=selected]')
+      output.should_not have_tag('select[id=employee_birth_datetime_2i] option[selected=selected]')
+      output.should_not have_tag('select[id=employee_birth_datetime_3i] option[selected=selected]')
+      output.should_not have_tag('select[id=employee_birth_datetime_4i] option[selected=selected]')
+      output.should_not have_tag('select[id=employee_birth_datetime_5i] option[selected=selected]')
+      output.should_not have_tag('select[id=employee_birth_datetime_6i] option[selected=selected]')
+    end
+  end
+
+  describe "date_select" do
+    it "should use param values when attribute is nil" do
+      params["employee"] = {
+        "birth_date(1i)" => 2009,
+        "birth_date(2i)" => 2,
+        "birth_date(3i)" => 29,
+      }
+      employee.birth_date = nil
+      output = date_select(:employee, :birth_date, :include_blank => true, :include_seconds => true)
+      output.should have_tag('select[id=employee_birth_date_1i] option[selected=selected]', '2009')
+      output.should have_tag('select[id=employee_birth_date_2i] option[selected=selected]', 'February')
+      output.should have_tag('select[id=employee_birth_date_3i] option[selected=selected]', '29')
+    end
+
+    it "should override object values and use params if present" do
+      params["employee"] = {
+        "birth_date(1i)" => 2009,
+        "birth_date(2i)" => 2,
+        "birth_date(3i)" => 29,
+      }
+      employee.birth_date = "2009-03-01"
+      output = date_select(:employee, :birth_date, :include_blank => true, :include_seconds => true)
+      output.should have_tag('select[id=employee_birth_date_1i] option[selected=selected]', '2009')
+      output.should have_tag('select[id=employee_birth_date_2i] option[selected=selected]', 'February')
+      output.should have_tag('select[id=employee_birth_date_3i] option[selected=selected]', '29')
+    end
+
+    it "should select attribute values from object if no params" do
+      employee.birth_date = "2009-01-02"
+      output = date_select(:employee, :birth_date, :include_blank => true, :include_seconds => true)
+      output.should have_tag('select[id=employee_birth_date_1i] option[selected=selected]', '2009')
+      output.should have_tag('select[id=employee_birth_date_2i] option[selected=selected]', 'January')
+      output.should have_tag('select[id=employee_birth_date_3i] option[selected=selected]', '2')
+    end
+
+    it "should select attribute values if params does not contain attribute params" do
+      employee.birth_date = "2009-01-02"
+      params["employee"] = { }
+      output = date_select(:employee, :birth_date, :include_blank => true, :include_seconds => true)
+      output.should have_tag('select[id=employee_birth_date_1i] option[selected=selected]', '2009')
+      output.should have_tag('select[id=employee_birth_date_2i] option[selected=selected]', 'January')
+      output.should have_tag('select[id=employee_birth_date_3i] option[selected=selected]', '2')
+    end
+
+    it "should not select values when attribute value is nil and has no param values" do
+      employee.birth_date = nil
+      output = date_select(:employee, :birth_date, :include_blank => true, :include_seconds => true)
+      output.should_not have_tag('select[id=employee_birth_date_1i] option[selected=selected]')
+      output.should_not have_tag('select[id=employee_birth_date_2i] option[selected=selected]')
+      output.should_not have_tag('select[id=employee_birth_date_3i] option[selected=selected]')
+    end
+  end
+
+  describe "time_select" do
+    before do
+      Timecop.freeze Time.mktime(2009,1,1)
+    end
+
+    it "should use param values when attribute is nil" do
+      params["employee"] = {
+        "birth_time(1i)" => 2000,
+        "birth_time(2i)" => 1,
+        "birth_time(3i)" => 1,
+        "birth_time(4i)" => 12,
+        "birth_time(5i)" => 13,
+        "birth_time(6i)" => 14,
+      }
+      employee.birth_time = nil
+      output = time_select(:employee, :birth_time, :include_blank => true, :include_seconds => true)
+      output.should have_tag('select[id=employee_birth_time_4i] option[selected=selected]', '12')
+      output.should have_tag('select[id=employee_birth_time_5i] option[selected=selected]', '13')
+      output.should have_tag('select[id=employee_birth_time_6i] option[selected=selected]', '14')
+    end
+
+    it "should select attribute values from object if no params" do
+      employee.birth_time = "2000-01-01 12:13:14"
+      output = time_select(:employee, :birth_time, :include_blank => true, :include_seconds => true)
+      output.should have_tag('select[id=employee_birth_time_4i] option[selected=selected]', '12')
+      output.should have_tag('select[id=employee_birth_time_5i] option[selected=selected]', '13')
+      output.should have_tag('select[id=employee_birth_time_6i] option[selected=selected]', '14')
+    end
+
+    it "should not select values when attribute value is nil and has no param values" do
+      employee.birth_time = nil
+      output = time_select(:employee, :birth_time, :include_blank => true, :include_seconds => true)
+      output.should_not have_tag('select[id=employee_birth_time_4i] option[selected=selected]')
+      output.should_not have_tag('select[id=employee_birth_time_5i] option[selected=selected]')
+      output.should_not have_tag('select[id=employee_birth_time_6i] option[selected=selected]')
+    end
+  end
+
+end

data/spec/validates_timeliness/extensions/multiparameter_handler_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe ValidatesTimeliness::Extensions::MultiparameterHandler do
+  let(:employee) { Employee.new }
+
+  it 'should return string value for invalid dates' do
+    instantiate_time_object('birth_date', [2000, 2, 31]).should == '2000-02-31'
+  end
+
+  it 'should return string value for invalid datetimes' do
+    instantiate_time_object('birth_datetime', [2000, 2, 31, 12, 0, 0]).should == '2000-02-31 12:00:00'
+  end
+   
+  it 'should return Time value for valid datetimes' do
+    instantiate_time_object('birth_datetime', [2000, 2, 28, 12, 0, 0]).should be_kind_of(Time)
+  end
+
+  def instantiate_time_object(name, values)
+    employee.send(:instantiate_time_object, name, values)
+  end
+end

data/spec/validates_timeliness/helper_methods_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe ValidatesTimeliness::HelperMethods do
+  it 'should define class validation methods on extended classes' do
+    ActiveRecord::Base.should respond_to(:validates_date)
+    ActiveRecord::Base.should respond_to(:validates_time)
+    ActiveRecord::Base.should respond_to(:validates_datetime)
+  end
+
+  it 'should define instance validation methods on extended classes' do
+    ActiveRecord::Base.instance_methods.should include('validates_date')
+    ActiveRecord::Base.instance_methods.should include('validates_time')
+    ActiveRecord::Base.instance_methods.should include('validates_datetime')
+  end
+
+  it 'should validate instance when validation method called' do
+    r = Employee.new
+    r.validates_date :birth_date
+    r.errors[:birth_date].should_not be_empty
+  end
+
+  describe ".timeliness_validated_attributes" do
+    it 'should return attributes validated with plugin validator' do
+      Person.timeliness_validated_attributes = {}
+      Person.validates_date :birth_date
+      Person.validates_time :birth_time
+      Person.validates_datetime :birth_datetime
+
+      Person.timeliness_validated_attributes.should == {
+        "birth_date" => :date,
+        "birth_time" => :time,
+        "birth_datetime" => :datetime
+      }
+    end
+  end
+end