validates_timeliness 1.1.6 → 1.1.7

data/CHANGELOG

@@ -1,3 +1,6 @@
+= 1.1.7 [2009-03-26]
+- Minor change to multiparameter attributes which I had not properly implemented for chaining
+
 = 1.1.6 [2009-03-19]
 - Rail 2.3 support
 - Added :with_date and :with_time options. They allow an attribute to be combined with another attribute or value to make a datetime value for validation against the temporal restrictions

data/Rakefile

@@ -5,7 +5,7 @@ require 'date'
 require 'spec/rake/spectask'
 
 GEM = "validates_timeliness"
-GEM_VERSION = "1.1.6"
+GEM_VERSION = "1.1.7"
 AUTHOR = "Adam Meehan"
 EMAIL = "adam.meehan@gmail.com"
 HOMEPAGE = "http://github.com/adzap/validates_timeliness"

data/TODO

@@ -1,3 +1,7 @@
 - :format option
 - valid formats could come from locale file
 - add replace_formats instead add_formats :before
+- array of values to all temporal options
+- use tz value from time string?
+- move make_time out of AR
+

data/lib/validates_timeliness/active_record/multiparameter_attributes.rb

@@ -16,18 +16,16 @@ module ValidatesTimeliness
       def execute_callstack_for_multiparameter_attributes_with_timeliness(callstack)
         errors = []
         callstack.each do |name, values|
-          klass = (self.class.reflect_on_aggregation(name.to_sym) || column_for_attribute(name)).klass
-          if values.empty?
-            send(name + "=", nil)
-          else
-            column = column_for_attribute(name)
+          column = column_for_attribute(name)
+          if column && [:date, :time, :datetime].include?(column.type)
             begin
-              value = if [:date, :time, :datetime].include?(column.type)
-                time_array_to_string(values, column.type)  
+              callstack.delete(name)
+              if values.empty?
+                send("#{name}=", nil)
               else
-                klass.new(*values)
+                value = time_array_to_string(values, column.type)
+                send("#{name}=", value)
               end
-              send(name + "=", value)
             rescue => ex
               errors << ::ActiveRecord::AttributeAssignmentError.new("error on assignment #{values.inspect} to #{name}", ex, name)
             end
@@ -36,10 +34,11 @@ module ValidatesTimeliness
         unless errors.empty?
           raise ::ActiveRecord::MultiparameterAssignmentErrors.new(errors), "#{errors.size} error(s) on assignment of multiparameter attributes"
         end
+        execute_callstack_for_multiparameter_attributes_without_timeliness(callstack)
       end
       
       def time_array_to_string(values, type)
-        values = values.map(&:to_s)
+        values = values.map {|v| v.to_s }
                 
         case type
         when :date
@@ -57,7 +56,8 @@ module ValidatesTimeliness
       end
       
       def extract_time_from_multiparameter_attributes(values)
-        values.last(3).map { |s| s.rjust(2, "0") }.join(":")
+        values = values.size > 3 ? values[3..5] : values
+        values.map { |s| s.rjust(2, "0") }.join(":")
       end
       
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: validates_timeliness
 version: !ruby/object:Gem::Version 
-  version: 1.1.6
+  version: 1.1.7
 platform: ruby
 authors: 
 - Adam Meehan
@@ -9,7 +9,7 @@ autorequire: validates_timeliness
 bindir: bin
 cert_chain: []
 
-date: 2009-03-19 00:00:00 +11:00
+date: 2009-03-26 00:00:00 +11:00
 default_executable: 
 dependencies: []