validates_lengths_from_database 0.5.2 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7d17fe52e66ac67d1cfc3a81dd72fee22a6050b7
-  data.tar.gz: 636155e6624043e9981dd9961eb990aa7059febf
+  metadata.gz: 8a2017e0b6fb3a3f8a69d7756dcbd581421d4520
+  data.tar.gz: cf44cca0ce1ffcf4b86afd8e188c44ede1db10ad
 SHA512:
-  metadata.gz: d500d14353f1297f9dc3c35a5333e4cedd81fcc1172867264d77299550c5fd3de9e58ae56231c47b09da517ef6e0f3fe2382a75bfdb95d5f1f6981ff706d5219
-  data.tar.gz: 445d4c872b1add3772218b3811e112823981935d4cd2f477fccae00fb9cfa56c11dbe49ff5fd10b76b0e0acc09e6ec0ebc9c6683300e3761dd27fa03f9c3650f
+  metadata.gz: 3aeba2873a46956abf4097a30eb0fb05a8934db8c13338aa69f3670d97a02d3c68689c2d5c8dc0f78ca8a34d026f0616f1d6e3914fec53b77db1fd77f8731a9c
+  data.tar.gz: 3e1ab91da9556d596daba58909c660ef1f924948c85c6eef9ff57d72c41837cb0606c153c78d9f19ed26de1376343015aa46dd9c241cea57ff230b79348e1406

data/CHANGELOG.rdoc

@@ -1,3 +1,7 @@
+== v0.6.0 (2017-05-02)
+
+* Drop support for integer length validations (too many issues)
+
 == v0.5.2 (2017-04-28)
 
 * Fix handling with STI models - thanks @iNecas

data/lib/validates_lengths_from_database.rb

@@ -54,20 +54,19 @@ module ValidatesLengthsFromDatabase
         column_schema = self.class.columns.find {|c| c.name == column }
         next if column_schema.nil?
         next if column_schema.respond_to?(:array) && column_schema.array
-
-        if [:string, :text, :integer, :decimal, :float].include?(column_schema.type)      
-          column_limit = options[:limit][column_schema.type] || column_schema.limit          
-
-          ActiveModel::Validations::LengthValidator.new(:maximum => column_limit, :allow_blank => true, :attributes => [column]).validate(self) if column_limit
-
-          if column_schema.type == :decimal && column_schema.precision && column_schema.scale
-
+        next unless [:string, :text, :decimal].include?(column_schema.type)
+        case column_schema.type
+        when :string, :text
+          column_limit = options[:limit][column_schema.type] || column_schema.limit
+          if column_limit
+            ActiveModel::Validations::LengthValidator.new(:maximum => column_limit, :allow_blank => true, :attributes => [column]).validate(self)
+          end
+        when :decimal
+          if column_schema.precision && column_schema.scale
             max_val = (10 ** column_schema.precision)/(10 ** column_schema.scale)
-
             ActiveModel::Validations::NumericalityValidator.new(:less_than => max_val, :allow_blank => true, :attributes => [column]).validate(self)
           end
         end
-
       end
     end
   end

data/lib/validates_lengths_from_database/version.rb

@@ -1,3 +1,3 @@
 module ValidatesLengthsFromDatabase
-  VERSION = "0.5.2"
+  VERSION = "0.6.0"
 end

data/spec/validates_lengths_from_database_spec.rb

@@ -130,8 +130,6 @@ describe ValidatesLengthsFromDatabase do
         @article.errors["string_2"].join.should =~ /too long/
         @article.errors["text_1"].join.should =~ /too long/  unless postgresql?  # PostgreSQL doesn't support limits on text columns
         @article.errors["decimal_1"].join.should =~ /less than/
-        @article.errors["integer_1"].join.should =~ /too long/  
-        @article.errors["float_1"].join.should =~ /too long/
       end
     end
 
@@ -203,9 +201,6 @@ describe ValidatesLengthsFromDatabase do
         @article.errors["string_1"].join.should =~ /too long/
         @article.errors["string_2"].join.should =~ /too long/
         @article.errors["text_1"].join.should =~ /too long/
-        @article.errors["decimal_1"].join.should =~ /too long/ 
-        @article.errors["integer_1"].join.should =~ /too long/
-        @article.errors["float_1"].join.should =~ /too long/
       end
     end
 
@@ -219,11 +214,11 @@ describe ValidatesLengthsFromDatabase do
     end
   end
 
-  context "Model with validates_lengths_from_database :limit => {:string => 5, :text => 100, :integer => 100, :decimal => 100, :float => 100}" do
+  context "Model with validates_lengths_from_database :limit => {:string => 5, :text => 100}" do
     before do
       class ArticleValidateSpecificLimit < ActiveRecord::Base
         self.table_name = "articles_high_limit"
-        validates_lengths_from_database :limit => {:string => 5, :text => 100, :integer => 100, :decimal => 100, :float => 100}
+        validates_lengths_from_database :limit => {:string => 5, :text => 100}
       end
     end
 
@@ -239,8 +234,6 @@ describe ValidatesLengthsFromDatabase do
         @article.errors["string_2"].join.should =~ /too long/
         @article.errors["text_1"].should_not be_present
         @article.errors["decimal_1"].should_not be_present
-        @article.errors["integer_1"].should_not be_present
-        @article.errors["float_1"].should_not be_present
       end
     end
   end
@@ -265,8 +258,6 @@ describe ValidatesLengthsFromDatabase do
         (@article.errors["string_2"] || []).should be_empty
         @article.errors["text_1"].join.should =~ /too long/ unless postgresql?  # PostgreSQL doesn't support limits on text columns
         (@article.errors["decimal_1"] || []).should be_empty
-        (@article.errors["integer_1"] || []).should be_empty
-        (@article.errors["float_1"] || []).should be_empty
       end
     end
 
@@ -298,9 +289,7 @@ describe ValidatesLengthsFromDatabase do
         (@article.errors["string_1"] || []).should be_empty
         (@article.errors["text_1"] || []).should be_empty
         @article.errors["decimal_1"].join.should =~ /less than/
-        @article.errors["integer_1"].join.should =~ /too long/
         @article.errors["string_2"].join.should =~ /too long/
-        @article.errors["float_1"].join.should =~ /too long/
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validates_lengths_from_database
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.6.0
 platform: ruby
 authors:
 - Ben Hughes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-28 00:00:00.000000000 Z
+date: 2017-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord