validates_lengths_from_database 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f73da6eb753b718d07fa7eb50a117bbdd51e6d96
-  data.tar.gz: d5a31be0048cea9e7960487582b75d3becc4fd65
+  metadata.gz: 7d17fe52e66ac67d1cfc3a81dd72fee22a6050b7
+  data.tar.gz: 636155e6624043e9981dd9961eb990aa7059febf
 SHA512:
-  metadata.gz: 351f1fcf3f3e9f2c674050775f1ef6150f07a952aa341e4702c67b5411f8abdc33a38b373deb2ca65774a1ea3c8c6f6876f39a4939c5dec05df9a4aa71956731
-  data.tar.gz: 0211d47b6bf46d5cfba5baea54d57ab872e963c8d9a66e1da7f023f423084f5cfc9e691981e7166106aa92bd937841500fec398377d5b4bb0efae258f44e2d7b
+  metadata.gz: d500d14353f1297f9dc3c35a5333e4cedd81fcc1172867264d77299550c5fd3de9e58ae56231c47b09da517ef6e0f3fe2382a75bfdb95d5f1f6981ff706d5219
+  data.tar.gz: 445d4c872b1add3772218b3811e112823981935d4cd2f477fccae00fb9cfa56c11dbe49ff5fd10b76b0e0acc09e6ec0ebc9c6683300e3761dd27fa03f9c3650f

data/CHANGELOG.rdoc

@@ -1,3 +1,7 @@
+== v0.5.2 (2017-04-28)
+
+* Fix handling with STI models - thanks @iNecas
+
 == v0.5.1 (2017-04-27)
 
 * Fix sharing options between models - thanks @iNecas

data/README.rdoc

@@ -50,7 +50,27 @@ Or to set the limit differently for string (VARCHAR) and (TEXT) columns:
     validates_lengths_from_database :limit => {:string => 255, :text => 4092}
   end
 
-Note that unfortunately this cannot be done at a global level directly against ActiveRecord::Base, since the +validates_length_from_database+ method requires the class to have a table name (with the ability to load the schema).
+Since v0.5.2, it's possible to use the `validate_lengths_from_database`
+on an abstract parent (without a table), such as +ApplicationRecord+ or <tt>ActiveRecord::Base</tt>.
+
+  class ApplicationRecord < ActiveRecord::Base
+    self.abstract_class = true
+    validates_lengths_from_database :limit => 255
+  end
+
+  # This will use the validations with default options (from parent)
+  class Post < ApplicationRecord
+  end
+
+  # This will use the validations, with overriding the default options (the limit will not be applied)
+  class User < ApplicationRecord
+    validates_lengths_from_database :only => [:name]
+  end
+
+  # This will use the validations, using the default options + adding some class specific customizations
+  class Comment < ApplicationRecord
+    validate_lengths_from_database_options[:only] << :name
+  end
 
 == Running Tests
 

data/lib/validates_lengths_from_database.rb

@@ -26,7 +26,16 @@ module ValidatesLengthsFromDatabase
     end
 
     def validate_lengths_from_database_options
-      @validate_lengths_from_database_options
+      if defined? @validate_lengths_from_database_options
+        @validate_lengths_from_database_options
+      else
+        # in case we inherited the validations, copy the options so that we can update it in child
+        # without affecting the parent
+        @validate_lengths_from_database_options = superclass.validate_lengths_from_database_options.inject({}) do |hash, (key, value)|
+          value = value.dup if value.respond_to?(:dup)
+          hash.update(key => value)
+        end
+      end
     end
   end
 

data/lib/validates_lengths_from_database/version.rb

@@ -1,3 +1,3 @@
 module ValidatesLengthsFromDatabase
-  VERSION = "0.5.1"
+  VERSION = "0.5.2"
 end

data/spec/validates_lengths_from_database_spec.rb

@@ -26,6 +26,11 @@ describe ValidatesLengthsFromDatabase do
     ActiveSupport::Deprecation.silenced = true
   end
 
+  class ApplicationRecord < ActiveRecord::Base
+    self.abstract_class = true
+    validates_lengths_from_database :limit => 255
+  end
+
   context "Model without associated table" do
     specify "defining validates_lengths_from_database should not raise an error" do
       lambda {
@@ -109,7 +114,7 @@ describe ValidatesLengthsFromDatabase do
 
       class ArticleValidateText < ActiveRecord::Base
         self.table_name = "articles"
-        validates_lengths_from_database :only => [:text_1]
+        validates_lengths_from_database :only => [:string_1]
       end
     end
 
@@ -130,6 +135,36 @@ describe ValidatesLengthsFromDatabase do
       end
     end
 
+    context "inheritance" do
+      before do
+        class ArticleValidateChild < ApplicationRecord
+          self.table_name = "articles"
+          validates_lengths_from_database :only => [:string_1]
+        end
+        class ArticleValidateChildOverwrite < ArticleValidateChild
+          validate_lengths_from_database_options[:only] << :string_2
+        end
+        class ArticleWithoutValidations < ApplicationRecord
+          self.table_name = "articles"
+          validates_lengths_from_database :only => []
+        end
+      end
+
+      it "should inherit the validation options from the parent" do
+        @article = ArticleValidateChild.new(LONG_ATTRIBUTES)
+        @article.valid?
+        @article.errors["string_1"].join.should =~ /too long/
+        @article.errors["string_2"].join.should_not =~ /too long/
+      end
+
+      it "should allow changing the validation options of child" do
+        @article = ArticleValidateChildOverwrite.new(LONG_ATTRIBUTES)
+        @article.valid?
+        @article.errors["string_1"].join.should =~ /too long/
+        @article.errors["string_2"].join.should =~ /too long/
+      end
+    end
+
     context "an article with short attributes" do
       before { @article = ArticleValidateAll.new(SHORT_ATTRIBUTES); @article.valid? }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validates_lengths_from_database
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Ben Hughes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-27 00:00:00.000000000 Z
+date: 2017-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord