validates_host 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3ccfaaef4bc3d52a9b8fa2ca185639ac9e8eef1b
-  data.tar.gz: 1a847e877ae09a88eb3ef62434a52fb9cb672f4c
+SHA256:
+  metadata.gz: f5b11543c72bb9ea5223f7f216d24f79606ca13e2f9d97967718132ef9589158
+  data.tar.gz: 3338ae72f989b7fa89cc546918519b69cd2000ef0c081a14afe465720ce0ae4f
 SHA512:
-  metadata.gz: 6911acf25d66107a291d5883753e1fc1e01565fd2312eedc15c97edc6bd627d959b25fc05ae00306241479ee0b94f682b46b0e8ce310e5a9ad9c682a2b9bf889
-  data.tar.gz: dda6fca0b134fbeda2248a265b627e1b54c6d06944b497089d2ef6593ab7d4e8a51340bc73cfab98e2e67ada6fcc6a3684a8811df60c0a8d3bc4c3e432dde1cd
+  metadata.gz: e4146e5334ec9aa078d6f715f225296e73625a10c3508bfa67bbaca3a85092326049873ae7cf8a7d0a5cec4bbbdd5a04c262bc1d7b70e6c100b8101d0263e755
+  data.tar.gz: 8d122306cf4753d4e077a0b76c92d5f8da7c9623f17cf1ff3c5f40368c42794f3da1ccb02e2cb66d68e923cd767e367fcfbfc63585bf5082780a7f97454b1530

data/.rubocop.yml

@@ -0,0 +1,53 @@
+require: rubocop-rspec
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/LineLength:
+  Max: 150
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Metrics/BlockLength:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/MixinUsage:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true

data/.travis.yml

@@ -1,22 +1,31 @@
-rvm:
-  - 2.0
-  - 2.1
-  - 2.2
-  - 2.3
-  - 2.4
-gemfile:
-  - gemfiles/Gemfile.rails3
-  - gemfiles/Gemfile.rails4
-  - gemfiles/Gemfile.rails5
 matrix:
-  exclude:
-    - rvm: 2.2
+  include:
+    - rvm: 2.0
       gemfile: gemfiles/Gemfile.rails3
-    - rvm: 2.3
+    - rvm: 2.0
+      gemfile: gemfiles/Gemfile.rails4
+    - rvm: 2.1
       gemfile: gemfiles/Gemfile.rails3
+    - rvm: 2.1
+      gemfile: gemfiles/Gemfile.rails4
+    - rvm: 2.2
+      gemfile: gemfiles/Gemfile.rails4
+    - rvm: 2.2
+      gemfile: gemfiles/Gemfile.rails5
+    - rvm: 2.3
+      gemfile: gemfiles/Gemfile.rails4
+    - rvm: 2.3
+      gemfile: gemfiles/Gemfile.rails5
+    - rvm: 2.4
+      gemfile: gemfiles/Gemfile.rails4
     - rvm: 2.4
-      gemfile: gemfiles/Gemfile.rails3
-    - rvm: 2.0
       gemfile: gemfiles/Gemfile.rails5
-    - rvm: 2.1
-      gemfile: gemfiles/Gemfile.rails5
+    - rvm: 2.5
+      gemfile: gemfiles/Gemfile.rails4
+    - rvm: 2.5
+      gemfile: gemfiles/Gemfile.rails5
+    - rvm: 2.6
+      gemfile: gemfiles/Gemfile.rails4
+    - rvm: 2.6
+      gemfile: gemfiles/Gemfile.rails5
+      script: rake complete

data/Gemfile

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in validates_host.gemspec
-gemspec
+gemspec

data/README.md

@@ -1,6 +1,6 @@
 # ValidatesHost 
 
-[![Gem Version](https://badge.fury.io/rb/validates_host.png)](http://badge.fury.io/rb/validates_host) [![Build Status](https://secure.travis-ci.org/plribeiro3000/validates_host.png?branch=master)](http://travis-ci.org/plribeiro3000/validates_host) [![Dependency Status](https://gemnasium.com/plribeiro3000/validates_host.png)](https://gemnasium.com/plribeiro3000/validates_host) [![Coverage Status](https://coveralls.io/repos/plribeiro3000/validates_host/badge.png?branch=master)](https://coveralls.io/r/plribeiro3000/validates_host)  [![Code Climate](https://codeclimate.com/github/plribeiro3000/validates_host.png)](https://codeclimate.com/github/plribeiro3000/validates_host)
+[![Gem Version](https://badge.fury.io/rb/validates_host.png)](http://badge.fury.io/rb/validates_host) [![Build Status](https://secure.travis-ci.org/plribeiro3000/validates_host.png?branch=master)](http://travis-ci.org/plribeiro3000/validates_host) [![Coverage Status](https://coveralls.io/repos/plribeiro3000/validates_host/badge.png?branch=master)](https://coveralls.io/r/plribeiro3000/validates_host)  [![Code Climate](https://codeclimate.com/github/plribeiro3000/validates_host.png)](https://codeclimate.com/github/plribeiro3000/validates_host)
 
 Validates host attributes and test it in a simple way
 

data/Rakefile

@@ -1,7 +1,12 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new
+RuboCop::RakeTask.new
 
-desc "Default Task"
-task :default => [ :spec ]
+desc 'Default Task'
+task default: [:spec]
+task complete: %i[spec rubocop]

data/lib/validates_host.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/core_ext/array/wrap'
 require 'validates_host/host_name_validator'
 require 'validates_host/domain_name_validator'
@@ -16,4 +18,4 @@ module ValidatesHost
   autoload :Ip, 'validates_host/ip'
   autoload :HostName, 'validates_host/host_name'
   autoload :DomainName, 'validates_host/domain_name'
-end
+end

data/lib/validates_host/domain_name.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ValidatesHost
   class DomainName
     def initialize(domain_name)
@@ -6,7 +8,8 @@ module ValidatesHost
 
     def valid?
       return true if @domain_name.blank?
-      @domain_name =~ /^[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,5}(:[0-9]{1,5})?(\/.*)?$/
+
+      @domain_name =~ %r{^[a-z0-9]+([\-.]{1}[a-z0-9]+)*\.[a-z]{2,5}(:[0-9]{1,5})?(/.*)?$}
     end
   end
-end
+end

data/lib/validates_host/domain_name_validator.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 class DomainNameValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, value)
     record.errors.add(attribute, :invalid, options) unless ValidatesHost::DomainName.new(value).valid?
   end
-end
+end

data/lib/validates_host/host_name.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ValidatesHost
   class HostName
     def initialize(host_name)
@@ -6,7 +8,8 @@ module ValidatesHost
 
     def valid?
       return true if @host_name.blank?
+
       @host_name =~ /^[a-z][a-z0-9-]+$/
     end
   end
-end
+end

data/lib/validates_host/host_name_validator.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 class HostNameValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, value)
     record.errors.add(attribute, :invalid, options) unless ValidatesHost::HostName.new(value).valid?
   end
-end
+end

data/lib/validates_host/ip.rb

@@ -1,12 +1,17 @@
+# frozen_string_literal: true
+
+require 'resolv'
+
 module ValidatesHost
   class Ip
-    def initialize(ip)
-      @ip = ip
+    def initialize(value)
+      @value = value
     end
 
     def valid?
-      return true if @ip.blank?
-      @ip =~ /^([1-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(\.([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3}$/
+      return true if @value.blank?
+
+      @value =~ Regexp.union(Resolv::IPv4::Regex, Resolv::IPv6::Regex)
     end
   end
-end
+end

data/lib/validates_host/ip_validator.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 class IpValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, value)
     record.errors.add(attribute, :invalid, options) unless ValidatesHost::Ip.new(value).valid?
   end
-end
+end

data/lib/validates_host/require_a_valid_domain_name_matcher.rb

@@ -1,4 +1,6 @@
-require "shoulda-matchers"
+# frozen_string_literal: true
+
+require 'shoulda-matchers'
 
 module Shoulda
   module Matchers
@@ -15,19 +17,19 @@ module Shoulda
         def matches?(subject)
           super(subject)
 
-          disallows_invalid_value and allows_valid_value
+          disallows_invalid_value && allows_valid_value
         end
 
         private
 
         def disallows_invalid_value
-          disallows_value_of("example")
+          disallows_value_of('example')
         end
 
         def allows_valid_value
-          allows_value_of("example.com")
+          allows_value_of('example.com')
         end
       end
     end
   end
-end
+end

data/lib/validates_host/require_a_valid_host_name_matcher.rb

@@ -1,4 +1,6 @@
-require "shoulda-matchers"
+# frozen_string_literal: true
+
+require 'shoulda-matchers'
 
 module Shoulda
   module Matchers
@@ -15,19 +17,19 @@ module Shoulda
         def matches?(subject)
           super(subject)
 
-          disallows_invalid_value and allows_valid_value
+          disallows_invalid_value && allows_valid_value
         end
 
         private
 
         def disallows_invalid_value
-          disallows_value_of("1bd")
+          disallows_value_of('1bd')
         end
 
         def allows_valid_value
-          allows_value_of("bd01")
+          allows_value_of('bd01')
         end
       end
     end
   end
-end
+end

data/lib/validates_host/require_a_valid_ip_matcher.rb

@@ -1,4 +1,6 @@
-require "shoulda-matchers"
+# frozen_string_literal: true
+
+require 'shoulda-matchers'
 
 module Shoulda
   module Matchers
@@ -15,19 +17,19 @@ module Shoulda
         def matches?(subject)
           super(subject)
 
-          disallows_invalid_value and allows_valid_value
+          disallows_invalid_value && allows_valid_value
         end
 
         private
 
         def disallows_invalid_value
-          disallows_value_of("10.0.0")
+          disallows_value_of('10.0.0')
         end
 
         def allows_valid_value
-          allows_value_of("10.10.10.1")
+          allows_value_of('10.10.10.1')
         end
       end
     end
   end
-end
+end

data/lib/validates_host/require_a_valid_subnet_matcher.rb

@@ -1,4 +1,6 @@
-require "shoulda-matchers"
+# frozen_string_literal: true
+
+require 'shoulda-matchers'
 
 module Shoulda
   module Matchers
@@ -15,19 +17,19 @@ module Shoulda
         def matches?(subject)
           super(subject)
 
-          disallows_invalid_value and allows_valid_value
+          disallows_invalid_value && allows_valid_value
         end
 
         private
 
         def disallows_invalid_value
-          disallows_value_of("10.0.0")
+          disallows_value_of('10.0.0')
         end
 
         def allows_valid_value
-          allows_value_of("10.10.10.1/28")
+          allows_value_of('10.10.10.1/28')
         end
       end
     end
   end
-end
+end

data/lib/validates_host/subnet.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ValidatesHost
   class Subnet
     def initialize(subnet)
@@ -6,7 +8,8 @@ module ValidatesHost
 
     def valid?
       return true if @subnet.blank?
-      @subnet =~ /^([1-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(\.([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3}\/(2[4-9]|30)$/
+
+      @subnet =~ %r{^([1-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(\.([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3}/(2[4-9]|30)$}
     end
   end
-end
+end

data/lib/validates_host/subnet_validator.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 class SubnetValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, value)
     record.errors.add(attribute, :invalid, options) unless ValidatesHost::Subnet.new(value).valid?
   end
-end
+end

data/lib/validates_host/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ValidatesHost
-  VERSION = '1.1.0'
-end
+  VERSION = '1.2.0'
+end

data/spec/fake_app/server.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Server
   include ActiveModel::Validations
   include ActiveModel::Conversion
@@ -5,13 +7,13 @@ class Server
 
   attr_accessor :domain_name, :host_name, :ip
 
-  validates :domain_name, :domain_name => true
-  validates :host_name, :host_name => true
-  validates :ip, :ip => true
+  validates :domain_name, domain_name: true
+  validates :host_name, host_name: true
+  validates :ip, ip: true
 
   def initialize(attributes = {})
     attributes.each do |name, value|
       send("#{name}=", value)
     end
   end
-end
+end

data/spec/fake_app/subnet.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Subnet
   include ActiveModel::Validations
   include ActiveModel::Conversion
@@ -5,11 +7,5 @@ class Subnet
 
   attr_accessor :id, :value
 
-  validates :value, :subnet => true
-
-  def initialize(attributes = {})
-    attributes.each do |name, value|
-      send("#{name}=", value)
-    end
-  end
-end
+  validates :value, subnet: true
+end

data/spec/shoulda/matchers/active_model/require_a_valid_domain_name_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidDomainNameMatcher do
+  let(:server) { Server.new }
+
+  it 'accepts on domain_name' do
+    expect(server).to require_a_valid_domain_name(:domain_name)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(server).to require_a_valid_domain_name
+  end
+
+  it 'rejects on host_name' do
+    expect(server).not_to require_a_valid_domain_name(:host_name)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_domain_name.description).to eq('require domain_name to be a valid domain name')
+  end
+end

data/spec/shoulda/matchers/active_model/require_a_valid_host_name_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidHostNameMatcher do
+  let(:server) { Server.new }
+
+  it 'accepts on host_name' do
+    expect(server).to require_a_valid_host_name(:host_name)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(server).to require_a_valid_host_name
+  end
+
+  it 'rejects on domain_name' do
+    expect(server).not_to require_a_valid_host_name(:domain_name)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_host_name.description).to eq('require host_name to be a valid host name')
+  end
+end

data/spec/shoulda/matchers/active_model/require_a_valid_ip_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidIpMatcher do
+  let(:server) { Server.new }
+
+  it 'accepts on ip' do
+    expect(server).to require_a_valid_ip(:ip)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(server).to require_a_valid_ip
+  end
+
+  it 'rejects on domain_name' do
+    expect(server).not_to require_a_valid_ip(:domain_name)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_ip.description).to eq('require ip to be a valid ip')
+  end
+end

data/spec/shoulda/matchers/active_model/require_a_valid_subnet_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidSubnetMatcher do
+  let(:subnet) { Subnet.new }
+
+  it 'accepts on value' do
+    expect(subnet).to require_a_valid_subnet(:value)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(subnet).to require_a_valid_subnet
+  end
+
+  it 'rejects on id' do
+    expect(subnet).not_to require_a_valid_subnet(:id)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_subnet.description).to eq('require value to be a valid subnet')
+  end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec'
 require 'active_model'
 require 'coveralls'
@@ -9,4 +11,4 @@ require 'validates_host'
 require 'fake_app/server'
 require 'fake_app/subnet'
 
-include Shoulda::Matchers::ActiveModel
+include Shoulda::Matchers::ActiveModel

data/spec/validates_host/domain_name_validator_spec.rb

@@ -1,38 +1,41 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe DomainNameValidator do
+  let(:server) { Server.new }
+
   context 'when domain_name is invalid' do
-    before :each do
-      @server = Server.new(:domain_name => 'http://')
+    before do
+      server.domain_name = 'http://'
+      server.valid?
     end
 
-    it 'should set object as invalid' do
-      expect(@server.valid?).to be_falsey
+    it 'sets object as invalid' do
+      expect(server).not_to be_valid
     end
 
-    it 'should set an error' do
-      @server.valid?
-      expect(@server.errors[:domain_name]).to eq(['is invalid'])
+    it 'sets an error' do
+      expect(server.errors[:domain_name]).to eq(['is invalid'])
     end
   end
 
   context 'when domain_name is valid' do
-    before :each do
-      @server = Server.new(:domain_name => 'example.com')
+    before do
+      server.domain_name = 'example.com'
+      server.valid?
     end
 
-    it 'should set object as valid' do
-      expect(@server.valid?).to be_truthy
+    it 'sets object as valid' do
+      expect(server).to be_valid
     end
 
-    it 'should not set an error on attribute' do
-      @server.valid?
-      expect(@server.errors[:domain_name]).to be_blank
+    it 'does not set an error on attribute' do
+      expect(server.errors[:domain_name]).to be_blank
     end
   end
 
-  it 'should be valid with a nil value' do
-    @server = Server.new(:domain_name => nil)
-    expect(@server.valid?).to be_truthy
+  it 'is valid with a nil value' do
+    expect(server).to be_valid
   end
-end
+end

data/spec/validates_host/host_name_validator_spec.rb

@@ -1,38 +1,41 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe HostNameValidator do
+  let(:server) { Server.new }
+
   context 'when host_name is invalid' do
-    before :each do
-      @server = Server.new(:host_name => 'http://')
+    before do
+      server.host_name = 'http://'
+      server.valid?
     end
 
-    it 'should set object as invalid' do
-      expect(@server.valid?).to be_falsey
+    it 'sets object as invalid' do
+      expect(server).not_to be_valid
     end
 
-    it 'should set an error' do
-      @server.valid?
-      expect(@server.errors[:host_name]).to eq(['is invalid'])
+    it 'sets an error' do
+      expect(server.errors[:host_name]).to eq(['is invalid'])
     end
   end
 
   context 'when host_name is valid' do
-    before :each do
-      @server = Server.new(:host_name => 'bd01')
+    before do
+      server.host_name = 'bd01'
+      server.valid?
     end
 
-    it 'should set object as valid' do
-      expect(@server.valid?).to be_truthy
+    it 'sets object as valid' do
+      expect(server).to be_valid
     end
 
-    it 'should not set an error on attribute' do
-      @server.valid?
-      expect(@server.errors[:host_name]).to be_blank
+    it 'does not set an error on attribute' do
+      expect(server.errors[:host_name]).to be_blank
     end
   end
 
-  it 'should be valid with a nil value' do
-    @server = Server.new(:host_name => nil)
-    expect(@server.valid?).to be_truthy
+  it 'is valid with a nil value' do
+    expect(server).to be_valid
   end
-end
+end

data/spec/validates_host/ip_validator_spec.rb

@@ -1,38 +1,56 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe IpValidator do
+  let(:server) { Server.new }
+
   context 'when ip is invalid' do
-    before :each do
-      @server = Server.new(:ip => '127.0.0')
+    before do
+      server.ip = '127.0.0'
+      server.valid?
+    end
+
+    it 'sets object as invalid' do
+      expect(server).not_to be_valid
+    end
+
+    it 'sets an error' do
+      expect(server.errors[:ip]).to eq(['is invalid'])
+    end
+  end
+
+  context 'when ip is IPV4 valid' do
+    before do
+      server.ip = '10.10.10.1'
+      server.valid?
     end
 
-    it 'should set object as invalid' do
-      expect(@server.valid?).to be_falsey
+    it 'sets object as valid' do
+      expect(server).to be_valid
     end
 
-    it 'should set an error' do
-      @server.valid?
-      expect(@server.errors[:ip]).to eq(['is invalid'])
+    it 'does not set an error on attribute' do
+      expect(server.errors[:ip]).to be_blank
     end
   end
 
-  context 'when ip is valid' do
-    before :each do
-      @server = Server.new(:ip => '10.10.10.1')
+  context 'when ip is IPV6 valid' do
+    before do
+      server.ip = 'fd92:fe56:b43a:062e:ffff:ffff:ffff:ffff'
+      server.valid?
     end
 
-    it 'should set object as valid' do
-      expect(@server.valid?).to be_truthy
+    it 'sets object as valid' do
+      expect(server).to be_valid
     end
 
-    it 'should not set an error on attribute' do
-      @server.valid?
-      expect(@server.errors[:ip]).to be_blank
+    it 'does not set an error on attribute' do
+      expect(server.errors[:ip]).to be_blank
     end
   end
 
-  it 'should be valid with a nil value' do
-    @server = Server.new(:ip => nil)
-    expect(@server.valid?).to be_truthy
+  it 'is valid with a nil value' do
+    expect(server).to be_valid
   end
-end
+end

data/spec/validates_host/subnet_validator_spec.rb

@@ -1,38 +1,41 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe SubnetValidator do
+  let(:subnet) { Subnet.new }
+
   context 'when subnet is invalid' do
-    before :each do
-      @subnet = Subnet.new(:value => '127.0.0')
+    before do
+      subnet.value = '127.0.0'
+      subnet.valid?
     end
 
-    it 'should set object as invalid' do
-      expect(@subnet.valid?).to be_falsey
+    it 'sets object as invalid' do
+      expect(subnet).not_to be_valid
     end
 
-    it 'should set an error' do
-      @subnet.valid?
-      expect(@subnet.errors[:value]).to eq(['is invalid'])
+    it 'sets an error' do
+      expect(subnet.errors[:value]).to eq(['is invalid'])
     end
   end
 
   context 'when subnet is valid' do
-    before :each do
-      @subnet = Subnet.new(:value => '10.10.10.1/28')
+    before do
+      subnet.value = '10.10.10.1/28'
+      subnet.valid?
     end
 
-    it 'should set object as valid' do
-      expect(@subnet.valid?).to be_truthy
+    it 'sets object as valid' do
+      expect(subnet).to be_valid
     end
 
-    it 'should not set an error on attribute' do
-      @subnet.valid?
-      expect(@subnet.errors[:value]).to be_blank
+    it 'does not set an error on attribute' do
+      expect(subnet.errors[:value]).to be_blank
     end
   end
 
-  it 'should be valid with a nil value' do
-    @subnet = Subnet.new(:value => nil)
-    expect(@subnet.valid?).to be_truthy
+  it 'is valid with a nil value' do
+    expect(subnet).to be_valid
   end
-end
+end

data/validates_host.gemspec

@@ -1,24 +1,27 @@
-# -*- encoding: utf-8 -*-
-require File.expand_path('../lib/validates_host/version', __FILE__)
+# frozen_string_literal: true
+
+require File.expand_path('lib/validates_host/version', __dir__)
 
 Gem::Specification.new do |gem|
   gem.name        = 'validates_host'
   gem.version     = ValidatesHost::VERSION
-  gem.authors     = %q{Paulo Henrique Lopes Ribeiro}
-  gem.email       = %q{plribeiro3000@gmail.com}
-  gem.summary     = %q{Validates Host, Domain and IP and test it with matchers in a simple way.}
+  gem.authors     = 'Paulo Henrique Lopes Ribeiro'
+  gem.email       = 'plribeiro3000@gmail.com'
+  gem.summary     = 'Validates Host, Domain and IP and test it with matchers in a simple way.'
 
-  gem.files         = `git ls-files`.split($\)
+  gem.files         = `git ls-files`.split($OUTPUT_RECORD_SEPARATOR)
   gem.test_files    = `git ls-files -- {test,spec,features,examples,gemfiles}/*`.split("\n")
-  gem.executables   = `git ls-files -- bin/*`.split('\n').map{ |f| File.basename(f) }
-  gem.require_paths = %w(lib)
+  gem.executables   = `git ls-files -- bin/*`.split('\n').map { |f| File.basename(f) }
+  gem.require_paths = %w[lib]
 
   gem.license = 'MIT'
 
+  gem.add_development_dependency 'coveralls'
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'rubocop'
+  gem.add_development_dependency 'rubocop-rspec'
   gem.add_development_dependency 'shoulda-matchers'
-  gem.add_development_dependency 'coveralls'
 
   gem.add_dependency 'activemodel', '>= 3.0.0'
-end
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: validates_host
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Paulo Henrique Lopes Ribeiro
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-08 00:00:00.000000000 Z
+date: 2020-06-07 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -39,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: shoulda-matchers
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +67,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -88,8 +116,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".ruby-gemset"
-- ".ruby-version"
 - ".travis.yml"
 - Gemfile
 - LICENSE
@@ -114,14 +142,14 @@ files:
 - lib/validates_host/version.rb
 - spec/fake_app/server.rb
 - spec/fake_app/subnet.rb
+- spec/shoulda/matchers/active_model/require_a_valid_domain_name_matcher_spec.rb
+- spec/shoulda/matchers/active_model/require_a_valid_host_name_matcher_spec.rb
+- spec/shoulda/matchers/active_model/require_a_valid_ip_matcher_spec.rb
+- spec/shoulda/matchers/active_model/require_a_valid_subnet_matcher_spec.rb
 - spec/spec_helper.rb
 - spec/validates_host/domain_name_validator_spec.rb
 - spec/validates_host/host_name_validator_spec.rb
 - spec/validates_host/ip_validator_spec.rb
-- spec/validates_host/require_a_valid_domain_name_matcher_spec.rb
-- spec/validates_host/require_a_valid_host_name_matcher_spec.rb
-- spec/validates_host/require_a_valid_ip_matcher_spec.rb
-- spec/validates_host/require_a_valid_subnet_matcher_spec.rb
 - spec/validates_host/subnet_validator_spec.rb
 - validates_host.gemspec
 homepage: 
@@ -143,8 +171,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: Validates Host, Domain and IP and test it with matchers in a simple way.
@@ -154,12 +181,12 @@ test_files:
 - gemfiles/Gemfile.rails5
 - spec/fake_app/server.rb
 - spec/fake_app/subnet.rb
+- spec/shoulda/matchers/active_model/require_a_valid_domain_name_matcher_spec.rb
+- spec/shoulda/matchers/active_model/require_a_valid_host_name_matcher_spec.rb
+- spec/shoulda/matchers/active_model/require_a_valid_ip_matcher_spec.rb
+- spec/shoulda/matchers/active_model/require_a_valid_subnet_matcher_spec.rb
 - spec/spec_helper.rb
 - spec/validates_host/domain_name_validator_spec.rb
 - spec/validates_host/host_name_validator_spec.rb
 - spec/validates_host/ip_validator_spec.rb
-- spec/validates_host/require_a_valid_domain_name_matcher_spec.rb
-- spec/validates_host/require_a_valid_host_name_matcher_spec.rb
-- spec/validates_host/require_a_valid_ip_matcher_spec.rb
-- spec/validates_host/require_a_valid_subnet_matcher_spec.rb
 - spec/validates_host/subnet_validator_spec.rb

data/.ruby-version

@@ -1 +0,0 @@
-2.3.6

data/spec/validates_host/require_a_valid_domain_name_matcher_spec.rb

@@ -1,23 +0,0 @@
-require 'spec_helper'
-
-describe Shoulda::Matchers::ActiveModel::RequireAValidDomainNameMatcher do
-  before :each do
-    @server = Server.new
-  end
-
-  it 'should accept on domain_name' do
-    expect(@server).to require_a_valid_domain_name(:domain_name)
-  end
-
-  it 'should accept without a specified attribute' do
-    expect(@server).to require_a_valid_domain_name
-  end
-
-  it 'should reject on host_name' do
-    expect(@server).not_to require_a_valid_domain_name(:host_name)
-  end
-
-  it 'should have a description message' do
-    expect(require_a_valid_domain_name.description).to eq('require domain_name to be a valid domain name')
-  end
-end

data/spec/validates_host/require_a_valid_host_name_matcher_spec.rb

@@ -1,23 +0,0 @@
-require 'spec_helper'
-
-describe Shoulda::Matchers::ActiveModel::RequireAValidHostNameMatcher do
-  before :each do
-    @server = Server.new
-  end
-
-  it 'should accept on host_name' do
-    expect(@server).to require_a_valid_host_name(:host_name)
-  end
-
-  it 'should accept without a specified attribute' do
-    expect(@server).to require_a_valid_host_name
-  end
-
-  it 'should reject on domain_name' do
-    expect(@server).not_to require_a_valid_host_name(:domain_name)
-  end
-
-  it 'should have a description message' do
-    expect(require_a_valid_host_name.description).to eq('require host_name to be a valid host name')
-  end
-end

data/spec/validates_host/require_a_valid_ip_matcher_spec.rb

@@ -1,23 +0,0 @@
-require 'spec_helper'
-
-describe Shoulda::Matchers::ActiveModel::RequireAValidIpMatcher do
-  before :each do
-    @server = Server.new
-  end
-
-  it 'should accept on ip' do
-    expect(@server).to require_a_valid_ip(:ip)
-  end
-
-  it 'should accept without a specified attribute' do
-    expect(@server).to require_a_valid_ip
-  end
-
-  it 'should reject on domain_name' do
-    expect(@server).not_to require_a_valid_ip(:domain_name)
-  end
-
-  it 'should have a description message' do
-    expect(require_a_valid_ip.description).to eq('require ip to be a valid ip')
-  end
-end

data/spec/validates_host/require_a_valid_subnet_matcher_spec.rb

@@ -1,23 +0,0 @@
-require 'spec_helper'
-
-describe Shoulda::Matchers::ActiveModel::RequireAValidSubnetMatcher do
-  before :each do
-    @subnet = Subnet.new
-  end
-
-  it 'should accept on value' do
-    expect(@subnet).to require_a_valid_subnet(:value)
-  end
-
-  it 'should accept without a specified attribute' do
-    expect(@subnet).to require_a_valid_subnet
-  end
-
-  it 'should reject on id' do
-    expect(@subnet).not_to require_a_valid_subnet(:id)
-  end
-
-  it 'should have a description message' do
-    expect(require_a_valid_subnet.description).to eq('require value to be a valid subnet')
-  end
-end