validates_host 0.2.0 → 1.2.0

data/lib/validates_host/{shoulda-matchers/ip_matcher.rb → require_a_valid_ip_matcher.rb}

@@ -1,17 +1,15 @@
-require "shoulda-matchers"
+# frozen_string_literal: true
+
+require 'shoulda-matchers'
 
 module Shoulda
   module Matchers
     module ActiveModel
       def require_a_valid_ip(attribute = :ip)
-        IpMatcher.new(attribute)
+        RequireAValidIpMatcher.new(attribute)
       end
 
-      class IpMatcher < ValidationMatcher
-        def initialize(attribute)
-          @attribute = attribute
-        end
-
+      class RequireAValidIpMatcher < ValidationMatcher
         def description
           "require #{@attribute} to be a valid ip"
         end
@@ -19,19 +17,19 @@ module Shoulda
         def matches?(subject)
           super(subject)
 
-          disallows_invalid_value and allows_valid_value
+          disallows_invalid_value && allows_valid_value
         end
 
         private
 
         def disallows_invalid_value
-          disallows_value_of("10.0.0")
+          disallows_value_of('10.0.0')
         end
 
         def allows_valid_value
-          allows_value_of("10.10.10.1")
+          allows_value_of('10.10.10.1')
         end
       end
     end
   end
-end
+end

data/lib/validates_host/require_a_valid_subnet_matcher.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'shoulda-matchers'
+
+module Shoulda
+  module Matchers
+    module ActiveModel
+      def require_a_valid_subnet(attribute = :value)
+        RequireAValidSubnetMatcher.new(attribute)
+      end
+
+      class RequireAValidSubnetMatcher < ValidationMatcher
+        def description
+          "require #{@attribute} to be a valid subnet"
+        end
+
+        def matches?(subject)
+          super(subject)
+
+          disallows_invalid_value && allows_valid_value
+        end
+
+        private
+
+        def disallows_invalid_value
+          disallows_value_of('10.0.0')
+        end
+
+        def allows_valid_value
+          allows_value_of('10.10.10.1/28')
+        end
+      end
+    end
+  end
+end

data/lib/validates_host/subnet.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module ValidatesHost
+  class Subnet
+    def initialize(subnet)
+      @subnet = subnet
+    end
+
+    def valid?
+      return true if @subnet.blank?
+
+      @subnet =~ %r{^([1-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(\.([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])){3}/(2[4-9]|30)$}
+    end
+  end
+end

data/lib/validates_host/subnet_validator.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class SubnetValidator < ActiveModel::EachValidator
+  def validate_each(record, attribute, value)
+    record.errors.add(attribute, :invalid, options) unless ValidatesHost::Subnet.new(value).valid?
+  end
+end

data/lib/validates_host/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ValidatesHost
-  VERSION = "0.2.0"
+  VERSION = '1.2.0'
 end

data/spec/fake_app/server.rb

@@ -1,5 +1,19 @@
-class Server < ActiveRecord::Base
-  validates :domain_name, :domain_name => true
-  validates :host_name, :host_name => true
-  validates :ip, :ip => true
-end
+# frozen_string_literal: true
+
+class Server
+  include ActiveModel::Validations
+  include ActiveModel::Conversion
+  extend ActiveModel::Naming
+
+  attr_accessor :domain_name, :host_name, :ip
+
+  validates :domain_name, domain_name: true
+  validates :host_name, host_name: true
+  validates :ip, ip: true
+
+  def initialize(attributes = {})
+    attributes.each do |name, value|
+      send("#{name}=", value)
+    end
+  end
+end

data/spec/fake_app/subnet.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class Subnet
+  include ActiveModel::Validations
+  include ActiveModel::Conversion
+  extend ActiveModel::Naming
+
+  attr_accessor :id, :value
+
+  validates :value, subnet: true
+end

data/spec/shoulda/matchers/active_model/require_a_valid_domain_name_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidDomainNameMatcher do
+  let(:server) { Server.new }
+
+  it 'accepts on domain_name' do
+    expect(server).to require_a_valid_domain_name(:domain_name)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(server).to require_a_valid_domain_name
+  end
+
+  it 'rejects on host_name' do
+    expect(server).not_to require_a_valid_domain_name(:host_name)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_domain_name.description).to eq('require domain_name to be a valid domain name')
+  end
+end

data/spec/shoulda/matchers/active_model/require_a_valid_host_name_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidHostNameMatcher do
+  let(:server) { Server.new }
+
+  it 'accepts on host_name' do
+    expect(server).to require_a_valid_host_name(:host_name)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(server).to require_a_valid_host_name
+  end
+
+  it 'rejects on domain_name' do
+    expect(server).not_to require_a_valid_host_name(:domain_name)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_host_name.description).to eq('require host_name to be a valid host name')
+  end
+end

data/spec/shoulda/matchers/active_model/require_a_valid_ip_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidIpMatcher do
+  let(:server) { Server.new }
+
+  it 'accepts on ip' do
+    expect(server).to require_a_valid_ip(:ip)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(server).to require_a_valid_ip
+  end
+
+  it 'rejects on domain_name' do
+    expect(server).not_to require_a_valid_ip(:domain_name)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_ip.description).to eq('require ip to be a valid ip')
+  end
+end

data/spec/shoulda/matchers/active_model/require_a_valid_subnet_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidSubnetMatcher do
+  let(:subnet) { Subnet.new }
+
+  it 'accepts on value' do
+    expect(subnet).to require_a_valid_subnet(:value)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(subnet).to require_a_valid_subnet
+  end
+
+  it 'rejects on id' do
+    expect(subnet).not_to require_a_valid_subnet(:id)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_subnet.description).to eq('require value to be a valid subnet')
+  end
+end

data/spec/spec_helper.rb

@@ -1,10 +1,14 @@
-require "rubygems"
-require "rspec"
-require "active_record"
+# frozen_string_literal: true
 
-Dir.glob(File.dirname(__FILE__) + "/../lib/**/*.rb").each { |file| require file }
-Dir.glob(File.dirname(__FILE__) + "/fake_app/**/*.rb").each { |file| require file }
+require 'rspec'
+require 'active_model'
+require 'coveralls'
+require 'shoulda-matchers'
 
-ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :database => ":memory:")
+Coveralls.wear!
 
-CreateServers.migrate(:up)
+require 'validates_host'
+require 'fake_app/server'
+require 'fake_app/subnet'
+
+include Shoulda::Matchers::ActiveModel

data/spec/validates_host/domain_name_validator_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe DomainNameValidator do
+  let(:server) { Server.new }
+
+  context 'when domain_name is invalid' do
+    before do
+      server.domain_name = 'http://'
+      server.valid?
+    end
+
+    it 'sets object as invalid' do
+      expect(server).not_to be_valid
+    end
+
+    it 'sets an error' do
+      expect(server.errors[:domain_name]).to eq(['is invalid'])
+    end
+  end
+
+  context 'when domain_name is valid' do
+    before do
+      server.domain_name = 'example.com'
+      server.valid?
+    end
+
+    it 'sets object as valid' do
+      expect(server).to be_valid
+    end
+
+    it 'does not set an error on attribute' do
+      expect(server.errors[:domain_name]).to be_blank
+    end
+  end
+
+  it 'is valid with a nil value' do
+    expect(server).to be_valid
+  end
+end

data/spec/validates_host/host_name_validator_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe HostNameValidator do
+  let(:server) { Server.new }
+
+  context 'when host_name is invalid' do
+    before do
+      server.host_name = 'http://'
+      server.valid?
+    end
+
+    it 'sets object as invalid' do
+      expect(server).not_to be_valid
+    end
+
+    it 'sets an error' do
+      expect(server.errors[:host_name]).to eq(['is invalid'])
+    end
+  end
+
+  context 'when host_name is valid' do
+    before do
+      server.host_name = 'bd01'
+      server.valid?
+    end
+
+    it 'sets object as valid' do
+      expect(server).to be_valid
+    end
+
+    it 'does not set an error on attribute' do
+      expect(server.errors[:host_name]).to be_blank
+    end
+  end
+
+  it 'is valid with a nil value' do
+    expect(server).to be_valid
+  end
+end

data/spec/validates_host/ip_validator_spec.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe IpValidator do
+  let(:server) { Server.new }
+
+  context 'when ip is invalid' do
+    before do
+      server.ip = '127.0.0'
+      server.valid?
+    end
+
+    it 'sets object as invalid' do
+      expect(server).not_to be_valid
+    end
+
+    it 'sets an error' do
+      expect(server.errors[:ip]).to eq(['is invalid'])
+    end
+  end
+
+  context 'when ip is IPV4 valid' do
+    before do
+      server.ip = '10.10.10.1'
+      server.valid?
+    end
+
+    it 'sets object as valid' do
+      expect(server).to be_valid
+    end
+
+    it 'does not set an error on attribute' do
+      expect(server.errors[:ip]).to be_blank
+    end
+  end
+
+  context 'when ip is IPV6 valid' do
+    before do
+      server.ip = 'fd92:fe56:b43a:062e:ffff:ffff:ffff:ffff'
+      server.valid?
+    end
+
+    it 'sets object as valid' do
+      expect(server).to be_valid
+    end
+
+    it 'does not set an error on attribute' do
+      expect(server.errors[:ip]).to be_blank
+    end
+  end
+
+  it 'is valid with a nil value' do
+    expect(server).to be_valid
+  end
+end

data/spec/validates_host/subnet_validator_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe SubnetValidator do
+  let(:subnet) { Subnet.new }
+
+  context 'when subnet is invalid' do
+    before do
+      subnet.value = '127.0.0'
+      subnet.valid?
+    end
+
+    it 'sets object as invalid' do
+      expect(subnet).not_to be_valid
+    end
+
+    it 'sets an error' do
+      expect(subnet.errors[:value]).to eq(['is invalid'])
+    end
+  end
+
+  context 'when subnet is valid' do
+    before do
+      subnet.value = '10.10.10.1/28'
+      subnet.valid?
+    end
+
+    it 'sets object as valid' do
+      expect(subnet).to be_valid
+    end
+
+    it 'does not set an error on attribute' do
+      expect(subnet.errors[:value]).to be_blank
+    end
+  end
+
+  it 'is valid with a nil value' do
+    expect(subnet).to be_valid
+  end
+end