validates_formatting_of 0.7.0 → 0.7.1

data/.travis.yml

@@ -1,4 +1,4 @@
-script: SKIP_SIMPLECOV=true bundle exec rspec spec
+script: bundle exec rspec spec
 rvm:
   - 1.9.2
   - 1.9.3

data/README.markdown

@@ -55,14 +55,36 @@ You can still add the following options when using `validates_formatting_of`:
 * `:unless`
 * You can also specify the `:message` option to use a custom validation message.
 
-# Available Formatting Validations
+# Share your Validations
 
-`validates_formatting_of` has support for the following validations:
+Say, for example, you have identical plain-old regex validations for different columns or even on different models entirely. You can easily alleviate this problem by simply adding the validation(s) in an initializer file.
+
+While very unrealistic, these examples should serve their purpose in demonstrating this ability.
+
+```ruby
+# config/initializers/validates_foramatting_of.rb
+ValidatesFormattingOf::Method.add :loweralpha, /[a-z]/, "must be lowercase and no spaces"
+ValidatesFormattingOf::Method.add :upperalpha, /[A-Z]/, "must be uppercase and no spaces"
+ValidatesFormattingOf::Method.add :weak_password, /[a-zA-Z0-9]{8,}/, "must contain only letters and numbers and be at least 8 characters long".
+```
+
+Keep in mind, since this gem is only ActiveModel-dependent, you should be able to do this in whatever non-Rails application classes you have that include `ActiveModel::Validations` in some way (and that extend the `ValidatesFormattingOf::ModelAdditons` module).
+
+# Built-in Validations
+
+`validates_formatting_of` has the following build-in validations:
 
 ### Email
 
 ```ruby
-class User < ActiveRecord::Base
+# non ActiveRecord::Base example. This is the least you need to get validations running.
+class User
+
+  include ActiveModel::Validations
+  extend ValidatesFormattingOf::ModelAdditions
+
+  attr_accessor :email
+
   validates_formatting_of :email, :using => :email
 end
 ```

data/lib/validates_formatting_of/validation_addition.rb

@@ -19,9 +19,6 @@ module ValidatesFormattingOf
     def find(attribute, opts = {})
       method = opts.fetch(:using, attribute)
       raise MissingValidation.new(method) if missing? method
-      if method.to_sym == :ip_address
-        raise ArgumentError, "[REMOVED] The :ip_address validation for `validates_formatting_of` has been removed since version 0.7.0. Please update your model validations to use :ip_address_v4."
-      end
       @validations[method.to_sym]
     end
 

data/lib/validates_formatting_of/version.rb

@@ -1,3 +1,3 @@
 module ValidatesFormattingOf
-  VERSION = "0.7.0"
+  VERSION = "0.7.1"
 end

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 require 'simplecov'
 
-unless ENV["SKIP_SIMPLECOV"] == 'true'
+if ENV["RUN_SIMPLECOV"] == 'true'
   SimpleCov.start do
     load_adapter 'test_frameworks'
   end
@@ -10,9 +10,8 @@ require 'validates_formatting_of'
 require 'active_model'
 
 class TestActiveRecord
-  include ActiveModel::Validations
-  include ActiveModel::Conversion
 
+  include ActiveModel::Validations
   extend ValidatesFormattingOf::ModelAdditions
 
   def initialize(attributes = {})

data/spec/validates_formatting_of/validation_addition_spec.rb

@@ -4,28 +4,33 @@ module ValidatesFormattingOf
 
   class TestAdding
     extend ValidationAddition
+    def self.clear!
+      @validations = nil
+    end
   end
 
   describe ValidationAddition do
     before do
+      TestAdding.clear!
       TestAdding.add :email, /email/i
     end
-    after do
-      TestAdding.instance_variable_set("@validations", nil)
-    end
     it "should be able to add new validations" do
       TestAdding.add :another, /another/i
       TestAdding.validations.count.should == 2
       TestAdding.validations[:email].should be_instance_of Validation
       TestAdding.validations[:another].should be_instance_of Validation
     end
-    it "should be able to smartly determine the method to use" do
-      validation = TestAdding.find(:email)
-      validation.name.should == :email
-      validation.regex.should == /email/i
-      validation = TestAdding.find(:non_existent_validation, :using => :email)
-      validation.name.should == :email
-      validation.regex.should == /email/i
+    describe "find" do
+      context "implicit validation method" do
+        subject { TestAdding.find(:email) }
+        its(:name) { should == :email }
+        its(:regex) { should == /email/i }
+      end
+      context "explicit validation method" do
+        subject { TestAdding.find(:non_existent_validation, :using => :email) }
+        its(:name)  { should == :email   }
+        its(:regex) { should == /email/i }
+      end
     end
     it "should raise an error if the method does not exist" do
       expect { TestAdding.find(:fake) }.to raise_error MissingValidation

data/spec/validates_formatting_of/validation_spec.rb

@@ -5,19 +5,14 @@ module ValidatesFormattingOf
   describe Validation do
     context "valid validation creation" do
       let(:validation) { Validation.new(:name, /something/i, "is an invalid value") }
-      it "should receive the right parameters" do
-        validation.name.should == :name
-        validation.regex.should == %r{something}i
-        validation.message.should == 'is an invalid value'
-      end
-      it "should print properly" do
-        validation.to_s.should == "<Validation::name>"
-      end
-      it "should be inspected properly" do
-        validation.inspect.should =~ /Validation/
-        validation.inspect.should =~ /\/something\/i/
-        validation.inspect.should =~ /\:name/
-      end
+      subject { validation }
+      its(:name) { should == :name }
+      its(:regex) { should == %r{something}i }
+      its(:message) { should == 'is an invalid value' }
+      its(:to_s) { should == "<Validation::name>" }
+      its(:inspect) { should =~ /Validation/ }
+      its(:inspect) { should =~ /\/something\/i/ }
+      its(:inspect) { should =~ /\:name/ }
     end
     context "invalid validation creation" do
       it "should raise an error if the specified regex is not a Regexp objct" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: validates_formatting_of
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-20 00:00:00.000000000 Z
+date: 2012-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -132,3 +132,4 @@ test_files:
 - spec/validates_formatting_of/model_additions_spec.rb
 - spec/validates_formatting_of/validation_addition_spec.rb
 - spec/validates_formatting_of/validation_spec.rb
+has_rdoc: