validates_email_format_of 1.5.3 → 1.6.0

data/lib/validates_email_format_of/railtie.rb

@@ -0,0 +1,7 @@
+module ValidatesEmailFormatOf
+  class Railtie < Rails::Railtie
+    initializer 'validates_email_format_of.load_i18n_locales' do |app|
+      ValidatesEmailFormatOf::load_i18n_locales
+    end
+  end
+end

data/lib/validates_email_format_of/rspec_matcher.rb

@@ -0,0 +1,15 @@
+require "validates_email_format_of"
+
+RSpec::Matchers.define :validate_email_format_of do |attribute|
+  match do
+    actual_class_name = subject.is_a?(Class) ? subject : subject.class
+    actual = actual_class_name.new
+    actual.send(:"#{attribute}=", "invalid@example.")
+    expect(actual).to be_invalid
+    @expected_message ||= ValidatesEmailFormatOf.default_message
+    expect(actual.errors.messages[attribute.to_sym]).to include(@expected_message)
+  end
+  chain :with_message do |message|
+    @expected_message = message
+  end
+end

data/lib/validates_email_format_of/version.rb

@@ -0,0 +1,3 @@
+module ValidatesEmailFormatOf
+  VERSION = '1.6.0'
+end

data/rakefile.rb

@@ -1,27 +1 @@
-require 'rake'
-require 'rake/testtask'
-require 'rake/rdoctask'
-
-desc 'Default: run unit tests.'
-task :default => [:clean_log, :test]
-
-desc 'Remove the old log file'
-task :clean_log do
-  "rm -f #{File.dirname(__FILE__)}/test/debug.log" if File.exists?(File.dirname(__FILE__) + '/test/debug.log')
-end
-
-desc 'Test the validates_email_format_of plugin.'
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.pattern = FileList['test/**/*_test.rb']
-  t.verbose = true
-end
-
-desc 'Generate documentation for the validates_email_format_of plugin and gem.'
-Rake::RDocTask.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'validates_email_format_of plugin and gem'
-  rdoc.options << '--line-numbers --inline-source'
-  rdoc.rdoc_files.include('README.rdoc')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
+require 'bundler/gem_tasks'

data/spec/rspec_matcher_spec.rb

@@ -0,0 +1,14 @@
+require "#{File.expand_path(File.dirname(__FILE__))}/spec_helper"
+if defined?(ActiveModel)
+  require "validates_email_format_of/rspec_matcher"
+
+  class Person
+    attr_accessor :email_address
+    include ::ActiveModel::Validations
+    validates_email_format_of :email_address
+  end
+
+  describe Person do
+    it { should validate_email_format_of(:email_address) }
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,29 @@
+require 'active_model' if Gem.loaded_specs.keys.include?('activemodel')
+
+RSpec::Matchers.define :have_errors_on_email do
+  match do |actual|
+    expect(actual).not_to be_nil, "#{actual} should not be nil"
+    expect(actual).not_to be_empty, "#{actual} should not be empty"
+    expect(actual.size).to eq(@reasons.size), "#{actual} should have #{@reasons.size} elements"
+    @reasons.each do |reason|
+      reason = "#{"Email " if defined?(ActiveModel)}#{reason}"
+      expect(actual).to include(reason), "#{actual} should contain #{reason}"
+    end
+  end
+  chain :because do |reason|
+    (@reasons ||= []) << reason
+  end
+  chain :and_because do |reason|
+    (@reasons ||= []) << reason
+  end
+  match_when_negated do |actual|
+    expect(actual).to (defined?(ActiveModel) ? be_empty : be_nil)
+  end
+end
+
+RSpec.configure do |config|
+  config.before(:suite) do
+    ValidatesEmailFormatOf.load_i18n_locales
+    I18n.enforce_available_locales = false
+  end
+end

data/spec/validates_email_format_of_spec.rb

@@ -0,0 +1,308 @@
+# -*- encoding : utf-8 -*-
+require "#{File.expand_path(File.dirname(__FILE__))}/spec_helper"
+require "validates_email_format_of"
+
+describe ValidatesEmailFormatOf do
+  subject do |example|
+    if defined?(ActiveModel)
+      user = Class.new do
+        def initialize(email)
+          @email = email.freeze
+        end
+        attr_reader :email
+        include ActiveModel::Validations
+        validates_email_format_of :email, example.example_group_instance.options
+      end
+      example.example_group_instance.class::User = user
+      user.new(example.example_group_instance.email).tap(&:valid?).errors.full_messages
+    else
+      ValidatesEmailFormatOf::validate_email_format(email.freeze, options)
+    end
+  end
+  let(:options) { {} }
+  let(:email) { |example| example.example_group.description }
+
+  shared_examples_for :all_specs do
+    [
+      'valid@example.com',
+      'Valid@test.example.com',
+      'valid+valid123@test.example.com',
+      'valid_valid123@test.example.com',
+      'valid-valid+123@test.example.co.uk',
+      'valid-valid+1.23@test.example.com.au',
+      'valid@example.co.uk',
+      'v@example.com',
+      'valid@example.ca',
+      'valid_@example.com',
+      'valid123.456@example.org',
+      'valid123.456@example.travel',
+      'valid123.456@example.museum',
+      'valid@example.mobi',
+      'valid@example.info',
+      'valid-@example.com',
+      'fake@p-t.k12.ok.us',
+      # allow single character domain parts
+      'valid@mail.x.example.com',
+      'valid@x.com',
+      'valid@example.w-dash.sch.uk',
+      # from RFC 3696, page 6
+      'customer/department=shipping@example.com',
+      '$A12345@example.com',
+      '!def!xyz%abc@example.com',
+      '_somename@example.com',
+      # apostrophes
+      "test'test@example.com",
+      # international domain names
+      'test@xn--bcher-kva.ch',
+      'test@example.xn--0zwm56d',
+      'test@192.192.192.1',
+      # Allow quoted characters.  Valid according to http://www.rfc-editor.org/errata_search.php?rfc=3696
+      '"Abc\@def"@example.com',
+      '"Fred\ Bloggs"@example.com',
+      '"Joe.\\Blow"@example.com',
+      # Balanced quoted characters
+      %!"example\\\\\\""@example.com!,
+      %!"example\\\\"@example.com!
+    ].each do |address|
+      describe address do
+        it { should_not have_errors_on_email }
+      end
+    end
+
+    [
+      'no_at_symbol',
+      'invalid@example-com',
+      # period can not start local part
+        '.invalid@example.com',
+      # period can not end local part
+        'invalid.@example.com',
+      # period can not appear twice consecutively in local part
+        'invali..d@example.com',
+      # should not allow underscores in domain names
+      'invalid@ex_mple.com',
+      'invalid@e..example.com',
+      'invalid@p-t..example.com',
+      'invalid@example.com.',
+      'invalid@example.com_',
+      'invalid@example.com-',
+      'invalid-example.com',
+      'invalid@example.b#r.com',
+      'invalid@example.c',
+      'invali d@example.com',
+      # TLD can not be only numeric
+      'invalid@example.123',
+      # unclosed quote
+      "\"a-17180061943-10618354-1993365053@example.com",
+      # too many special chars used to cause the regexp to hang
+      "-+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++@foo",
+      'invalidexample.com',
+      # should not allow special chars after a period in the domain
+      'local@sub.)domain.com',
+      'local@sub.#domain.com',
+      # one at a time
+      "foo@example.com\nexample@gmail.com",
+      'invalid@example.',
+      "\"foo\\\\\"\"@bar.com",
+      "foo@mail.com\r\nfoo@mail.com",
+      '@example.com',
+      'foo@',
+      'foo',
+      'Iñtërnâtiônàlizætiøn@hasnt.happened.to.email',
+      # Escaped characters with quotes.  From http://tools.ietf.org/html/rfc3696, page 5.  Corrected in http://www.rfc-editor.org/errata_search.php?rfc=3696
+      'Fred\ Bloggs_@example.com',
+      'Abc\@def+@example.com',
+      'Joe.\\Blow@example.com',
+      # Unbalanced quoted characters
+      %!"example\\\\""example.com!
+    ].each do |address|
+      describe address do
+        it { should have_errors_on_email.because("does not appear to be a valid e-mail address") }
+      end
+    end
+
+    describe do
+      shared_examples_for :local_length_limit do |limit|
+        describe "#{'a' * limit}@example.com" do
+          it { should_not have_errors_on_email }
+        end
+        describe "#{'a' * (limit + 1)}@example.com" do
+          it { should have_errors_on_email.because("does not appear to be a valid e-mail address") }
+        end
+      end
+      describe "when using default" do
+        it_should_behave_like :local_length_limit, 64
+      end
+      describe "when overriding defaults" do
+        let(:options) { { :local_length => 20 } }
+        it_should_behave_like :local_length_limit, 20
+      end
+    end
+    describe do
+      shared_examples_for :domain_length_limit do |limit|
+        describe "user@#{'a' * (limit - 4)}.com" do
+          it { should_not have_errors_on_email }
+        end
+        describe "user@#{'a' * (limit - 3)}.com" do
+          it { should have_errors_on_email.because("does not appear to be a valid e-mail address") }
+        end
+      end
+      describe "when using default" do
+        it_should_behave_like :domain_length_limit, 255
+      end
+      describe "when overriding defaults" do
+        let(:options) { { :domain_length => 100 } }
+        it_should_behave_like :domain_length_limit, 100
+      end
+    end
+
+    describe "custom error messages" do
+      describe 'invalid@example.' do
+        let(:options) { { :message => "just because I don't like you" } }
+        it { should have_errors_on_email.because("just because I don't like you") }
+      end
+    end
+
+    describe "mx record" do
+      domain = "stubbed.com"
+      email = "valid@#{domain}"
+      describe "when testing" do
+        let(:dns) { double(Resolv::DNS) }
+        let(:mx_record) { [double] }
+        let(:a_record) { [double] }
+        before(:each) do
+          allow(Resolv::DNS).to receive(:open).and_yield(dns)
+          allow(dns).to receive(:getresources).with(domain, Resolv::DNS::Resource::IN::MX).once.and_return(mx_record)
+          allow(dns).to receive(:getresources).with(domain, Resolv::DNS::Resource::IN::A).once.and_return(a_record)
+        end
+        let(:options) { { :check_mx => true } }
+        describe "and only an mx record is found" do
+          let(:a_record) { [] }
+          describe email do
+            it { should_not have_errors_on_email }
+          end
+        end
+        describe "and only an a record is found" do
+          let(:mx_record) { [] }
+          describe email do
+            it { should_not have_errors_on_email }
+          end
+        end
+        describe "and both an mx record and an a record are found" do
+          describe email do
+            it { should_not have_errors_on_email }
+          end
+        end
+        describe "and neither an mx record nor an a record is found" do
+          let(:a_record) { [] }
+          let(:mx_record) { [] }
+          describe email do
+            it { should have_errors_on_email.because("is not routable") }
+          end
+          describe "with a custom error message" do
+            let(:options) { { :check_mx => true, :mx_message => "There ain't no such domain!" } }
+            describe email do
+              it { should have_errors_on_email.because("There ain't no such domain!") }
+            end
+          end
+          describe "i18n" do
+            before(:each) { allow(I18n.config).to receive(:locale).and_return(locale) }
+            describe "present locale" do
+              let(:locale) { :pl }
+              describe email do
+                it { should have_errors_on_email.because("jest nieosiągalny") }
+              end
+            end
+            describe email do
+              let(:locale) { :ir }
+              describe email do
+                it { should have_errors_on_email.because("is not routable") }
+              end
+            end
+          end
+          unless defined?(ActiveModel)
+            describe "without i18n" do
+              before(:each) { hide_const("I18n") }
+              describe email do
+                it { should have_errors_on_email.because("is not routable") }
+              end
+            end
+          end
+        end
+      end
+      describe "when not testing" do
+        before(:each) { allow(Resolv::DNS).to receive(:open).never }
+        describe "by default" do
+          describe email do
+            it { should_not have_errors_on_email }
+          end
+        end
+        describe "explicitly" do
+          describe email do
+            let(:options) { { :check_mx => false } }
+            it { should_not have_errors_on_email }
+          end
+        end
+      end
+      describe "without mocks" do
+        describe email do
+          let(:options) { { :check_mx => true } }
+          it { should_not have_errors_on_email }
+        end
+      end
+    end
+
+    describe "custom regex" do
+      let(:options) { { :with => /[0-9]+\@[0-9]+/ } }
+      describe '012345@789' do
+        it { should_not have_errors_on_email }
+      end
+      describe 'valid@example.com' do
+        it { should have_errors_on_email.because("does not appear to be a valid e-mail address") }
+      end
+    end
+
+    describe "i18n" do
+      before(:each) { allow(I18n.config).to receive(:locale).and_return(locale) }
+      describe "present locale" do
+        let(:locale) { :pl }
+        describe "invalid@exmaple." do
+          it { should have_errors_on_email.because("nieprawidłowy adres e-mail") }
+        end
+      end
+      describe "missing locale" do
+        let(:locale) { :ir }
+        describe "invalid@exmaple." do
+          it { should have_errors_on_email.because("does not appear to be valid") }
+        end
+      end
+    end
+    unless defined?(ActiveModel)
+      describe "without i18n" do
+        before(:each) { hide_const("I18n") }
+        describe "invalid@exmaple." do
+          it { should have_errors_on_email.because("does not appear to be valid") }
+        end
+      end
+    end
+  end
+  it_should_behave_like :all_specs
+
+  if defined?(ActiveModel)
+    describe "shorthand ActiveModel validation" do
+      subject do |example|
+        user = Class.new do
+          def initialize(email)
+            @email = email.freeze
+          end
+          attr_reader :email
+          include ActiveModel::Validations
+          validates :email, :email_format => example.example_group_instance.options
+        end
+        example.example_group_instance.class::User = user
+        user.new(example.example_group_instance.email).tap(&:valid?).errors.full_messages
+      end
+
+      it_should_behave_like :all_specs
+    end
+  end
+end

data/validates_email_format_of.gemspec

@@ -0,0 +1,21 @@
+# -*- encoding: utf-8 -*-
+$:.unshift File.expand_path('../lib', __FILE__)
+require 'validates_email_format_of/version'
+
+spec = Gem::Specification.new do |s|
+  s.name          = 'validates_email_format_of'
+  s.version       = ValidatesEmailFormatOf::VERSION
+  s.summary       = 'Validate e-mail addresses against RFC 2822 and RFC 3696.'
+  s.description   = s.summary
+  s.authors       = ['Alex Dunae', 'Isaac Betesh']
+  s.email         = ['code@dunae.ca', 'iybetesh@gmail.com']
+  s.homepage      = 'https://github.com/validates-email-format-of/validates_email_format_of'
+  s.license       = 'MIT'
+  s.test_files    = s.files.grep(%r{^test/})
+  s.files         = `git ls-files`.split($/)
+  s.require_paths = ['lib']
+
+  s.add_dependency 'i18n'
+  s.add_development_dependency 'bundler'
+  s.add_development_dependency 'rspec'
+end

metadata

@@ -1,87 +1,113 @@
 --- !ruby/object:Gem::Specification
 name: validates_email_format_of
 version: !ruby/object:Gem::Version
-  version: 1.5.3
-  prerelease: 
+  version: 1.6.0
 platform: ruby
 authors:
 - Alex Dunae
+- Isaac Betesh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-12 00:00:00.000000000Z
+date: 2014-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: &2160409580 !ruby/object:Gem::Requirement
-    none: false
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160409580
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: activerecord
-  requirement: &2160407040 !ruby/object:Gem::Requirement
-    none: false
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160407040
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Validate e-mail addresses against RFC 2822 and RFC 3696.
-email: code@dunae.ca
+email:
+- code@dunae.ca
+- iybetesh@gmail.com
 executables: []
 extensions: []
-extra_rdoc_files:
-- README.rdoc
-- MIT-LICENSE
+extra_rdoc_files: []
 files:
+- .gitignore
+- .rspec
+- .travis.yml
+- Gemfile
 - MIT-LICENSE
-- init.rb
-- rakefile.rb
 - README.rdoc
+- config/locales/en.yml
+- config/locales/pl.yml
+- gemfiles/Gemfile.active_model_2_1
+- gemfiles/Gemfile.active_model_3_0
+- gemfiles/Gemfile.active_model_3_1
+- gemfiles/Gemfile.active_model_3_2
+- gemfiles/Gemfile.active_model_3_3
+- gemfiles/Gemfile.active_model_4_0
+- gemfiles/Gemfile.active_model_4_1
 - lib/validates_email_format_of.rb
-- test/fixtures/person.rb
-- test/schema.rb
-- test/test_helper.rb
-- test/validates_email_format_of_test.rb
-- test/database.yml
-- test/fixtures/people.yml
-homepage: https://github.com/alexdunae/validates_email_format_of
-licenses: []
+- lib/validates_email_format_of/active_model.rb
+- lib/validates_email_format_of/railtie.rb
+- lib/validates_email_format_of/rspec_matcher.rb
+- lib/validates_email_format_of/version.rb
+- rakefile.rb
+- spec/rspec_matcher_spec.rb
+- spec/spec_helper.rb
+- spec/validates_email_format_of_spec.rb
+- validates_email_format_of.gemspec
+homepage: https://github.com/validates-email-format-of/validates_email_format_of
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
-rdoc_options:
-- --title
-- validates_email_format_of
+rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 2.1.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Validate e-mail addresses against RFC 2822 and RFC 3696.
-test_files:
-- test/fixtures/person.rb
-- test/schema.rb
-- test/test_helper.rb
-- test/validates_email_format_of_test.rb
-- test/database.yml
-- test/fixtures/people.yml
+test_files: []