valid_email2 4.0.6 → 5.0.0

data/lib/valid_email2/address.rb

@@ -91,12 +91,14 @@ module ValidEmail2
 
     def valid_mx?
       return false unless valid?
+      return false if null_mx?
 
       mx_or_a_servers.any?
     end
 
     def valid_strict_mx?
       return false unless valid?
+      return false if null_mx?
 
       mx_servers.any?
     end
@@ -138,6 +140,10 @@ module ValidEmail2
       end
     end
 
+    def null_mx?
+      mx_servers.length == 1 && mx_servers.first.preference == 0 && mx_servers.first.exchange.length == 0
+    end
+
     def mx_or_a_servers
       @mx_or_a_servers ||= Resolv::DNS.open do |dns|
         dns.timeouts = @dns_timeout

data/lib/valid_email2/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal:true
 
 module ValidEmail2
-  VERSION = "4.0.6"
+  VERSION = "5.0.0"
 end

data/spec/valid_email2_spec.rb

@@ -255,6 +255,11 @@ describe ValidEmail2 do
       user = TestUserMX.new(email: "foo@subdomain.gmail.com")
       expect(user.valid?).to be_falsey
     end
+
+    it "is invalid if a null mx is found" do
+      user = TestUserMX.new(email: "foo@gmail.de")
+      expect(user.valid?).to be_falsey
+    end
   end
 
   describe "with strict mx validation" do
@@ -272,6 +277,11 @@ describe ValidEmail2 do
       user = TestUserStrictMX.new(email: "foo@subdomain.gmail.com")
       expect(user.valid?).to be_falsey
     end
+
+    it "is invalid if a null mx is found" do
+      user = TestUserStrictMX.new(email: "foo@gmail.de")
+      expect(user.valid?).to be_falsey
+    end
   end
 
   describe "with dotted validation" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email2
 version: !ruby/object:Gem::Version
-  version: 4.0.6
+  version: 5.0.0
 platform: ruby
 authors:
 - Micke Lisinge
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-24 00:00:00.000000000 Z
+date: 2023-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler