valid_email2 3.7.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4cb2c121fd6702c7060c30c6b79be1bd4f08c40ed94f06aa3f360c333b28a5d6
-  data.tar.gz: '09ed3d5c345731baaf90bda8bf5fca432c753277cdd909e19e58feef7525f404'
+  metadata.gz: d71886fd78b212aba95930356a6c8881f1e9368561a2cf96a961ff31798ca2ce
+  data.tar.gz: a1e3e23dc457a405b7394d673773f82acb6366d21629e037038337a31a0748e9
 SHA512:
-  metadata.gz: 6718851acadedad38dd94c423a9fe84b71469fd9ee14b97687b4400f36edc7f31eeeb2fe63b973a3e451f6bcb3f8fda32f448571d1590e0b23319a78fcff3b7e
-  data.tar.gz: f794802a5e7e4ee12a5c840e900d167e6d7ccaf3cefce4eaa285cf6b4d3fc100f364c37ebd9a00f4ab9368444745d0bc72e8237e3372f69145c5a471478a6f47
+  metadata.gz: ff81fb5ba77ed53af7835033cae8bb1a10efe35a18b51a24dbe6af1030b6ee5fac5db9ed6d28066e6d07875d9b84c5079f3b9f2e94131f68a6772254fd8266d0
+  data.tar.gz: 452ccbe3dee5b6df8b93625283c1e592474a56cc4dd5f8b51e043b9ff6dc41ad4ad023cb397a962edc0e9d26b3c4fa863a545feb8ff4dcb771c228a66de01ce1

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## Version 4.0.0
+* Support setting a timout for DNS lookups and default to 5 seconds https://github.com/micke/valid_email2/pull/181
+
 ## Version 3.7.0
 * Support validating arrays https://github.com/micke/valid_email2/pull/178
 * Pull new domains

data/README.md

@@ -47,10 +47,15 @@ To validate that the domain has an MX record or A record:
 ```ruby
 validates :email, 'valid_email_2/email': { mx: true }
 ```
+
 To validate strictly that the domain has an MX record:
 ```ruby
 validates :email, 'valid_email_2/email': { strict_mx: true }
 ```
+`strict_mx` and `mx` both default to a 5 second timeout for DNS lookups.  To
+override this timeout, specify a `dns_timeout` option:
+```ruby
+validates :email, 'valid_email_2/email': { strict_mx: true, dns_timeout: 10 }
 
 To validate that the domain is not a disposable email (checks domain and MX server):
 ```ruby

data/lib/valid_email2/address.rb

@@ -20,9 +20,10 @@ module ValidEmail2
       @prohibited_domain_characters_regex = val
     end
 
-    def initialize(address)
+    def initialize(address, dns_timeout = 5)
       @parse_error = false
       @raw_address = address
+      @dns_timeout = dns_timeout
 
       begin
         @address = Mail::Address.new(address)
@@ -132,12 +133,14 @@ module ValidEmail2
 
     def mx_servers
       @mx_servers ||= Resolv::DNS.open do |dns|
+        dns.timeouts = @dns_timeout
         dns.getresources(address.domain, Resolv::DNS::Resource::IN::MX)
       end
     end
 
     def mx_or_a_servers
       @mx_or_a_servers ||= Resolv::DNS.open do |dns|
+        dns.timeouts = @dns_timeout
         (mx_servers.any? && mx_servers) ||
           dns.getresources(address.domain, Resolv::DNS::Resource::IN::A)
       end

data/lib/valid_email2/email_validator.rb

@@ -5,14 +5,14 @@ require "active_model/validations"
 module ValidEmail2
   class EmailValidator < ActiveModel::EachValidator
     def default_options
-      { regex: true, disposable: false, mx: false, strict_mx: false, disallow_subaddressing: false, multiple: false }
+      { regex: true, disposable: false, mx: false, strict_mx: false, disallow_subaddressing: false, multiple: false, dns_timeout: 5 }
     end
 
     def validate_each(record, attribute, value)
       return unless value.present?
       options = default_options.merge(self.options)
 
-      addresses = sanitized_values(value).map { |v| ValidEmail2::Address.new(v) }
+      addresses = sanitized_values(value).map { |v| ValidEmail2::Address.new(v, options[:dns_timeout]) }
 
       error(record, attribute) && return unless addresses.all?(&:valid?)
 

data/lib/valid_email2/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal:true
 
 module ValidEmail2
-  VERSION = "3.7.0"
+  VERSION = "4.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email2
 version: !ruby/object:Gem::Version
-  version: 3.7.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Micke Lisinge
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-06-26 00:00:00.000000000 Z
+date: 2021-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler