valid_email2 3.2.2 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 72dbf447c5b40cb7e347efa6a7e7e44bcde6b81cef1b1fbb9ba4703adff15e6b
-  data.tar.gz: 36b83448929482e263e09dfd579e1359f6c3066fd418c26437c14274f736d072
+  metadata.gz: fe834d489ba46cf4a8262cb077bf2f88b0fd866b604bf1ae628d877bbfdbb57b
+  data.tar.gz: af8e27efffae003ed85189ae10d1f9b6e30817e8529deb4064811156a332208e
 SHA512:
-  metadata.gz: 7ce45d7dd425b621280b5977378a6b7b3001b2e7e909b92b2b261094bdd4529a628820df5440969d8f8dde839a581e7c478069b5cb2b1a24a440256f174c3f5c
-  data.tar.gz: 668831fbb29286e4a3f9d4e3adda30312a34c0f90ce366e4574dbb506cd4d5ba794d6cfe59533e467f7f7f95325a60e6cbb52337cf55c620b378fa83e6c22a8d
+  metadata.gz: 300c5f449125f0d6bd1abfd224aa88c65caa0377fe2b2a56ec6bc695bb3c0e9bac4ea03f2c091509c19f5cb8614137578ec8fc52a844cfd0765f9da7d5707615
+  data.tar.gz: ce9dfe893b11555a195f4777e3146f0065c3d49c26b289e874d01cb40da0f02f575f5a3efd8430e57bffdd2aaf52a36f05056986b789b3bd982b14d889bea0e2

data/CHANGELOG.md

@@ -1,3 +1,22 @@
+## Version 3.3.1
+* Fix some performance regressions (https://github.com/micke/valid_email2/pull/150)
+
+## Version 3.3.0
+* Allow multiple addresses separated by comma (https://github.com/micke/valid_email2/pull/156)
+* Make prohibited_domain_characters_regex changeable (https://github.com/micke/valid_email2/pull/157)
+
+## Version 3.2.5
+* Remove false positives
+* Pull new domains
+
+## Version 3.2.4
+* Remove false positives
+
+## Version 3.2.3
+* Disallow backtick (\`) in domain
+* https://github.com/micke/valid_email2/pull/152
+* https://github.com/micke/valid_email2/pull/151
+
 ## Version 3.2.2
 * Disallow quote (') in domain
 

data/README.md

@@ -4,7 +4,7 @@
 
 Validate emails with the help of the `mail` gem instead of some clunky regexp.
 Aditionally validate that the domain has a MX record.
-Optionally validate against a static [list of disposable email services](config/disposable_email_domains.yml).
+Optionally validate against a static [list of disposable email services](config/disposable_email_domains.txt).
 Optionally validate that the email is not subaddressed ([RFC5233](https://tools.ietf.org/html/rfc5233)).
 
 ### Why?
@@ -83,6 +83,11 @@ To validate create your own custom message:
 validates :email, 'valid_email_2/email': { message: "is not a valid email" }
 ```
 
+To allow multiple addresses separated by comma:
+```ruby
+validates :email, 'valid_email_2/email': { multiple: true }
+```
+
 All together:
 ```ruby
 validates :email, 'valid_email_2/email': { mx: true, disposable: true, disallow_subaddressing: true}

data/config/disposable_email_domains.txt

@@ -4181,6 +4181,9 @@ awahal0vk1o7gbyzf0.ml
 awahal0vk1o7gbyzf0.tk
 awatum.de
 awca.eu
+awdrt.com
+awdrt.net
+awdrt.org
 aweather.ru
 aweightlossguide.com
 awemail.com
@@ -4672,6 +4675,7 @@ beaniemania.net
 beanlignt.com
 bearegone.pro
 bearsarefuzzy.com
+beastmail.email
 beastrapleaks.blogspot.com
 beatelse.com
 beats-rock.com
@@ -7862,6 +7866,7 @@ cungmuachungnhom.com
 cungsuyngam.com
 cungtam.com
 cuoiz.com
+cuoly.com
 cuongvumarketingseo.com
 cupf6mdhtujxytdcoxh.cf
 cupf6mdhtujxytdcoxh.ga
@@ -9768,7 +9773,6 @@ edu.auction
 edu.dmtc.dev
 edu.hstu.eu.org
 edu.my
-edu.sg
 eduanswer.ru
 education.eu
 educationleaders-ksa.com
@@ -10118,6 +10122,7 @@ emailme.win
 emailmenow.info
 emailmiser.com
 emailmobile.net
+emailmonkey.club
 emailmynn.com
 emailmysr.com
 emailna.co
@@ -10347,6 +10352,7 @@ eo-z.com
 eoffice.top
 eomail.com
 eonmech.com
+eoopy.com
 eorbs.com
 eos2mail.com
 eotoplenie.ru
@@ -11396,6 +11402,8 @@ fitnessjockey.org
 fitnessmojo.org
 fitnessreviewsonline.com
 fitnesszbyszko.pl
+fitschool.be
+fitschool.space
 fittinggeeks.pl
 fitzgeraldforjudge.com
 five-club.com
@@ -12822,10 +12830,8 @@ gmmx.com
 gmojl.com
 gmsdfhail.com
 gmssail.com
-gmx.com
 gmx.dns-cloud.net
 gmx.dnsabr.com
-gmx.es
 gmx.fr.nf
 gmx1mail.top
 gmxip8vet5glx2n9ld.cf
@@ -15034,6 +15040,7 @@ inboxmail.world
 inboxmails.co
 inboxmails.net
 inboxproxy.com
+inboxsecure.info
 inboxstore.me
 incarnal.pl
 incestry.co.uk
@@ -15177,6 +15184,7 @@ instaindofree.com
 instaku-media.com
 instambox.com
 instance-email.com
+instant-email.org
 instant-job.com
 instant-mail.de
 instantblingmail.info
@@ -17263,6 +17271,7 @@ labas.com
 labetteraverouge.at
 labfortyone.tk
 labo.ch
+labomail.pro
 laboratortehnicadentara.ro
 laboriously.com
 labum.com
@@ -18795,6 +18804,7 @@ mailbox92.biz
 mailboxheaven.info
 mailboxint.info
 mailboxlife.net
+mailboxok.club
 mailboxonline.org
 mailboxrental.org
 mailboxxx.net
@@ -18984,6 +18994,7 @@ mailloading.com
 maillotdefoot.com
 mailly.xyz
 mailman.com
+mailmanbox.com
 mailmassa.info
 mailmate.com
 mailme.gq
@@ -19024,6 +19035,7 @@ mailnowapp.com
 mailnull.com
 mailo.cf
 mailo.tk
+mailolo.info
 mailonaut.com
 mailondandan.com
 mailone.es.vu
@@ -19054,6 +19066,7 @@ mailproxy.gm9.com
 mailpts.com
 mailpuppet.tk
 mailquack.com
+mailquack.info
 mailraccoon.com
 mailrard01.ga
 mailrazer.com
@@ -21561,6 +21574,7 @@ nomail.ga
 nomail.net
 nomail.nodns.xyz
 nomail.pw
+nomail.top
 nomail.xl.cx
 nomail2me.com
 nomailthankyou.com
@@ -23839,6 +23853,7 @@ privateclosets.com
 privateinvest.me
 privatemail.in
 privatemailinator.nl
+privateme.site
 privatemitel.cf
 privatemitel.ml
 privatesent.tk
@@ -23914,6 +23929,7 @@ prolagu.pro
 prolifepowerup.com
 promail.net
 promail.site
+promailerapp.com
 promails.xyz
 promdresses-short.com
 promenadahotel.pl
@@ -26757,6 +26773,7 @@ simple-mail-server.bid
 simplebox.email
 simpleemail.in
 simpleemail.info
+simpleinboxer.site
 simpleitsecurity.info
 simplemail.in
 simplemail.top
@@ -28469,6 +28486,7 @@ tempemailaddress.com
 tempemails.io
 tempinbox.co.uk
 tempinbox.com
+tempinbox.xyz
 tempm.cf
 tempm.com
 tempm.ga
@@ -29585,6 +29603,9 @@ tsukushiakihito.gq
 tt2dx90.com
 ttbbc.com
 ttdfytdd.ml
+ttirv.com
+ttirv.net
+ttirv.org
 ttoubdzlowecm7i2ua8.cf
 ttoubdzlowecm7i2ua8.ga
 ttoubdzlowecm7i2ua8.gq
@@ -30251,6 +30272,7 @@ url.gen.in
 urleur.com
 urltc.com
 urlwave.org
+urmailman.com
 urodzinydlaadzieci.pl
 uroetueptriwe.cz.cc
 uroid.com
@@ -32774,7 +32796,6 @@ yammyshop.com
 yandere.cu.cc
 yandex.ca
 yandex.comx.cf
-yandex.net
 yandexmail.cf
 yandexmail.ga
 yandexmail.gq

data/lib/valid_email2.rb

@@ -7,23 +7,35 @@ module ValidEmail2
   WHITELIST_FILE  = "config/whitelisted_email_domains.yml"
   DISPOSABLE_FILE = File.expand_path('../config/disposable_email_domains.txt', __dir__)
 
-  def self.disposable_emails
-    @disposable_emails ||= File.open(DISPOSABLE_FILE){ |f| f.read }.split("\n")
-  end
+  class << self
+    def disposable_emails
+      @disposable_emails ||= load_file(DISPOSABLE_FILE)
+    end
 
-  def self.blacklist
-    @blacklist ||= if File.exist?(BLACKLIST_FILE)
-                     YAML.load_file(File.expand_path(BLACKLIST_FILE))
-                   else
-                     []
-                   end
-  end
+    def blacklist
+      @blacklist ||= load_if_exists(BLACKLIST_FILE)
+    end
+
+    def whitelist
+      @whitelist ||= load_if_exists(WHITELIST_FILE)
+    end
+
+    private
+
+    def load_if_exists(path)
+      File.exist?(path) ? load_file(path) : Set.new
+    end
 
-  def self.whitelist
-    @whitelist ||= if File.exist?(WHITELIST_FILE)
-                     YAML.load_file(File.expand_path(WHITELIST_FILE))
-                   else
-                     []
-                   end
+    def load_file(path)
+      # This method MUST return a Set, otherwise the
+      # performance will suffer!
+      if path.end_with?(".yml")
+        Set.new(YAML.load_file(path))
+      else
+        File.open(path, "r").each_line.each_with_object(Set.new) do |domain, set|
+          set << domain.tap(&:chomp!)
+        end
+      end
+    end
   end
 end

data/lib/valid_email2/address.rb

@@ -6,10 +6,18 @@ module ValidEmail2
   class Address
     attr_accessor :address
 
-    PROHIBITED_DOMAIN_CHARACTERS_REGEX = /[+!_\/\s']/
+    PROHIBITED_DOMAIN_CHARACTERS_REGEX = /[+!_\/\s'`]/
     DEFAULT_RECIPIENT_DELIMITER = '+'.freeze
     DOT_DELIMITER = '.'.freeze
 
+    def self.prohibited_domain_characters_regex
+      @prohibited_domain_characters_regex ||= PROHIBITED_DOMAIN_CHARACTERS_REGEX
+    end
+
+    def self.prohibited_domain_characters_regex=(val)
+      @prohibited_domain_characters_regex = val
+    end
+
     def initialize(address)
       @parse_error = false
       @raw_address = address
@@ -24,25 +32,20 @@ module ValidEmail2
     end
 
     def valid?
-      @valid ||= begin
-        return false if @parse_error
+      return @valid unless @valid.nil?
+      return false  if @parse_error
 
+      @valid = begin
         if address.domain && address.address == @raw_address
           domain = address.domain
 
-          domain !~ PROHIBITED_DOMAIN_CHARACTERS_REGEX &&
-            # Domain needs to have at least one dot
-            domain =~ /\./ &&
-            # Domain may not have two consecutive dots
-            domain !~ /\.{2,}/ &&
-            # Domain may not start with a dot
-            domain !~ /^\./ &&
-            # Domain may not start with a dash
-            domain !~ /^-/ &&
-            # Domain name may not end with a dash
-            domain !~ /-\./ &&
-            # Address may not contain a dot directly before @
-            address.address !~ /\.@/
+          domain !~ self.class.prohibited_domain_characters_regex &&
+            domain.include?('.') &&
+            !domain.include?('..') &&
+            !domain.start_with?('.') &&
+            !domain.start_with?('-') &&
+            !domain.include?('-.') &&
+            !address.local.end_with?('.')
         else
           false
         end
@@ -62,7 +65,7 @@ module ValidEmail2
     end
 
     def disposable_domain?
-      valid? && domain_is_in?(ValidEmail2.disposable_emails)
+      domain_is_in?(ValidEmail2.disposable_emails)
     end
 
     def disposable_mx_server?

data/lib/valid_email2/email_validator.rb

@@ -5,43 +5,44 @@ require "active_model/validations"
 module ValidEmail2
   class EmailValidator < ActiveModel::EachValidator
     def default_options
-      { regex: true, disposable: false, mx: false, disallow_subaddressing: false }
+      { regex: true, disposable: false, mx: false, disallow_subaddressing: false, multiple: false }
     end
 
     def validate_each(record, attribute, value)
       return unless value.present?
       options = default_options.merge(self.options)
 
-      address = ValidEmail2::Address.new(value)
+      value_spitted = options[:multiple] ? value.split(',').map(&:strip) : [value]
+      addresses = value_spitted.map { |v| ValidEmail2::Address.new(v) }
 
-      error(record, attribute) && return unless address.valid?
+      error(record, attribute) && return unless addresses.all?(&:valid?)
 
       if options[:disallow_dotted]
-        error(record, attribute) && return if address.dotted?
+        error(record, attribute) && return if addresses.any?(&:dotted?)
       end
 
       if options[:disallow_subaddressing]
-        error(record, attribute) && return if address.subaddressed?
+        error(record, attribute) && return if addresses.any?(&:subaddressed?)
       end
 
       if options[:disposable]
-        error(record, attribute) && return if address.disposable?
+        error(record, attribute) && return if addresses.any?(&:disposable?)
       end
 
       if options[:disposable_domain]
-        error(record, attribute) && return if address.disposable_domain?
+        error(record, attribute) && return if addresses.any?(&:disposable_domain?)
       end
 
       if options[:disposable_with_whitelist]
-        error(record, attribute) && return if address.disposable? && !address.whitelisted?
+        error(record, attribute) && return if addresses.any? { |address| address.disposable? && !address.whitelisted? }
       end
 
       if options[:blacklist]
-        error(record, attribute) && return if address.blacklisted?
+        error(record, attribute) && return if addresses.any?(&:blacklisted?)
       end
 
       if options[:mx]
-        error(record, attribute) && return unless address.valid_mx?
+        error(record, attribute) && return unless addresses.all?(&:valid_mx?)
       end
     end
 

data/lib/valid_email2/version.rb

@@ -1,3 +1,3 @@
 module ValidEmail2
-  VERSION = "3.2.2"
+  VERSION = "3.3.1"
 end

data/pull_mailchecker_emails.rb

@@ -8,6 +8,7 @@ require "net/http"
 whitelisted_emails = %w(
   onet.pl poczta.onet.pl fastmail.fm hushmail.com
   hush.ai hush.com hushmail.me naver.com qq.com example.com
+  yandex.net gmx.com gmx.es
 )
 
 existing_emails = File.open("config/disposable_email_domains.txt") { |f| f.read.split("\n") }

data/spec/benchmark_spec.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Performance testing" do
+  let(:disposable_domain) { ValidEmail2.disposable_emails.first }
+
+  it "has acceptable lookup performance" do
+    address = ValidEmail2::Address.new("test@example.com")
+
+    # preload list and check size
+    expect(ValidEmail2.disposable_emails).to be_a(Set)
+    expect(ValidEmail2.disposable_emails.count).to be > 30000
+
+    # check lookup timing
+    expect { address.disposable_domain? }.to perform_under(0.0001).sample(10).times
+  end
+end

data/spec/spec_helper.rb

@@ -1,6 +1,15 @@
 $:.unshift File.expand_path("../lib",__FILE__)
 require "valid_email2"
 
+# Include and configure  benchmark
+require 'rspec-benchmark'
+RSpec.configure do |config|
+  config.include RSpec::Benchmark::Matchers
+end
+RSpec::Benchmark.configure do |config|
+  config.disable_gc = true
+end
+
 class TestModel
   include ActiveModel::Validations
 

data/spec/valid_email2_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require "fileutils"
 
 class TestUser < TestModel
   validates :email, 'valid_email_2/email': true
@@ -38,6 +39,10 @@ class TestUserMessage < TestModel
   validates :email, 'valid_email_2/email': { message: "custom message" }
 end
 
+class TestUserMultiple < TestModel
+  validates :email, 'valid_email_2/email': { multiple: true }
+end
+
 describe ValidEmail2 do
 
   let(:disposable_domain) { ValidEmail2.disposable_emails.first }
@@ -59,7 +64,7 @@ describe ValidEmail2 do
       expect(user.valid?).to be_falsey
     end
 
-    %w[+ _ ! / \  '].each do |invalid_character|
+    %w[+ _ ! / \  ' `].each do |invalid_character|
       it "is invalid if email contains a \"#{invalid_character}\" character" do
         user = TestUser.new(email: "foo@google#{invalid_character}yahoo.com")
         expect(user.valid?).to be_falsey
@@ -82,16 +87,11 @@ describe ValidEmail2 do
       expect(user.valid?).to be_falsey
     end
 
-    it "is invalid if the domain contains emoticons" do
+    it "is invalid if the email contains emoticons" do
       user = TestUser.new(email: "foo🙈@gmail.com")
       expect(user.valid?).to be_falsy
     end
 
-    it "is invalid if the domain contains .@ consecutively" do
-      user = TestUser.new(email: "foo.@gmail.com")
-      expect(user.valid?).to be_falsy
-    end
-
     it "is invalid if the domain contains spaces" do
       user = TestUser.new(email: "user@gmail .com")
       expect(user.valid?).to be_falsy
@@ -243,6 +243,20 @@ describe ValidEmail2 do
     end
   end
 
+  describe "with multiple addresses" do
+    it "tests each address for it's own" do
+      user = TestUserMultiple.new(email: "foo@gmail.com, bar@gmail.com")
+      expect(user.valid?).to be_truthy
+    end
+
+    context 'when one address is invalid' do
+      it "fails for all" do
+        user = TestUserMultiple.new(email: "foo@gmail.com, bar@123")
+        expect(user.valid?).to be_falsey
+      end
+    end
+  end
+
   describe "#dotted?" do
     it "is true when address local part contains a dot delimiter ('.')" do
       email = ValidEmail2::Address.new("john.doe@gmail.com")

data/valid_email2.gemspec

@@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake", "~> 12.3.3"
   spec.add_development_dependency "rspec", "~> 3.5.0"
+  spec.add_development_dependency "rspec-benchmark", "~> 0.6"
   spec.add_development_dependency "pry"
   spec.add_runtime_dependency "mail", "~> 2.5"
   spec.add_runtime_dependency "activemodel", ">= 3.2"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email2
 version: !ruby/object:Gem::Version
-  version: 3.2.2
+  version: 3.3.1
 platform: ruby
 authors:
 - Micke Lisinge
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-05 00:00:00.000000000 Z
+date: 2020-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.5.0
+- !ruby/object:Gem::Dependency
+  name: rspec-benchmark
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -120,6 +134,7 @@ files:
 - lib/valid_email2/email_validator.rb
 - lib/valid_email2/version.rb
 - pull_mailchecker_emails.rb
+- spec/benchmark_spec.rb
 - spec/spec_helper.rb
 - spec/valid_email2_spec.rb
 - valid_email2.gemspec
@@ -127,7 +142,7 @@ homepage: https://github.com/micke/valid_email2
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -142,11 +157,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: ActiveModel validation for email. Including MX lookup and disposable email
   blacklist
 test_files:
+- spec/benchmark_spec.rb
 - spec/spec_helper.rb
 - spec/valid_email2_spec.rb