valid_email2 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b1b27babaa4cb566d2b63dc25f726f534ad05fb9364d21c52c44c775ce12218
-  data.tar.gz: 735df3dc625cebce4bda35547a4d3b6e8e558fc2133872c8b678e51a4891c073
+  metadata.gz: 63b864a75746bfe17f788bb3b57052c34f2ac4970d827c66bee6b0d13e300fae
+  data.tar.gz: 40ca941d76160a68fcda81b2313ba2df94d9e979d9e688d7e79e2c732cfabe14
 SHA512:
-  metadata.gz: f4d6da63e2f4f1894605a1b83f0c92300d8fe3d8a558d09f670d890d38ef3efbf3f59dfdd49f1bda9696ddad73c0ee5b9fd33ca742f7293524cb29e83c96b57f
-  data.tar.gz: e74ea532d0510bdd0c9c8ddcc53e88aebc384d3ea4bafe475c28a754518f90103873c814134acb2cc942720a5f889ff349a142b5164e842d81bc67a08816ce1a
+  metadata.gz: 0d192c49f1d30c39e94b0d3af97114e75c3c298be5201e62988650fcf90158714cd0595db060138709ebf17cd938e7b930e928ddd03a4c634820a41e12fe26aa
+  data.tar.gz: a19ca613dab66f590075509db6e702d583d714ea4203499d26a0b635a1ac60648a146bca65978c52b5490e81cbf2c2a036f80342ce1ad621c7bac59d42274207

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## Version 3.1.1
+* Disallow domains starting or ending with `-` https://github.com/micke/valid_email2/pull/140
+
 ## Version 3.1.0
 * Performance improvements https://github.com/micke/valid_email2/pull/137
 

data/config/disposable_email_domains.yml

@@ -14819,7 +14819,6 @@
 - xvcezxodtqzbvvcfw4a.gq
 - xvcezxodtqzbvvcfw4a.ml
 - xvcezxodtqzbvvcfw4a.tk
-- xwaretech.com
 - xwaretech.info
 - xwaretech.net
 - xwgpzgajlpw.cf

data/lib/valid_email2/address.rb

@@ -35,6 +35,10 @@ module ValidEmail2
           domain !~ /\.{2,}/ &&
           # Domain may not start with a dot
           domain !~ /^\./ &&
+          # Domain may not start with a dash
+          domain !~ /^-/ &&
+          # Domain name may not end with a dash
+          domain !~ /-\./ &&
           # Address may not contain a dot directly before @
           address.address !~ /\.@/
       else

data/lib/valid_email2/version.rb

@@ -1,3 +1,3 @@
 module ValidEmail2
-  VERSION = "3.1.0"
+  VERSION = "3.1.1"
 end

data/spec/valid_email2_spec.rb

@@ -83,6 +83,16 @@ describe ValidEmail2 do
       user = TestUser.new(email: "foo.@gmail.com")
       expect(user.valid?).to be_falsy
     end
+
+    it "is invalid if the domain begins with a dash" do
+      user = TestUser.new(email: "foo@-gmail.com")
+      expect(user.valid?).to be_falsy
+    end
+
+    it "is invalid if the domain name ends with a dash" do
+      user = TestUser.new(email: "foo@gmail-.com")
+      expect(user.valid?).to be_falsy
+    end
   end
 
   describe "with disposable validation" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email2
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Micke Lisinge
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-28 00:00:00.000000000 Z
+date: 2019-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler