valid_email2 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0296f4789b78afcfabaa2f6815dbcb00d31f791e68b6f555f0d59dc3e7d2c458'
-  data.tar.gz: ea0e4c44adbec83fe1aae8e600e4e2730852007d53e1aac7b5f1482fc04f674d
+  metadata.gz: 7a2cf0205525e8abee7c2bdc06389a0c49e63407bbb863f44eff7d0e7018dde1
+  data.tar.gz: 8a3459e1bce845359ebd651666c354935d58fcad9f71fdfcb4e6fbeca32e7e2c
 SHA512:
-  metadata.gz: 37b74fe00a659b7db36020e1acd7e403721df1e8dc12250c1224b98e23b30768caa41584538be75006dfa83c8d16cea86ac44a6fd4a5281d1d722feb4fc8e65b
-  data.tar.gz: bf89335f3cd8f28a7b8367989dc6aa36dd85555c064d3eb9f066a657871c1e32c6a0eed30da7d625b39027b2ff485f71c20806ed9f1983ebd9556adbf7d2b564
+  metadata.gz: 92029d3f7c4f7ed447c033f60ff4e372186386d5876746fd994761a7b332e143e0a198e2e87c223a1465c43448dfe4871137e3b6d03d55bc846f6abf0ff25796
+  data.tar.gz: 7cffa1a1628d3a9f2fc0dd1fa2b809c6fc111efaf3fdfe1e75b003a1df973e3f7ebaf66c626740f7387cf78c857a2e7c614ae913165d8e0964df4f43e1c850c5

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## Version 3.0.1
+Relax the restrictions on domain validation so that we allow unicode domains and
+other non ASCII domains while still disallowing the domains we blocked before.
+
 ## Version 3.0.0
 * Moved __and__ renamed blacklist and whitelist and disposable_emails. Moved from the vendor directory to
   the config directory.  

data/README.md

@@ -114,6 +114,7 @@ This gem requires Rails 3.2 or 4.0 or higher. It is tested against both versions
 
 In version v3.0.0 I decided to move __and__ rename the config files from the
 vendor directory to the config directory. That means:
+
 `vendor/blacklist.yml` -> `config/blacklisted_email_domains.yml`  
 `vendor/whitelist.yml` -> `config/whitelisted_email_domains.yml`
 

data/lib/valid_email2/address.rb

@@ -6,7 +6,7 @@ module ValidEmail2
   class Address
     attr_accessor :address
 
-    ALLOWED_DOMAIN_CHARACTERS_REGEX = /\A[a-z0-9\-.]+\z/i
+    PROHIBITED_DOMAIN_CHARACTERS_REGEX = /[+!_]/
     DEFAULT_RECIPIENT_DELIMITER = '+'.freeze
 
     def initialize(address)
@@ -28,13 +28,13 @@ module ValidEmail2
       if address.domain && address.address == @raw_address
         domain = address.domain
 
-        domain.match(ALLOWED_DOMAIN_CHARACTERS_REGEX) &&
+        domain !~ PROHIBITED_DOMAIN_CHARACTERS_REGEX &&
           # Domain needs to have at least one dot
-          domain.match(/\./) &&
+          domain =~ /\./ &&
           # Domain may not have two consecutive dots
-          !domain.match(/\.{2,}/) &&
+          domain !~ /\.{2,}/ &&
           # Domain may not start with a dot
-          !domain.match(/^\./)
+          domain !~ /^\./
       else
         false
       end

data/lib/valid_email2/version.rb

@@ -1,3 +1,3 @@
 module ValidEmail2
-  VERSION = "3.0.0"
+  VERSION = "3.0.1"
 end

data/spec/valid_email2_spec.rb

@@ -147,17 +147,17 @@ describe ValidEmail2 do
   end
 
   describe "with mx validation" do
-    it "should be valid if mx records are found" do
+    it "is valid if mx records are found" do
       user = TestUserMX.new(email: "foo@gmail.com")
       expect(user.valid?).to be_truthy
     end
 
-    it "should be valid if A records are found" do
+    it "is valid if A records are found" do
       user = TestUserMX.new(email: "foo@ghs.google.com")
       expect(user.valid?).to be_truthy
     end
 
-    it "should be invalid if no mx records are found" do
+    it "is invalid if no mx records are found" do
       user = TestUserMX.new(email: "foo@subdomain.gmail.com")
       expect(user.valid?).to be_falsey
     end
@@ -184,12 +184,12 @@ describe ValidEmail2 do
   end
 
   describe "#subaddressed?" do
-    it "should be true when address local part contains a recipient delimiter ('+')" do
+    it "is true when address local part contains a recipient delimiter ('+')" do
       email = ValidEmail2::Address.new("foo+1@gmail.com")
       expect(email.subaddressed?).to be_truthy
     end
 
-    it "should be false when address local part contains a recipient delimiter ('+')" do
+    it "is false when address local part contains a recipient delimiter ('+')" do
       email = ValidEmail2::Address.new("foo@gmail.com")
       expect(email.subaddressed?).to be_falsey
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email2
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Micke Lisinge
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-02 00:00:00.000000000 Z
+date: 2019-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler