valid_email 0.1.4 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 912afd4576d829541b67adb5b5830c4c31d8bf7f7005092957a655f9dbcf07ba
-  data.tar.gz: a0647b0db0f921c5159c585fb2298211f1be85cafe138fd426ebf1ec5d32049d
+  metadata.gz: '07881400a61a403d6c3e518404847d050d28e5b28e1442205cd36daf77f5ca1d'
+  data.tar.gz: 9aeb926a06b6a3ca32147ae9c2c01b7aee0c5c8932668f980ca9ab2a2c4c3519
 SHA512:
-  metadata.gz: bc35a4b3adb7b092b9158dff8d2d2c16bd1e5cc5f59b91f521ea0cbfd30d0bd5c4c523f2990752486036fed8db8908566228eee18b7f3c282f7b9824cca0b1f2
-  data.tar.gz: 44233a8c92c72e597c3b10bdc052e17c1e8ead83c87dfab94103f7341d9b2b32348f555fbe4fdee2af0e474c7af92f253b3421fb4ed37aed779eabc30c1a9cbd
+  metadata.gz: 3f6cf4d94d6ecf345189b7ffc41f185977d2b23b21c011b98cfa01f5da7c1c9add6f00425b317547d14cd4dd5e4ca595b6e13523e25ceaf9163b04567b781707
+  data.tar.gz: 8aa4b92513c11e81b87b793a348d9581f6d11a70300006a3c1d6434032cf52b3aeacdf61b470db06ff74433ad677903156cc3967c6db7f833c9cb3bfe0c43c76

data/.github/workflows/ci.yaml

@@ -0,0 +1,44 @@
+name: CI
+on:
+  workflow_dispatch:
+  push:
+
+permissions:
+  checks: write
+  contents: read
+  pull-requests: write
+
+jobs:
+  rspec:
+    name: RSpec (ruby ${{ matrix.ruby-version }})
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby-version:
+          - '1.9.3'
+          - '2.0'
+          - '2.1'
+          - '2.2'
+          - '2.3'
+          - '2.4'
+          - '2.5'
+          - '2.6'
+          - '2.7'
+          - '3.0'
+          - '3.1'
+          - '3.2'
+          - 'jruby-head'
+          - 'truffleruby-head'
+    env:
+      CI: true
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Setup ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - name: Run tests
+        run: bundle exec rake

data/README.md

@@ -122,7 +122,7 @@ nil.email? # => false
 
 ## Code Status
 
-[![Build Status](https://travis-ci.org/hallelujah/valid_email.svg?branch=master)](https://travis-ci.org/hallelujah/valid_email)
+[![Build Status](https://github.com/hallelujah/valid_email/actions/workflows/ci.yaml/badge.svg)](https://github.com/hallelujah/valid_email/actions/workflows/ci.yaml)
 
 ## Credits
 

data/lib/valid_email/email_validator.rb

@@ -22,7 +22,7 @@ class EmailValidator < ActiveModel::EachValidator
     end
     unless r
       msg = (options[:message] || I18n.t(:invalid, :scope => "valid_email.validations.email"))
-      record.errors.add attribute, message: (msg % {value: value})
+      record.errors.add attribute, message: I18n.interpolate(msg, value: value)
     end
   end
 end

data/lib/valid_email/version.rb

@@ -1 +1 @@
-ValidEmailVersion = "0.1.4"
+ValidEmailVersion = "0.2.0"

data/spec/email_validator_spec.rb

@@ -1,5 +1,21 @@
 require 'spec_helper'
 
+RSpec::Matchers.define :have_error_messages do |field, expected|
+  match do |model|
+    errors = model.errors[field]
+
+    messages = errors.map do |error|
+      case error
+      when String then error
+      when Hash then error[:message]
+      else fail ArgumentError, "Unknown model error type #{error.class}"
+      end
+    end
+
+    expect(messages).to eq expected
+  end
+end
+
 describe EmailValidator do
   email_class = Class.new do
     include ActiveModel::Validations
@@ -69,43 +85,43 @@ describe EmailValidator do
 
       it "fails when email empty" do
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "fails when email is not valid" do
         subject.email = 'joh@doe'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "fails when email domain is prefixed with dot" do
         subject.email = 'john@.doe'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "fails when email domain contains two consecutive dots" do
         subject.email = 'john@doe-two..com'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "fails when email ends with a period" do
         subject.email = 'john@doe.com.'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "fails when email ends with special characters" do
         subject.email = 'john@doe.com&'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "fails when email is valid with information" do
         subject.email = '"John Doe" <john@doe.com>'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "passes when email is simple email address" do
@@ -117,42 +133,52 @@ describe EmailValidator do
       it "fails when email is simple email address not stripped" do
         subject.email = 'john@doe.com            '
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "fails when domain contains a space" do
         subject.email = 'john@doe .com'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "fails when passing multiple simple email addresses" do
         subject.email = 'john@doe.com, maria@doe.com'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
     end
 
     describe "validating email with MX and fallback to A" do
+      let(:dns) { instance_double('Resolv::DNS', :dns) }
+
       subject { person_class_mx_with_fallback.new }
 
+      before do
+        allow(Resolv::DNS).to receive(:open).and_yield(dns)
+      end
+
       it "passes when email domain has MX record" do
-        subject.email = 'john@gmail.com'
+        allow(dns).to receive(:getresources).with('has-mx-record.org', Resolv::DNS::Resource::IN::MX).and_return(['1.2.3.4'])
+        subject.email = 'john@has-mx-record.org'
         expect(subject.valid?).to be_truthy
         expect(subject.errors[:email]).to be_empty
       end
 
       it "passes when email domain has no MX record but has an A record" do
-        subject.email = 'john@subdomain.rubyonrails.org'
+        allow(dns).to receive(:getresources).with('has-a-record.org', Resolv::DNS::Resource::IN::MX).and_return([])
+        allow(dns).to receive(:getresources).with('has-a-record.org', Resolv::DNS::Resource::IN::A).and_return(['1.2.3.4'])
+        subject.email = 'john@has-a-record.org'
         expect(subject.valid?).to be_truthy
         expect(subject.errors[:email]).to be_empty
       end
 
       it "fails when domain does not exists" do
-        subject.email = 'john@nonexistentdomain.abc'
+        allow(dns).to receive(:getresources).with('does-not-exist.org', anything).and_return([])
+        subject.email = 'john@does-not-exist.org'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
     end
 
@@ -168,13 +194,13 @@ describe EmailValidator do
       it "fails when email domain has no MX record" do
         subject.email = 'john@subdomain.rubyonrails.org'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "fails when domain does not exists" do
         subject.email = 'john@nonexistentdomain.abc'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
     end
 
@@ -218,7 +244,7 @@ describe EmailValidator do
       it "fails when email from disposable email services" do
         subject.email = 'john@grr.la'
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
     end
 
@@ -228,7 +254,7 @@ describe EmailValidator do
       it "does not pass with an invalid domain" do
         subject.email = "test@example.org$\'"
         expect(subject.valid?).to be_falsey
-        expect(subject.errors[:email]).to eq errors
+        expect(subject).to have_error_messages(:email, errors)
       end
 
       it "passes with valid domain" do

data/spec/spec_helper.rb

@@ -3,7 +3,10 @@ require 'valid_email'
 
 RSpec.configure do |config|
   config.order = :random
-  config.profile_examples = 10
   config.raise_errors_for_deprecations!
   Kernel.srand config.seed
+
+  if ENV['CI']
+    config.warnings = true
+  end
 end

data/valid_email.gemspec

@@ -19,13 +19,13 @@ Gem::Specification.new do |s|
 
   # specify any dependencies here; for example:
   s.add_development_dependency "rspec", "~> 3.10"
-  s.add_development_dependency "rake", '< 11.0'
+  s.add_development_dependency "rake"
   s.add_runtime_dependency "mail", ">= 2.6.1"
   s.add_runtime_dependency "simpleidn"
-  if Gem::Version.new(RUBY_VERSION) <= Gem::Version.new('2.0')
+  if Gem::Version.new(RUBY_VERSION.dup) <= Gem::Version.new('2.0')
     s.add_runtime_dependency 'mime-types', '<= 2.6.2'
   end
-  if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.2.2')
+  if Gem::Version.new(RUBY_VERSION.dup) < Gem::Version.new('2.2.2')
     s.add_runtime_dependency "activemodel", '< 5.0.0'
   else
     s.add_runtime_dependency "activemodel"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valid_email
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.2.0
 platform: ruby
 authors:
 - Ramihajamalala Hery
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-30 00:00:00.000000000 Z
+date: 2023-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -28,16 +28,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mail
   requirement: !ruby/object:Gem::Requirement
@@ -87,8 +87,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yaml"
 - ".gitignore"
-- ".travis.yml"
+- ".rspec"
 - Gemfile
 - History.md
 - LICENSE
@@ -129,7 +130,7 @@ homepage: https://github.com/hallelujah/valid_email
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -144,8 +145,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key: 
+rubygems_version: 3.4.13
+signing_key:
 specification_version: 4
 summary: ActiveModel Validation for email
 test_files:

data/.travis.yml

@@ -1,18 +0,0 @@
-before_install:
-  - gem install bundler:1.17.3
-cache: bundler
-dist: xenial
-language: ruby
-rvm:
-  - 1.9.3
-  - 2.0
-  - 2.1
-  - 2.2
-  - 2.2
-  - 2.3
-  - 2.4
-  - 2.5
-  - 2.6
-  - 2.7
-  - 3.0
-  - jruby-head