valid_email 0.0.1 → 0.0.2

data/README.md

@@ -32,7 +32,26 @@ In your code :
     p.email = "John Does <john@doe.com>"
     p.valid? # => false
 
+You can check if email domain has MX record :
 
+    validates :email, :email => {:mx => true}
+
+Or
+    validates :email, :email => true, :mx => true
+
+
+If you don't want the MX validator stuff, just require the right file
+
+    require 'valid\_email/email_validator'
+
+Or in your Gemfile
+
+    gem 'valid_email', :require => 'valid_email/email_validator'
+
+
+# Credits
+
+* Dush dusanek[at]iquest.cz
 
 # Note on Patches/Pull Requests
 

data/lib/valid_email.rb

@@ -1,23 +1,2 @@
-require 'active_model'
-require 'active_model/validations'
-require 'mail'
-class EmailValidator < ActiveModel::EachValidator
-  def validate_each(record,attribute,value)
-    begin
-      m = Mail::Address.new(value)
-      # We must check that value contains a domain and that value is an email address
-      r = m.domain && m.address == value
-      t = m.__send__(:tree)
-      # We need to dig into treetop
-      # A valid domain must have dot_atom_text elements size > 1
-      # user@localhost is excluded
-      # treetop must respond to domain
-      # We exclude valid email values like <user@localhost.com>
-      # Hence we use m.__send__(tree).domain
-      r &&= (t.domain.dot_atom_text.elements.size > 1)
-    rescue Exception => e
-      r = false
-    end
-    record.errors[attribute] << (options[:message] || "is invalid") unless r
-  end
-end
+require 'valid_email/all'
+

data/lib/valid_email/all.rb

@@ -0,0 +1,2 @@
+require 'valid_email/email_validator'
+require 'valid_email/mx_validator'

data/lib/valid_email/email_validator.rb

@@ -0,0 +1,28 @@
+require 'active_model'
+require 'active_model/validations'
+require 'mail'
+class EmailValidator < ActiveModel::EachValidator
+  def validate_each(record,attribute,value)
+    begin
+      m = Mail::Address.new(value)
+      # We must check that value contains a domain and that value is an email address
+      r = m.domain && m.address == value
+      t = m.__send__(:tree)
+      # We need to dig into treetop
+      # A valid domain must have dot_atom_text elements size > 1
+      # user@localhost is excluded
+      # treetop must respond to domain
+      # We exclude valid email values like <user@localhost.com>
+      # Hence we use m.__send__(tree).domain
+      r &&= (t.domain.dot_atom_text.elements.size > 1)
+      # Check if domain has DNS MX record
+      if r && options[:mx]
+        require 'valid_email/mx_validator'
+        r &&= MxValidator.new(:attributes => attributes).validate(record)
+      end
+    rescue Exception => e
+      r = false
+    end
+    record.errors.add attribute, (options[:message] || "is invalid") unless r
+  end
+end

data/lib/valid_email/mx_validator.rb

@@ -0,0 +1,16 @@
+require 'active_model'
+require 'active_model/validations'
+require 'mail'
+require 'resolv'
+class MxValidator < ActiveModel::EachValidator
+  def validate_each(record,attribute,value)
+    m = Mail::Address.new(value)
+    mx = []
+    Resolv::DNS.open do |dns|
+      mx.concat dns.getresources(m.domain, Resolv::DNS::Resource::IN::MX)
+    end
+    r = mx.size > 0
+    record.errors.add attribute, (options[:message] || "is invalid") unless r
+    r
+  end
+end

data/lib/valid_email/version.rb

@@ -1,2 +1,2 @@
-ValidEmailVersion = "0.0.1"
+ValidEmailVersion = "0.0.2"
 

data/spec/email_validator_spec.rb

@@ -47,6 +47,34 @@ describe EmailValidator do
       subject.valid?.should be_false
       subject.errors[:email].should == [ "is invalid" ]
     end
+  end
+    
+  person_class_mx = Class.new do
+    include ActiveModel::Validations
+    attr_accessor :email
+    validates :email, :email => {:mx => true}
+  end
+
+  describe "validating email with MX" do
+    subject { person_class_mx.new }
+
+    it "should pass when email domain has MX record" do
+      subject.email = 'john@gmail.com'
+      subject.valid?.should be_true
+      subject.errors[:email].should be_empty
+    end
+
+    it "should fail when email domain has no MX record" do
+      subject.email = 'john@subdomain.rubyonrails.org'
+      subject.valid?.should be_false
+      subject.errors[:email].should == [ "is invalid" ]
+    end
+
+    it "should fail when domain does not exists" do
+      subject.email = 'john@nonexistentdomain.abc'
+      subject.valid?.should be_false
+      subject.errors[:email].should == [ "is invalid" ]
+    end
 
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: valid_email
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-09 00:00:00.000000000Z
+date: 2011-12-09 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &18108960 !ruby/object:Gem::Requirement
+  requirement: &70131339816040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *18108960
+  version_requirements: *70131339816040
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &18108020 !ruby/object:Gem::Requirement
+  requirement: &70131339815620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *18108020
+  version_requirements: *70131339815620
 - !ruby/object:Gem::Dependency
   name: mail
-  requirement: &18107240 !ruby/object:Gem::Requirement
+  requirement: &70131339815200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *18107240
+  version_requirements: *70131339815200
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &18106280 !ruby/object:Gem::Requirement
+  requirement: &70131339814780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *18106280
+  version_requirements: *70131339814780
 description: ActiveModel Validation for email
 email:
 - hery@rails-royce.org
@@ -68,6 +68,9 @@ files:
 - README.md
 - Rakefile
 - lib/valid_email.rb
+- lib/valid_email/all.rb
+- lib/valid_email/email_validator.rb
+- lib/valid_email/mx_validator.rb
 - lib/valid_email/version.rb
 - spec/email_validator_spec.rb
 - spec/spec_helper.rb
@@ -84,18 +87,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -211291560077668896
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -211291560077668896
 requirements: []
 rubyforge_project: valid_email
 rubygems_version: 1.8.6