valicuit 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 152af78be77b708c5f1250b822ba6e51c3f3a0d9
-  data.tar.gz: eb3e1a106becb4ee13dacca3d027a3428027fb37
+  metadata.gz: 24b741a2e8ab39b34b05604b34fc3c0bf7a64f9b
+  data.tar.gz: cc5582902091c831fdd7d0091c13fd58292c2a3f
 SHA512:
-  metadata.gz: 59f2ecf49e180404dae2d6e239d55dee15c2423f70ab8b311a9c78aa5a9857a64bdacce91c223273e22839978dc95cdb8a8e9bbf51241d9c277e39ab0a804088
-  data.tar.gz: d30e08ff153bf3f0b6dd5c1526a060288e8767cff022bdfc7429f1e62157a817f5083ff895843cf3663a603cad25e61daf2096c239fee1a45a4cc5768ed6316f
+  metadata.gz: dcd32f985e9b1b235ba76bb0e59c7773d36b2375b95f475eb007ca9fe1cbdcb547ca357b09bc94c102e5087c0a471fb8b758efe9759d4fc19f351e4edb6b7423
+  data.tar.gz: aba2719b8532e2bd591cfd8f564ac5f2065f1fbd32e4b320c8b4d2a87ab899852b799f3d8ba999632cc22fffeba9791604eaaf0bdfbfb5c81f1e4d0ffb10fcf3

data/README.md

@@ -9,7 +9,7 @@ Un validador de CUIT/CUIL para ActiveModel & Rails.
 Lo de siempre... agregar esta línea en el Gemfile del proyecto:
 
 ```
-gem 'valicuit', github: 'lndl/valicuit'
+gem 'valicuit'
 ```
 
 Y, finalmente, ejecutar **bundle install**
@@ -52,12 +52,14 @@ Análogamente se cumple lo mismo para el género:
 
 ```ruby
 class Persona < ActiveRecord::Base
-  validates :cuit, cuit: { gender_compatible: { field: :genero, male: 'M', female: 'F' } }
+  validates :cuit, cuit: { gender_compatible: { field: :genero, male: 'M', female: 'F', company: 'C' } }
 end
 ```
 
 Y se especifica el campo que representa el género en el modelo, más los valores para validar tales géneros.
 
+Notar que la opción *company*, para validar CUITs de empresas/instituciones, es opcional (pasará la validación directamente en caso de no estar especificado) mientras que las opciones *male*, *female* y *field* no lo son.
+
 
 ## Tests
 

data/lib/active_model/validations/cuit_validator.rb

@@ -101,15 +101,20 @@ module ActiveModel
         raise ArgumentError, 'Valicuit: gender field specification must be present!' unless options[:gender_compatible][:field].present?
         raise ArgumentError, 'Valicuit: declaration of male value missing!'          unless options[:gender_compatible][:male].present?
         raise ArgumentError, 'Valicuit: declaration of female value missing!'        unless options[:gender_compatible][:female].present?
-        case type
-        when '20'
-          options[:gender_compatible][:male]
-        when '27'
-          options[:gender_compatible][:female]
-        else
-          # Machist!
-          options[:gender_compatible][:male]
-        end == record.public_send(options[:gender_compatible][:field])
+        gender = case type
+                 when '20'
+                   options[:gender_compatible][:male]
+                 when '27'
+                   options[:gender_compatible][:female]
+                 when '30', '33'
+                   options[:gender_compatible][:company] || :pass
+                 when '23', '24', '25', '26'
+                   :pass
+                 else
+                   :dont_pass
+                 end
+
+        gender == :pass ? true : gender == record.public_send(options[:gender_compatible][:field])
       end
     end
 

data/lib/valicuit/version.rb

@@ -1,3 +1,3 @@
 module Valicuit
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/spec/cuit_validator_spec.rb

@@ -193,18 +193,22 @@ RSpec.describe ActiveModel::Validations::CuitValidator do
     end
     context 'with gender compatible option' do
       before do
-        TestModel.validates :cuit, cuit: { gender_compatible: { field: :gender, male: 'M', female: 'F' } }
+        TestModel.validates :cuit, cuit: { gender_compatible: { field: :gender, male: 'M', female: 'F', company: 'C' } }
       end
       it 'must return true when CUIT/CUIL is valid and gender part is compatible with gender model' do
         expect(TestModel.new(cuit: '20120112989', gender: 'M')).to be_valid
         expect(TestModel.new(cuit: '27049852032', gender: 'F')).to be_valid
+        expect(TestModel.new(cuit: '30615459190', gender: 'C')).to be_valid
+        expect(TestModel.new(cuit: '23218381669', gender: 'M')).to be_valid
+        expect(TestModel.new(cuit: '23218381669', gender: 'F')).to be_valid
       end
-      it 'must return true with cuit type different of 20/27 as "Male"' do
-        expect(TestModel.new(cuit: '30709316547', gender: 'M')).to be_valid
+      it 'must return false when CUIT/CUIL is valid but gender part is invalid' do
+        expect(TestModel.new(cuit: '17049852032', gender: 'F')).to be_invalid
       end
       it 'must return false when CUIT/CUIL is valid but gender part is incompatible with gender model' do
         expect(TestModel.new(cuit: '20120112989', gender: 'F')).to be_invalid
         expect(TestModel.new(cuit: '27049852032', gender: 'M')).to be_invalid
+        expect(TestModel.new(cuit: '27049852032', gender: 'C')).to be_invalid
       end
       it 'must leave a specific message over :cuit in #errors array' do
         record = TestModel.new(cuit: '20120112989', gender: 'F')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valicuit
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Lautaro Nahuel De León
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-01 00:00:00.000000000 Z
+date: 2016-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel