valcro 0.1 → 0.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: d0b163e4ce4b3622845484854e1d18cb2da5c979a6d7553ac4dafddbf3a30b53
+  data.tar.gz: 755ae121491f4a852b2aa98ac57f167a411b93d4f8626ed99d2fea8e76bcca18
+SHA512:
+  metadata.gz: 635a3e342da795569d4ed2998c7a719d308fccb66d9fde5783328d03d5e65bbb4a4ce622f62111b20239909c56e102065e1e9c03e81e721daec06a96b1df3b5a
+  data.tar.gz: 68e7c8ff05dd6543efdb7916c6a495ae7ad66fb2c38c708a8cc97b0681864356716d7b9d6f8b0807ddd115867dd4835de66bc9835143f216cced8d630da11af9

data/.travis.yml

@@ -1,6 +1,5 @@
 language: ruby
 rvm:
-  - 1.9.2
-  - 1.9.3
-  - jruby-19mode
-  - rbx-19mode
+  - 2.2
+  - 2.3
+  - 2.4.1

data/lib/valcro/error_list.rb

@@ -32,5 +32,9 @@ module Valcro
     def any?
       @errors.any?
     end
+
+    def none?
+      @errors.none?
+    end
   end
 end

data/lib/valcro/runner.rb

@@ -6,6 +6,11 @@ module Valcro
       @error_list = error_list
     end
 
+    def clear!
+      @validators.clear
+      @error_list.clear!
+    end
+
     def add_validator(validator)
       @validators << validator
     end

data/lib/valcro/version.rb

@@ -1,3 +1,3 @@
 module Valcro
-  VERSION = "0.1"
+  VERSION = "0.2.0"
 end

data/lib/valcro.rb

@@ -20,9 +20,14 @@ module Valcro
   end
 
   def validate
-    errors.clear!
+    validation_runner.clear!
     self.class.validators.each do |validator_class|
-      validation_runner.add_validator validator_class.new(self)
+      validator = if validator_class.respond_to?(:build)
+                    validator_class.build(self)
+                  else
+                    validator_class.new(self)
+                  end
+      validation_runner.add_validator validator
     end
     self.class.validation_blocks.each do |validation_block|
       instance_eval(&validation_block)

data/spec/error_list_spec.rb

@@ -51,10 +51,21 @@ describe Valcro::ErrorList, '#any?' do
   it 'is true when there are errors 'do
     list = Valcro::ErrorList.new
 
-    expect(list.any?).to be_false
+    expect(list.any?).to be_falsey
     list.add :prop, 'some error'
 
-    expect(list.any?).to be_true
+    expect(list.any?).to be_truthy
+  end
+end
+
+describe Valcro::ErrorList, '#none?' do
+  it 'is true when there no errors 'do
+    list = Valcro::ErrorList.new
+
+    expect(list.none?).to be_truthy
+    list.add :prop, 'some error'
+
+    expect(list.none?).to be_falsey
   end
 end
 
@@ -62,9 +73,9 @@ describe Valcro::ErrorList, '#clear!' do
   it 'removes all errors' do
     list = Valcro::ErrorList.new
     list.add :prop, 'some error'
-    expect(list.any?).to be_true
+    expect(list.any?).to be_truthy
 
     list.clear!
-    expect(list.any?).to be_false
+    expect(list.any?).to be_falsey
   end
 end

data/spec/runner_spec.rb

@@ -14,6 +14,6 @@ describe Valcro::Runner do
 
     runner.validate
 
-    expect(error_list.any?).to be_true
+    expect(error_list.any?).to be_truthy
   end
 end

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 require 'valcro'
+require 'rspec/collection_matchers'
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
 

data/spec/valcro_spec.rb

@@ -6,7 +6,7 @@ describe Valcro do
   end
 
   it 'is valid with no validations defined' do
-    expect(TestClass.new.valid?).to be_true
+    expect(TestClass.new.valid?).to be_truthy
   end
 end
 
@@ -68,6 +68,51 @@ describe Valcro, 'validators' do
   end
 end
 
+describe Valcro, 'reusable validators' do
+  class ScopedStatusFailValidator
+    def self.build(context)
+      new(context.status)
+    end
+
+    def initialize(status)
+      @status = status
+    end
+    def call(errors)
+      errors.add(:status, 'big mistake') if @status == 'fail'
+    end
+  end
+
+  let(:test_class) do
+    Class.new do
+      include Valcro
+      attr_accessor :status
+      def status
+        @status ||= "fail"
+      end
+
+      validates_with ScopedStatusFailValidator
+    end
+  end
+
+  it 'can be added validators' do
+    test_instance = test_class.new
+
+    test_instance.validate
+    expect(test_instance).not_to be_valid
+  end
+
+  it 'clears validations on subsequent runs' do
+    test_instance = test_class.new
+
+    test_instance.validate
+    expect(test_instance).not_to be_valid
+
+    test_instance.status = 'win'
+    test_instance.validate
+    expect(test_instance).to be_valid
+  end
+end
+
 describe Valcro, '#error_messages' do
   let(:test_class) do
     Class.new { include Valcro }
@@ -75,7 +120,7 @@ describe Valcro, '#error_messages' do
 
   it 'delegates to errors' do
     test_instance = test_class.new
-    test_instance.stub!(errors: double(to_s: 'some errors'))
+    allow(test_instance).to receive(:errors).and_return(double(to_s: 'some errors'))
 
     expect(test_instance.error_messages).to eq('some errors')
   end
@@ -96,10 +141,10 @@ describe Valcro, '.validate' do
     test_instance = test_class.new
     test_instance.works = false
     test_instance.validate
-    expect(test_instance.valid?).to be_false
+    expect(test_instance.valid?).to be_falsey
 
     test_instance.works = true
     test_instance.validate
-    expect(test_instance.valid?).to be_true
+    expect(test_instance.valid?).to be_truthy
   end
 end

data/valcro.gemspec

@@ -19,5 +19,6 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   s.add_development_dependency "rspec"
+  s.add_development_dependency "rspec-collection_matchers"
   s.add_development_dependency "rake"
 end

metadata

@@ -1,38 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: valcro
 version: !ruby/object:Gem::Version
-  version: '0.1'
-  prerelease: 
+  version: 0.2.0
 platform: ruby
 authors:
 - Harold Giménez
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2012-10-16 00:00:00.000000000 Z
+date: 2023-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70279594936620 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70279594936620
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-collection_matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70279594952580 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70279594952580
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Valcro is a validation library for arbitrary ruby objects. I's primary
   goal is to remain as simple as possible so that it can be useful to a large surface
   of use cases remaining easily extensible.
@@ -42,8 +61,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -61,33 +80,25 @@ files:
 - valcro.gemspec
 homepage: https://github.com/hgimenez/valcro
 licenses: []
-post_install_message: 
+metadata: {}
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -54788049467793668
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -54788049467793668
 requirements: []
-rubyforge_project: valcro
-rubygems_version: 1.8.10
-signing_key: 
-specification_version: 3
+rubygems_version: 3.4.12
+signing_key:
+specification_version: 4
 summary: The simplest possible validation library for Ruby
 test_files:
 - spec/error_list_spec.rb