vagrant 0.8.10 → 0.9.0

data/lib/vagrant/config/top.rb

@@ -1,5 +1,5 @@
 module Vagrant
-  class Config
+  module Config
     # This class is the "top" configure class, which handles registering
     # other configuration classes as well as validation of all configured
     # classes. This is the object which is returned by {Environment#config}
@@ -7,34 +7,45 @@ module Vagrant
     #
     # If you're looking to create your own configuration class, see {Base}.
     class Top < Base
-      @@configures = {} if !defined?(@@configures)
+      attr_reader :keys
 
-      # The environment that this configuration is for.
-      attr_reader :env
+      def initialize(registry=nil)
+        @keys = {}
+        @registry = registry || Vagrant.config_keys
+      end
 
-      class << self
-        # The list of registered configuration classes as well as the key
-        # they're registered under.
-        def configures_list
-          @@configures ||= {}
-        end
+      # We use method_missing as a way to get the configuration that is used
+      # for Vagrant and load the proper configuration classes for each.
+      def method_missing(name, *args)
+        return @keys[name] if @keys.has_key?(name)
 
-        # Registers a configuration class with the given key. This method shouldn't
-        # be called. Instead, inherit from {Base} and call {Base.configures}.
-        def configures(key, klass)
-          configures_list[key] = klass
-          attr_reader key.to_sym
+        config_klass = @registry.get(name.to_sym)
+        if config_klass
+          # Instantiate the class and return the instance
+          @keys[name] = config_klass.new
+          return @keys[name]
+        else
+          # Super it up to probably raise a NoMethodError
+          super
         end
       end
 
-      def initialize(env=nil)
-        self.class.configures_list.each do |key, klass|
-          config = klass.new
-          config.top = self
-          instance_variable_set("@#{key}".to_sym, config)
+      # Custom implementation to merge each key separately.
+      def merge(other)
+        result = self.class.new
+        @keys.each do |key, value|
+          result.keys[key] = value.merge(other.send(key))
+        end
+
+        other.keys.each do |key, value|
+          if !@keys.has_key?(key)
+            # This is a key that the other configuration class has
+            # that we don't, so just copy it in.
+            result.keys[key] = value.dup
+          end
         end
 
-        @env = env
+        result
       end
 
       # Validates the configuration classes of this instance and raises an
@@ -42,13 +53,13 @@ module Vagrant
       # class, the method you want to implement is {Base#validate}. This is
       # the method that checks all the validation, not one which defines
       # validation rules.
-      def validate!
+      def validate!(env)
         # Validate each of the configured classes and store the results into
         # a hash.
-        errors = self.class.configures_list.inject({}) do |container, data|
-          key, _ = data
+        errors = @keys.inject({}) do |container, data|
+          key, instance = data
           recorder = ErrorRecorder.new
-          send(key.to_sym).validate(recorder)
+          instance.validate(env, recorder)
           container[key.to_sym] = recorder if !recorder.errors.empty?
           container
         end

data/lib/vagrant/config/vagrant.rb

@@ -1,13 +1,10 @@
 module Vagrant
-  class Config
+  module Config
     class VagrantConfig < Base
-      configures :vagrant
-
       attr_accessor :dotfile_name
       attr_accessor :host
-      attr_accessor :ssh_session_cache
 
-      def validate(errors)
+      def validate(env, errors)
         [:dotfile_name, :host].each do |field|
           errors.add(I18n.t("vagrant.config.common.error_empty", :field => field)) if !instance_variable_get("@#{field}".to_sym)
         end

data/lib/vagrant/config/vm.rb

@@ -1,77 +1,120 @@
+require 'pathname'
+
 require 'vagrant/config/vm/sub_vm'
 require 'vagrant/config/vm/provisioner'
 
 module Vagrant
-  class Config
+  module Config
     class VMConfig < Base
-      configures :vm
-
-      include Util::StackedProcRunner
-
+      attr_accessor :name
       attr_accessor :auto_port_range
       attr_accessor :box
       attr_accessor :box_url
-      attr_accessor :box_ovf
       attr_accessor :base_mac
       attr_accessor :boot_mode
       attr_accessor :host_name
       attr_reader :forwarded_ports
       attr_reader :shared_folders
-      attr_reader :network_options
+      attr_reader :networks
       attr_reader :provisioners
-      attr_accessor :system
+      attr_reader :customizations
+      attr_accessor :guest
 
       def initialize
-        @forwarded_ports = {}
+        @forwarded_ports = []
         @shared_folders = {}
-        @network_options = []
+        @networks = []
         @provisioners = []
+        @customizations = []
       end
 
-      def forward_port(name, guestport, hostport, options=nil)
-        options = {
+      # Custom merge method since some keys here are merged differently.
+      def merge(other)
+        result = super
+        result.instance_variable_set(:@forwarded_ports, @forwarded_ports + other.forwarded_ports)
+        result.instance_variable_set(:@shared_folders, @shared_folders.merge(other.shared_folders))
+        result.instance_variable_set(:@networks, @networks + other.networks)
+        result.instance_variable_set(:@provisioners, @provisioners + other.provisioners)
+        result.instance_variable_set(:@customizations, @customizations + other.customizations)
+        result
+      end
+
+      def forward_port(guestport, hostport, options=nil)
+        if !guestport.kind_of?(Integer)
+          raise Errors::DeprecationError, :message => <<-MESSAGE
+`config.vm.forward_port` changed in 0.9.0 where the required name
+argument is now removed. Vagrant will now automatically generate
+a unique name for your forwarded port. For example, to forward
+port 80 to port 8080 you now do the following:
+
+    config.vm.forward_port 80, 8080
+
+Please change your configurations to match this new syntax.
+          MESSAGE
+        end
+
+        @forwarded_ports << {
+          :name       => "#{guestport.to_s(32)}-#{hostport.to_s(32)}",
           :guestport  => guestport,
           :hostport   => hostport,
           :protocol   => :tcp,
-          :adapter    => 0,
+          :adapter    => 1,
           :auto       => false
         }.merge(options || {})
-
-        forwarded_ports[name] = options
       end
 
       def share_folder(name, guestpath, hostpath, opts=nil)
         @shared_folders[name] = {
-          :guestpath => guestpath,
-          :hostpath => hostpath,
+          :guestpath => guestpath.to_s,
+          :hostpath => hostpath.to_s,
+          :create => false,
           :owner => nil,
           :group => nil,
-          :nfs   => false
+          :nfs   => false,
+          :extra => nil
         }.merge(opts || {})
       end
 
-      def network(ip, options=nil)
-        options = {
-          :ip => ip,
-          :netmask => "255.255.255.0",
-          :adapter => 1,
-          :mac => nil,
-          :name => nil
-        }.merge(options || {})
+      def network(type, *args)
+        if !type.kind_of?(Symbol)
+          raise Errors::DeprecationError, :message => <<-MESSAGE
+`config.vm.network` changed in 0.9.0 where the first argument is
+now the type of network and the remaining arguments are options for
+that type. For example, host only networks are now configured like
+so:
 
-        @network_options[options[:adapter]] = options
+    config.vm.network :hostonly, "172.24.24.24"
+
+Please change your configurations to match this new syntax.
+          MESSAGE
+        end
+
+        @networks << [type, args]
       end
 
       def provision(name, options=nil, &block)
-        @provisioners << Provisioner.new(top, name, options, &block)
+        @provisioners << Provisioner.new(name, options, &block)
       end
 
-      def customize(&block)
-        push_proc(&block)
-      end
+      # TODO: This argument should not be `nil` in the future.
+      # It is only defaulted to nil so that the deprecation error
+      # can be properly shown.
+      def customize(command=nil)
+        if block_given?
+          raise Errors::DeprecationError, :message => <<-MESSAGE
+`config.vm.customize` now takes an array of arguments to send to
+`VBoxManage` instead of having a block which gets a virtual machine
+object. Example of the new usage:
+
+    config.vm.customize ["modifyvm", :id, "--memory", "1024"]
+
+The above will run `VBoxManage modifyvm 1234 --memory 1024` where
+"1234" is the ID of your current virtual machine. Anything you could
+do before is certainly still possible with `VBoxManage` as well.
+          MESSAGE
+        end
 
-      def has_multi_vms?
-        !defined_vms.empty?
+        @customizations << command if command
       end
 
       def defined_vms
@@ -95,17 +138,19 @@ module Vagrant
         # Add the SubVM to the hash of defined VMs
         defined_vms[name] ||= SubVM.new
         defined_vms[name].options.merge!(options)
-        defined_vms[name].push_proc(&block)
+        defined_vms[name].push_proc(&block) if block
       end
 
-      def validate(errors)
+      def validate(env, errors)
         errors.add(I18n.t("vagrant.config.vm.box_missing")) if !box
-        errors.add(I18n.t("vagrant.config.vm.box_not_found", :name => box)) if box && !box_url && !env.box
-        errors.add(I18n.t("vagrant.config.vm.boot_mode_invalid")) if ![:vrdp, :gui].include?(boot_mode.to_sym)
-        errors.add(I18n.t("vagrant.config.vm.base_mac_invalid")) if env.box && !base_mac
+        errors.add(I18n.t("vagrant.config.vm.box_not_found", :name => box)) if box && !box_url && !env.boxes.find(box)
+        errors.add(I18n.t("vagrant.config.vm.boot_mode_invalid")) if ![:headless, :gui].include?(boot_mode.to_sym)
+        errors.add(I18n.t("vagrant.config.vm.base_mac_invalid")) if env.boxes.find(box) && !base_mac
 
         shared_folders.each do |name, options|
-          if !File.directory?(File.expand_path(options[:hostpath].to_s, env.root_path))
+          hostpath = Pathname.new(options[:hostpath]).expand_path(env.root_path)
+
+          if !hostpath.directory? && !options[:create]
             errors.add(I18n.t("vagrant.config.vm.shared_folder_hostpath_missing",
                        :name => name,
                        :path => options[:hostpath]))
@@ -119,28 +164,42 @@ module Vagrant
         end
 
         # Validate some basic networking
-        network_options.each do |options|
-          next if !options
-
-          ip = options[:ip].split(".")
-
-          if ip.length != 4
-            errors.add(I18n.t("vagrant.config.vm.network_ip_invalid",
-                              :ip => options[:ip]))
-          elsif ip.last == "1"
-            errors.add(I18n.t("vagrant.config.vm.network_ip_ends_one",
-                              :ip => options[:ip]))
+        #
+        # TODO: One day we need to abstract this out, since in the future
+        # providers other than VirtualBox will not be able to satisfy
+        # all types of networks.
+        networks.each do |type, args|
+          if type == :hostonly && args[0] == :dhcp
+            # Valid. There is no real way this can be invalid at the moment.
+          elsif type == :hostonly
+            # Validate the host-only network
+            ip      = args[0]
+            options = args[1] || {}
+
+            if !ip
+              errors.add(I18n.t("vagrant.config.vm.network_ip_required"))
+            else
+              ip_parts = ip.split(".")
+
+              if ip_parts.length != 4
+                errors.add(I18n.t("vagrant.config.vm.network_ip_invalid",
+                                  :ip => ip))
+              elsif ip_parts.last == "1"
+                errors.add(I18n.t("vagrant.config.vm.network_ip_ends_one",
+                                  :ip => ip))
+              end
+            end
+          elsif type == :bridged
+          else
+            # Invalid network type
+            errors.add(I18n.t("vagrant.config.vm.network_invalid",
+                              :type => type.to_s))
           end
         end
 
         # Each provisioner can validate itself
         provisioners.each do |prov|
-          # TODO: Remove at some point
-          if prov.shortcut == :chef_server
-            errors.add(I18n.t("vagrant.config.vm.provisioner_chef_server_changed"))
-          else
-            prov.validate(errors)
-          end
+          prov.validate(env, errors)
         end
       end
     end

data/lib/vagrant/config/vm/provisioner.rb

@@ -1,42 +1,38 @@
+require 'log4r'
+
 module Vagrant
-  class Config
+  module Config
     class VMConfig < Base
       # Represents a single configured provisioner for a VM.
       class Provisioner
-        attr_reader :top
         attr_reader :shortcut
         attr_reader :provisioner
         attr_reader :config
 
-        def initialize(top, shortcut, options=nil, &block)
-          @top = top
+        def initialize(shortcut, options=nil, &block)
+          @logger = Log4r::Logger.new("vagrant::config::vm::provisioner")
+          @logger.debug("Provisioner config: #{shortcut}")
           @shortcut = shortcut
           @provisioner = shortcut
-          @provisioner = Provisioners::Base.registered[shortcut] if shortcut.is_a?(Symbol)
+          @provisioner = Vagrant.provisioners.get(shortcut) if shortcut.is_a?(Symbol)
           @config = nil
 
-          configure(options, &block)
+          @logger.info("Provisioner class: #{provisioner}")
+          configure(options, &block) if @provisioner
         end
 
         # Configures the provisioner if it can (if it is valid).
         def configure(options=nil, &block)
-          # We don't want ancestors to be searched. This is the default in 1.8,
-          # but not in 1.9, hence this hackery.
-          const_args = ["Config"]
-          const_args << false if RUBY_VERSION >= "1.9"
-
-          # We assume that every provisioner has a `Config` class beneath
-          # it for configuring.
-          return if !@provisioner || !@provisioner.const_defined?(*const_args)
-
-          # Instantiate the config class and configure it
-          @config = @provisioner.const_get(*const_args).new
-          @config.top = top
+          config_class = @provisioner.config_class
+          return if !config_class
+
+          @logger.debug("Configuring provisioner with: #{config_class}")
+          @config = config_class.new
           @config.set_options(options) if options
           block.call(@config) if block
         end
 
-        def validate(errors)
+        def validate(env, errors)
           if !provisioner
             # If we don't have a provisioner then the whole thing is invalid.
             errors.add(I18n.t("vagrant.config.vm.provisioner_not_found", :shortcut => shortcut))
@@ -48,7 +44,7 @@ module Vagrant
           end
 
           # Pass on validation to the provisioner config
-          config.validate(errors) if config
+          config.validate(env, errors) if config
         end
       end
     end

data/lib/vagrant/config/vm/sub_vm.rb

@@ -1,5 +1,5 @@
 module Vagrant
-  class Config
+  module Config
     class VMConfig < Base
       # Represents a single sub-VM in a multi-VM environment.
       class SubVM

data/lib/vagrant/data_store.rb

@@ -1,3 +1,7 @@
+require 'pathname'
+
+require 'log4r'
+
 module Vagrant
   # The Vagrant data store is a key-value store which is persisted
   # as JSON in a local file which is specified in the initializer.
@@ -16,19 +20,19 @@ module Vagrant
     attr_reader :file_path
 
     def initialize(file_path)
-      @file_path = file_path
-      return if !file_path
+      @logger    = Log4r::Logger.new("vagrant::datastore")
+      @logger.info("Created: #{file_path}")
+
+      @file_path = Pathname.new(file_path)
 
-      raise Errors::DotfileIsDirectory if File.directory?(file_path)
+      if @file_path.exist?
+        raise Errors::DotfileIsDirectory if @file_path.directory?
 
-      if File.exist?(file_path)
-        File.open(file_path, "r") do |f|
-          begin
-            merge!(JSON.parse(f.read))
-          rescue JSON::ParserError
-            # Ignore if the data is invalid in the file.
-            # TODO: Log here.
-          end
+        begin
+          merge!(JSON.parse(@file_path.read))
+        rescue JSON::ParserError
+          # Ignore if the data is invalid in the file.
+          @logger.error("Data store contained invalid JSON. Ignoring.")
         end
       end
     end
@@ -36,15 +40,19 @@ module Vagrant
     # Commits any changes to the data to disk. Even if the data
     # hasn't changed, it will be reserialized and written to disk.
     def commit
-      return if !file_path
-
       clean_nil_and_empties
 
       if empty?
         # Delete the file since an empty data store is not useful
-        File.delete(file_path) if File.file?(file_path)
+        @logger.info("Deleting data store since we're empty: #{@file_path}")
+        @file_path.delete if @file_path.exist?
       else
-        File.open(file_path, "w") { |f| f.write(to_json) }
+        @logger.info("Committing data to data store: #{@file_path}")
+
+        @file_path.open("w") do |f|
+          f.write(to_json)
+          f.fsync
+        end
       end
     end