vagrant-vmware-esxi 1.2.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '038a1ea82c5af283f14aec64af6772ce14ab4a4c'
-  data.tar.gz: ddf92761c6a4c8156306c2584bf0f4996ad3ac88
+  metadata.gz: e6c1b544be5e69be9aad5aa1d1eb7f7e47097f83
+  data.tar.gz: 5cfd76a90f5f9a1a5fc8989b7a32b69b214a010d
 SHA512:
-  metadata.gz: 72258bd912e1a2c306d18033929378867137a4d84d9e6719ac1931c0fbf022ce82073c24db07d53a96db9c78f170bf19dc6df1e5ab891eae758497cc49240e90
-  data.tar.gz: 36b7980ccebfbbc75a5012b791430dce5d88cb519ce515a25071c4600173453ece226241f6117b7c78a116d996ee8b1b8b214568e4e50b4ce703bfb48126e581
+  metadata.gz: a288fc3eb3823e2763cf55d720889a87456cce474535a23233cfc0372f47aae956201df6de80fb0487fe0b09a7bbc3565704335909b96dc83a5b6861fffd3c9b
+  data.tar.gz: 2dedd6fbc8d32a7b5c1d7f5d20b2214fbc27dfd2a4124552e685067a5429d1e493ed3064331a631c8781eab00e9f10a062b3fdd41945f18aad236bfa8954ce3d

data/README.md

@@ -85,44 +85,69 @@ Vagrant.configure("2") do |config|
     esxi.esxi_username = "root"
 
     #
-    #  A NOTE about esxi_password / ssh keys!!
+    #  IMPORTANT!  ESXi password.
+    #  *** NOTES about esxi_password & ssh keys!! ***
+    #
+    #    1) "prompt:"
+    #       This will prompt you for the esxi password each time you
+    #       run a vagrant command.  This is the default.
+    #
+    #    2) "file:"  or  "file:my_secret_file"
+    #       This will read a plain text file containing the esxi
+    #       password.   The default filename is ~/.esxi_password, or
+    #       you can specify any filename after the colon ":".
+    #
+    #    3) "env:"  or "env:my_secret_env_var"
+    #        This will read the esxi password via a environment
+    #        variable.  The default is $esxi_password, but you can
+    #        specify any environment variable after the colon ":".
+    #
+    #            $ export esxi_password="my_secret_password"
     #
-    #    If you don't specify a password and do not use ssh
-    #    keys, you will be entering your esxi password A LOT!
+    #    4)  "key:"  or  key:~/.ssh/some_ssh_private_key"
+    #        Use ssh keys.  The default is to use the system private keys,
+    #        or you specify a custom private key after the colon ":".
     #
-    #    From your command line, you should be able to run
-    #    following command without an error and be able to get to
-    #    the esxi command prompt.
+    #        To test connectivity. From your command line, you should be able to
+    #        run following command without an error and get an esxi prompt.
     #
-    #      $ ssh root@ESXi_IP_ADDRESS
+    #            $ ssh root@ESXi_IP_ADDRESS
+    #
+    #        The ssh connections to esxi will try the ssh private
+    #        keys.  However the ovftool does NOT!  To make
+    #        vagrant fully password-less, you will need to use other
+    #        options. (set the passord, use "env:" or "file:")
+    #
+    #    5)  esxi.esxi_password = "my_esxi_password"
+    #        Enter your esxi passowrd in clear text here...  This is the
+    #        least secure method because you may share this Vagrant file without
+    #        realizing the password is in clear text.
+    #
+    #  IMPORTANT!  Set the ESXi password or authentication method..
+    esxi.esxi_password = "prompt:"
 
-    #  IMPORTANT!  ESXi password.
-    #    The ssh connections to esxi will try your ssh
-    #    keys first.  However the ovftool does NOT!  To make
-    #    vagrant up fully password-less, you will need to
-    #    enter your password here....
-    esxi.esxi_password = nil
-
-    #  ESXi ssh keys
-    #    The Default is to use system defaults, However
+    #  ESXi ssh keys.   (This is depreciated!!!)
+    #    The Default is to use system default ssh keys, However
     #    you can specify an array of keys here...
+    #
+    #   ***  Depreciated, use esxi_password = "key:" instead. ***
     #esxi.esxi_private_keys = []
 
     #  SSH port.
-    #    Default port 22
+    #    Default port 22.
     #esxi.esxi_hostport = 22
 
     #  HIGHLY RECOMMENDED!  Virtual Network
-    #    You should specify a Virtual Network!
-    #    The default is to use the first found!
+    #    You should specify a Virtual Network!  If it's not specified, the
+    #    default is to use the first found.
     #    You can specify up to 4 virtual networks using an array
-    #    format.  Note that Vagrant only looks at the first 
-    #    interface for an IP address.
+    #    format.  Note that Vagrant only looks at the first
+    #    interface for a valid IP address.
     #esxi.virtual_network = "vmnet_example"
     #esxi.virtual_network = ["vmnet1","vmnet2","vmnet3","vmnet4"]
 
     #  OPTIONAL.  Specify a Disk Store
-    #    The Default is to use the least used Disk Store.
+    #    If it's not specified, the Default is to use the least used Disk Store.
     #esxi.vm_disk_store = "DS_001"
 
     #  OPTIONAL.  Guest VM name to be created/used.
@@ -142,20 +167,22 @@ Vagrant.configure("2") do |config|
     #esxi.memsize = "2048"
 
     #  OPTIONAL.  Virtual CPUs override
-    #    The default is to use the number of virt cpus specified
+    #    The default is to use the number of virtual cpus specified
     #     in the vmx file, however you can specify a new value here.
     #esxi.numvcpus = "2"
 
     #  OPTIONAL.  Resource Pool
-    #    The default is to create VMs in the "root".  You can
-    #     specify a resource pool here to partition memory and
-    #     cpu usage away from other systems on your esxi host.
-    #     The resource pool must already exist and have the
-    #     proper permissions set.
+    #    If unspecified, the default is to create VMs in the "root".  You can
+    #    specify a resource pool here to partition memory and cpu usage away
+    #    from other systems on your esxi host.  The resource pool must
+    #    already exist and have the proper permissions set.
+    #     
     #     Vagrant will NOT create a Resource pool it for you.
     #esxi.resource_pool = "/Vagrant"
 
     #  DANGEROUS!  Allow Overwrite
+    #    If unspecified, the default is to produce an error if overwriting
+    #    vm's and packages.
     #    Set this to 'True' will overwrite existing VMs (with the same name)
     #    when you run vagrant up.   ie,  if the vmname already exists,
     #    it will be destroyed, then over written...  This is helpful
@@ -178,6 +205,7 @@ Basic usage
   * `vagrant resume`
   * `vagrant snapshot push`
   * `vagrant snapshot list`
+  * `vagrant snapshot-info`
   * `vagrant snapshot pop`  
   * `vagrant halt`
   * `vagrant provision`
@@ -189,12 +217,13 @@ Known issues with vmware_esxi
 * Cleanup doesn't always destroy a VM that has been partially built.  Use the allow_overwrite = 'True' option if you need to force a rebuild.
 * ovftool installer for windows doesn't put ovftool.exe in your path.  You can manually set your path, or install ovftool in the \HashiCorp\Vagrant\bin directory.
 * Built-in Vagrant synced folders using NFS fails if you try to re-provision.
-  * In general I find NFS synced folders pretty "flakey" anyways...
+  * In general I find NFS synced folders pretty "flaky" anyways...
 * Multi machines may not provision one VM if the boxes are different.
   * I found this problem with libvirt also, so I'm assuming it's a vagrant problem...
 
 Version History
 ---------------
+* 1.3.0 Add support to get esxi password from env, from a file or prompt.
 * 1.2.1 Encode special characters in password.
 * 1.2.0 Add support for up to 4 virtual networks.
 * 1.7.1 Show all port groups for each virtual switch instead of just the first.

data/Rakefile

@@ -1,4 +1,4 @@
 require "rubygems"
 require "bundler/gem_tasks"
-require "net/ssh/simple"
+require "net/ssh"
 Bundler::GemHelper.install_tasks

data/example_box/Vagrantfile

@@ -19,7 +19,7 @@ Vagrant.configure("2") do |config|
   #config.vm.box = 'generic/alpine36'
 
 
-  #  Supports type rsync and NFS.
+  #  Synced folders supports type rsync and NFS.
   config.vm.synced_folder('.', '/Vagrantfiles', type: 'rsync')
 
   #
@@ -37,27 +37,52 @@ Vagrant.configure("2") do |config|
     esxi.esxi_username = "root"
 
     #
-    #  A NOTE about esxi_password / ssh keys!!
+    #  IMPORTANT!  ESXi password.
+    #  *** NOTES about esxi_password & ssh keys!! ***
+    #
+    #    1)  esxi.esxi_password = "my_esxi_password"
+    #        Enter your esxi passowrd in clear text here...
+    #
+    #    2)  "key:"  or  ""  or "key:~/.ssh/some_ssh_private_key"
+    #        Use ssh keys.  The default is to use the system private keys,
+    #        or you specify a custom private key after the colon ":".
+    #
+    #        From your command line, you should be able to run
+    #        following command without an error and be able to get to
+    #        the esxi command prompt.
+    #
+    #            $ ssh root@ESXi_IP_ADDRESS
+    #
+    #        The ssh connections to esxi will try the ssh private
+    #        keys.  However the ovftool does NOT!  To make
+    #        vagrant fully password-less, you will need to use other
+    #        options. (set the passord, use "env:" or "file:")
     #
-    #    If you don't specify a password and do not use ssh
-    #    keys, you will be entering your esxi password A LOT!
+    #    3) "prompt:"
+    #       This will prompt you for the esxi password each time you
+    #       run a vagrant command.
     #
-    #    From your command line, you should be able to run
-    #    following command without an error and be able to get to
-    #    the esxi command prompt.
+    #    4) "file:"  or  "file:my_secret_file"
+    #       This will read a plain text file containing the esxi
+    #       password.   The default filename is ~/.esxi_password, or
+    #       you can specify any filename after the colon ":".
     #
-    #      $ ssh root@ESXi_IP_ADDRESS
+    #    5) "env:"  or "env:my_secret_env_var"
+    #        This will read the esxi password via a environment
+    #        variable.  The default is $esxi_password, but you can
+    #        specify any environment variable after the colon ":".
+    #
+    #            $ export esxi_password="my_secret_password"
+    #
+    #
+    #  IMPORTANT!  Set the ESXi password.
+    esxi.esxi_password = "prompt:"
 
-    #  IMPORTANT!  ESXi password.
-    #    The ssh connections to esxi will try your ssh
-    #    keys first.  However the ovftool does NOT!  To make
-    #    vagrant up fully password-less, you will need to
-    #    enter your password here....
-    esxi.esxi_password = nil
-
-    #  ESXi ssh keys
-    #    The Default is to use system defaults, However
+    #  ESXi ssh keys.   (This will be depreciated!!!)
+    #    The Default is to use system default ssh keys, However
     #    you can specify an array of keys here...
+    #
+    #   ***  Depreciated, use esxi_password = "key:" instead. ***
     #esxi.esxi_private_keys = []
 
     #  SSH port.

data/example_box/Vagrantfile-multimachine

@@ -22,7 +22,7 @@ Vagrant.configure("2") do |config|
     #
     esxi.esxi_hostname = "esxi"
     esxi.esxi_username = "root"
-    esxi.esxi_password = nil
+    esxi.esxi_password = "file:"
     #esxi.esxi_private_keys = []
     #esxi.esxi_hostport = 22
     #esxi.virtual_network = "vmnet_example"

data/lib/vagrant-vmware-esxi/action.rb

@@ -5,14 +5,10 @@ module VagrantPlugins
     # actions and how to run them
     module Action
       include Vagrant::Action::Builtin
-      def self.action_connect_esxi
-        Vagrant::Action::Builder.new.tap do |b|
-          b.use ConnectESXi
-        end
-      end
 
       def self.action_read_state
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use ReadSSHInfo
           b.use ReadState
         end
@@ -20,12 +16,14 @@ module VagrantPlugins
 
       def self.action_read_ssh_info
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use ReadSSHInfo
         end
       end
 
       def self.action_halt
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use ReadState
           b.use Halt
         end
@@ -33,6 +31,7 @@ module VagrantPlugins
 
       def self.action_suspend
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use ReadState
           b.use Suspend
         end
@@ -40,6 +39,7 @@ module VagrantPlugins
 
       def self.action_resume
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use ReadState
           b.use Resume
         end
@@ -47,6 +47,7 @@ module VagrantPlugins
 
       def self.action_ssh
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use ReadState
           b.use ReadSSHInfo
           b.use SSHExec
@@ -56,24 +57,28 @@ module VagrantPlugins
 
       def self.action_snapshot_list
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use SnapshotList
         end
       end
 
       def self.action_snapshot_info
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use SnapshotInfo
         end
       end
 
       def self.action_snapshot_save
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use SnapshotSave
         end
       end
 
       def self.action_snapshot_restore
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use action_halt
           b.use Call, WaitForState, :powered_off, 240 do |env1, b1|
             if env1[:result] == 'True'
@@ -86,6 +91,7 @@ module VagrantPlugins
 
       def self.action_snapshot_delete
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use SnapshotDelete
         end
       end
@@ -93,6 +99,7 @@ module VagrantPlugins
 
       def self.action_destroy
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use Call, ReadState do |env1, b1|
             unless env1[:machine_state] == 'powered_off'
               b1.use action_halt
@@ -105,6 +112,7 @@ module VagrantPlugins
 
       def self.action_reload
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use Call, ReadState do |env1, b1|
             if (env1[:machine_state].to_s == 'powered_on') ||
                (env1[:machine_state].to_s == 'running') ||
@@ -118,8 +126,8 @@ module VagrantPlugins
 
       def self.action_up
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use ConfigValidate
-          b.use ConnectESXi
           b.use HandleBox
           b.use ReadState
           b.use CreateVM
@@ -135,6 +143,7 @@ module VagrantPlugins
 
       def self.action_provision
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use ReadState
           b.use Call, WaitForState, :running, 240 do |env1, b1|
             if env1[:result] == 'True'
@@ -149,13 +158,14 @@ module VagrantPlugins
 
       def self.action_package
         Vagrant::Action::Builder.new.tap do |b|
+          b.use SetESXiPassword
           b.use ReadState
           b.use Package
         end
       end
 
       action_root = Pathname.new(File.expand_path('../action', __FILE__))
-      autoload :ConnectESXi, action_root.join('connect_esxi')
+      autoload :SetESXiPassword, action_root.join('esxi_password')
       autoload :CreateVM, action_root.join('createvm')
       autoload :ReadState, action_root.join('read_state')
       autoload :ReadSSHInfo, action_root.join('read_ssh_info')

data/lib/vagrant-vmware-esxi/action/boot.rb

@@ -1,5 +1,5 @@
 require 'log4r'
-require 'net/ssh/simple'
+require 'net/ssh'
 
 module VagrantPlugins
   module ESXi
@@ -34,19 +34,20 @@ module VagrantPlugins
             env[:ui].info I18n.t('vagrant_vmware_esxi.vagrant_vmware_esxi_message',
                                  message: 'Cannot boot in this state')
           else
-            Net::SSH::Simple.sync(
-              user:     config.esxi_username,
-              password: config.esxi_password,
-              port:     config.esxi_hostport,
-              keys:     config.esxi_private_keys
-            ) do
+            Net::SSH.start( config.esxi_hostname, config.esxi_username,
+              password:                   $esxi_password,
+              port:                       config.esxi_hostport,
+              keys:                       config.esxi_private_keys,
+              timeout:                    10,
+              number_of_password_prompts: 0,
+              non_interactive:            true
+            ) do |ssh|
 
-              r = ssh config.esxi_hostname,
-                      "vim-cmd vmsvc/power.on #{machine.id}"
-              if r.exit_code != 0
+              r = ssh.exec!("vim-cmd vmsvc/power.on #{machine.id}")
+              if r.exitstatus != 0
                 raise Errors::ESXiError,
                       message: "Unable to power on VM:\n"\
-                               "  #{r.stdout}\n#{r.stderr}"
+                               "  #{r}"
               end
               env[:ui].info I18n.t('vagrant_vmware_esxi.vagrant_vmware_esxi_message',
                                    message: 'VM has been Powered On...')

data/lib/vagrant-vmware-esxi/action/createvm.rb

@@ -1,11 +1,11 @@
 require 'log4r'
-require 'net/ssh/simple'
+require 'net/ssh'
 
 module VagrantPlugins
   module ESXi
     module Action
-      # This action connects to the ESXi, verifies credentials and
-      # validates if it's a ESXi host
+      # This action creates a new vmx file (using overwrides from config file),
+      # then creates a new VM guest using ovftool.
       class CreateVM
         def initialize(app, _env)
           @app    = app
@@ -64,27 +64,28 @@ module VagrantPlugins
           #
           #  Open the network connection
           #
-          Net::SSH::Simple.sync(
-            user:     config.esxi_username,
-            password: config.esxi_password,
-            port:     config.esxi_hostport,
-            keys:     config.esxi_private_keys
-          ) do
+          Net::SSH.start( config.esxi_hostname, config.esxi_username,
+            password:                   $esxi_password,
+            port:                       config.esxi_hostport,
+            keys:                       config.esxi_private_keys,
+            timeout:                    10,
+            number_of_password_prompts: 0,
+            non_interactive:            true
+          ) do |ssh|
 
             @logger = Log4r::Logger.new('vagrant_vmware_esxi::action::createvm-ssh')
 
             #
             #  Figure out DataStore
-            r = ssh config.esxi_hostname,
+            r = ssh.exec!(
                     'df | grep "^[VMFS|NFS]" | sort -nk4 |'\
-                    'sed "s|.*/vmfs/volumes/||g" | tail +2'
+                    'sed "s|.*/vmfs/volumes/||g" | tail +2')
 
-            availvolumes = r.stdout.dup.split(/\n/)
-            if (config.debug =~ %r{true}i) ||
-               (config.debug =~ %r{yes}i)
+            availvolumes = r.split(/\n/)
+            if (config.debug =~ %r{true}i)
                puts "Available DS Volumes: #{availvolumes}"
             end
-            if (r == '') || (r.exit_code != 0)
+            if (r == '') || (r.exitstatus != 0)
               raise Errors::ESXiError,
                     message: 'Unable to get list of Disk Stores:'
             end
@@ -116,16 +117,15 @@ module VagrantPlugins
             #
             #  Figure out network
             #
-            r = ssh config.esxi_hostname,
+            r = ssh.exec!(
                     'esxcli network vswitch standard list |'\
                     'grep Portgroups | sed "s/^   Portgroups: //g" |'\
-                    'sed "s/,./\n/g"'
-            availnetworks = r.stdout.dup.split(/\n/)
-            if (config.debug =~ %r{true}i) ||
-               (config.debug =~ %r{yes}i)
+                    'sed "s/,./\n/g"')
+            availnetworks = r.split(/\n/)
+            if (config.debug =~ %r{true}i)
                puts "Available Networks: #{availnetworks}"
             end
-            if (availnetworks == '') || (r.exit_code != 0)
+            if (availnetworks == '') || (r.exitstatus != 0)
               raise Errors::ESXiError,
                     message: "Unable to get list of Virtual Networks:\n"\
                              "#{r.stderr}"
@@ -202,14 +202,11 @@ module VagrantPlugins
               end
             end
 
-            #unless new_vmx_contents =~ %r{^ethernet0.networkName =}i
-            #  new_vmx_contents << "ethernet0.networkName = \"#{guestvm_network}\"\n"
-            #end
+            #  Append virt network options
             netOpts = ""
             networkID = 0
             for element in guestvm_network do
-              if (config.debug =~ %r{true}i) ||
-                 (config.debug =~ %r{yes}i)
+              if (config.debug =~ %r{true}i)
                 puts "guestvm_network[#{networkID}]: #{element}"
               end
               new_vmx_contents << "ethernet#{networkID}.networkName = \"net#{networkID}\"\n"
@@ -222,6 +219,7 @@ module VagrantPlugins
               end
             end
 
+            # append custom_vmx_settings if exists
             if config.custom_vmx_settings.is_a? Array
               env[:machine].provider_config.custom_vmx_settings.each do |k, v|
                 new_vmx_contents << "#{k} = \"#{v}\"\n"
@@ -286,19 +284,6 @@ module VagrantPlugins
             end
             env[:ui].info I18n.t('vagrant_vmware_esxi.vagrant_vmware_esxi_message',
                                  message: "Resource Pool   : #{resource_pool}")
-            #
-            #  Encode special characters in PW
-            #
-            encoded_esxi_password = config.esxi_password.gsub('@', '%40').gsub(\
-              '<', '%3c').gsub('>', '%3e').gsub(\
-              '[', '%5b').gsub(']', '%5d').gsub(\
-              '(', '%28').gsub(')', '%29').gsub(\
-              '%', '%25').gsub('#', '%23').gsub(\
-              '&', '%26').gsub(':', '%3a').gsub(\
-              '/', '%2f').gsub('\\','%5c').gsub(\
-              '"', '%22').gsub('\'','%27').gsub(\
-              '*', '%2a').gsub('?', '%3f')
-
 
             #
             # Using ovftool, import vmx in box folder, export to ESXi server
@@ -313,32 +298,34 @@ module VagrantPlugins
                   "#{netOpts} -dm=thin --powerOn "\
                   "-ds=\"#{guestvm_dsname}\" --name=\"#{guestvm_vmname}\" "\
                   "\"#{new_vmx_file}\" vi://#{config.esxi_username}:"\
-                  "#{encoded_esxi_password}@#{config.esxi_hostname}"\
+                  "#{$encoded_esxi_password}@#{config.esxi_hostname}"\
                   "#{resource_pool}"
 
             #  Security bug if unremarked! Password will be exposed in log file.
-            #  @logger.info("vagrant-vmware-esxi, createvm: ovf_cmd #{ovf_cmd}")
-            if (config.debug =~ %r{true}i) ||
-               (config.debug =~ %r{yes}i)
-               puts "ovftool command: #{ovf_cmd}"
+            if (config.debug =~ %r{password}i)
+              @logger.info("vagrant-vmware-esxi, createvm: ovf_cmd #{ovf_cmd}")
+              puts "ovftool command: #{ovf_cmd}"
+            end
+            if (config.debug =~ %r{true}i)
+              ovf_cmd_nopw = ovf_cmd.gsub(/#{$encoded_esxi_password}/, '******')
+              puts "ovftool command: #{ovf_cmd_nopw}"
             end
             unless system "#{ovf_cmd}"
               raise Errors::OVFToolError, message: ''
             end
 
-            # VMX file is not needed any longer
-            if (config.debug =~ %r{true}i) ||
-               (config.debug =~ %r{yes}i)
+            # VMX file is not needed any longer. Delete it
+            if (config.debug =~ %r{true}i)
                puts "Keeping file: #{new_vmx_file}"
              else
                File.delete(new_vmx_file)
              end
 
-            r = ssh config.esxi_hostname,
+            r = ssh.exec!(
                     'vim-cmd vmsvc/getallvms |'\
-                    "grep \" #{guestvm_vmname} \"|awk '{print $1}'"
-            vmid = r.stdout
-            if (vmid == '') || (r.exit_code != 0)
+                    "grep \" #{guestvm_vmname} \"|awk '{print $1}'")
+            vmid = r
+            if (vmid == '') || (r.exitstatus != 0)
               raise Errors::ESXiError,
                     message: "Unable to register / start #{guestvm_vmname}"
             end