vagrant-shell-commander 0.1.0 → 0.1.1

data/.gitignore

@@ -16,4 +16,5 @@ test/version_tmp
 tmp
 .ruby-*
 *~
-.vagrant
+.vagrant
+*gem

data/Gemfile.lock

@@ -13,7 +13,7 @@ GIT
 PATH
   remote: .
   specs:
-    vagrant-shell-commander (0.1.0)
+    vagrant-shell-commander (0.1.1)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -7,7 +7,7 @@ Vagrant plugin for executing arbitrary shell commands on guest. Executes the giv
 
 ## Installation
 
-Install it as a vagrant plugin:
+As usual with vagrant plugins:
 
     $ vagrant plugin install vagrant-shell-commander
 
@@ -21,14 +21,19 @@ Restrict the machine to run:
 
     $ vagrant sh --cmd 'free' machine1
 
-Add working directory:
+Specify the working directory:
 
-    $ vagrant sh --cmd 'ls -al' --cwd '/srv/www'
+    $ vagrant sh --cmd 'ls -al' --dir '/srv/www'
+
+Get help:
+
+    $ vagrant sh -h
 
 ## Contributing
 
 1. Fork it
 2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+3. Add and implement your specs
+4. Commit your changes (`git commit -am 'Add some feature'`)
+5. Push to the branch (`git push origin my-new-feature`)
+6. Create new Pull Request

data/lib/vagrant-shell-commander/command.rb

@@ -11,10 +11,11 @@ module VagrantShellCommander
       
       return unless argv
       
-      with_target_vms(argv) do |machine|
-        manage_machine(machine, cli_options) 
+      unless [nil, ''].include? cli_options[:values][:cmd]
+        with_target_vms(argv) do |machine|
+          manage_machine(machine, cli_options) 
+        end
       end
-
       0
     end
 

data/lib/vagrant-shell-commander/option_manager.rb

@@ -9,13 +9,13 @@ module VagrantShellCommander
     def execute
       options = {}
       block = lambda do |parser|
-        parser.banner = "Usage: vagrant sh --cmd 'COMMAND' --cwd [DIR] [MACHINE]"
+        parser.banner = "Usage: vagrant sh --cmd 'COMMAND' --dir [DIR] [MACHINE]"
 
         parser.separator ''
 
-        parser.on('--cwd [DIR]', '--change-working-dir [DIR]', 
-                  'Directory to execute the command') do |cwd|
-          options[:cwd] = cwd
+        parser.on('--dir [DIR]', '--change-working-dir [DIR]', 
+                  'Directory to execute the command') do |dir|
+          options[:dir] = dir
         end
 
         parser.on("--cmd 'COMMAND'", "--command 'COMMAND'", 

data/lib/vagrant-shell-commander/version.rb

@@ -1,3 +1,3 @@
 module VagrantShellCommander
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/command_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe VagrantShellCommander::Command do
   let(:subject) {described_class.new('2', 'command')}
   let(:argv) {double}
-  let(:opts) {{parser: 'parser', values: 'values'}}
+  let(:opts) {{parser: 'parser', values: {cmd: 'cmd'}}}
 
   before(:each) do
     VagrantShellCommander::OptionManager.stub_chain(:new, :execute).
@@ -67,6 +67,7 @@ describe VagrantShellCommander::Command do
 
       context 'running machine' do
         let(:cmd) {'command'}
+        let(:cwd) {'cwd'}
         let(:communicate) {double(execute: true)}
         
         before(:each) do
@@ -90,14 +91,27 @@ describe VagrantShellCommander::Command do
         end
 
         it 'executes the command in the given cwd' do
-          cwd = 'cwd'
-
           VagrantShellCommander::OptionManager.stub_chain(:new, :execute).
             and_return(parser: 'parser', values: {cmd: cmd, cwd: cwd})
           
           communicate.should_receive(:execute).with("cd #{cwd} && #{cmd}")
         end
 
+        describe 'does nothing' do
+          after(:each) do
+            subject.should_not_receive(:with_target_vms)
+          end
+
+          it 'an empty command' do
+            VagrantShellCommander::OptionManager.stub_chain(:new, :execute).
+              and_return(parser: 'parser', values: {cmd: '', cwd: cwd})
+          end
+
+          it 'non present command' do
+            VagrantShellCommander::OptionManager.stub_chain(:new, :execute).
+              and_return(parser: 'parser', values: {cwd: cwd})
+          end
+        end
       end
     end
   end

data/spec/option_manager_spec.rb

@@ -26,17 +26,17 @@ describe VagrantShellCommander::OptionManager do
       subject.execute
     end
     
-    it 'has a cwd option' do
-      cwd_value = 'cwd'
+    it 'has a dir option' do
+      dir_value = 'dir'
       
-      option_parser.stub(:on).with('--cwd [DIR]', 
+      option_parser.stub(:on).with('--dir [DIR]', 
                                    anything, 
                                    anything).
-        and_yield(cwd_value)
+        and_yield(dir_value)
 
       result = subject.execute
 
-      expect(result[:values][:cwd]).to eql(cwd_value)
+      expect(result[:values][:dir]).to eql(dir_value)
     end
     
     it 'has a cmd option' do

data/vagrant-shell-commander.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |spec|
   spec.version       = VagrantShellCommander::VERSION
   spec.authors       = ["Federico Gimenez Nieto"]
   spec.email         = ["federico.gimenez@gmail.com"]
-  spec.description   = %q{This plugin allows you to execute a given shell command on all the machines of your multinode environment. You can aldo specify the working directory to execute the command}
+  spec.description   = %q{This Vagrant plugin allows you to execute a given shell command on all the machines of your multinode environment. You can also specify the working directory to execute the command}
   spec.summary       = %q{Vagrant plugin for executing arbitrary shell commands on guest(s)}
   spec.homepage      = "https://github.com/fgimenez/vagrant-shell-commander"
   spec.license       = "MIT"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vagrant-shell-commander
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-10 00:00:00.000000000 Z
+date: 2013-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -123,9 +123,9 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: This plugin allows you to execute a given shell command on all the machines
-  of your multinode environment. You can aldo specify the working directory to execute
-  the command
+description: This Vagrant plugin allows you to execute a given shell command on all
+  the machines of your multinode environment. You can also specify the working directory
+  to execute the command
 email:
 - federico.gimenez@gmail.com
 executables: []