vagrant-proxyconf 2.0.0 → 2.0.1

data/spec/unit/vagrant-proxyconf/action/is_enabled_spec.rb

@@ -20,26 +20,176 @@ describe VagrantPlugins::ProxyConf::Action::IsEnabled do
     end
   end
 
-  [false, ''].each do |value|
-    context "with `config.proxy.enabled=#{value.inspect}`" do
-      let(:enabled) { value }
+  describe "#has_proxy_env_var?" do
+    subject do
+      is_enabled = described_class.new(app, env)
 
-      it "results to falsy" do
-        described_class.new(app, {}).call(env)
-        expect(env[:result]).to be_falsey
+      is_enabled.send(:has_proxy_env_var?, var)
+    end
+
+    context "when HTTP_PROXY is set in the environment and config.proxy.enabled=true" do
+      let(:enabled) { true }
+      let(:var) { 'HTTP_PROXY' }
+
+      before :each do
+        ENV[var] = 'http://localhost:8888'
+      end
+
+      after :each do
+        ENV[var] = nil
+      end
+
+      it { expect(ENV[var]).to eq 'http://localhost:8888' }
+
+      it { is_expected.to eq true }
+    end
+
+    context "when HTTPS_PROXY="" is set in the environment and config.proxy.enabled=true" do
+      let(:enabled) { true }
+      let(:var) { 'HTTPS_PROXY' }
+
+      before :each do
+        ENV[var] = ''
+      end
+
+      after :each do
+        ENV[var] = nil
+      end
+
+      it { expect(ENV[var]).to eq '' }
+      it { is_expected.to eq false }
+    end
+
+  end
+
+  describe "#plugin_disabled?" do
+
+    subject do
+      is_enabled = described_class.new(app, env)
+      is_enabled.send(:plugin_disabled?, env[:machine].config.proxy)
+    end
+
+    context "given config.proxy.enabled=false" do
+      let(:enabled) { false }
+
+      it { is_expected.to eq true }
+    end
+
+    context "given config.proxy.enabled=''" do
+      let(:enabled) { "" }
+
+      it { is_expected.to eq true }
+    end
+
+    context "given config.proxy.enabled=nil" do
+      let(:enabled) { false }
+
+      it { is_expected.to eq true }
+    end
+
+    context "given config.proxy.enabled={}" do
+      let(:enabled) { false }
+
+      it { is_expected.to eq true }
+    end
+
+    context "given config.proxy.enabled={:foo => 'bar'}" do
+      let(:enabled) do
+        {:foo => 'bar'}
       end
+
+      it { is_expected.to eq false }
+    end
+
+    context "given config.proxy.enabled=true" do
+      let(:enabled) { true }
+
+      it { is_expected.to eq false }
     end
+
+    context "given config.proxy.enabled='http://localhost:8080'" do
+      let(:enabled) { 'http://localhost:8080' }
+
+      it { is_expected.to eq false }
+    end
+
   end
 
-  [nil, true, :auto, 'yes please'].each do |value|
-    context "with `config.proxy.enabled=#{value.inspect}`" do
-      let(:enabled) { value }
+  describe "#plugin_enabled?" do
+    subject do
+      is_enabled = described_class.new(app, env)
+      is_enabled.send(:plugin_enabled?, env[:machine].config.proxy)
+    end
+
+    context "when config.proxy.enabled=false and ENV['HTTP_PROXY']='http://localhost:8888'" do
+      let(:enabled) { false }
+      let(:var) { 'HTTP_PROXY' }
+
+      before :each do
+        ENV[var] = 'http://localhost:8888'
+      end
 
-      it "results to truthy" do
-        described_class.new(app, {}).call(env)
-        expect(env[:result]).to be_truthy
+      after :each do
+        ENV[var] = nil
       end
+
+      it { is_expected.to eq false }
     end
+
+  end
+
+  describe "#call" do
+    [false, '', {}, nil].each do |value|
+      context "with `config.proxy.enabled=#{value.inspect}`" do
+        let(:enabled) { value }
+
+        it "results to falsy" do
+          described_class.new(app, {}).call(env)
+          expect(env[:result]).to be_falsey
+        end
+      end
+    end
+
+    [true, :auto, 'yes please', {:foo => 'yes'}].each do |value|
+      context "with `config.proxy.enabled=#{value.inspect}` and HTTP_PROXY=http://localhost:8888" do
+        let(:enabled) { value }
+        let(:var) { 'HTTP_PROXY' }
+
+        before :each do
+          ENV[var] = 'http://localhost:8888'
+        end
+
+        after :each do
+          ENV[var] = nil
+        end
+
+        it "results to truthy" do
+          described_class.new(app, {}).call(env)
+          expect(env[:result]).to be_truthy
+        end
+      end
+    end
+
+    [true, :auto, 'yes please', {:foo => 'yes'}].each do |value|
+      context "with `config.proxy.enabled=#{value.inspect}` and HTTP_PROXY=''" do
+        let(:enabled) { value }
+        let(:var) { 'HTTP_PROXY' }
+
+        before :each do
+          ENV[var] = ''
+        end
+
+        after :each do
+          ENV[var] = nil
+        end
+
+        it "results to truthy" do
+          described_class.new(app, {}).call(env)
+          expect(env[:result]).to be_falsey
+        end
+      end
+    end
+
   end
 
 end

data/test/issues/180/.rspec

@@ -0,0 +1,2 @@
+--color
+--format documentation

data/test/issues/180/Dockerfile

@@ -0,0 +1,47 @@
+FROM centos:7
+
+ENV CI_USERNAME vagrant
+ENV CI_PASSWORD vagrant
+ENV CI_HOMEDIR  /home/vagrant
+ENV CI_SHELL    /bin/bash
+
+EXPOSE 8888
+
+RUN yum clean all && \
+    yum makecache fast && \
+    yum -y install epel-release && \
+    yum clean expire-cache && \
+    yum -y install \
+      curl \
+      initscripts \
+      openssh-clients \
+      openssh-server \
+      sudo \
+      tinyproxy
+
+RUN /usr/sbin/sshd-keygen && \
+    mkdir -p /var/run/sshd && \
+    rm -f /usr/lib/tmpfiles.d/systemd-nologin.conf
+
+RUN if ! getent passwd $CI_USERNAME; then \
+      useradd -m -d ${CI_HOMEDIR} -s ${CI_SHELL} $CI_USERNAME; \
+    fi && \
+    echo "${CI_USERNAME}:${CI_PASSWORD}" | chpasswd && \
+    echo "${CI_USERNAME} ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers && \
+    mkdir -p /etc/sudoers.d && \
+    echo "${CI_USERNAME} ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers.d/${CI_USERNAME} && \
+    chmod 0440 /etc/sudoers.d/${CI_USERNAME} && \
+    mkdir -p ${CI_HOMEDIR}/.ssh && \
+    chown -R ${CI_USERNAME}:${CI_USERNAME} ${CI_HOMEDIR}/.ssh && \
+    chmod 0700 ${CI_HOMEDIR}/.ssh && \
+    curl -L https://raw.githubusercontent.com/hashicorp/vagrant/master/keys/vagrant.pub > ${CI_HOMEDIR}/.ssh/vagrant.pub && \
+    touch ${CI_HOMEDIR}/.ssh/authorized_keys && \
+    grep -q "$(cat ${CI_HOMEDIR}/.ssh/vagrant.pub | awk '{print $2}')" ${CI_HOMEDIR}/.ssh/authorized_keys || cat ${CI_HOMEDIR}/.ssh/vagrant.pub >> ${CI_HOMEDIR}/.ssh/authorized_keys && \
+    chown ${CI_USERNAME}:${CI_USERNAME} ${CI_HOMEDIR}/.ssh/authorized_keys && \
+    chmod 0600 ${CI_HOMEDIR}/.ssh/authorized_keys
+
+COPY tinyproxy.conf /etc/tinyproxy/tinyproxy.conf
+COPY entrypoint.sh /entrypoint.sh
+
+ENTRYPOINT ["/entrypoint.sh"]
+CMD [ "start" ]

data/test/issues/180/README.md

@@ -0,0 +1,31 @@
+Tests
+-----
+
+If you are testing the current release of this plugin via bundler
+
+```
+bundle exec vagrant up default
+```
+
+## Expect
+
+
+### Box `default``
+
+  - The box `default` is a docker container that will be a reverse
+    proxy. It should provision itself and work without errors.
+
+  - You can check that the proxy is working by
+    `tail -f /var/log/tinyproxy/tinyproxy.log` inside the container
+
+  - **NOTE**: You'll need to use `docker exec <hash> -it bash` to get into the container
+
+
+### Box `docker-host`
+
+  - Vagrant should automatically instally docker-ce.
+  - The box should come up and provision itself with the proxy settings
+    configured in your Vagrantfile.
+
+
+  - **NOTE**: You can use `ssh` to connect to this container.

data/test/issues/180/Rakefile

@@ -0,0 +1,27 @@
+require 'rake'
+require 'rspec/core/rake_task'
+
+task :spec    => 'spec:all'
+task :default => :spec
+
+namespace :spec do
+  targets = []
+  Dir.glob('./spec/*').each do |dir|
+    next unless File.directory?(dir)
+    target = File.basename(dir)
+    target = "_#{target}" if target == "default"
+    targets << target
+  end
+
+  task :all     => targets
+  task :default => :all
+
+  targets.each do |target|
+    original_target = target == "_default" ? target[1..-1] : target
+    desc "Run serverspec tests to #{original_target}"
+    RSpec::Core::RakeTask.new(target.to_sym) do |t|
+      ENV['TARGET_HOST'] = original_target
+      t.pattern = "spec/#{original_target}/*_spec.rb"
+    end
+  end
+end

data/test/issues/180/Vagrantfile

@@ -0,0 +1,31 @@
+
+Vagrant.configure("2") do |config|
+
+  config.vm.define 'default' do |c|
+    c.vm.box = nil
+
+    if Vagrant.has_plugin?('vagrant-proxyconf')
+      c.proxy.enabled = false
+    end
+
+    c.vm.provider "docker" do |d|
+      d.build_dir = "."
+      d.expose = ['8888']
+      d.has_ssh = true
+      d.ports = ['8888:8888']
+    end
+  end
+
+  config.vm.define 'docker_host' do |c|
+    c.vm.box = "centos/7"
+
+    if Vagrant.has_plugin?('vagrant-proxyconf')
+      c.proxy.http     = ENV['HTTP_PROXY']
+      c.proxy.https    = ENV['HTTPS_PROXY']
+      c.proxy.no_proxy = ENV['NO_PROXY']
+    end
+
+    c.vm.provision "docker"
+  end
+
+end

data/test/issues/180/entrypoint.sh

@@ -0,0 +1,50 @@
+#!/bin/bash
+set -ex
+
+export PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
+
+start() {
+  # start ssh if sshd is installed
+  if [ -f /usr/sbin/sshd ]; then
+
+    /usr/sbin/sshd-keygen
+    /usr/sbin/sshd -t
+    /usr/sbin/sshd
+
+  else
+
+    true
+
+  fi
+
+  # start tinyproxy
+  /usr/sbin/tinyproxy \
+    -d \
+    -c "/etc/tinyproxy/tinyproxy.conf"
+}
+
+stop() {
+
+  pgrep -f 'sshd' | while read _pid
+  do
+    kill -9 $_pid
+  done
+
+  pgrep -f 'tinyproxy' | while read _pid
+  do
+    kill -9 $_pid
+  done
+
+}
+
+case "${1}" in
+
+  start)
+    start
+    ;;
+
+  stop)
+    stop
+    ;;
+
+esac

data/test/issues/180/spec/default/redhat_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe package('tinyproxy') do
+  it { should be_installed }
+end
+
+describe service('tinyproxy') do
+  it { should be_enabled }
+  it { should be_running }
+end
+
+
+describe port(8888) do
+  it { should be_listening }
+end

data/test/issues/180/spec/docker_host/redhat_spec.rb

@@ -0,0 +1,165 @@
+require 'spec_helper'
+
+PROXY_HOST = "10.0.2.2"
+
+describe service('docker') do
+  it { should be_running }
+  it { should be_enabled  }
+end
+
+describe file('/etc/docker/config.json') do
+  it { should be_file }
+  it { should exist }
+  it { should be_mode 600 }
+  it { should be_owned_by "root" }
+  it { should be_grouped_into "root" }
+end
+
+context 'when proxy is enabled' do
+
+  before(:context) do
+    ENV['HTTP_PROXY']  = "http://#{PROXY_HOST}:8888"
+    ENV['HTTPS_PROXY'] = "http://#{PROXY_HOST}:8888"
+    ENV['NO_PROXY']    = "*.example.com"
+
+    `vagrant provision #{ENV['TARGET_HOST']}`
+    `sleep 3`
+  end
+
+  describe file('/etc/docker/config.json') do
+    let(:expected_content) do
+      {
+        "proxies" => {
+          "default" => {
+            "httpProxy"  => "http://10.0.2.2:8888",
+            "httpsProxy" => "http://10.0.2.2:8888",
+             "noProxy"   => "*.example.com",
+          }
+        }
+      }
+    end
+
+    its(:content_as_json) do
+       should include(expected_content)
+    end
+  end
+
+end
+
+context 'when HTTP_PROXY=""' do
+
+  before(:context) do
+    ENV['HTTP_PROXY']  = ""
+    ENV['HTTPS_PROXY'] = "https://#{PROXY_HOST}:8888"
+    ENV['NO_PROXY']    = "*.example.com"
+
+    `vagrant provision #{ENV['TARGET_HOST']}`
+    `sleep 3`
+  end
+
+  describe file('/etc/docker/config.json') do
+    let(:expected_content) do
+      {
+        "proxies" => {
+          "default" => {
+            "httpsProxy" => "https://#{PROXY_HOST}:8888",
+             "noProxy"   => "*.example.com",
+          }
+        }
+      }
+    end
+
+    its(:content_as_json) do
+       should include(expected_content)
+    end
+  end
+
+end
+
+context 'when HTTPS_PROXY=""' do
+
+  before(:context) do
+    ENV['HTTP_PROXY']  = "http://#{PROXY_HOST}:8888"
+    ENV['HTTPS_PROXY'] = ""
+    ENV['NO_PROXY']    = "*.example.com"
+
+    `vagrant provision #{ENV['TARGET_HOST']}`
+  end
+
+  describe file('/etc/docker/config.json') do
+    let(:expected_content) do
+      {
+        "proxies" => {
+          "default" => {
+            "httpProxy"  => "http://#{PROXY_HOST}:8888",
+             "noProxy"   => "*.example.com",
+          }
+        }
+      }
+    end
+
+    its(:content_as_json) do
+       should include(expected_content)
+    end
+  end
+
+end
+
+context 'when HTTPS_PROXY="" and HTTP_PROXY=""' do
+
+  before(:context) do
+    ENV['HTTP_PROXY']  = ""
+    ENV['HTTPS_PROXY'] = ""
+    ENV['NO_PROXY']    = "*.example.com"
+
+    `vagrant provision #{ENV['TARGET_HOST']}`
+    `sleep 3`
+  end
+
+  describe file('/etc/docker/config.json') do
+    let(:expected_content) do
+      {
+        "proxies" => {
+          "default" => {
+             "noProxy"   => "*.example.com",
+          }
+        }
+      }
+    end
+
+    its(:content_as_json) do
+       should include(expected_content)
+    end
+  end
+
+end
+
+context 'when NO_PROXY=""' do
+
+  before(:context) do
+    ENV['HTTP_PROXY']  = "http://#{PROXY_HOST}:8888"
+    ENV['HTTPS_PROXY'] = "https://#{PROXY_HOST}:8888"
+    ENV['NO_PROXY']    = ""
+
+    `vagrant provision #{ENV['TARGET_HOST']}`
+    `sleep 3`
+  end
+
+  describe file('/etc/docker/config.json') do
+    let(:expected_content) do
+      {
+        "proxies" => {
+          "default" => {
+             "httpProxy" => "http://#{PROXY_HOST}:8888",
+             "httpsProxy" => "https://#{PROXY_HOST}:8888",
+          }
+        }
+      }
+    end
+
+    its(:content_as_json) do
+       should include(expected_content)
+    end
+  end
+
+end