vagrant-proxyconf 1.5.2 → 2.0.1

data/spec/unit/vagrant-proxyconf/action/configure_env_proxy_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'
 require 'vagrant-proxyconf/action/configure_env_proxy'
+require 'vagrant-proxyconf/config/proxy'
 
 describe VagrantPlugins::ProxyConf::Action::ConfigureEnvProxy do
 
@@ -24,12 +25,14 @@ describe VagrantPlugins::ProxyConf::Action::ConfigureEnvProxy do
         is_expected.to eq false
       end
     end
+
     context 'when config proxy is not enabled' do
       it do
         @config_proxy_enabled = false
         is_expected.to eq true
       end
     end
+
     context 'when config proxy is empty string' do
       it do
         @config_proxy_enabled = ''
@@ -38,24 +41,60 @@ describe VagrantPlugins::ProxyConf::Action::ConfigureEnvProxy do
     end
 
     context 'when target config proxy is enabled' do
-      it do
-        @config_proxy_enabled = { env: true }
-        is_expected.to eq false
+      context 'given config.proxy.enabled is a Hash' do
+        it 'when has key :enabled => true and not skipped, #disabled? should return false' do
+          @config_proxy_enabled = {
+            :env => {
+              :enabled => true,
+              :skip    => false,
+            }
+          }
+          is_expected.to eq false
+        end
+
+        it 'when key :enabled => true and skipped => true, #disabled should return false' do
+          @config_proxy_enabled = {
+            :env => {
+              :enabled => true,
+              :skip    => true,
+            }
+          }
+          is_expected.to eq false
+        end
+
+        it 'when config.proxy.enabled[:env] = true, return false' do
+          @config_proxy_enabled = { :env => true }
+          is_expected.to eq false
+        end
+      end
+
+      context 'given config.proxy.enabled is a Boolean' do
+        it 'when true, #disabled? should return false' do
+          @config_proxy_enabled = true
+          is_expected.to eq false
+        end
+
+        it 'when false, #disabled? should return true' do
+          @config_proxy_enabled = false
+          is_expected.to eq true
+        end
       end
     end
+
     context 'when target config proxy target is not enabled' do
       it do
         @config_proxy_enabled = { env: false }
         is_expected.to eq true
       end
     end
+
     context 'when other config proxy are not enabled' do
       it do
         @config_proxy_enabled = {
-          svn: false,
           apt: false,
           chef: false,
           docker: false,
+          env: true,
           git: false,
           npm: false,
           pear: false,
@@ -67,4 +106,66 @@ describe VagrantPlugins::ProxyConf::Action::ConfigureEnvProxy do
 
     end
   end
+
+  describe "#unconfigure_machine" do
+    let(:app) { lambda { |env| } }
+    let(:env) { Hash.new }
+    let(:machine) { double('machine') }
+
+    context 'when proxy is not enabled' do
+      context "and guest is windows" do
+        subject do
+          conf = described_class.new(app, env)
+          allow(conf).to receive(:windows_guest?).and_return(true)
+          conf.send(:unconfigure_machine)
+        end
+
+        it 'should raise NotImplementedError' do
+          expect { subject }.to raise_error(NotImplementedError)
+        end
+      end
+
+      context "and guest is linux" do
+        subject do
+          conf = described_class.new(app, env)
+
+          # configure test doubles
+          allow(conf).to receive(:windows_guest?).and_return(false)
+          conf.instance_variable_set(:@machine, machine)
+
+          @config[:enabled] = false
+          proxy = create_config_proxy(@config)
+
+          allow(machine).to receive_message_chain(:config, :proxy).and_return(proxy)
+          allow(machine).to receive_message_chain(:config, :public_send).with(:env_proxy).and_return(proxy)
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("rm -f /etc/sudoers.d/proxy")
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("rm -f /etc/profile.d/proxy.sh")
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("rm -f /tmp/vagrant-proxyconf", {:error_check => false})
+          allow(machine).to receive_message_chain(:communicate, :upload)
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("touch /etc/environment")
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("sed -e '/^HTTP_PROXY=/ d\n/^HTTPS_PROXY=/ d\n/^FTP_PROXY=/ d\n/^NO_PROXY=/ d\n/^http_proxy=/ d\n/^https_proxy=/ d\n/^ftp_proxy=/ d\n/^no_proxy=/ d\n' -e '/^$/d' /etc/environment > /etc/environment.new")
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("cat /tmp/vagrant-proxyconf >> /etc/environment.new")
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("chmod 0644 /etc/environment.new")
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("chown root:root /etc/environment.new")
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("mv -f /etc/environment.new /etc/environment")
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("rm -f /tmp/vagrant-proxyconf").and_return("sib")
+          allow(machine).to receive_message_chain(:guest, :capability).with(:env_proxy_conf).and_return("/etc/profile.d/proxy.sh")
+
+          conf.send(:unconfigure_machine)
+        end
+
+        it 'should remove file /etc/sudoers.d/proxy, /etc/sudoers.d/proxy.sh and remove configuration from /etc/environment and return true' do
+          @config = {
+            :ftp      => 'ftp://foo-proxy.foo-domain.com:8080',
+            :http     => nil,
+            :https    => 'https://foo-proxy.foo-domain.com:8080',
+            :no_proxy => 'localhost',
+          }
+
+          is_expected.to eq true
+        end
+      end
+    end
+  end
+
 end

data/spec/unit/vagrant-proxyconf/action/configure_git_proxy_spec.rb

@@ -8,4 +8,120 @@ describe VagrantPlugins::ProxyConf::Action::ConfigureGitProxy do
     it      { is_expected.to eq 'git_proxy' }
   end
 
+  describe "#configure_machine" do
+
+    context "when configuration is enabled" do
+      let(:app) { OpenStruct.new }
+      let(:env) { OpenStruct.new }
+      let(:machine) { double('machine') }
+
+      context "when supported" do
+        subject do
+          git_proxy = described_class.new(app, env)
+          git_proxy.instance_variable_set(:@machine, machine)
+
+          config = create_config_proxy(
+            :enabled  => true,
+            :http     => 'http://proxy-server-01.example.com:8080',
+            :https    => 'https://proxy-server-01.example.com:8080',
+            :no_proxy => 'localhost',
+          )
+
+          allow(machine).to receive_message_chain(:config, :proxy).and_return(config)
+          allow(machine).to receive_message_chain(:config, :public_send).with(:git_proxy).and_return(config)
+
+          allow(machine).to receive_message_chain(:guest, :capability?).with(:git_proxy_conf).and_return(true)
+          allow(machine).to receive_message_chain(:guest, :capability).with(:git_proxy_conf).and_return("/usr/bin/git")
+
+          if git_proxy.send(:disabled?)
+            binding.pry
+          else
+            allow(machine).to receive_message_chain(:communicate, :sudo).with("/usr/bin/git config --system http.proxy http://proxy-server-01.example.com:8080")
+            allow(machine).to receive_message_chain(:communicate, :sudo).with("/usr/bin/git config --system https.proxy https://proxy-server-01.example.com:8080")
+          end
+
+          git_proxy.send(:configure_machine)
+        end
+
+        it 'configures git proxy and returns true' do
+          is_expected.to eq true
+        end
+      end
+
+      context "when not supported" do
+        subject do
+          git_proxy = described_class.new(app, env)
+          git_proxy.instance_variable_set(:@machine, machine)
+
+          allow(machine).to receive_message_chain(:guest, :capability?).with(:git_proxy_conf).and_return(false)
+          allow(machine).to receive_message_chain(:guest, :capability).with(:git_proxy_conf).and_return(nil)
+
+          git_proxy.send(:configure_machine)
+        end
+
+        it "does not configure the git proxy and returns nil" do
+          is_expected.to eq nil
+        end
+      end
+
+    end
+
+    context "when configuration is disabled" do
+    end
+  end
+
+  describe "#unconfigure_machine" do
+    context "when not supported" do
+      let(:app) { OpenStruct.new }
+      let(:env) { OpenStruct.new }
+      let(:machine) { double('machine') }
+
+      subject do
+        git_proxy = described_class.new(app, env)
+        git_proxy.instance_variable_set(:@machine, machine)
+
+        allow(machine).to receive_message_chain(:guest, :capability?).with(:git_proxy_conf).and_return(false)
+        allow(machine).to receive_message_chain(:guest, :capability).with(:git_proxy_conf).and_return(nil)
+
+        git_proxy.send(:unconfigure_machine)
+      end
+
+      it 'returns nil' do
+          is_expected.to eq nil
+      end
+    end
+
+    context "when supported and configuration is disabled" do
+      let(:app) { OpenStruct.new }
+      let(:env) { OpenStruct.new }
+      let(:machine) { double('machine') }
+
+      subject do
+        git_proxy = described_class.new(app, env)
+        git_proxy.instance_variable_set(:@machine, machine)
+
+        config = create_config_proxy(
+          :enabled  => false,
+          :http     => 'http://proxy-server-01.example.com:8080',
+          :https    => 'https://proxy-server-01.example.com:8080',
+          :no_proxy => 'localhost',
+        )
+
+        allow(machine).to receive_message_chain(:config, :proxy).and_return(config)
+        allow(machine).to receive_message_chain(:config, :public_send).with(:git_proxy).and_return(config)
+
+        allow(machine).to receive_message_chain(:guest, :capability?).with(:git_proxy_conf).and_return(true)
+        allow(machine).to receive_message_chain(:guest, :capability).with(:git_proxy_conf).and_return("/usr/bin/git")
+
+        allow(machine).to receive_message_chain(:communicate, :sudo).with("/usr/bin/git config --system --unset-all http.proxy", error_check: false)
+        allow(machine).to receive_message_chain(:communicate, :sudo).with("/usr/bin/git config --system --unset-all https.proxy", error_check: false)
+
+        git_proxy.send(:unconfigure_machine)
+      end
+
+      it 'configures git proxy and returns true' do
+        is_expected.to eq true
+      end
+    end
+  end
 end

data/spec/unit/vagrant-proxyconf/action/configure_npm_proxy_spec.rb

@@ -7,4 +7,71 @@ describe VagrantPlugins::ProxyConf::Action::ConfigureNpmProxy do
     subject { described_class.new(double, double).config_name }
     it      { is_expected.to eq 'npm_proxy' }
   end
+
+  describe '#set_or_delete_proxy' do
+    let(:app) { OpenStruct.new }
+    let(:env) { OpenStruct.new }
+    let(:machine) { double('machine') }
+
+    context "when not supported" do
+      subject do
+        npm_proxy = described_class.new(app, env)
+        npm_proxy.instance_variable_set(:@machine, machine)
+
+        allow(machine).to receive_message_chain(:guest, :capability?).with(:npm_proxy_conf).and_return(false)
+        allow(machine).to receive_message_chain(:guest, :capability).with(:npm_proxy_conf).and_return(nil)
+
+        npm_proxy.send(:set_or_delete_proxy, @key, @value)
+      end
+
+      it 'return nil' do
+        @key = "proxy"
+        @value = "http://proxy-server-01.example.com:8888"
+        is_expected.to eq nil
+      end
+    end
+
+    context 'when supported' do
+      context 'and has value argument' do
+        subject do
+          npm_proxy = described_class.new(app, env)
+          npm_proxy.instance_variable_set(:@machine, machine)
+
+          allow(machine).to receive_message_chain(:guest, :capability?).with(:npm_proxy_conf).and_return(true)
+          allow(machine).to receive_message_chain(:guest, :capability).with(:npm_proxy_conf).and_return("/usr/bin/npm")
+
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("/usr/bin/npm config --global set #{@key} #{@value}")
+
+          npm_proxy.send(:set_or_delete_proxy, @key, @value)
+        end
+
+        it 'should set npm config item' do
+          @key = "proxy"
+          @value = "http://proxyserver:8080"
+          is_expected.to eq true
+        end
+      end
+
+      context 'and does not have value argument' do
+        subject do
+          npm_proxy = described_class.new(app, env)
+          npm_proxy.instance_variable_set(:@machine, machine)
+
+          allow(machine).to receive_message_chain(:guest, :capability?).with(:npm_proxy_conf).and_return(true)
+          allow(machine).to receive_message_chain(:guest, :capability).with(:npm_proxy_conf).and_return("/usr/bin/npm")
+
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("/usr/bin/npm config --global set #{@key} foo")
+          allow(machine).to receive_message_chain(:communicate, :sudo).with("/usr/bin/npm config --global delete #{@key}")
+
+          npm_proxy.send(:set_or_delete_proxy, @key, @value)
+        end
+
+        it 'should delete npm config item' do
+          @key = "proxy"
+          @value = nil
+          is_expected.to eq true
+        end
+      end
+    end
+  end
 end

data/spec/unit/vagrant-proxyconf/action/configure_pear_proxy_spec.rb

@@ -7,4 +7,120 @@ describe VagrantPlugins::ProxyConf::Action::ConfigurePearProxy do
     subject { described_class.new(double, double).config_name }
     it      { is_expected.to eq 'pear_proxy' }
   end
+
+  describe "#configure_machine" do
+    let(:app) { OpenStruct.new }
+    let(:env) { OpenStruct.new }
+    let(:machine) { double('machine') }
+
+    context "when not supported" do
+      subject do
+        pear_proxy = described_class.new(app, env)
+        pear_proxy.instance_variable_set(:@machine, machine)
+
+        allow(machine).to receive_message_chain(:guest, :capability?).with(:pear_proxy_conf).and_return(false)
+        allow(machine).to receive_message_chain(:guest, :capability).with(:pear_proxy_conf).and_return(nil)
+
+        pear_proxy.send(:configure_machine)
+      end
+
+      it 'returns nil' do
+        is_expected.to eq nil
+      end
+    end
+
+    context "when supported" do
+      subject do
+        pear_proxy = described_class.new(app, env)
+        pear_proxy.instance_variable_set(:@machine, machine)
+
+        allow(machine).to receive_message_chain(:guest, :capability?).with(:pear_proxy_conf).and_return(true)
+        allow(machine).to receive_message_chain(:guest, :capability).with(:pear_proxy_conf).and_return('/usr/bin/pear')
+
+        allow(machine).to receive_message_chain(:config, :proxy).and_return(@config)
+        allow(machine).to receive_message_chain(:config, :public_send).with(:pear_proxy).and_return(@config)
+
+        allow(machine).to receive_message_chain(:communicate, :sudo).with("/usr/bin/pear config-set http_proxy #{@http_proxy} system")
+
+        pear_proxy.send(:configure_machine)
+      end
+
+      it 'and not disabled, sets http proxy to http://proxy:8080' do
+        @config = create_config_proxy(
+           :enabled  => true,
+           :http     => 'http://proxy:8080',
+           :https    => 'https://proxy:8080',
+           :no_proxy => 'localhost',
+        )
+        @http_proxy = "http://proxy:8080"
+
+        is_expected.to eq true
+      end
+
+      it 'and disabled, disables the proxy' do
+        @config = create_config_proxy(
+           :enabled  => false,
+           :http     => 'http://proxy:8080',
+           :https    => 'https://proxy:8080',
+           :no_proxy => 'localhost',
+        )
+        @http_proxy = "''"
+
+        is_expected.to eq true
+      end
+    end
+  end
+
+  describe "#unconfigure_machine" do
+    let(:app) { OpenStruct.new }
+    let(:env) { OpenStruct.new }
+    let(:machine) { double('machine') }
+
+    context "when not supported" do
+      subject do
+        pear_proxy = described_class.new(app, env)
+        pear_proxy.instance_variable_set(:@machine, machine)
+
+        allow(machine).to receive_message_chain(:guest, :capability?).with(:pear_proxy_conf).and_return(false)
+        allow(machine).to receive_message_chain(:guest, :capability).with(:pear_proxy_conf).and_return(nil)
+
+        pear_proxy.send(:unconfigure_machine)
+      end
+
+      it 'returns nil' do
+        is_expected.to eq nil
+      end
+    end
+
+    context "when supported" do
+      subject do
+        pear_proxy = described_class.new(app, env)
+        pear_proxy.instance_variable_set(:@machine, machine)
+
+        allow(machine).to receive_message_chain(:guest, :capability?).with(:pear_proxy_conf).and_return(true)
+        allow(machine).to receive_message_chain(:guest, :capability).with(:pear_proxy_conf).and_return('/usr/bin/pear')
+
+        allow(machine).to receive_message_chain(:config, :proxy).and_return(@config)
+        allow(machine).to receive_message_chain(:config, :public_send).with(:pear_proxy).and_return(@config)
+
+        allow(machine).to receive_message_chain(:communicate, :sudo).with("/usr/bin/pear config-set http_proxy #{@http_proxy} system")
+
+        pear_proxy.send(:unconfigure_machine)
+      end
+
+      it 'disables http proxy' do
+        @config = create_config_proxy(
+           :enabled  => false,
+           :http     => nil,
+           :https    => nil,
+           :no_proxy => nil,
+        )
+        @http_proxy = "''"
+
+        is_expected.to eq true
+      end
+    end
+  end
+
+
 end