vagrant-proxmox 0.0.2

data/spec/actions/sync_folders_action_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+require 'actions/proxmox_action_shared'
+
+module VagrantPlugins::Proxmox
+
+	describe Action::SyncFolders do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox), ui: double('ui').as_null_object} }
+
+		subject { described_class.new(-> (_) {}, environment) }
+
+		describe '#call' do
+
+			before do
+				env[:machine].stub(:ssh_info) { {host: '127.0.0.1', port: 22, username: 'vagrant', private_key_path: 'key'} }
+				env[:machine].communicate.stub :sudo
+				Vagrant::Util::Subprocess.stub(:execute).and_return Vagrant::Util::Subprocess::Result.new 0, nil, nil
+			end
+
+			it_behaves_like 'a proxmox action call'
+
+			it 'should print a message to the user interface' do
+				expect(env[:ui]).to receive(:info).with("Rsyncing folder: #{Dir.pwd}/ => /vagrant")
+				subject.call env
+			end
+
+			it 'should create a directory on the vm with the predefined ownership' do
+				expect(env[:machine].communicate).to receive(:sudo).with("mkdir -p '/vagrant'")
+				expect(env[:machine].communicate).to receive(:sudo).with("chown vagrant '/vagrant'")
+				subject.call env
+			end
+
+			it 'should rsync the directory with the vm' do
+				expect(Vagrant::Util::Subprocess).to receive(:execute).with(
+																								 'rsync', '--verbose', '--archive', '--compress', '--delete',
+																								 '-e', "ssh -p 22 -i 'key' -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null",
+																								 "#{Dir.pwd}/", 'vagrant@127.0.0.1:/vagrant')
+				subject.call env
+			end
+
+			it 'should raise an error if the rsync fails' do
+				allow(Vagrant::Util::Subprocess).to receive(:execute).and_return(Vagrant::Util::Subprocess::Result.new 1, nil, nil)
+				expect { subject.call(env) }.to raise_error Errors::RsyncError
+			end
+
+		end
+
+	end
+
+end

data/spec/commands/destroy_command_spec.rb

@@ -0,0 +1,68 @@
+require 'spec_helper'
+
+module VagrantPlugins::Proxmox
+
+	describe 'Vagrant Proxmox provider destroy command', :need_box do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox)} }
+		let(:ui) { double('ui').as_null_object }
+
+		context 'the vm is not created on the proxmox server' do
+			it 'should call the appropriate actions to print a ui message that the vm is not created' do
+				Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+				Action::IsCreated.should be_called { |env| env[:result] = false }
+				Action::MessageNotCreated.should be_called
+				Action::DestroyVm.should be_ommited
+				execute_vagrant_command environment, :destroy
+			end
+		end
+
+		context 'the vm exists on the proxmox server' do
+
+			context 'the destroy command is not confirmed' do
+				it 'should call the appropriate actions to print a ui message that the vm will not be destroyed' do
+					Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+					Action::IsCreated.should be_called { |env| env[:result] = true }
+					::Vagrant::Action::Builtin::DestroyConfirm.should be_called { |env| env[:result] = false }
+					::VagrantPlugins::ProviderVirtualBox::Action::MessageWillNotDestroy.should be_called
+					Action::DestroyVm.should be_ommited
+					execute_vagrant_command environment, :destroy
+				end
+			end
+
+			context 'the destroy command is confirmed' do
+				context 'the vm is running' do
+					it 'should call the appropriate actions to destroy the vm' do
+						Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+						Action::IsCreated.should be_called { |env| env[:result] = true }
+						::Vagrant::Action::Builtin::DestroyConfirm.should be_called { |env| env[:result] = true }
+						Action::IsStopped.should be_called { |env| env[:result] = false }
+						Action::ShutdownVm.should be_called
+						Action::DestroyVm.should be_called
+						::Vagrant::Action::Builtin::ProvisionerCleanup.should be_called
+						Action::CleanupAfterDestroy.should be_called
+						execute_vagrant_command environment, :destroy
+					end
+				end
+
+				context 'the vm is stopped' do
+					it 'should call the appropriate actions to destroy the vm' do
+						Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+						Action::IsCreated.should be_called { |env| env[:result] = true }
+						Action::DestroyConfirm.should be_called { |env| env[:result] = true }
+						Action::IsStopped.should be_called { |env| env[:result] = true }
+						Action::DestroyVm.should be_called
+						::Vagrant::Action::Builtin::ProvisionerCleanup.should be_called
+						Action::CleanupAfterDestroy.should be_called
+						Action::ShutdownVm.should be_ommited
+						execute_vagrant_command environment, :destroy
+					end
+				end
+			end
+
+		end
+
+	end
+
+end

data/spec/commands/halt_command_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+module VagrantPlugins::Proxmox
+
+	describe 'Vagrant Proxmox provider halt command', :need_box do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:ui) { double('ui').as_null_object }
+
+		context 'the vm is not created on the proxmox server' do
+			it 'should call the appropriate actions and print a ui message that the vm is not created' do
+				Action::ConfigValidate.should be_called
+				Action::IsCreated.should be_called { |env| env[:result] = false }
+				Action::MessageNotCreated.should be_called
+				Action::ConnectProxmox.should be_ommited
+				Action::ShutdownVm.should be_ommited
+				execute_vagrant_command environment, :halt
+			end
+		end
+
+		context 'the vm is stopped' do
+			it 'should call the appropriate actions to shut down the vm' do
+				Action::ConfigValidate.should be_called
+				Action::IsCreated.should be_called { |env| env[:result] = true }
+				Action::IsStopped.should be_called { |env| env[:result] = true }
+				Action::MessageAlreadyStopped.should be_called
+				Action::ConnectProxmox.should be_ommited
+				Action::ShutdownVm.should be_ommited
+				execute_vagrant_command environment, :halt
+			end
+		end
+
+		context 'the vm is running' do
+			it 'should call the appropriate actions to shut down the vm' do
+				Action::ConfigValidate.should be_called
+				Action::IsCreated.should be_called { |env| env[:result] = true }
+				Action::IsStopped.should be_called { |env| env[:result] = false }
+				Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+				Action::ShutdownVm.should be_called
+				execute_vagrant_command environment, :halt
+			end
+		end
+
+	end
+
+end

data/spec/commands/provision_command_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+module VagrantPlugins::Proxmox
+
+	describe 'Vagrant Proxmox provider provision command', :need_box do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:ui) { double('ui').as_null_object }
+
+		context 'the vm is not created on the proxmox server' do
+			it 'should call the appropriate actions and print a ui message that the vm is not created' do
+				Action::ConfigValidate.should be_called
+				Action::IsCreated.should be_called { |env| env[:result] = false }
+				Action::MessageNotCreated.should be_called
+				Action::Provision.should be_ommited
+				Action::SyncFolders.should be_ommited
+				execute_vagrant_command environment, :provision
+			end
+		end
+
+		context 'the vm exists on the proxmox server' do
+			it 'should call the appropriate actions and provision the vm' do
+				Action::ConfigValidate.should be_called
+				Action::IsCreated.should be_called { |env| env[:result] = true }
+				Action::Provision.should be_called
+				Action::SyncFolders.should be_called
+				execute_vagrant_command environment, :provision
+			end
+		end
+
+	end
+
+end

data/spec/commands/ssh_command_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+module VagrantPlugins::Proxmox
+
+	describe 'Vagrant Proxmox provider ssh command', :need_box do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:ui) { double('ui').as_null_object }
+
+		context 'the vm is not created on the proxmox server' do
+			it 'should call the appropriate actions and print a ui message that the vm is not created' do
+				Action::IsCreated.should be_called { |env| env[:result] = false }
+				Action::MessageNotCreated.should be_called
+				Action::SSHExec.should be_ommited
+				execute_vagrant_command environment, :ssh
+			end
+		end
+
+		context 'the vm exists on the proxmox server' do
+
+			it 'should call the appropriate actions to open a ssh connection' do
+				Action::IsCreated.should be_called { |env| env[:result] = true }
+				Action::SSHExec.should be_called
+				execute_vagrant_command environment, :ssh
+			end
+
+		end
+
+	end
+
+end

data/spec/commands/ssh_run_command_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+module VagrantPlugins::Proxmox
+
+	describe 'Vagrant Proxmox provider ssh exec command', :need_box do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:env) { {machine: environment.machine(environment.primary_machine_name, :proxmox), ui: double('ui').as_null_object} }
+		let(:ui) { double('ui').as_null_object }
+
+		context 'the vm is not created on the proxmox server' do
+			it 'should call the appropriate actions and print a ui message that the vm is not created' do
+				Action::IsCreated.should be_called { |env| env[:result] = false }
+				Action::MessageNotCreated.should be_called
+				Action::SSHRun.should be_ommited
+				execute_vagrant_command environment, :ssh, '--command', 'foo'
+			end
+		end
+
+		context 'the vm exists on the proxmox server' do
+			before { env[:machine].stub(:ssh_info) { {host: '127.0.0.1', port: 22, username: 'vagrant', private_key_path: 'key'} } }
+
+			it 'should call the appropriate actions to execute a command via ssh on the vm' do
+				Action::IsCreated.should be_called { |env| env[:result] = true }
+				Action::SSHRun.should be_called
+				execute_vagrant_command environment, :ssh, '--command', 'foo'
+			end
+		end
+
+	end
+
+end

data/spec/commands/status_command_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+module VagrantPlugins::Proxmox
+
+	describe 'Vagrant Proxmox provider status command', :need_box do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:ui) { double('ui').as_null_object }
+
+		specify do
+			Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+			Action::ReadState.should be_called { |env| env[:machine_state_id] = :stopped }
+			expect(ui).to receive(:info).with /stopped \(proxmox\)/, anything
+			execute_vagrant_command environment, :status
+		end
+
+	end
+
+end

data/spec/commands/up_command_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+module VagrantPlugins::Proxmox
+
+	describe 'Vagrant Proxmox provider up command' do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:ui) { double('ui').as_null_object }
+
+		before do
+			Vagrant::UI::Interface.stub(:new).and_return ui
+		end
+
+		context 'the vm is not yet created' do
+			it 'should call the appropriate actions and print a ui message that the vm will be created' do
+				Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+				Action::GetNodeList.should be_called { |env| env[:proxmox_nodes] = [{node: 'localhost'}] }
+				Action::IsCreated.should be_called { |env| env[:result] = false }
+				Action::CreateVm.should be_called { |env| env[:machine].id = 'localhost/100' }
+				Action::Provision.should be_called
+				Action::StartVm.should be_called
+				Action::SyncFolders.should be_called
+				execute_vagrant_command environment, :up, '--provider=proxmox'
+			end
+		end
+
+		context 'the vm is stopped' do
+			it 'should call the appropriate actions and print a ui message that the vm will be started' do
+				Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+				Action::IsCreated.should be_called { |env| env[:result] = true }
+				Action::IsStopped.should be_called { |env| env[:result] = true }
+				Action::Provision.should be_called
+				Action::StartVm.should be_called
+				Action::SyncFolders.should be_called
+				Action::CreateVm.should be_ommited
+				execute_vagrant_command environment, :up, '--provider=proxmox'
+			end
+		end
+
+		context 'the vm is already running' do
+			it 'should call the appropriate actions and print a ui message that the vm is already running' do
+				Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+				Action::IsCreated.should be_called { |env| env[:result] = true }
+				Action::IsStopped.should be_called { |env| env[:result] = false }
+				Action::MessageAlreadyRunning.should be_called
+				Action::Provision.should be_ommited
+				Action::CreateVm.should be_ommited
+				Action::StartVm.should be_ommited
+				execute_vagrant_command environment, :up, '--provider=proxmox'
+			end
+		end
+
+	end
+
+end

data/spec/config_spec.rb

@@ -0,0 +1,71 @@
+require 'spec_helper'
+require 'vagrant-proxmox/config'
+
+describe VagrantPlugins::Proxmox::Config do
+
+	describe 'defaults' do
+		subject { super().tap { |o| o.finalize! } }
+
+		its(:endpoint) { should be_nil }
+		its(:user_name) { should be_nil }
+		its(:password) { should be_nil }
+		its(:os_template) { should be_nil }
+		its(:vm_id_range) { should == (900..999) }
+		its(:vm_name_prefix) { should == 'vagrant_' }
+		its(:vm_memory) { should == 512 }
+		its(:task_timeout) { should == 60 }
+		its(:task_status_check_interval) { should == 2 }
+	end
+
+	describe 'overwriting defaults using a Vagrantfile' do
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:config) { environment.machine(environment.primary_machine_name, :proxmox).config.vm.get_provider_config :proxmox }
+
+		subject { config }
+
+		its(:endpoint) { should == 'https://your.proxmox.server/api2/json' }
+		its(:user_name) { should == 'vagrant' }
+		its(:password) { should == 'password' }
+		its(:os_template) { should == 'local:vztmpl/template.tgz' }
+		its(:vm_id_range) { should == (900..910) }
+		its(:vm_name_prefix) { should == 'vagrant_test_' }
+		its(:vm_memory) { should == 256 }
+		its(:task_timeout) { should == 30 }
+		its(:task_status_check_interval) { should == 1 }
+	end
+
+	describe 'Configuration validation' do
+		let(:machine) { double 'machine' }
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:config) { environment.machine(environment.primary_machine_name, :proxmox).config.vm.get_provider_config :proxmox }
+
+		subject { config }
+
+		describe 'with a valid configuration' do
+			it 'should validate without any error' do
+				subject.validate(machine).should == {'Proxmox Provider' => []}
+			end
+		end
+
+		describe 'with a missing endpoint' do
+			before { subject.endpoint = nil }
+			specify { subject.validate(machine).should == {'Proxmox Provider' => ['No endpoint specified.']} }
+		end
+
+		describe 'with a missing user_name' do
+			before { subject.user_name = nil }
+			specify { subject.validate(machine).should == {'Proxmox Provider' => ['No user_name specified.']} }
+		end
+
+		describe 'with a missing password' do
+			before { subject.password = nil }
+			specify { subject.validate(machine).should == {'Proxmox Provider' => ['No password specified.']} }
+		end
+
+		describe 'with a missing os_template' do
+			before { subject.os_template = nil }
+			specify { subject.validate(machine).should == {'Proxmox Provider' => ['No os_template specified.']} }
+		end
+	end
+
+end

data/spec/plugin_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe 'Vagrant Proxmox plugin' do
+
+	specify { Vagrant.should have_plugin 'Proxmox' }
+
+	describe 'contains a fix for RestClient header unescaping bug' do
+		let(:request) { RestClient::Request.new method: :get, url: 'url', cookies: { key: '+%20%21' }}
+		it 'should not unescape the cookies' do
+			request.make_headers({})['Cookie'].should == 'key=+%20%21'
+		end
+	end
+
+	describe 'when vagrant log level is set in ENV[VAGRANT_LOG]' do
+		before { ENV['VAGRANT_LOG'] = 'DEBUG' }
+		it 'should create a new vagrant proxmox logger ' do
+			expect(Log4r::Logger).to receive(:new).with('vagrant_proxmox').and_call_original
+			VagrantPlugins::Proxmox::Plugin.setup_logging
+		end
+	end
+
+end

data/spec/provider_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+require 'vagrant-proxmox/provider'
+
+module VagrantPlugins::Proxmox
+
+	describe Provider do
+
+		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+		let(:machine) { environment.machine(environment.primary_machine_name, :proxmox) }
+		let(:ui) { double('ui').as_null_object }
+
+		subject { described_class.new(machine) }
+
+		describe '#ssh_info', :need_box do
+			it 'should call the appropriate actions and return the ssh info' do
+				Action::ConfigValidate.should be_called
+				Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+				Action::ReadSSHInfo.should be_called { |env| env[:machine_ssh_info] = 'ssh_info'}
+				subject.ssh_info.should == 'ssh_info'
+			end
+		end
+
+	end
+
+end

data/spec/sanity_checks_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe 'Vagrant Proxmox sanity checks' do
+
+	describe 'when loaded without vagrant installed' do
+		before { Object.any_instance.stub(:require) { raise LoadError } }
+		it 'should raise an error' do
+			expect { load 'sanity_checks.rb' }.to raise_error
+		end
+	end
+
+	describe 'when used with an outdated vagrant version' do
+		before { stub_const 'Vagrant::VERSION', '1.0.7' }
+		it 'should raise an error' do
+			expect { load 'sanity_checks.rb' }.to raise_error
+		end
+	end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,128 @@
+if ENV['RUN_WITH_COVERAGE']
+	require 'simplecov'
+	require 'simplecov-rcov'
+	SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+			SimpleCov::Formatter::HTMLFormatter,
+			SimpleCov::Formatter::RcovFormatter,
+	]
+	SimpleCov.start do
+		add_filter '/dummy_box/Vagrantfile'
+		add_filter '/spec/'
+		add_filter '/lib/sanity_checks.rb'
+	end
+end
+
+require 'vagrant-proxmox'
+require 'active_support/core_ext/string'
+
+RSpec.configure do |config|
+	config.treat_symbols_as_metadata_keys_with_true_values = true
+
+	config.before(:suite) do
+		begin
+			Vagrant::Environment.new.boxes.add 'dummy_box/dummy.box', 'dummy', :proxmox
+		rescue Vagrant::Errors::BoxAlreadyExists
+
+		end
+		FileUtils.rm_r '.vagrant', force: true
+	end
+	config.after(:suite) do
+		execute_vagrant_command Vagrant::Environment.new, :box, 'remove', 'dummy'
+	end
+	config.after(:each) do
+		FileUtils.rm_r '.vagrant', force: true
+	end
+
+	config.before(:each, :need_box) do
+		up_local_box
+	end
+end
+
+
+def execute_vagrant_command environment, command, *params
+	Vagrant.plugin('2').manager.commands[command].new(params, environment).execute
+end
+
+# If you want expectations on the action_class use something like:
+#
+#		let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+#
+#   mock_action(VagrantPlugins::Proxmox::Action::ConnectProxmox).tap do |action|
+# 	  action.should receive(:perform) {|env| env[:proxmox_ticket] = 'ticket' }
+#   end
+#
+def mock_action action_class, env = RSpec::Mocks::Mock.new('env').as_null_object
+	action_class.new(nil, env).tap do |action_instance|
+		action_instance_name = "@#{action_class.name.demodulize}Action".underscore
+		self.instance_variable_set action_instance_name, action_instance
+
+		action_class.stub(:new) do |app, _|
+			action_instance.instance_variable_set '@app', app
+			action_instance
+		end
+	end
+end
+
+# If you want to stub your actions (stub their call methods), use something like this:
+#
+#   let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+#
+#   stub_action(Action::ConnectProxmox) { |env| env[:proxmox_ticket] = 'ticket' }
+#
+def stub_action action_class
+	mock_action(action_class).tap do |action|
+		action.stub(:call) do |env|
+			yield env if block_given?
+			action.instance_variable_get(:@app).call env
+		end
+	end
+end
+
+# If you want to expect your actions to be called (and optionally stub their call methods),
+# use something like this:
+#
+#   let(:environment) { Vagrant::Environment.new vagrantfile_name: 'dummy_box/Vagrantfile' }
+#
+#   Action::ConnectProxmox.should be_called { |env| env[:proxmox_ticket] = 'ticket' }
+#
+class ActionCallMatcher < RSpec::Matchers::BuiltIn::BaseMatcher
+	def initialize action_stub, environment, example_group, kind=:called
+		super action_stub
+		@environment = environment
+		@example_group = example_group
+		@kind = kind
+	end
+
+	def match(action_stub, action_class)
+		mock_action(action_class).tap do |action|
+			case @kind
+				when :called
+					@example_group.expect(action).to @example_group.receive(:call).at_least(:once) do |env|
+						action_stub.call(env) if action_stub
+						action.instance_variable_get(:@app).call env
+					end
+				when :ommited
+					action.should_not_receive :call
+			end
+		end
+	end
+end
+
+def be_called &action_stub
+	ActionCallMatcher.new action_stub, environment, self, :called
+end
+
+def be_ommited &action_stub
+	ActionCallMatcher.new action_stub, environment, self, :ommited
+end
+
+def up_local_box
+	Vagrant::UI::Interface.stub(:new).and_return ui
+	stub_action(VagrantPlugins::Proxmox::Action::ConnectProxmox)
+	stub_action(VagrantPlugins::Proxmox::Action::GetNodeList) { |env| env[:proxmox_nodes] = [{node: 'localhost'}] }
+	stub_action(VagrantPlugins::Proxmox::Action::IsCreated) { |env| env[:result] = false }
+	stub_action(VagrantPlugins::Proxmox::Action::CreateVm) { |env| env[:machine].id = 'localhost/100' }
+	stub_action(VagrantPlugins::Proxmox::Action::StartVm)
+	stub_action(VagrantPlugins::Proxmox::Action::SyncFolders)
+	execute_vagrant_command environment, :up, '--provider=proxmox'
+end