vagrant-ovirt4 2.0.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 48a3502fc6d918fe1418248df8be2ca6ba8d2e0f477eb79784c0dbfd6a12c2e2
-  data.tar.gz: f33988dd5f134f0f6336e62ab21e4a4de534a434eb721e754301e6319e9043be
+  metadata.gz: a9d8f5174e1f8b016b4b832ec0ad9b90306bfb2bddde338213d29c697010b43d
+  data.tar.gz: '0637690ae57219b53d018430ab5573495a086ec7ed1ceb2d90d6f2f6f670c629'
 SHA512:
-  metadata.gz: a84a0d2994268c8fa8df3715fbc5d3c5b40c1505cfdbb750e94539561498cc2d803ca532478bf24d9fc45d1a220bee0bcd1fd00b977f9bf221f841deed5860ec
-  data.tar.gz: 2533a97a3cfe3435cad9c3d9dc9199380874736f9221991e8b3072504a07dc7a590aceaf616450f4ddb7d0f52b169f57ef7855e3e3f7a75df1ea81e5ff638600
+  metadata.gz: 90e8331a727b24e155d29dcf1d3f8567903f5b7eef088d64dd4b7da363ee32e68bae8ee2ff32e80e002cfa57745d1047b0c3b521b08322bab74457f5095f251d
+  data.tar.gz: c5b3b0a0c3d05a34ad1f89c716314b50ec39c0157c40f93d3a74cc0b531f37d76c16468b7ed20386751da2683eda9bdcbcc45999e5eaac724e9ea44209c53f8b

data/CHANGELOG

@@ -0,0 +1,54 @@
+v2.2.0
+ef555e3 Config spec: assert that we test all attributes
+6e47c1b Add tests for additional configuration params
+
+v2.1.2
+79a0074 Fix lock file
+
+v2.1.1
+605663e Bump nokogiri from 1.13.3 to 1.13.4
+2981f5c Default to disabling run-once mode
+f048313 Enable oVirt conn debugging when VAGRANT_LOG=info
+3555e36 Add safe connection closing methods
+cdb765c Support :timeout and :timeout_connect options
+tomeon/test-all-vmtype-andvmaffinity-values
+2a9a653 Rakefile: add RSpec task
+7641780 test all valid VmType and VmAffinity values
+54efcde Add tests for vmname and hostname settings
+dc3ab3e Add "vmname" provider option
+233e4bb read_ssh_info: return nil on IPv4 lookup failure
+fcff147 Bump nokogiri from 1.12.5 to 1.13.3
+da44f24 Bump nokogiri from 1.11.4 to 1.12.5
+9025f4e Bump nokogiri from 1.11.3 to 1.11.4
+
+v2.1.0
+41b8c63 Move where rspec-mocks is included.
+0015c45 Update engine binding.
+b2a0015 Not actually using the vagrant-spec thing.
+a598043 Address the change in parsing.
+0ad3b72 Get the tests runnable.
+a8f1d5f Test the connection before passing it on for use.
+8adf277 list only snapshots for vm's defined in the environment
+a2ee89b Add security.md
+3399aab Add CHANGELOG
+
+v2.0.0
+
+1810832 Attempt to fix gem push
+9d1ef6b handle fallback with rescue
+6cc0f90 fix for backwards compatibility with ovirt 4.3
+2298314 Make no assumptions on biosdevname/systemd device naming
+1d870df Support for network interfaces named by biosdevname
+5c8035a add missing translation
+f9b6e28 fixed double disconnect due to action_up used in combination wth with_ovirt
+96f17c0 fixed doule disconnect on reload due to use of with_ovirt
+697e3d4 fixed inconsistent usages of memory units (MB/MiB and GB/GiB)
+5a68e8b vagrant destroy only calls halt if vm is up
+8772ee9 fix for erroneous rsync and state error due to missing ip address
+5b49114 Bump nokogiri from 1.10.9 to 1.11.0
+b8314fb fix for waiting indefinitely for an ip when deploying on ovirt 4.4
+722f2e0 Default to rsync instead of NFS like before
+2582f53 Use vagrant builtin rsync folder sync
+84c6c53 In case graceful shutdown failed, fallback to stopping VM immediately
+640d640 Fix up dependencies
+029b53b give guests a chance to shutdown gracefully before pulling the plug with a poweroff

data/Gemfile

@@ -3,10 +3,13 @@ source 'http://rubygems.org'
 group :development do
   gem 'rake'
   gem 'rspec-core'
+  gem 'rspec-its'
+  gem "rspec-mocks", "~> 3.5"
   gem 'pry'
   gem 'byebug'
   gem 'pry-byebug'
   gem 'rake-release'
+  gem "vagrant", git: "https://github.com/hashicorp/vagrant.git"
 end
 
 group :plugins do

data/Gemfile.lock

@@ -1,38 +1,150 @@
+GIT
+  remote: https://github.com/hashicorp/vagrant.git
+  revision: 22795b161bf67a4c0ebbe32c9ce8777cb888c4a7
+  specs:
+    vagrant (2.2.11.dev)
+      bcrypt_pbkdf (~> 1.0.0)
+      childprocess (~> 4.0.0)
+      ed25519 (~> 1.2.4)
+      erubi
+      hashicorp-checkpoint (~> 0.1.5)
+      i18n (~> 1.8)
+      listen (~> 3.1)
+      log4r (~> 1.1.9, < 1.1.11)
+      mime (~> 0.4.4)
+      net-scp (~> 1.2.0)
+      net-sftp (~> 3.0)
+      net-ssh (~> 6.0)
+      rb-kqueue (~> 0.2.0)
+      rest-client (>= 1.6.0, < 3.0)
+      ruby_dep (<= 1.3.1)
+      rubyzip (~> 2.0)
+      vagrant_cloud (~> 2.0.3)
+      wdm (~> 0.1.0)
+      winrm (>= 2.3.4, < 3.0)
+      winrm-elevated (>= 1.2.1, < 2.0)
+      winrm-fs (>= 1.3.4, < 2.0)
+
 PATH
   remote: .
   specs:
-    vagrant-ovirt4 (2.0.0)
+    vagrant-ovirt4 (2.2.0)
       filesize (~> 0)
-      nokogiri (>= 1.10.8)
-      ovirt-engine-sdk (~> 4.0.1)
+      nokogiri (~> 1)
+      ovirt-engine-sdk (~> 4)
 
 GEM
   remote: http://rubygems.org/
   specs:
+    bcrypt_pbkdf (1.0.1)
+    builder (3.2.4)
     byebug (11.1.3)
-    coderay (1.1.2)
+    childprocess (4.0.0)
+    coderay (1.1.3)
+    concurrent-ruby (1.1.10)
+    diff-lcs (1.5.0)
+    domain_name (0.5.20190701)
+      unf (>= 0.0.5, < 1.0.0)
+    ed25519 (1.2.4)
+    erubi (1.10.0)
+    ffi (1.15.5)
     filesize (0.2.0)
-    json (2.5.1)
+    gssapi (1.3.1)
+      ffi (>= 1.0.1)
+    gyoku (1.4.0)
+      builder (>= 2.1.2)
+      rexml (~> 3.0)
+    hashicorp-checkpoint (0.1.5)
+    http-cookie (1.0.4)
+      domain_name (~> 0.5)
+    httpclient (2.8.3)
+    i18n (1.10.0)
+      concurrent-ruby (~> 1.0)
+    json (2.6.1)
+    listen (3.7.1)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    little-plugger (1.1.4)
+    log4r (1.1.10)
+    logging (2.3.0)
+      little-plugger (~> 1.1)
+      multi_json (~> 1.14)
     method_source (1.0.0)
-    mini_portile2 (2.5.0)
-    nokogiri (1.11.1)
-      mini_portile2 (~> 2.5.0)
+    mime (0.4.4)
+    mime-types (3.4.1)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2022.0105)
+    multi_json (1.15.0)
+    net-scp (1.2.1)
+      net-ssh (>= 2.6.5)
+    net-sftp (3.0.0)
+      net-ssh (>= 5.0.0, < 7.0.0)
+    net-ssh (6.1.0)
+    netrc (0.11.0)
+    nokogiri (1.13.4-x86_64-darwin)
       racc (~> 1.4)
-    ovirt-engine-sdk (4.0.12)
-      json
+    nori (2.6.0)
+    ovirt-engine-sdk (4.4.1)
+      json (>= 1, < 3)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     pry-byebug (3.9.0)
       byebug (~> 11.0)
       pry (~> 0.13.0)
-    racc (1.5.2)
-    rake (13.0.3)
-    rake-release (1.2.1)
+    racc (1.6.0)
+    rake (13.0.6)
+    rake-release (1.3.0)
       bundler (>= 1.11, < 3)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.1)
+    rb-fsevent (0.11.1)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rb-kqueue (0.2.8)
+      ffi (>= 0.5.0)
+    rest-client (2.0.2)
+      http-cookie (>= 1.0.2, < 2.0)
+      mime-types (>= 1.16, < 4.0)
+      netrc (~> 0.8)
+    rexml (3.2.5)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-its (1.3.0)
+      rspec-core (>= 3.0.0)
+      rspec-expectations (>= 3.0.0)
+    rspec-mocks (3.11.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.0)
+    ruby_dep (1.3.1)
+    rubyntlm (0.6.3)
+    rubyzip (2.3.2)
+    unf (0.1.4)
+      unf_ext
+    unf_ext (0.0.8.1)
+    vagrant_cloud (2.0.3)
+      rest-client (~> 2.0.2)
+    wdm (0.1.1)
+    winrm (2.3.6)
+      builder (>= 2.1.2)
+      erubi (~> 1.8)
+      gssapi (~> 1.2)
+      gyoku (~> 1.0)
+      httpclient (~> 2.2, >= 2.2.0.2)
+      logging (>= 1.6.1, < 3.0)
+      nori (~> 2.0)
+      rubyntlm (~> 0.6.0, >= 0.6.3)
+    winrm-elevated (1.2.3)
+      erubi (~> 1.8)
+      winrm (~> 2.0)
+      winrm-fs (~> 1.0)
+    winrm-fs (1.3.5)
+      erubi (~> 1.8)
+      logging (>= 1.6.1, < 3.0)
+      rubyzip (~> 2.0)
+      winrm (~> 2.0)
 
 PLATFORMS
   ruby
@@ -44,6 +156,9 @@ DEPENDENCIES
   rake
   rake-release
   rspec-core
+  rspec-its
+  rspec-mocks (~> 3.5)
+  vagrant!
   vagrant-ovirt4!
 
 BUNDLED WITH

data/README.md

@@ -1,3 +1,5 @@
+[OvirtSDK4::Connection#initialize]: https://rubydoc.info/gems/ovirt-engine-sdk/OvirtSDK4%2FConnection:initialize
+
 # Vagrant oVirt v4 Provider
 
 This is a [Vagrant](http://www.vagrantup.com) 1.1+ plugin that adds an
@@ -76,8 +78,12 @@ Vagrant.configure("2") do |config|
     ovirt.password = "password"
     ovirt.insecure = true
     ovirt.debug = true
+    ovirt.timeout = 120 # seconds
+    ovirt.connect_timeout = 30 # seconds
     ovirt.filtered_api = true #see http://www.ovirt.org/develop/release-management/features/infra/user-portal-permissions/
     ovirt.cluster = 'Default'
+    ovirt.vmname = 'my-vm'
+    ovirt.run_once = false
     ovirt.template = 'Vagrant-Centos7-test'
     ovirt.console = 'vnc'
     ovirt.disk_size = '15 GiB' # only growing is supported. works the same way as below memory settings
@@ -105,8 +111,8 @@ end
 ### Configuration options
 
 1. Vagrant specific
-  1. `config.vm.hostname` => Sets the hostname of the VM
-    a. Is the 'name' in the Virtual Machine tab of the UI
+  1. `config.vm.hostname` => Sets the hostname of the VM. Optional. String.
+     Default is `"vagrant"`.
     a. Is the 'hostname' of the VM configured by `cloud-init`
   1. `config.vm.network` => Sets the network information of the VM.
     a. Note: `:ip` => is ignored, but `:ovirt__ip` is used and merged with `:ip`
@@ -118,7 +124,22 @@ end
   1. `username` => The username for the API. Required. String. No default value.
   1. `password` => The password for the API. Required. String. No default value.
   1. `insecure` => Allow connecting to SSL sites without certificates. Optional. Bool. Default is `false`
-  1. `debug` => Turn on additional log statements. Optional. Bool. Default is `false`.
+  1. `debug` => Turn on additional log statements. Optional. Bool. Default is
+     `true` if Vagrant's logging verbosity is set to `info` or above
+     (`VAGRANT_LOG={info,debug,...}`); otherwise, the default is `false`.
+  1. `timeout` => Per [the oVirt SDK docs][OvirtSDK4::Connection#initialize],
+     "The maximun (_sic_) total time to wait for the response, in seconds. A value of
+     zero (the default) means wait for ever." Optional. Integer. Uses the
+     `OvirtSDK4::Connection` default if omitted; as of the time of writing,
+     this is `0` (i.e. wait forever).
+  1. `connect_timeout` => Per [the oVirt SDK docs][OvirtSDK4::Connection#initialize],
+     "The maximun (_sic_) time to wait for connection establishment, in
+     seconds." Optional. Integer. Uses the `OvirtSDK4::Connection` default if
+     omitted; as of the time of writing, this is `300`.
+  1. `vmname` => Sets the name of the VM. Optional. String. Default is
+     `config.vm.hostname`, if defined, otherwise `"vagrant"`.
+    a. Is the 'name' in the Virtual Machine tab of the UI
+  1. `run_once` => Launch VM in run-once mode. Optional. Default is `false`.
   1. `template` => The name of the template to use for creation. Required. String. No Default value.
   1. `cluster` => The name of the ovirt cluster to create within. Required. String. No Default value.
   1. `console` => The type of remote viewing protocol to use. Required. String. No Default value.
@@ -145,3 +166,10 @@ end
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+Some pointers:
+
+* To install the requirements when developing:
+    * `bundle install`
+* To run the test suite:
+    * `bundle exec rspec spec/`

data/Rakefile

@@ -14,3 +14,7 @@ Dir.chdir(File.expand_path("../", __FILE__))
 # This installs the tasks that help with gem creation and
 # publishing.
 Bundler::GemHelper.install_tasks
+
+RSpec::Core::RakeTask.new
+
+task :default => [:spec]

data/SECURITY.md

@@ -0,0 +1,23 @@
+## Security
+
+If you believe you have found a security vulnerability, please report it to me as described below.
+
+## Reporting Security Issues
+
+**Please do not report security vulnerabilities through public GitHub issues.** Instead, please report them to me directly at [myoung34@my.apsu.edu](mailto:myoung34@my.apsu.edu).  
+
+If you'd like to communicate securely, my keybase is [here](https://keybase.io/3vilpenguin)
+
+Please include the requested information listed below (as much as you can provide) to help better understand the nature and scope of the possible issue:
+
+  * Type of issue (e.g. buffer overflow, SQL injection, cross-site scripting, etc.)
+  * Full paths of source file(s) related to the manifestation of the issue
+  * The location of the affected source code (tag/branch/commit or direct URL)
+  * Any special configuration required to reproduce the issue
+  * Step-by-step instructions to reproduce the issue
+  * Proof-of-concept or exploit code (if possible)
+  * Impact of the issue, including how an attacker might exploit the issue
+
+## Preferred Languages
+
+I prefer all communications to be in English.

data/lib/vagrant-ovirt4/action/connect_ovirt.rb

@@ -19,17 +19,39 @@ module VagrantPlugins
           conn_attr[:url] = "#{config.url}"
           conn_attr[:username] = config.username if config.username
           conn_attr[:password] = config.password if config.password
-          conn_attr[:debug] = config.debug if config.debug
           conn_attr[:insecure] = true if config.insecure
           conn_attr[:headers] = {'Filter' => true} if config.filtered_api
+          conn_attr[:timeout] = config.timeout unless config.timeout.nil?
+          conn_attr[:connect_timeout] = config.connect_timeout unless config.connect_timeout.nil?
 
-          @logger.info("Connecting to oVirt (#{config.url}) ...")
-          OVirtProvider.ovirt_connection = OvirtSDK4::Connection.new(conn_attr)          
-          OVirtProvider.vms_service = OVirtProvider.ovirt_connection.system_service.vms_service
-          env[:connection] = OVirtProvider.ovirt_connection
-          env[:vms_service] = OVirtProvider.vms_service
+          # Respect VAGRANT_LOG setting -- any level at least as verbose as
+          # "info" will result in logging oVirt connection debugging messages
+          # (read: libcurl verbose output).
+          conn_attr[:debug] = config.debug or @logger.info?
+
+          # Inject our own logger so that messages are namespaced under
+          # "connect_ovirt"
+          conn_attr[:log] = @logger
 
-          @app.call(env)
+          @logger.info("Connecting to oVirt (#{config.url}) ...")
+          ovirt_connection = OvirtSDK4::Connection.new(conn_attr)
+          vms_service = ovirt_connection.system_service.vms_service
+
+          # XXX: Continue setting deprecated global properties. Use of the
+          # related values from env should be preferred.
+          OVirtProvider.ovirt_connection = ovirt_connection
+          OVirtProvider.vms_service = vms_service
+
+          begin
+            ovirt_connection.test(true, 30)
+          rescue => error
+            raise Errors::ServiceConnectionError,
+              :error_message => error.message
+          else
+            env[:connection] = ovirt_connection
+            env[:vms_service] = vms_service
+            @app.call(env)
+          end
         end
 
       end

data/lib/vagrant-ovirt4/action/create_vm.rb

@@ -1,10 +1,14 @@
 require 'log4r'
+require 'vagrant-ovirt4/util/connection'
+require 'vagrant-ovirt4/util/machine_names'
 require 'vagrant/util/retryable'
 
 module VagrantPlugins
   module OVirtProvider
     module Action
       class CreateVM
+        include Util::Connection
+        include Util::MachineNames
         include Vagrant::Util::Retryable
 
         def initialize(app, env)
@@ -16,12 +20,11 @@ module VagrantPlugins
           # Get config.
           config = env[:machine].provider_config
 
-          hostname = env[:machine].config.vm.hostname
-          hostname = 'vagrant' if hostname.nil?
+          vmname = machine_vmname(env[:machine])
 
           # Output the settings we're going to use to the user
           env[:ui].info(I18n.t("vagrant_ovirt4.creating_vm"))
-          env[:ui].info(" -- Name:          #{hostname}")
+          env[:ui].info(" -- Name:          #{vmname}")
           env[:ui].info(" -- Cluster:       #{config.cluster}")
           env[:ui].info(" -- Template:      #{config.template}")
           env[:ui].info(" -- Console Type:  #{config.console}")
@@ -46,7 +49,7 @@ module VagrantPlugins
 
           # Create oVirt VM.
           attr = {
-              :name     => hostname,
+              :name     => vmname,
               :description => config.description,
               :comment => config.comment,
               :cpu      => {
@@ -127,7 +130,7 @@ module VagrantPlugins
               OvirtSDK4::DiskAttachment.new(
                 disk: {
                   name: disk[:name],
-                  description: '#{hostname} storage disk',
+                  description: "#{vmname} storage disk",
                   format: disk[:type] == 'qcow2' ? OvirtSDK4::DiskFormat::COW : OvirtSDK4::DiskFormat::RAW,
                   provisioned_size: disk[:size],
                   storage_domains: [{
@@ -192,7 +195,7 @@ module VagrantPlugins
           destroy_env[:config_validate] = false
           destroy_env[:force_confirm_destroy] = true
           env[:action_runner].run(Action.action_destroy, destroy_env)
-          env[:connection].close()
+          safe_close_connection_standard!(env)
         end
       end
     end

data/lib/vagrant-ovirt4/action/disconnect_ovirt.rb

@@ -1,10 +1,13 @@
 require 'log4r'
 require 'ovirtsdk4'
+require 'vagrant-ovirt4/util/connection'
 
 module VagrantPlugins
   module OVirtProvider
     module Action
       class DisconnectOVirt
+        include Util::Connection
+
         def initialize(app, env)
           @logger = Log4r::Logger.new("vagrant_ovirt4::action::disconnect_ovirt")
           @app = app
@@ -14,7 +17,7 @@ module VagrantPlugins
 
           # Get config options for ovirt provider.
           @logger.info("Disconnecting oVirt connection")
-          env[:connection].close()
+          safe_close_connection_standard!(env)
 
           @app.call(env)
         end

data/lib/vagrant-ovirt4/action/read_ssh_info.rb

@@ -17,31 +17,31 @@ module VagrantPlugins
           @app.call(env)
         end
 
+        # This method powers OVirtProvider::Provider#ssh_info.  It returns a
+        # hash of SSH connection information if and only if at least one IPv4
+        # address associated with the machine in question could be retrieved
+        # from the oVirt API.  Otherwise, it returns nil.
         def read_ssh_info(env)
           vms_service, machine = env[:vms_service], env[:machine]
-          return :not_created if machine.id.nil?
+          return nil if machine.id.nil?
 
           # Find the machine
           server = vms_service.vm_service(machine.id)
           begin
             if server.get.nil?
               machine.id = nil
-              return :not_created
+              return nil
             end
           rescue Exception => e
             machine.id = nil
-            return :not_created
-            raise e
+            return nil
           end
 
           nics_service = server.nics_service
           nics = nics_service.list
-          begin
-            ip_addr = nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment.reported_devices).collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first
-          rescue
-            # for backwards compatibility with ovirt 4.3
-            ip_addr = nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment).reported_devices.collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first rescue nil
-          end
+          ip_addr = first_active_ipv4_address(env, nics)
+
+          return nil if ip_addr.nil?
 
           # Return the info
           # TODO: Some info should be configurable in Vagrantfile
@@ -54,7 +54,16 @@ module VagrantPlugins
             :forward_x11      => machine.config.ssh.forward_x11,
           }
 
-        end 
+        end
+
+      private
+
+        def first_active_ipv4_address(env, nics)
+          nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment.reported_devices).collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first
+        rescue
+          # for backwards compatibility with ovirt 4.3
+          nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment).reported_devices.collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first rescue nil
+        end
       end
     end
   end

data/lib/vagrant-ovirt4/action/snapshot_list.rb

@@ -14,34 +14,30 @@ module VagrantPlugins
 
           system_service = env[:connection].system_service
 
-          # Find all the virtual machines and store the id and name in a
+          #Find all storage domains and store the id and name in a
           # hash, so that looking them up later will be faster:
-          vms_map = Hash[env[:vms_service].list.map { |vm| [vm.id, vm.name] }]
-          
-          # Same for storage domains:
           sds_service = system_service.storage_domains_service
           sds_map = Hash[sds_service.list.map { |sd| [sd.id, sd.name] }]
           
           # For each virtual machine find its snapshots, then for each snapshot
           # find its disks:
           xs = [['id', 'description', 'date']]
-          vms_map.each do |vm_id, vm_name|
-            vm_service = env[:vms_service].vm_service(vm_id)
-            snaps_service = vm_service.snapshots_service
-            snaps_map = Hash[snaps_service.list.map { |snap| [snap.id, { description: snap.description, date: snap.date }] }]
-            snaps_map.each do |snap_id, metadata|
-              snap_description = metadata[:description]
-              snap_date = metadata[:date]
-              snap_service = snaps_service.snapshot_service(snap_id)
-              disks_service = snap_service.disks_service
-              disks_service.list.each do |disk|
-                next unless disk.storage_domains.any?
-                sd_id = disk.storage_domains.first.id
-                sd_name = sds_map[sd_id]
-                xs.push([snap_id, snap_description, snap_date.to_s])
-              end
+          vm_service = env[:vms_service].vm_service(env[:machine].id)
+          snaps_service = vm_service.snapshots_service
+          snaps_map = Hash[snaps_service.list.map { |snap| [snap.id, { description: snap.description, date: snap.date }] }]
+          snaps_map.each do |snap_id, metadata|
+            snap_description = metadata[:description]
+            snap_date = metadata[:date]
+            snap_service = snaps_service.snapshot_service(snap_id)
+            disks_service = snap_service.disks_service
+            disks_service.list.each do |disk|
+              next unless disk.storage_domains.any?
+              sd_id = disk.storage_domains.first.id
+              sd_name = sds_map[sd_id]
+              xs.push([snap_id, snap_description, snap_date.to_s])
             end
           end
+
           widths = xs.transpose.map { |column_arr| column_arr.map(&:size).max }
           env[:machine_snapshot_list] = 
               xs.map { |row_arr| 

data/lib/vagrant-ovirt4/action/start_vm.rb

@@ -1,4 +1,6 @@
 require 'log4r'
+require 'vagrant-ovirt4/errors'
+require 'vagrant-ovirt4/util/machine_names'
 require 'vagrant/util/scoped_hash_override'
 
 module VagrantPlugins
@@ -7,6 +9,7 @@ module VagrantPlugins
 
       # Just start the VM.
       class StartVM
+        include Util::MachineNames
         include Vagrant::Util::ScopedHashOverride
 
         def initialize(app, env)
@@ -26,8 +29,7 @@ module VagrantPlugins
           end
 
           # FIX MULTIPLE NETWORK INTERFACES
-          hostname = env[:machine].config.vm.hostname
-          hostname = 'vagrant' if hostname.nil?
+          hostname = machine_hostname(env[:machine])
 
           initialization = {
             host_name: hostname,
@@ -81,6 +83,7 @@ module VagrantPlugins
           vm_configuration = {
             initialization: initialization,
             placement_policy: {},
+            run_once: config.run_once
           }
 
           vm_configuration[:placement_policy][:hosts] = [{ :name => config.placement_host }] unless config.placement_host.nil?