vagrant-ovirt4 1.2.3 → 2.1.3

data/lib/vagrant-ovirt4/action/create_vm.rb

@@ -1,10 +1,14 @@
 require 'log4r'
+require 'vagrant-ovirt4/util/connection'
+require 'vagrant-ovirt4/util/machine_names'
 require 'vagrant/util/retryable'
 
 module VagrantPlugins
   module OVirtProvider
     module Action
       class CreateVM
+        include Util::Connection
+        include Util::MachineNames
         include Vagrant::Util::Retryable
 
         def initialize(app, env)
@@ -16,12 +20,11 @@ module VagrantPlugins
           # Get config.
           config = env[:machine].provider_config
 
-          hostname = env[:machine].config.vm.hostname
-          hostname = 'vagrant' if hostname.nil?
+          vmname = machine_vmname(env[:machine])
 
           # Output the settings we're going to use to the user
           env[:ui].info(I18n.t("vagrant_ovirt4.creating_vm"))
-          env[:ui].info(" -- Name:          #{hostname}")
+          env[:ui].info(" -- Name:          #{vmname}")
           env[:ui].info(" -- Cluster:       #{config.cluster}")
           env[:ui].info(" -- Template:      #{config.template}")
           env[:ui].info(" -- Console Type:  #{config.console}")
@@ -29,15 +32,15 @@ module VagrantPlugins
           env[:ui].info(" -- Optimized For: #{config.optimized_for}")
           env[:ui].info(" -- Description:   #{config.description}")
           env[:ui].info(" -- Comment:       #{config.comment}")
-          env[:ui].info(" -- Disk:          #{Filesize.from("#{config.disk_size} B").to_f('GB').to_i} GB") unless config.disk_size.nil?
+          env[:ui].info(" -- Disk:          #{Filesize.from("#{config.disk_size} B").to_f('GiB').to_i} GiB") unless config.disk_size.nil?
           env[:ui].info(" -- Additional Disks:") unless config.disks.empty?
           config.disks.each do |disk|
-            env[:ui].info(" ---- name=#{disk[:name]} size=#{Filesize.from("#{disk[:size]} B").to_f('GB').to_i} GB")
+            env[:ui].info(" ---- name=#{disk[:name]} size=#{Filesize.from("#{disk[:size]} B").to_f('GiB').to_i} GiB")
           end
           env[:ui].info(" -- Memory:        ")
-          env[:ui].info(" ---- Memory:      #{Filesize.from("#{config.memory_size} B").to_f('MB').to_i} MB")
-          env[:ui].info(" ---- Maximum:     #{Filesize.from("#{config.memory_maximum} B").to_f('MB').to_i} MB")
-          env[:ui].info(" ---- Guaranteed:  #{Filesize.from("#{config.memory_guaranteed} B").to_f('MB').to_i} MB")
+          env[:ui].info(" ---- Memory:      #{Filesize.from("#{config.memory_size} B").to_f('MiB').to_i} MiB")
+          env[:ui].info(" ---- Maximum:     #{Filesize.from("#{config.memory_maximum} B").to_f('MiB').to_i} MiB")
+          env[:ui].info(" ---- Guaranteed:  #{Filesize.from("#{config.memory_guaranteed} B").to_f('MiB').to_i} MiB")
           env[:ui].info(" -- Cpu:           ")
           env[:ui].info(" ---- Cores:       #{config.cpu_cores}")
           env[:ui].info(" ---- Sockets:     #{config.cpu_sockets}")
@@ -46,7 +49,7 @@ module VagrantPlugins
 
           # Create oVirt VM.
           attr = {
-              :name     => hostname,
+              :name     => vmname,
               :description => config.description,
               :comment => config.comment,
               :cpu      => {
@@ -127,7 +130,7 @@ module VagrantPlugins
               OvirtSDK4::DiskAttachment.new(
                 disk: {
                   name: disk[:name],
-                  description: '#{hostname} storage disk',
+                  description: "#{vmname} storage disk",
                   format: disk[:type] == 'qcow2' ? OvirtSDK4::DiskFormat::COW : OvirtSDK4::DiskFormat::RAW,
                   provisioned_size: disk[:size],
                   storage_domains: [{
@@ -192,7 +195,7 @@ module VagrantPlugins
           destroy_env[:config_validate] = false
           destroy_env[:force_confirm_destroy] = true
           env[:action_runner].run(Action.action_destroy, destroy_env)
-          env[:connection].close()
+          safe_close_connection_standard!(env)
         end
       end
     end

data/lib/vagrant-ovirt4/action/disconnect_ovirt.rb

@@ -1,10 +1,13 @@
 require 'log4r'
 require 'ovirtsdk4'
+require 'vagrant-ovirt4/util/connection'
 
 module VagrantPlugins
   module OVirtProvider
     module Action
       class DisconnectOVirt
+        include Util::Connection
+
         def initialize(app, env)
           @logger = Log4r::Logger.new("vagrant_ovirt4::action::disconnect_ovirt")
           @app = app
@@ -14,7 +17,7 @@ module VagrantPlugins
 
           # Get config options for ovirt provider.
           @logger.info("Disconnecting oVirt connection")
-          env[:connection].close()
+          safe_close_connection_standard!(env)
 
           @app.call(env)
         end

data/lib/vagrant-ovirt4/action/halt_vm.rb

@@ -12,6 +12,17 @@ module VagrantPlugins
         def call(env)
           env[:ui].info(I18n.t("vagrant_ovirt4.halt_vm"))
 
+          # Halt via OS capability
+          begin
+            if env[:machine].guest.capability?(:halt)
+              env[:machine].guest.capability(:halt)
+              # Give the VM a chance to shutdown gracefully..."
+              sleep 10
+            end
+          rescue
+            env[:ui].info("Failed to shutdown guest gracefully.")
+          end
+
           machine = env[:vms_service].vm_service(env[:machine].id)
           machine.stop rescue nil #todo dont rescue
 

data/lib/vagrant-ovirt4/action/read_ssh_info.rb

@@ -17,26 +17,31 @@ module VagrantPlugins
           @app.call(env)
         end
 
+        # This method powers OVirtProvider::Provider#ssh_info.  It returns a
+        # hash of SSH connection information if and only if at least one IPv4
+        # address associated with the machine in question could be retrieved
+        # from the oVirt API.  Otherwise, it returns nil.
         def read_ssh_info(env)
           vms_service, machine = env[:vms_service], env[:machine]
-          return :not_created if machine.id.nil?
+          return nil if machine.id.nil?
 
           # Find the machine
           server = vms_service.vm_service(machine.id)
           begin
             if server.get.nil?
               machine.id = nil
-              return :not_created
+              return nil
             end
           rescue Exception => e
             machine.id = nil
-            return :not_created
-            raise e
+            return nil
           end
 
           nics_service = server.nics_service
           nics = nics_service.list
-          ip_addr = nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment).reported_devices.collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first rescue nil
+          ip_addr = first_active_ipv4_address(env, nics)
+
+          return nil if ip_addr.nil?
 
           # Return the info
           # TODO: Some info should be configurable in Vagrantfile
@@ -49,7 +54,16 @@ module VagrantPlugins
             :forward_x11      => machine.config.ssh.forward_x11,
           }
 
-        end 
+        end
+
+      private
+
+        def first_active_ipv4_address(env, nics)
+          nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment.reported_devices).collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first
+        rescue
+          # for backwards compatibility with ovirt 4.3
+          nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment).reported_devices.collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first rescue nil
+        end
       end
     end
   end

data/lib/vagrant-ovirt4/action/read_state.rb

@@ -33,7 +33,13 @@ module VagrantPlugins
           end
           nics_service = server.nics_service
           nics = nics_service.list
-          ip_addr = nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment).reported_devices.collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first rescue nil
+          begin
+            ip_addr = nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment.reported_devices).collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first
+          rescue
+            # for backwards compatibility with ovirt 4.3
+            ip_addr = nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment).reported_devices.collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first rescue nil
+          end
+
           unless ip_addr.nil?
             env[:ip_address] = ip_addr
             @logger.debug("Got output #{env[:ip_address]}")

data/lib/vagrant-ovirt4/action/snapshot_list.rb

@@ -14,34 +14,30 @@ module VagrantPlugins
 
           system_service = env[:connection].system_service
 
-          # Find all the virtual machines and store the id and name in a
+          #Find all storage domains and store the id and name in a
           # hash, so that looking them up later will be faster:
-          vms_map = Hash[env[:vms_service].list.map { |vm| [vm.id, vm.name] }]
-          
-          # Same for storage domains:
           sds_service = system_service.storage_domains_service
           sds_map = Hash[sds_service.list.map { |sd| [sd.id, sd.name] }]
           
           # For each virtual machine find its snapshots, then for each snapshot
           # find its disks:
           xs = [['id', 'description', 'date']]
-          vms_map.each do |vm_id, vm_name|
-            vm_service = env[:vms_service].vm_service(vm_id)
-            snaps_service = vm_service.snapshots_service
-            snaps_map = Hash[snaps_service.list.map { |snap| [snap.id, { description: snap.description, date: snap.date }] }]
-            snaps_map.each do |snap_id, metadata|
-              snap_description = metadata[:description]
-              snap_date = metadata[:date]
-              snap_service = snaps_service.snapshot_service(snap_id)
-              disks_service = snap_service.disks_service
-              disks_service.list.each do |disk|
-                next unless disk.storage_domains.any?
-                sd_id = disk.storage_domains.first.id
-                sd_name = sds_map[sd_id]
-                xs.push([snap_id, snap_description, snap_date.to_s])
-              end
+          vm_service = env[:vms_service].vm_service(env[:machine].id)
+          snaps_service = vm_service.snapshots_service
+          snaps_map = Hash[snaps_service.list.map { |snap| [snap.id, { description: snap.description, date: snap.date }] }]
+          snaps_map.each do |snap_id, metadata|
+            snap_description = metadata[:description]
+            snap_date = metadata[:date]
+            snap_service = snaps_service.snapshot_service(snap_id)
+            disks_service = snap_service.disks_service
+            disks_service.list.each do |disk|
+              next unless disk.storage_domains.any?
+              sd_id = disk.storage_domains.first.id
+              sd_name = sds_map[sd_id]
+              xs.push([snap_id, snap_description, snap_date.to_s])
             end
           end
+
           widths = xs.transpose.map { |column_arr| column_arr.map(&:size).max }
           env[:machine_snapshot_list] = 
               xs.map { |row_arr| 

data/lib/vagrant-ovirt4/action/start_vm.rb

@@ -1,4 +1,6 @@
 require 'log4r'
+require 'vagrant-ovirt4/errors'
+require 'vagrant-ovirt4/util/machine_names'
 require 'vagrant/util/scoped_hash_override'
 
 module VagrantPlugins
@@ -7,6 +9,7 @@ module VagrantPlugins
 
       # Just start the VM.
       class StartVM
+        include Util::MachineNames
         include Vagrant::Util::ScopedHashOverride
 
         def initialize(app, env)
@@ -26,8 +29,7 @@ module VagrantPlugins
           end
 
           # FIX MULTIPLE NETWORK INTERFACES
-          hostname = env[:machine].config.vm.hostname
-          hostname = 'vagrant' if hostname.nil?
+          hostname = machine_hostname(env[:machine])
 
           initialization = {
             host_name: hostname,
@@ -46,9 +48,15 @@ module VagrantPlugins
           (0...configured_ifaces_options.length()).each do |iface_index|
             iface_options = configured_ifaces_options[iface_index]
 
+            if iface_options[:interface_name] != nil then
+              iface_name = iface_options[:interface_name]
+            else
+              iface_name = "eth#{iface_index}"
+            end
+
             if iface_options[:ip] then
               nic_configuration = {
-                name: "eth#{iface_index}",
+                name: iface_name,
                 on_boot: true,
                 boot_protocol: OvirtSDK4::BootProtocol::STATIC,
                 ip: {
@@ -60,7 +68,7 @@ module VagrantPlugins
               }
             else
               nic_configuration = {
-                name: "eth#{iface_index}",
+                name: iface_name,
                 on_boot: true,
                 boot_protocol: OvirtSDK4::BootProtocol::DHCP,
               }
@@ -75,6 +83,7 @@ module VagrantPlugins
           vm_configuration = {
             initialization: initialization,
             placement_policy: {},
+            run_once: config.run_once
           }
 
           vm_configuration[:placement_policy][:hosts] = [{ :name => config.placement_host }] unless config.placement_host.nil?

data/lib/vagrant-ovirt4/action/wait_till_up.rb

@@ -57,7 +57,13 @@ module VagrantPlugins
 
               nics_service = server.nics_service
               nics = nics_service.list
-              ip_addr = nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment).reported_devices.collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first rescue nil
+              begin
+                ip_addr = nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment.reported_devices).collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first
+              rescue
+                # for backwards compatibility with ovirt 4.3
+                ip_addr = nics.collect { |nic_attachment| env[:connection].follow_link(nic_attachment).reported_devices.collect { |dev| dev.ips.collect { |ip| ip.address if ip.version == 'v4' } unless dev.ips.nil? } }.flatten.reject { |ip| ip.nil? }.first rescue nil
+              end
+
               unless ip_addr.nil?
                 env[:ui].info("Got IP: #{ip_addr}")
                 # Check if SSH-Server is up

data/lib/vagrant-ovirt4/action.rb

@@ -13,8 +13,11 @@ module VagrantPlugins
           b.use ConfigValidate
           b.use ConnectOVirt
           b.use Call, ReadState do |env, b2|
+            # synced_folders defaults to NFS on linux. Make it default to rsync as before.
+            env[:machine].config.nfs.functional = false
             if env[:machine_state_id] == :up
-              b2.use SyncFolders
+              b2.use SyncedFolderCleanup
+              b2.use SyncedFolders
               b2.use MessageAlreadyUp
               next
             end
@@ -37,7 +40,8 @@ module VagrantPlugins
 
             b2.use StartVM
             b2.use WaitTillUp
-            b2.use SyncFolders
+            b2.use SyncedFolderCleanup
+            b2.use SyncedFolders
           end
           b.use DisconnectOVirt
         end
@@ -54,8 +58,8 @@ module VagrantPlugins
 
             b2.use ConnectOVirt
             b2.use ProvisionerCleanup, :before if defined?(ProvisionerCleanup)
-            b2.use HaltVM
-            b2.use WaitTillDown
+            b2.use HaltVM unless env[:machine].state.id == :down
+            b2.use WaitTillDown unless env[:machine].state.id == :down
             b2.use DestroyVM
             b2.use DisconnectOVirt
           end
@@ -66,12 +70,15 @@ module VagrantPlugins
         Vagrant::Action::Builder.new.tap do |b|
           b.use ConfigValidate
           b.use Call, IsCreated do |env, b2|
+            # synced_folders defaults to NFS on linux. Make it default to rsync as before.
+            env[:machine].config.nfs.functional = false
             if !env[:result]
               b2.use MessageNotCreated
               next
             end
             b2.use Provision
-            b2.use SyncFolders
+            b2.use SyncedFolderCleanup
+            b2.use SyncedFolders
           end
         end
       end
@@ -161,7 +168,7 @@ module VagrantPlugins
       end
 
       def self.action_reload
-        with_ovirt do |env, b|
+        Vagrant::Action::Builder.new.tap do |b|
           b.use action_halt
           b.use action_up
         end
@@ -194,7 +201,8 @@ module VagrantPlugins
             b.use MessageNotSuspended
             next
           end
-          b.use action_up
+          b.use StartVM
+          b.use WaitTillUp
         end
       end
 
@@ -234,7 +242,8 @@ module VagrantPlugins
       autoload :SnapshotSave, action_root.join("snapshot_save")
       autoload :StartVM, action_root.join("start_vm")
       autoload :SuspendVM, action_root.join("suspend_vm")
-      autoload :SyncFolders, action_root.join("sync_folders")
+      autoload :SyncedFolders, 'vagrant/action/builtin/synced_folders'
+      autoload :SyncedFolderCleanup, 'vagrant/action/builtin/synced_folder_cleanup'
       autoload :WaitTillDown, action_root.join("wait_till_down")
       autoload :WaitTillUp, action_root.join("wait_till_up")
       autoload :WaitTilSuspended, action_root.join("wait_til_suspended")

data/lib/vagrant-ovirt4/config.rb

@@ -29,7 +29,11 @@ module VagrantPlugins
       attr_accessor :optimized_for
       attr_accessor :description
       attr_accessor :comment
+      attr_accessor :vmname
       attr_accessor :disks
+      attr_accessor :timeout
+      attr_accessor :connect_timeout
+      attr_accessor :run_once
 
       def initialize
         @url               = UNSET_VALUE
@@ -55,6 +59,10 @@ module VagrantPlugins
         @optimized_for     = UNSET_VALUE
         @description       = UNSET_VALUE
         @comment           = UNSET_VALUE
+        @vmname            = UNSET_VALUE
+        @timeout           = UNSET_VALUE
+        @connect_timeout   = UNSET_VALUE
+        @run_once          = UNSET_VALUE
         @disks             = []
 
       end
@@ -98,7 +106,7 @@ module VagrantPlugins
         @cpu_threads = 1 if @cpu_threads == UNSET_VALUE
         @cluster = nil if @cluster == UNSET_VALUE
         @console = nil if @console == UNSET_VALUE
-        @memory_size = '256 MB' if @memory_size == UNSET_VALUE
+        @memory_size = '256 MiB' if @memory_size == UNSET_VALUE
         @memory_maximum = @memory_size if @memory_maximum == UNSET_VALUE
         @memory_guaranteed = @memory_size if @memory_guaranteed == UNSET_VALUE
         @template = nil if @template == UNSET_VALUE
@@ -109,6 +117,10 @@ module VagrantPlugins
         @optimized_for = nil if @optimized_for == UNSET_VALUE
         @description = '' if @description == UNSET_VALUE
         @comment = '' if @comment == UNSET_VALUE
+        @vmname = nil if @vmname == UNSET_VALUE
+        @timeout = nil if @timeout == UNSET_VALUE
+        @connect_timeout = nil if @connect_timeout == UNSET_VALUE
+        @run_once = @run_once == UNSET_VALUE ? false : !!@run_once
 
         unless optimized_for.nil?
           raise "Invalid 'optimized_for'. Must be one of #{OvirtSDK4::VmType.constants.map { |s| "'#{s.downcase}'" }.join(' ')}" unless OvirtSDK4::VmType.constants.include? optimized_for.upcase.to_sym
@@ -133,6 +145,24 @@ module VagrantPlugins
         rescue ArgumentError
           raise "Not able to parse either `memory_size` or `memory_guaranteed`. Please verify and check again."
         end
+
+        unless timeout.nil?
+          begin
+            @timeout = Integer(@timeout)
+            raise ArgumentError if @timeout < 0
+          rescue ArgumentError, TypeError
+            raise "`timeout` argument #{@timeout.inspect} is not a valid nonnegative integer"
+          end
+        end
+
+        unless connect_timeout.nil?
+          begin
+            @connect_timeout = Integer(@connect_timeout)
+            raise ArgumentError if @connect_timeout < 0
+          rescue ArgumentError, TypeError
+            raise "`connect_timeout` argument #{@connect_timeout.inspect} is not a valid nonnegative integer"
+          end
+        end
       end
 
     end

data/lib/vagrant-ovirt4/errors.rb

@@ -7,6 +7,10 @@ module VagrantPlugins
         error_namespace("vagrant_ovirt4.errors")
       end
 
+      class ServiceConnectionError < VagrantOVirtError
+        error_key(:service_connection_error)
+      end
+
       class RsyncError < VagrantOVirtError
         error_key(:rsync_error)
       end

data/lib/vagrant-ovirt4/util/connection.rb

@@ -0,0 +1,40 @@
+require 'ovirtsdk4'
+require 'ovirtsdk4/connection'
+
+module VagrantPlugins
+  module OVirtProvider
+    module Util
+      module Connection
+        # Use OVirtSDK4::ConnectionError if available; SDK versions older than
+        # 4.2.0 used the generic OVirtSDK4::Error.
+        ERROR_CLASSES = (OvirtSDK4.const_defined?(:ConnectionError) ? [OvirtSDK4::ConnectionError, OvirtSDK4::Error] : [OvirtSDK4::Error]).freeze
+
+      module_function
+
+        # Close a connection, suppressing errors generated by the SDK.  Yield
+        # the error to the caller to re-raise if appropriate (or log, or do
+        # whatever).
+        def safe_close_connection!(conn)
+          conn.close
+        rescue *ERROR_CLASSES => e
+          yield e if block_given?
+        rescue StandardError => e
+          yield e if block_given?
+          raise e
+        end
+
+        # Wrapper for "#safe_close_connection" that issues a warning message
+        # with diagnostic information about the exception raised.
+        def safe_close_connection_with_warning!(conn, ui)
+          safe_close_connection!(conn) { |e| ui.warn("Encountered exception of class #{e.class}: #{e.message}") }
+        end
+
+        # Wrapper for "#safe_close_connection_with_warning" that extracts the
+        # connection and UI from a Vagrant environment.
+        def safe_close_connection_standard!(env)
+          safe_close_connection_with_warning!(env[:connection], env[:ui])
+        end
+      end
+    end
+  end
+end

data/lib/vagrant-ovirt4/util/machine_names.rb

@@ -0,0 +1,21 @@
+module VagrantPlugins
+  module OVirtProvider
+    module Util
+      module MachineNames
+        DEFAULT_NAME = 'vagrant'.freeze
+
+      module_function
+
+        def machine_hostname(machine)
+          machine.config.vm.hostname || DEFAULT_NAME
+        end
+
+        def machine_vmname(machine)
+          machine.provider_config.vmname || machine_hostname(machine)
+        end
+      end
+    end
+  end
+end
+
+

data/lib/vagrant-ovirt4/version.rb

@@ -1,6 +1,6 @@
 module VagrantPlugins
   module OVirtProvider
-    VERSION = '1.2.3'
+    VERSION = '2.1.3'
   end
 end
 

data/lib/vagrant-ovirt4.rb

@@ -1,3 +1,4 @@
+require 'log4r'
 require 'pathname'
 require 'vagrant-ovirt4/plugin'
 
@@ -8,9 +9,11 @@ module VagrantPlugins
     autoload :Errors, lib_path.join("errors")
     autoload :Util,   lib_path.join("util")
 
+    @@logger = Log4r::Logger.new("vagrant_ovirt4::provider")
     @@ovirt_connection = nil
     @@vms_service = nil
     def self.ovirt_connection
+      @@logger.warn('Use of deprecated OVirtProvider.ovirt_connection detected.')
       @@ovirt_connection
     end
 
@@ -19,6 +22,7 @@ module VagrantPlugins
     end
 
     def self.vms_service
+      @@logger.warn('Use of deprecated OVirtProvider.vms_service detected.')
       @@vms_service
     end
 

data/locales/en.yml

@@ -55,7 +55,13 @@ en:
         The instance is not running. Use `vagrant up` to start it.
       short_down: |-
         down
+      long_not_created: |-
+        The instance is not created. Use `vagrant up` to create it.
+      short_not_created: |-
+        not created
     errors:
+      service_connection_error: |-
+        Error connecting to the oVirt cluster endpoint: "%{error_message}"
       remove_vm_error: |-
         Error removing VM '%{vm_name}'. oVirt error message was '%{error_message}'
       no_vm_error: |-

data/spec/spec_helper.rb

@@ -1 +1,3 @@
 require 'vagrant'
+
+require_relative 'support/shared_context'

data/spec/support/shared_context.rb

@@ -0,0 +1,39 @@
+require 'vagrant-ovirt4/config'
+
+shared_context 'provider:action' do
+  let(:app) { double('app') }
+
+  let(:env) {
+    {
+      connection: double('connection',
+        system_service: double('system_service', disks_service: double('disks_service'))
+      ),
+      machine: double('machine',
+        provider: double('provider'),
+        provider_config: VagrantPlugins::OVirtProvider::Config.new,
+        name: 'machname',
+        id: 'ID',
+        config: double('config',
+          vm: double('vm_config',
+            networks: [],
+          ),
+        ),
+      ),
+      ui: double('ui'),
+      vms_service: double('vms_service'),
+    }
+  }
+
+  let(:vm_service) {
+    double('vm_service',
+      disk_attachments_service: double('disk_attachments_service', list: []),
+      get: double('get'),
+    )
+  }
+
+  before do
+    allow(app).to receive(:call)
+    allow(env[:vms_service]).to receive(:vm_service).with(env[:machine].id).and_return(vm_service)
+    env[:machine].provider_config.finalize!
+  end
+end