vagrant-openstack-provider 0.7.2 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4dd7cf830eecfb15611665ed53da19db9cd5bab5
-  data.tar.gz: 1b5bce071291bc0af764f91933b839803ee3f4c7
+  metadata.gz: 609b227799e2765e0d6f7bb5277e7e8602cb424f
+  data.tar.gz: d92034eb5c24737dc80912e983e35443e8929550
 SHA512:
-  metadata.gz: b95d4b1ccc79200bcd97f7a189e21768b214b3f50056d77ff53c83d7581b31c3d23a3e9d343f7023b37a31e8128a65cf6303c7315af3f3f00906286e634145c5
-  data.tar.gz: 2f071db27ddf020cb30cbf15bbcb7e11e0944dcf63572418c6fc3ce751d4080da54931172424fc88dc2aacf7fb7011ec8f6cedf17278ed7793e11f770d257e96
+  metadata.gz: 34905aff4b10744c0c2402b01d801d76adff1c4be7107c46d55e85be80455dc44046dccf6d46fd7df3694695ceef9eaabbc603fb3eff217438648ad6473a0763
+  data.tar.gz: e4cdb6940e49072f44bd79829981dce5b6fbc4b385e7f59528ff8c9a22663e86137f03b1999389168dc888b9aa90b21ec05e2738b114968b9cc4ce024b47afce

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+# 0.8.0 (November 19, 2016)
+
+IMPROVEMENTS:
+
+  - Move to standard Vagrant synced folders middleware #295
+
+FEATURES:
+
+  - Support Keystone v3 API #4
+
+BUG FIXES:
+
+  - Bugfix on IP address resolution #285
+
 # 0.7.2 (May 1, 2016)
 
 IMPROVEMENTS:

data/Gemfile

@@ -3,7 +3,14 @@ source 'https://rubygems.org'
 gemspec
 
 group :development do
-  gem 'vagrant', git: 'https://github.com/mitchellh/vagrant.git', tag: 'v1.8.1'
+  gem 'vagrant', git: 'https://github.com/mitchellh/vagrant.git', tag: 'v1.8.5'
+  # FIXME: Hack to allow Vagrant v1.6.5 to install for tests. Remove when
+  # support for 1.6.5 is dropped.
+  gem 'rack', '< 2'
+  # FIXME: Version 1.4.0 of the ruby_dep gem added a constraint on the Ruby
+  # version being >=2.2.5. This pin to ruby_dep 1.3.1 can be removed when the
+  # next Vagrant version after 1.8.5 is released.
+  gem 'ruby_dep', '~> 1.3.1'
   gem 'appraisal', '1.0.0'
   gem 'rubocop', '0.29.0', require: false
   gem 'coveralls', require: false

data/lib/vagrant-openstack-provider/action.rb

@@ -39,7 +39,13 @@ module VagrantPlugins
               else
                 b2.use Provision
               end
-              b2.use SyncFolders
+              if env[:machine].provider_config.use_legacy_synced_folders
+                env[:machine].ui.warn I18n.t('vagrant_openstack.config.sync_folders_deprecated')
+                b2.use SyncFolders
+              else
+                # Standard Vagrant implementation.
+                b2.use SyncedFolders
+              end
             end
           end
         end
@@ -61,6 +67,7 @@ module VagrantPlugins
       # key.
       def self.action_read_state
         new_builder.tap do |b|
+          b.use HandleBox
           b.use ConfigValidate
           b.use ConnectOpenstack
           b.use ReadState
@@ -97,6 +104,7 @@ module VagrantPlugins
 
       def self.action_up
         new_builder.tap do |b|
+          b.use HandleBox
           b.use ConfigValidate
           b.use ConnectOpenstack
 
@@ -111,7 +119,15 @@ module VagrantPlugins
                   b2.use Provision
                 end
               end
-              b2.use SyncFolders
+
+              if env[:machine].provider_config.use_legacy_synced_folders
+                env[:machine].ui.warn I18n.t('vagrant_openstack.config.sync_folders_deprecated')
+                b2.use SyncFolders
+              else
+                # Standard Vagrant implementation.
+                b2.use SyncedFolders
+              end
+
               b2.use CreateStack
               b2.use CreateServer
               b2.use Message, I18n.t('vagrant_openstack.ssh_disabled_provisioning') if ssh_disabled

data/lib/vagrant-openstack-provider/action/create_server.rb

@@ -99,7 +99,7 @@ module VagrantPlugins
             end
           end
 
-          log = "Lauching server '#{server_name}' in project '#{config.tenant_name}' "
+          log = "Launching server '#{server_name}' in project '#{config.tenant_name}' "
           log << "with flavor '#{options[:flavor].name}' (#{options[:flavor].id}), "
           unless options[:image].nil?
             log << "image '#{options[:image].name}' (#{options[:image].id}) "
@@ -131,7 +131,7 @@ module VagrantPlugins
           @logger.info "Waiting for the server with id #{server_id} to be built..."
           env[:ui].info(I18n.t('vagrant_openstack.waiting_for_build'))
           config = env[:machine].provider_config
-          timeout(config.server_create_timeout, Errors::Timeout) do
+          Timeout.timeout(config.server_create_timeout, Errors::Timeout) do
             server_status = 'WAITING'
             until server_status == 'ACTIVE'
               @logger.debug('Waiting for server to be ACTIVE')

data/lib/vagrant-openstack-provider/action/create_stack.rb

@@ -60,7 +60,7 @@ module VagrantPlugins
           @logger.info "Waiting for the stack with id #{stack_id} to be built..."
           env[:ui].info(I18n.t('vagrant_openstack.waiting_for_stack'))
           config = env[:machine].provider_config
-          timeout(config.stack_create_timeout, Errors::Timeout) do
+          Timeout.timeout(config.stack_create_timeout, Errors::Timeout) do
             stack_status = 'CREATE_IN_PROGRESS'
             until stack_status == 'CREATE_COMPLETE'
               @logger.debug('Waiting for stack to be CREATED')

data/lib/vagrant-openstack-provider/action/delete_server.rb

@@ -32,7 +32,7 @@ module VagrantPlugins
           @logger.info "Waiting for the instance with id #{instance_id} to be deleted..."
           env[:ui].info(I18n.t('vagrant_openstack.waiting_deleted'))
           config = env[:machine].provider_config
-          timeout(config.server_delete_timeout, Errors::Timeout) do
+          Timeout.timeout(config.server_delete_timeout, Errors::Timeout) do
             delete_ok = false
             until delete_ok
               begin

data/lib/vagrant-openstack-provider/action/delete_stack.rb

@@ -57,7 +57,7 @@ module VagrantPlugins
           @logger.info "Waiting for the stack with id #{stack_id} to be deleted..."
           env[:ui].info(I18n.t('vagrant_openstack.waiting_for_stack_deleted'))
           config = env[:machine].provider_config
-          timeout(config.stack_delete_timeout, Errors::Timeout) do
+          Timeout.timeout(config.stack_delete_timeout, Errors::Timeout) do
             stack_status = 'DELETE_IN_PROGRESS'
             until stack_status == 'DELETE_COMPLETE'
               @logger.debug('Waiting for stack to be DELETED')

data/lib/vagrant-openstack-provider/action/wait_active.rb

@@ -18,7 +18,7 @@ module VagrantPlugins
             env[:ui].info(I18n.t('vagrant_openstack.waiting_start'))
             client = env[:openstack_client].nova
             config = env[:machine].provider_config
-            timeout(config.server_active_timeout, Errors::Timeout) do
+            Timeout.timeout(config.server_active_timeout, Errors::Timeout) do
               while client.get_server_details(env, env[:machine].id)['status'] != 'ACTIVE'
                 sleep @retry_interval
                 @logger.info('Waiting for server to be active')

data/lib/vagrant-openstack-provider/action/wait_stop.rb

@@ -18,7 +18,7 @@ module VagrantPlugins
             env[:ui].info(I18n.t('vagrant_openstack.waiting_stop'))
             client = env[:openstack_client].nova
             config = env[:machine].provider_config
-            timeout(config.server_stop_timeout, Errors::Timeout) do
+            Timeout.timeout(config.server_stop_timeout, Errors::Timeout) do
               while client.get_server_details(env, env[:machine].id)['status'] != 'SHUTOFF'
                 sleep @retry_interval
                 @logger.info('Waiting for server to stop')

data/lib/vagrant-openstack-provider/catalog/openstack_catalog.rb

@@ -10,24 +10,16 @@ module VagrantPlugins
           config = env[:machine].provider_config
           client = env[:openstack_client]
           endpoints = client.session.endpoints
-          endpoint_type = config.endpoint_type
           @logger.info(I18n.t('vagrant_openstack.client.looking_for_available_endpoints'))
           @logger.info("Selecting endpoints matching region '#{config.region}'") unless config.region.nil?
 
           catalog.each do |service|
             se = service['endpoints']
-            if config.region.nil?
-              if se.size > 1
-                env[:ui].warn I18n.t('vagrant_openstack.client.multiple_endpoint', size: se.size, type: service['type'])
-                env[:ui].warn "  => #{service['endpoints'][0][endpoint_type]}"
-              end
-              url = se[0][endpoint_type].strip
-            else
-              se.each do |endpoint|
-                url = endpoint[endpoint_type].strip if endpoint['region'].eql? config.region
-              end
+            if config.identity_api_version == '2'
+              get_endpoints_2(env, se, service, config, endpoints)
+            elsif config.identity_api_version == '3'
+              get_interfaces_3(se, service, config, endpoints)
             end
-            endpoints[service['type'].to_sym] = url unless url.nil? || url.empty?
           end
 
           endpoints[:network] = choose_api_version('Neutron', 'openstack_network_url', 'v2') do
@@ -41,6 +33,37 @@ module VagrantPlugins
 
         private
 
+        def get_endpoints_2(env, se, service, config, endpoints)
+          endpoint_type = config.endpoint_type
+          if config.region.nil?
+            if se.size > 1
+              env[:ui].warn I18n.t('vagrant_openstack.client.multiple_endpoint', size: se.size, type: service['type'])
+              env[:ui].warn "  => #{service['endpoints'][0][endpoint_type]}"
+            end
+            url = se[0][endpoint_type].strip
+          else
+            se.each do |endpoint|
+              url = endpoint[endpoint_type].strip if endpoint['region'].eql? config.region
+            end
+          end
+          endpoints[service['type'].to_sym] = url unless url.nil? || url.empty?
+        end
+
+        def get_interfaces_3(se, service, config, endpoints)
+          url = nil
+          se.each do |endpoint|
+            next if endpoint['interface'] != config.interface_type
+            if config.region.nil?
+              url = endpoint['url']
+              break
+            elsif endpoint['region'] == config.region
+              url = endpoint['url']
+              break
+            end
+          end
+          endpoints[service['type'].to_sym] = url unless url.nil? || url.empty?
+        end
+
         def choose_api_version(service_name, url_property, version_prefix = nil, fail_if_not_found = true)
           versions = yield
 

data/lib/vagrant-openstack-provider/client/keystone.rb

@@ -19,20 +19,13 @@ module VagrantPlugins
         config = env[:machine].provider_config
         @logger.info(I18n.t('vagrant_openstack.client.authentication', project: config.tenant_name, user: config.username))
 
-        post_body =
-          {
-            auth:
-              {
-                tenantName: config.tenant_name,
-                passwordCredentials:
-                  {
-                    username: config.username,
-                    password: '****'
-                  }
-              }
-          }
-
-        auth_url = get_auth_url_v2 env
+        if config.identity_api_version == '2'
+          post_body = get_body_2 config
+          auth_url = get_auth_url_2 env
+        elsif config.identity_api_version == '3'
+          post_body = get_body_3 config
+          auth_url = get_auth_url_3 env
+        end
 
         headers = {
           content_type: :json,
@@ -41,13 +34,19 @@ module VagrantPlugins
 
         log_request(:POST, auth_url, post_body.to_json, headers)
 
-        post_body[:auth][:passwordCredentials][:password] = config.password
+        if config.identity_api_version == '2'
+          post_body[:auth][:passwordCredentials][:password] = config.password
+        elsif config.identity_api_version == '3'
+          post_body[:auth][:identity][:password][:user][:password] = config.password
+        end
 
         authentication = RestUtils.post(env, auth_url, post_body.to_json, headers) do |response|
           log_response(response)
           case response.code
           when 200
             response
+          when 201
+            response
           when 401
             fail Errors::AuthenticationFailed
           when 404
@@ -57,17 +56,69 @@ module VagrantPlugins
           end
         end
 
-        access = JSON.parse(authentication)['access']
-        response_token = access['token']
-        @session.token = response_token['id']
-        @session.project_id = response_token['tenant']['id']
-
-        access['serviceCatalog']
+        if config.identity_api_version == '2'
+          access = JSON.parse(authentication)['access']
+          response_token = access['token']
+          @session.token = response_token['id']
+          @session.project_id = response_token['tenant']['id']
+          return access['serviceCatalog']
+        elsif config.identity_api_version == '3'
+          body = JSON.parse(authentication)
+          @session.token = authentication.headers[:x_subject_token]
+          @session.project_id = body['token']['project']['id']
+          return body['token']['catalog']
+        end
       end
 
       private
 
-      def get_auth_url_v2(env)
+      def get_body_2(config)
+        {
+          auth:
+          {
+            tenantName: config.tenant_name,
+            passwordCredentials:
+            {
+              username: config.username,
+              password: '****'
+            }
+          }
+        }
+      end
+
+      def get_body_3(config)
+        {
+          auth:
+          {
+            identity: {
+              methods: ['password'],
+              password: {
+                user: {
+                  name: config.username,
+                  domain: {
+                    name: config.domain_name
+                  },
+                  password: '****'
+                }
+              }
+            },
+            scope: {
+              project: {
+                name: config.project_name,
+                domain: { name: config.domain_name }
+              }
+            }
+          }
+        }
+      end
+
+      def get_auth_url_3(env)
+        url = env[:machine].provider_config.openstack_auth_url
+        return url if url.match(%r{/tokens/*$})
+        "#{url}/auth/tokens"
+      end
+
+      def get_auth_url_2(env)
         url = env[:machine].provider_config.openstack_auth_url
         return url if url.match(%r{/tokens/*$})
         "#{url}/tokens"

data/lib/vagrant-openstack-provider/config.rb

@@ -52,6 +52,11 @@ module VagrantPlugins
       #
       attr_accessor :tenant_name
 
+      #
+      # The name of the openstack project on witch the vm will be created, changed name in v3 identity API.
+      #
+      attr_accessor :project_name
+
       # The name of the server. This defaults to the name of the machine
       # defined by Vagrant (via `config.vm.define`), but can be overriden
       # here.
@@ -62,6 +67,11 @@ module VagrantPlugins
       # @return [String]
       attr_accessor :username
 
+      # The domain name to access Openstack, this defaults to Default.
+      #
+      # @return [String]
+      attr_accessor :domain_name
+
       # The name of the keypair to use.
       #
       # @return [String]
@@ -82,6 +92,8 @@ module VagrantPlugins
 
       # Opt files/directories in to the rsync operation performed by this provider
       #
+      # @deprecated Use standard Vagrant synced folders instead.
+      #
       # @return [Array]
       attr_accessor :rsync_includes
 
@@ -103,12 +115,16 @@ module VagrantPlugins
 
       # Sync folder method. Can be either "rsync" or "none"
       #
+      # @deprecated Use standard Vagrant synced folders instead.
+      #
       # @return [String]
       attr_accessor :sync_method
 
       # Sync folder ignore files. A list of files containing exclude patterns to ignore in the rsync operation
       #  performed by this provider
       #
+      # @deprecated Use standard Vagrant synced folders instead.
+      #
       # @return [Array]
       attr_accessor :rsync_ignore_files
 
@@ -167,6 +183,16 @@ module VagrantPlugins
       # @return [String]
       attr_accessor :endpoint_type
 
+      # Specify the endpoint_type to use : publicL, admin, or internal (default is public)
+      #
+      # @return [String]
+      attr_accessor :interface_type
+
+      # Specify the authentication version to use : 2 or 3 (ddefault is 2()
+      #
+      # @return [String]
+      attr_accessor :identity_api_version
+
       #
       # @return [Integer]
       attr_accessor :server_create_timeout
@@ -199,6 +225,20 @@ module VagrantPlugins
       # @return [Boolean]
       attr_accessor :meta_args_support
 
+      # A switch for enabling the legacy synced folders implementation.
+      #
+      # This defaults to false, but is automatically set to true if any of the
+      # legacy synced folder options are used:
+      #
+      #   - {#rsync_includes}
+      #   - {#rsync_ignore_files}
+      #   - {#sync_method}
+      #
+      # @deprecated Use standard Vagrant synced folders instead.
+      #
+      # @return [Boolean]
+      attr_accessor :use_legacy_synced_folders
+
       def initialize
         @password = UNSET_VALUE
         @openstack_compute_url = UNSET_VALUE
@@ -208,6 +248,8 @@ module VagrantPlugins
         @openstack_image_url = UNSET_VALUE
         @openstack_auth_url = UNSET_VALUE
         @endpoint_type = UNSET_VALUE
+        @interface_type = UNSET_VALUE
+        @identity_api_version = UNSET_VALUE
         @region = UNSET_VALUE
         @flavor = UNSET_VALUE
         @image = UNSET_VALUE
@@ -242,6 +284,7 @@ module VagrantPlugins
         @stack_delete_timeout = UNSET_VALUE
         @meta_args_support = UNSET_VALUE
         @http = HttpConfig.new
+        @use_legacy_synced_folders = UNSET_VALUE
       end
 
       def merge(other)
@@ -282,7 +325,7 @@ module VagrantPlugins
         result
       end
 
-      # rubocop:disable Metrics/CyclomaticComplexity
+      # rubocop:disable Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
       def finalize!
         @password = nil if @password == UNSET_VALUE
         @openstack_compute_url = nil if @openstack_compute_url == UNSET_VALUE
@@ -292,19 +335,20 @@ module VagrantPlugins
         @openstack_image_url = nil if @openstack_image_url == UNSET_VALUE
         @openstack_auth_url = nil if @openstack_auth_url == UNSET_VALUE
         @endpoint_type = 'publicURL' if @endpoint_type == UNSET_VALUE
+        @interface_type = 'public' if @interface_type == UNSET_VALUE
+        @identity_api_version = '2' if @identity_api_version == UNSET_VALUE
         @region = nil if @region == UNSET_VALUE
         @flavor = nil if @flavor == UNSET_VALUE
         @image = nil if @image == UNSET_VALUE
         @volume_boot = nil if @volume_boot == UNSET_VALUE
         @tenant_name = nil if @tenant_name == UNSET_VALUE
+        @project_name = nil if @project_name == UNSET_VALUE
         @server_name = nil if @server_name == UNSET_VALUE
         @username = nil if @username == UNSET_VALUE
-        @rsync_includes = nil if @rsync_includes.empty?
-        @rsync_ignore_files = nil if @rsync_ignore_files.empty?
+        @domain_name = 'Default' if @domain_name == UNSET_VALUE
         @floating_ip = nil if @floating_ip == UNSET_VALUE
         @floating_ip_pool = nil if @floating_ip_pool == UNSET_VALUE
         @floating_ip_pool_always_allocate = false if floating_ip_pool_always_allocate == UNSET_VALUE
-        @sync_method = 'rsync' if @sync_method == UNSET_VALUE
         @keypair_name = nil if @keypair_name == UNSET_VALUE
         @public_key_path = nil if @public_key_path == UNSET_VALUE
         @availability_zone = nil if @availability_zone == UNSET_VALUE
@@ -314,6 +358,27 @@ module VagrantPlugins
         @metadata = nil if @metadata == UNSET_VALUE
         @ssh_disabled = false if @ssh_disabled == UNSET_VALUE
 
+        # The value of use_legacy_synced_folders is used by action chains
+        # to determine which synced folder implementation to run.
+        if @use_legacy_synced_folders == UNSET_VALUE
+          @use_legacy_synced_folders = !(
+            (@rsync_includes.nil? || @rsync_includes.empty?) &&
+            (@rsync_ignore_files.nil? || @rsync_ignore_files.empty?) &&
+            (@sync_method.nil? || @sync_method == UNSET_VALUE))
+        end
+
+        if @use_legacy_synced_folders
+          # Original defaults.
+          @rsync_includes = nil if @rsync_includes.empty?
+          @rsync_ignore_files = nil if @rsync_ignore_files.empty?
+          @sync_method = 'rsync' if @sync_method == UNSET_VALUE
+        else
+          # Disable all sync settings.
+          @rsync_includes = nil
+          @rsync_ignore_files = nil
+          @sync_method = nil
+        end
+
         # The SSH values by default are nil, and the top-level config
         # `config.ssh` and `config.vm.boot_timeout` values are used.
         @ssh_username = nil if @ssh_username == UNSET_VALUE
@@ -331,8 +396,10 @@ module VagrantPlugins
         @stacks = nil if @stacks.empty?
         @http.finalize!
       end
-      # rubocop:enable Metrics/CyclomaticComplexity
+      # rubocop:enable Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
 
+      #
+      # @deprecated Use standard Vagrant synced folders instead.
       def rsync_include(inc)
         @rsync_includes << inc
       end
@@ -342,9 +409,9 @@ module VagrantPlugins
 
         errors << I18n.t('vagrant_openstack.config.password_required') if @password.nil? || @password.empty?
         errors << I18n.t('vagrant_openstack.config.username_required') if @username.nil? || @username.empty?
-        errors << I18n.t('vagrant_openstack.config.tenant_name_required') if @tenant_name.nil? || @tenant_name.empty?
-        errors << I18n.t('vagrant_openstack.config.invalid_endpoint_type') unless  %w(publicURL adminURL internalURL).include?(@endpoint_type)
+        errors << I18n.t('vagrant_openstack.config.invalid_api_version') unless  %w(2 3).include?(@identity_api_version)
 
+        validate_api_version(errors)
         validate_ssh_username(machine, errors)
         validate_stack_config(errors)
         validate_ssh_timeout(errors)
@@ -371,6 +438,17 @@ module VagrantPlugins
 
       private
 
+      def validate_api_version(errors)
+        if @identity_api_version == '2'
+          errors << I18n.t('vagrant_openstack.config.tenant_name_required') if @tenant_name.nil? || @tenant_name.empty?
+          errors << I18n.t('vagrant_openstack.config.invalid_endpoint_type') unless  %w(publicURL adminURL internalURL).include?(@endpoint_type)
+        elsif @identity_api_version == '3'
+          errors << I18n.t('vagrant_openstack.config.domain_required') if @domain_name.nil? || @domain_name.empty?
+          errors << I18n.t('vagrant_openstack.config.project_name_required') if @project_name.nil? || @project_name.empty?
+          errors << I18n.t('vagrant_openstack.config.invalid_interface_type') unless  %w(public admin internal).include?(@interface_type)
+        end
+      end
+
       def validate_stack_config(errors)
         @stacks.each do |stack|
           errors << I18n.t('vagrant_openstack.config.invalid_stack') unless stack[:name] && stack[:template]

data/lib/vagrant-openstack-provider/utils.rb

@@ -16,7 +16,12 @@ module VagrantPlugins
         if addresses.size == 1
           net_addresses = addresses.first[1]
         else
-          net_addresses = addresses[env[:machine].provider_config.networks[0]]
+          first_network = env[:machine].provider_config.networks[0]
+          if first_network.is_a? String
+            net_addresses = addresses[first_network]
+          else
+            net_addresses = addresses[first_network[:name]]
+          end
         end
         fail Errors::UnableToResolveIP if net_addresses.size == 0
         net_addresses[0]['addr']

data/lib/vagrant-openstack-provider/version.rb

@@ -4,7 +4,7 @@ module VagrantPlugins
     # Stable versions must respect the pattern given
     # by VagrantPlugins::Openstack::VERSION_PATTERN
     #
-    VERSION = '0.7.2'
+    VERSION = '0.8.0'
 
     #
     # Stable version must respect the naming convention 'x.y.z'

data/lib/vagrant-openstack-provider/version_checker.rb

@@ -65,7 +65,7 @@ module VagrantPlugins
 
     # rubocop:disable Lint/HandleExceptions
     def self.check_version
-      timeout(3, Errors::Timeout) do
+      Timeout.timeout(3, Errors::Timeout) do
         VersionChecker.instance.check
       end
     rescue

data/locales/en.yml

@@ -138,6 +138,19 @@ en:
         to the standard vagrant configuration option `config.vm.boot_timeout`.
       invalid_value_for_parameter: |-
         Invalid value '%{value}' for parameter '%{parameter}'
+      sync_folders_deprecated: |-
+        The following configuration settings are deprecated and should be
+        removed: rsync_includes, rsync_ignore_files, sync_method. Using these
+        settings causes the OpenStack provider to fall back to an old synced
+        folder implementation instead of using standard Vagrant synced folders.
+      domain_required: |-
+        A domain is required when using identity API version 3
+      project_name_required: |-
+        A project name is required when using identity API version 3
+      invalid_interface_type: |-
+        Interface type must be public, admin or internal (if not provided, default is public)
+      invalid_api_version: |-
+        identity API verison must be 2 or 3 (if nto provided, default is 2)
 
     errors:
       default: |-

data/spec/vagrant-openstack-provider/action/connect_openstack_spec.rb

@@ -18,10 +18,13 @@ describe VagrantPlugins::Openstack::Action::ConnectOpenstack do
       config.stub(:openstack_volume_url) { nil }
       config.stub(:openstack_image_url) { nil }
       config.stub(:tenant_name) { 'testTenant' }
+      config.stub(:project_name) { 'testTenant' }
       config.stub(:username) { 'username' }
       config.stub(:password) { 'password' }
       config.stub(:region) { nil }
       config.stub(:endpoint_type) { 'publicURL' }
+      config.stub(:interface_type) { 'public' }
+      config.stub(:identity_api_version) { '2' }
     end
   end
 
@@ -243,6 +246,78 @@ describe VagrantPlugins::Openstack::Action::ConnectOpenstack do
       end
     end
 
+    context 'with one endpoint by service v3' do
+      it 'read service catalog and stores endpoints URL in session v3' do
+        catalog = [
+          {
+            'endpoints' => [
+              {
+                'url' => 'http://nova/v2/projectId',
+                'interface' => 'public',
+                'region' => 'RegionOne',
+                'id' => '1'
+              }
+            ],
+            'type' => 'compute',
+            'name' => 'nova'
+          },
+          {
+            'endpoints' => [
+              {
+                'url' => 'http://neutron',
+                'interface' => 'public',
+                'region' => 'RegionOne',
+                'id' => '2'
+              }
+            ],
+            'type' => 'network',
+            'name' => 'neutron'
+          },
+          {
+            'endpoints' => [
+              {
+                'url' => 'http://cinder/v2/projectId',
+                'interface' => 'public',
+                'region' => 'RegionOne',
+                'id' => '2'
+              }
+            ],
+            'type' => 'volume',
+            'name' => 'cinder'
+          },
+          {
+            'endpoints' => [
+              {
+                'url' => 'http://glance',
+                'interface' => 'public',
+                'region' => 'RegionOne',
+                'id' => '2'
+              }
+            ],
+            'type' => 'image',
+            'name' => 'glance'
+          }
+        ]
+
+        double.tap do |keystone|
+          keystone.stub(:authenticate).with(anything) { catalog }
+          env[:openstack_client].stub(:keystone) { keystone }
+        end
+        env[:openstack_client].stub(:neutron)  { neutron }
+        env[:openstack_client].stub(:glance)   { glance }
+        config.stub(:domain_name) { 'dummy' }
+        config.stub(:identity_api_version) { '3' }
+
+        @action.call(env)
+
+        expect(env[:openstack_client].session.endpoints)
+          .to eq(compute: 'http://nova/v2/projectId',
+                 network: 'http://neutron/v2.0',
+                 volume:  'http://cinder/v2/projectId',
+                 image:   'http://glance/v2.0')
+      end
+    end
+
     context 'with multiple regions' do
       it 'read service catalog and stores endpoints URL for desired regions in session' do
         catalog = [

data/spec/vagrant-openstack-provider/client/keystone_spec.rb

@@ -17,6 +17,9 @@ describe VagrantPlugins::Openstack::KeystoneClient do
       config.stub(:username) { 'username' }
       config.stub(:password) { 'password' }
       config.stub(:http) { http }
+      config.stub(:interface_type) { 'public' }
+      config.stub(:identity_api_version) { '2' }
+      config.stub(:project_name) { 'testTenant' }
     end
   end
 
@@ -52,6 +55,29 @@ describe VagrantPlugins::Openstack::KeystoneClient do
        ]}}'
     end
 
+    let(:keystone_response_headers_v3) do
+      {
+        'Accept' => 'application/json',
+        'Content-Type' => 'application/json',
+        'x_subject_token' => '0123456789'
+      }
+    end
+
+    let(:keystone_request_body_v3) do
+      '{"auth":{"identity":{"methods":["password"],"password":{"user":{"name":"username","domain":'\
+      '{"name":"dummy"},"password":"password"}}},"scope":{"project":{"name":"testTenant","domain":'\
+      '{"name":"dummy"}}}}}'
+    end
+
+    let(:keystone_response_body_v3) do
+      '{"token":{"is_domain":false,"methods":["password"],"roles":[{"id":"1234","name":"_member_"}],
+        "is_admin_project":false,"project":{"domain":{"id":"1234","name":"dummy"},"id":"012345678910",
+        "name":"testTenantId"},"catalog":[
+         {"endpoints":[{"id":"eid1","interface":"public","url":"http://nova"}],"type":"compute"},
+         {"endpoints":[{"id":"eid2","interface":"public","url":"http://neutron"}],"type":"network"}
+       ]}}'
+    end
+
     before :each do
       @keystone_client = VagrantPlugins::Openstack.keystone
     end
@@ -146,5 +172,53 @@ describe VagrantPlugins::Openstack::KeystoneClient do
         end
       end
     end
+
+    # V3
+    context 'with good credentials v3' do
+      it 'store token and tenant id' do
+        config.stub(:domain_name) { 'dummy' }
+        config.stub(:identity_api_version) { '3' }
+        config.stub(:openstack_auth_url) { 'http://keystoneAuthV3' }
+
+        stub_request(:post, 'http://keystoneAuthV3/auth/tokens')
+          .with(
+            body: keystone_request_body_v3,
+            headers: keystone_request_headers)
+          .to_return(
+            status: 200,
+            body: keystone_response_body_v3,
+            headers: keystone_response_headers_v3)
+
+        @keystone_client.authenticate(env)
+
+        session.token.should eq('0123456789')
+        session.project_id.should eq('012345678910')
+      end
+    end
+
+    context 'with wrong credentials v3' do
+      it 'raise an unauthorized error ' do
+        config.stub(:domain_name) { 'dummy' }
+        config.stub(:identity_api_version) { '3' }
+        config.stub(:openstack_auth_url) { 'http://keystoneAuthV3' }
+
+        stub_request(:post, 'http://keystoneAuthV3/auth/tokens')
+          .with(
+            body: keystone_request_body_v3,
+            headers: keystone_request_headers)
+          .to_return(
+            status: 401,
+            body: '{
+                "error": {
+                  "message": "The request you have made requires authentication.",
+                  "code": 401,
+                  "title": "Unauthorized"
+               }
+              }',
+            headers: keystone_response_headers_v3)
+
+        expect { @keystone_client.authenticate(env) }.to raise_error(Errors::AuthenticationFailed)
+      end
+    end
   end
 end

data/spec/vagrant-openstack-provider/config_spec.rb

@@ -16,7 +16,10 @@ describe VagrantPlugins::Openstack::Config do
     its(:image)    { should be_nil }
     its(:server_name) { should be_nil }
     its(:username) { should be_nil }
+    its(:use_legacy_synced_folders) { should eq(false) }
     its(:rsync_includes) { should be_nil }
+    its(:rsync_ignore_files) { should be_nil }
+    its(:sync_method) { should be_nil }
     its(:keypair_name) { should be_nil }
     its(:public_key_path) { should be_nil }
     its(:availability_zone) { should be_nil }
@@ -55,11 +58,36 @@ describe VagrantPlugins::Openstack::Config do
       end
     end
 
+    describe 'use_legacy_synced_folders' do
+      it 'should default to true if sync_method is set' do
+        subject.sync_method = 'rsync'
+        subject.finalize!
+
+        expect(subject.use_legacy_synced_folders).to eq(true)
+      end
+
+      it 'should default to true if rsync_includes is non-empty' do
+        subject.rsync_includes = ['some/file']
+        subject.finalize!
+
+        expect(subject.use_legacy_synced_folders).to eq(true)
+      end
+
+      it 'should default to true if rsync_ignore_files is non-empty' do
+        subject.rsync_ignore_files = ['some/file']
+        subject.finalize!
+
+        expect(subject.use_legacy_synced_folders).to eq(true)
+      end
+    end
+
     it 'should not default rsync_includes if overridden' do
       inc = 'core'
       subject.send(:rsync_include, inc)
       subject.finalize!
-      subject.send(:rsync_includes).should include(inc)
+
+      expect(subject.rsync_includes).to include(inc)
+      expect(subject.use_legacy_synced_folders).to eq(true)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vagrant-openstack-provider
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.8.0
 platform: ruby
 authors:
 - Guillaume Giamarchi
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-30 00:00:00.000000000 Z
+date: 2016-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json