vagrant-openstack-provider 0.1.2 → 0.2.0

data/spec/vagrant-openstack-provider/client/utils_spec.rb

@@ -0,0 +1,125 @@
+require 'vagrant-openstack-provider/spec_helper'
+
+include VagrantPlugins::Openstack
+
+describe VagrantPlugins::Openstack::Utils do
+
+  let(:keystone) do
+    double('keystone').tap do |keystone|
+      keystone.stub(:authenticate).with(anything)
+    end
+  end
+
+  let(:env) do
+    Hash.new.tap do |env|
+      env[:ui] = double('ui')
+      env[:ui].stub(:warn).with(anything)
+      env[:openstack_client] = double('openstack_client')
+      env[:openstack_client].stub(:keystone) { keystone }
+    end
+  end
+
+  class TestUtils
+    include VagrantPlugins::Openstack::Utils
+    include VagrantPlugins::Openstack::Errors
+    def target(env)
+      authenticated(env) do
+        env[:target].call
+      end
+    end
+  end
+
+  def error
+    fail Errors::AuthenticationRequired
+  end
+
+  describe 'authenticated' do
+
+    before :each do
+      @utils = TestUtils.new
+    end
+
+    context 'with two authentication errors' do
+      it 'should retry two times and success' do
+        env[:target] = double.tap do |stub|
+          nb_calls = 0
+          stub.stub(:call) do
+            nb_calls += 1
+            fail Errors::AuthenticationRequired if nb_calls < 3
+          end.and_return('object response')
+        end
+        env[:target].should_receive(:call).exactly(3).times
+
+        response = @utils.target(env)
+
+        expect(response).to eq('object response')
+      end
+    end
+
+    context 'with three authentication errors' do
+      it 'should retry two times and fail' do
+        env[:target] = double.tap do |stub|
+          stub.stub(:call) do
+            fail Errors::AuthenticationRequired
+          end
+        end
+        env[:target].should_receive(:call).exactly(3).times
+
+        expect { @utils.target(env) }.to raise_error Errors::AuthenticationRequired
+      end
+    end
+  end
+
+  describe 'handle_response' do
+    before :each do
+      @utils = TestUtils.new
+    end
+
+    [200, 201, 202, 204].each do |code|
+      context "response code is #{code}" do
+        it 'should return the response' do
+          mock_resp = double.tap { |mock| mock.stub(:code).and_return(code) }
+          resp = @utils.handle_response(mock_resp)
+          expect(resp.code).to eq(code)
+        end
+      end
+    end
+
+    context 'response code is 401' do
+      it 'should return raise a AuthenticationRequired error' do
+        mock_resp = double.tap { |mock| mock.stub(:code).and_return(401) }
+        expect { @utils.handle_response(mock_resp) }.to raise_error Errors::AuthenticationRequired
+      end
+    end
+
+    context 'response code is 400' do
+      it 'should return raise a VagrantOpenstackError error with error message' do
+        mock_resp = double.tap do |mock|
+          mock.stub(:code).and_return(400)
+          mock.stub(:to_s).and_return('{ "badRequest": { "message": "Error... Bad request" } }')
+        end
+        begin
+          @utils.handle_response(mock_resp)
+          fail
+        rescue Errors::VagrantOpenstackError => e
+          expect(e.message).to eq('Error... Bad request')
+        end
+      end
+    end
+
+    context 'response code is 500' do
+      it 'should return raise a VagrantOpenstackError error with error message' do
+        mock_resp = double.tap do |mock|
+          mock.stub(:code).and_return(500)
+          mock.stub(:to_s).and_return('Internal server error')
+        end
+        begin
+          @utils.handle_response(mock_resp)
+          fail
+        rescue Errors::VagrantOpenstackError => e
+          expect(e.message).to eq('Internal server error')
+        end
+      end
+    end
+  end
+end

data/spec/vagrant-openstack-provider/config_spec.rb

@@ -0,0 +1,117 @@
+require 'vagrant-openstack-provider/spec_helper'
+
+describe VagrantPlugins::Openstack::Config do
+  describe 'defaults' do
+    let(:vagrant_public_key) { Vagrant.source_root.join('keys/vagrant.pub') }
+
+    subject do
+      super().tap do |o|
+        o.finalize!
+      end
+    end
+
+    its(:password)  { should be_nil }
+    its(:openstack_compute_url) { should be_nil }
+    its(:openstack_auth_url) { should be_nil }
+    its(:flavor)   { should be_nil }
+    its(:image)    { should be_nil }
+    its(:server_name) { should be_nil }
+    its(:username) { should be_nil }
+    its(:rsync_includes) { should be_nil }
+    its(:keypair_name) { should be_nil }
+    its(:ssh_username) { should be_nil }
+  end
+
+  describe 'overriding defaults' do
+    [
+      :password,
+      :openstack_compute_url,
+      :openstack_auth_url,
+      :flavor,
+      :image,
+      :server_name,
+      :username,
+      :keypair_name,
+      :ssh_username].each do |attribute|
+      it "should not default #{attribute} if overridden" do
+        subject.send("#{attribute}=".to_sym, 'foo')
+        subject.finalize!
+        subject.send(attribute).should == 'foo'
+      end
+    end
+
+    it 'should not default rsync_includes if overridden' do
+      inc = 'core'
+      subject.send(:rsync_include, inc)
+      subject.finalize!
+      subject.send(:rsync_includes).should include(inc)
+    end
+  end
+
+  describe 'validation' do
+    let(:machine) { double('machine') }
+    let(:validation_errors) { subject.validate(machine)['Openstack Provider'] }
+    let(:error_message) { double('error message') }
+
+    before(:each) do
+      machine.stub_chain(:env, :root_path).and_return '/'
+      subject.username = 'foo'
+      subject.password = 'bar'
+      subject.keypair_name = 'keypair'
+    end
+
+    subject do
+      super().tap do |o|
+        o.finalize!
+      end
+    end
+
+    context 'with invalid key' do
+      it 'should raise an error' do
+        subject.nonsense1 = true
+        subject.nonsense2 = false
+        I18n.should_receive(:t).with('vagrant.config.common.bad_field', fields: 'nonsense1, nonsense2').and_return error_message
+        validation_errors.first.should == error_message
+      end
+    end
+    context 'with good values' do
+      it 'should validate' do
+        validation_errors.should be_empty
+      end
+    end
+
+    context 'the keypair name' do
+      it 'should error if not given' do
+        subject.keypair_name = nil
+        I18n.should_receive(:t).with('vagrant_openstack.config.keypair_name_required').and_return error_message
+        validation_errors.first.should == error_message
+      end
+    end
+
+    context 'the API key' do
+      it 'should error if not given' do
+        subject.password = nil
+        I18n.should_receive(:t).with('vagrant_openstack.config.password_required').and_return error_message
+        validation_errors.first.should == error_message
+      end
+    end
+
+    context 'the username' do
+      it 'should error if not given' do
+        subject.username = nil
+        I18n.should_receive(:t).with('vagrant_openstack.config.username_required').and_return error_message
+        validation_errors.first.should == error_message
+      end
+    end
+
+    [:openstack_compute_url, :openstack_auth_url].each do |url|
+      context "the #{url}" do
+        it 'should not validate if the URL is invalid' do
+          subject.send "#{url}=", 'baz'
+          I18n.should_receive(:t).with('vagrant_openstack.config.invalid_uri', key: url, uri: 'baz').and_return error_message
+          validation_errors.first.should == error_message
+        end
+      end
+    end
+  end
+end

data/spec/vagrant-openstack-provider/provider_spec.rb

@@ -0,0 +1,13 @@
+require 'vagrant-openstack-provider/spec_helper'
+
+describe VagrantPlugins::Openstack::Provider do
+  before :each do
+    @provider = VagrantPlugins::Openstack::Provider.new :machine
+  end
+
+  describe 'to string' do
+    it 'should give the provider name' do
+      @provider.to_s.should eq('Openstack Cloud')
+    end
+  end
+end

data/spec/vagrant-openstack-provider/spec_helper.rb

@@ -0,0 +1,23 @@
+
+if ENV['COVERAGE'] != 'false'
+  require 'simplecov'
+  require 'coveralls'
+  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+      SimpleCov::Formatter::HTMLFormatter,
+      Coveralls::SimpleCov::Formatter
+  ]
+  SimpleCov.start do
+    add_filter 'spec'
+  end
+end
+
+Dir[
+  'lib/vagrant-openstack-provider/config.rb',
+  'lib/vagrant-openstack-provider/errors.rb',
+  'lib/vagrant-openstack-provider/provider.rb',
+  'lib/vagrant-openstack-provider/client/*.rb',
+  'lib/vagrant-openstack-provider/action/*.rb'].each { |file| require file[4, file.length - 1] }
+
+require 'webmock/rspec'
+
+I18n.load_path << File.expand_path('locales/en.yml', Pathname.new(File.expand_path('../../../', __FILE__)))

data/vagrant-openstack-provider.gemspec

@@ -1,23 +1,22 @@
-# -*- encoding: utf-8 -*-
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'vagrant-openstack-provider/version'
 
 Gem::Specification.new do |gem|
-  gem.name          = "vagrant-openstack-provider"
+  gem.name          = 'vagrant-openstack-provider'
   gem.version       = VagrantPlugins::Openstack::VERSION
-  gem.authors       = ["Guillaume Giamarchi", "Julien Vey"]
-  gem.email         = ["guillaume.giamarchi@gmail.com", "vey.julien@gmail.com"]
-  gem.description   = "Enables Vagrant to manage machines in Openstack Cloud."
-  gem.summary       = "Enables Vagrant to manage machines in Openstack Cloud."
-  gem.homepage      = "https://github.com/ggiamarchi/vagrant-openstack"
+  gem.authors       = ['Guillaume Giamarchi', 'Julien Vey']
+  gem.email         = ['guillaume.giamarchi@gmail.com', 'vey.julien@gmail.com']
+  gem.description   = 'Enables Vagrant to manage machines in Openstack Cloud.'
+  gem.summary       = 'Enables Vagrant to manage machines in Openstack Cloud.'
+  gem.homepage      = 'https://github.com/ggiamarchi/vagrant-openstack'
 
-  gem.add_development_dependency "rake"
-  gem.add_development_dependency "rspec", "~> 2.13.0"
-  gem.add_development_dependency "aruba"
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec', '~> 2.13.0'
+  gem.add_development_dependency 'aruba'
 
-  gem.files         = `git ls-files`.split($/)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.require_paths = ["lib"]
+  gem.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  gem.executables   = gem.files.grep(/^bin\//).map { |f| File.basename(f) }
+  gem.test_files    = gem.files.grep(/^(test|spec|features)\//)
+  gem.require_paths = ['lib']
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vagrant-openstack-provider
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Guillaume Giamarchi
@@ -9,48 +9,48 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-25 00:00:00.000000000 Z
+date: 2014-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.13.0
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Enables Vagrant to manage machines in Openstack Cloud.
@@ -61,7 +61,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
+- .gitignore
+- .rubocop.yml
 - Appraisals
 - CHANGELOG.md
 - Gemfile
@@ -72,12 +73,6 @@ files:
 - dummy.box
 - example_box/README.md
 - example_box/metadata.json
-- features/provision.feature
-- features/steps/sdk_steps.rb
-- features/steps/server_steps.rb
-- features/support/env.rb
-- features/support/fog_mock.rb
-- features/vagrant-openstack-provider.feature
 - gemfiles/latest_stable.gemfile
 - gemfiles/oldest_current.gemfile
 - gemfiles/previous_release.gemfile
@@ -86,21 +81,35 @@ files:
 - lib/vagrant-openstack-provider/action/connect_openstack.rb
 - lib/vagrant-openstack-provider/action/create_server.rb
 - lib/vagrant-openstack-provider/action/delete_server.rb
-- lib/vagrant-openstack-provider/action/is_created.rb
-- lib/vagrant-openstack-provider/action/message_already_created.rb
-- lib/vagrant-openstack-provider/action/message_not_created.rb
+- lib/vagrant-openstack-provider/action/message.rb
 - lib/vagrant-openstack-provider/action/read_ssh_info.rb
 - lib/vagrant-openstack-provider/action/read_state.rb
+- lib/vagrant-openstack-provider/action/resume.rb
+- lib/vagrant-openstack-provider/action/start_server.rb
+- lib/vagrant-openstack-provider/action/stop_server.rb
+- lib/vagrant-openstack-provider/action/suspend.rb
 - lib/vagrant-openstack-provider/action/sync_folders.rb
+- lib/vagrant-openstack-provider/action/wait_stop.rb
+- lib/vagrant-openstack-provider/client/keystone.rb
+- lib/vagrant-openstack-provider/client/neutron.rb
+- lib/vagrant-openstack-provider/client/nova.rb
+- lib/vagrant-openstack-provider/client/openstack.rb
+- lib/vagrant-openstack-provider/client/utils.rb
 - lib/vagrant-openstack-provider/config.rb
 - lib/vagrant-openstack-provider/errors.rb
-- lib/vagrant-openstack-provider/openstack_client.rb
 - lib/vagrant-openstack-provider/plugin.rb
 - lib/vagrant-openstack-provider/provider.rb
 - lib/vagrant-openstack-provider/version.rb
 - locales/en.yml
-- spec/vagrant-openstack/config_spec.rb
-- stackrc
+- numergyrc
+- spec/vagrant-openstack-provider/action/create_server_spec.rb
+- spec/vagrant-openstack-provider/client/keystone_spec.rb
+- spec/vagrant-openstack-provider/client/neutron_spec.rb
+- spec/vagrant-openstack-provider/client/nova_spec.rb
+- spec/vagrant-openstack-provider/client/utils_spec.rb
+- spec/vagrant-openstack-provider/config_spec.rb
+- spec/vagrant-openstack-provider/provider_spec.rb
+- spec/vagrant-openstack-provider/spec_helper.rb
 - vagrant-openstack-provider.gemspec
 homepage: https://github.com/ggiamarchi/vagrant-openstack
 licenses: []
@@ -111,12 +120,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -126,10 +135,11 @@ signing_key:
 specification_version: 4
 summary: Enables Vagrant to manage machines in Openstack Cloud.
 test_files:
-- features/provision.feature
-- features/steps/sdk_steps.rb
-- features/steps/server_steps.rb
-- features/support/env.rb
-- features/support/fog_mock.rb
-- features/vagrant-openstack-provider.feature
-- spec/vagrant-openstack/config_spec.rb
+- spec/vagrant-openstack-provider/action/create_server_spec.rb
+- spec/vagrant-openstack-provider/client/keystone_spec.rb
+- spec/vagrant-openstack-provider/client/neutron_spec.rb
+- spec/vagrant-openstack-provider/client/nova_spec.rb
+- spec/vagrant-openstack-provider/client/utils_spec.rb
+- spec/vagrant-openstack-provider/config_spec.rb
+- spec/vagrant-openstack-provider/provider_spec.rb
+- spec/vagrant-openstack-provider/spec_helper.rb