vagrant-openshift 3.0.8 → 3.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f801d1a034a23c6ed705d62ff7b4117170cf03b
-  data.tar.gz: ef9e37029fd017195bdd6752946d064a7eb34a37
+  metadata.gz: 17e68ca9975be343edfb92ff6834f5163b1a3563
+  data.tar.gz: 4f980dc0dfb287f8247fbec5600eab2bd463d6be
 SHA512:
-  metadata.gz: 3322ccb80bc697835fa435b6a2be8eaa7ef8eed49a8ef341d22a759a24aa13ab5e4473e041073e7f4a3c6b5a94b176e783aa9a433ade67d5ee4fbb66851c5d7f
-  data.tar.gz: ff6d96ec3325ef751c8209b09e73a50ef53590d6829628564b7641d10195609df8cc55114aeabbd198bc99854f1fc8a4315c1ab09c536b8fef9534bec76f3124
+  metadata.gz: c18a6ef845c6dfd0250bc560668de2a55bfbb9e27b9efe23708815b869dff5c49ac82fd54ee654314903e5b035856986ad82d1057b6085d382b185c40638be06
+  data.tar.gz: 0d3ae65ef3f0db3b31d8729980ceccbfe4b65cdb29de296ad89567368d595ea0ac6ab1fd976a3d4c114aa45f4ccb06275b4ef3a51aefb3bd1f5f721368cb61ea

data/.travis.yml

@@ -1,5 +1,10 @@
+before_install:
+  - gem uninstall bundler -aIxq --force
+  - gem uninstall -Ixq --force -i /home/travis/.rvm/gems/ruby-2.2.3@global bundler
+  - gem install bundler -v '1.12.5'
+
 rvm:
-  - 2.0.0
+  - 2.2.3
 
 gemfile: Gemfile
 

data/Gemfile

@@ -10,7 +10,11 @@ group :development do
   if File.exist?(File.expand_path("../../vagrant", __FILE__))
     gem "vagrant", path: "../vagrant"
   else
-    gem "vagrant", :git => "git://github.com/mitchellh/vagrant.git"
+    if Gem::Version.new(Bundler::VERSION) < Gem::Version.new("1.12.5")
+      gem "vagrant", :git => "https://github.com/mitchellh/vagrant", :ref => "v1.7.4"
+    else
+      gem "vagrant", :git => "https://github.com/mitchellh/vagrant"
+    end
   end
   gem "json"
 end

data/README.asciidoc

@@ -32,16 +32,19 @@ Like other plugins, this gem will be installed in your `~/.vagrant.d/gems/` dire
 To work on the *vagrant-openshift* plugin, clone this repository and use
 link:http://gembundler.com[Bundler] to get the dependencies:
 
+You *MUST* use bundler < = 1.10.5 or bundler = 1.12.5 when building this gem, as it is required by the vagrant gem.
+
 [source, sh]
 ----
-$ bundle
+$ gem install bundler -v '1.12.5'
+$ bundle _1.12.5_
 ----
 
 Compile using Rake:
 
 [source, sh]
 ----
-$ bundle exec rake
+$ bundle _1.12.5_ exec rake
 ----
 
 ===== From rubygems.org
@@ -103,7 +106,7 @@ NOTE: If you are trying to refresh an existing image, you'll want to remove the
 
 [source, sh]
 ----
-$ vagrant up
+$ vagrant up --provider=virtualbox
 ----
 
 NOTE: See link:#other-providers[Other Providers] below for launching VMs from other providers.
@@ -140,6 +143,44 @@ To enable easy customization of the build environment, any files placed under `\
 the vagrant user home directory. For example: `~/.openshiftdev/home.d/.bash_profile` will be copied to `.bash_profile`
 on the vagrant VM.
 
+==== Configuring Docker and Golang versions for tests
+
+If the version of OpenShift that is being tested requires a version
+of Golang or Docker that is not default in the RPM streams for the
+operating system used for the image, `vagrant-openshift` allows for
+customization of the image.
+
+To build a new image with the versions of Golang and Docker necessary,
+begin with an 'os' stage:
+[source, sh]
+----
+$ vagrant origin-init --stage os --os rhel7 --instance-type c4.xlarge "${instance_name}"
+----
+
+Then, you may provide the following information to customize your image:
+
+* URLs to repositories containing the desired Docker and/or Golang RPMs to use during the install
+* names of repositores already installed on the OS that you want to use during the install
+* versions of Golang and/or Docker to install
+
+Any RPM repositories you add by providing URLs will only be enabled for
+the duration of the installation. Only the repositories you provide using
+URLs or those that you name explcitly will be enabled during the install.
+
+For instance, some installation of  OpenShift Origin could want custom
+Go and Docker versions, both of which must be installed from custom URLs.
+Furthermore, some of the Docker dependencies may have up-to-date versions
+in the RHEL streams, so the following commands would be used to configure
+the image base:
+[source, sh]
+----
+$ vagrant install-golang --golang.repourl=http://some.golang.rpm.repository.com/ \
+                         --golang.version=1.6.2
+
+$ vagrant install-docker --docker.repourl=http://some.docker.rpm.repository.com/ \
+                         --docker.repo=oso-rhui-rhel-server-releases \
+                         --docker.version=1.10.3
+----
 
 === Other Providers
 
@@ -252,106 +293,53 @@ vagrant up --provider=openstack
 NOTE: Requires latest link:https://github.com/cloudbau/vagrant-openstack-plugin[OpenStack] provider.
 
 
-==== LibVirt
+==== Libvirt
 
-* Install the vagrant-libvirt plugin dependencies
+* If using a recent version of Fedora, you can install vagrant-libvirt directly using yum/dnf.  Otherwise you will need to follow the `vagrant plugin install` instructions below.
 
 [source, sh]
 ----
-yum install libxslt-devel libxml2-devel libvirt-devel ruby-devel rubygems
+sudo yum install vagrant-libvirt
 ----
 
-* Install the vagrant-libvirt plugin
+* Install the vagrant-libvirt plugin dependencies (only if `sudo yum install vagrant-libvirt` didn't work)
 
 [source, sh]
 ----
-vagrant plugin install vagrant-libvirt
+sudo yum install libxslt-devel libxml2-devel libvirt-devel ruby-devel rubygems
 ----
 
-NOTE: This may require modifying the system linker as described in
-      link:https://github.com/mitchellh/vagrant/issues/5118[this issue]:
+* Install the vagrant-libvirt plugin *(only if `sudo yum install vagrant-libvirt` didn't work)*
 
+[source, sh]
 ----
-# alternatives --set ld /usr/bin/ld.gold
+vagrant plugin install vagrant-libvirt
 ----
 
+NOTE: This may require modifying the system linker as described in
+      link:https://github.com/mitchellh/vagrant/issues/5118[this issue]:
 
-* Configure LibVirt to allow remote TLS connections
-** Create TLS certificates and key pairs. Follow the guide at http://libvirt.org/remote.html#Remote_certificates
-Example commands for creating a self signed certificate are provided below.
-
-.Example self-signed certificates
-[source, sh]
 ----
-mkdir -p /etc/pki/libvirt/private
-
-#CA Cert
-certtool --generate-privkey > cakey.pem
-
-cat <<EOF> ca.info
-cn = MyOrg
-ca
-cert_signing_key
-EOF
-
-certtool --generate-self-signed --load-privkey cakey.pem --template ca.info --outfile cacert.pem
-/bin/cp -f cacert.pem /etc/pki/CA/cacert.pem
-
-#Server cert
-certtool --generate-privkey > serverkey.pem
-
-cat <<EOF> server.info
-organization = MyOrg
-cn = oirase
-tls_www_server
-encryption_key
-signing_key
-EOF
-
-certtool --generate-certificate --load-privkey serverkey.pem \
-  --load-ca-certificate cacert.pem --load-ca-privkey cakey.pem \
-  --template server.info --outfile servercert.pem
-/bin/cp -f serverkey.pem /etc/pki/libvirt/private/serverkey.pem
-/bin/cp -f servercert.pem /etc/pki/libvirt/servercert.pem
-
-#Client cert
-certtool --generate-privkey > clientkey.pem
-
-cat <<EOF> client.info
-country = US
-state = California
-locality = Mountain View
-organization = MyOrg
-cn = client1
-tls_www_client
-encryption_key
-signing_key
-EOF
-
-certtool --generate-certificate --load-privkey clientkey.pem \
-  --load-ca-certificate cacert.pem --load-ca-privkey cakey.pem \
-  --template client.info --outfile clientcert.pem
-
-/bin/cp -f clientkey.pem /etc/pki/libvirt/private/clientkey.pem
-/bin/cp -f clientcert.pem /etc/pki/libvirt/clientcert.pem
+sudo alternatives --set ld /usr/bin/ld.gold
 ----
 
-** Modify /etc/sysconfig/libvirtd and enable listening to connections
+* Add your user to the libvirt group - this gives authorization to connect to libvirtd
 
+[source, sh]
 ----
-LIBVIRTD_ARGS="--listen"
+sudo usermod -a -G libvirt $USER
 ----
 
-** Restart libvirtd
+* Log out and log in for the group change to take effect
 
-* Start the LibVirt machine
+* Start the libvirt machine
 
 [source, sh]
 ----
 vagrant up --provider=libvirt
 ----
 
-NOTE: Requires latest link:https://github.com/pradels/vagrant-libvirt[LibVirt] provider
+NOTE: Requires latest link:https://github.com/pradels/vagrant-libvirt[libvirt] provider
 
 ===== Managed
 
@@ -420,20 +408,19 @@ $ vagrant build-origin --images
 $ vagrant build-sti --binary-only
 ----
 
-=== Testing openshift/origin-aggregated-logging
+=== Testing openshift/origin-aggregated-logging or openshift/origin-metrics
 
 NOTE: You will still need to clone the OpenShift Origin repo as above, in order
 to use the Vagrantfile and the contrib/vagrant directory.
-origin-aggregated-logging currently has no vagrant support.
+origin-aggregated-logging and origin-metrics currently have no vagrant support.
 
-==== Clone the OpenShift Origin aggregated logging repositories
+==== Clone the OpenShift Origin aggregated logging or metrics repositories
 
 Use `vagrant origin-local-checkout` as above link:#clone-the-openshift-origin-repositories[Clone the OpenShift Origin repositories], except use `--repo origin-aggregated-logging`:
 [source, sh]
 ----
 $ cd $GOPATH
-$ vagrant origin-local-checkout --repo origin-aggregated-logging -u <github
-username>
+$ vagrant origin-local-checkout --repo origin-aggregated-logging -u <github username>
 # run the remaining vagrant commands from $GOPATH/src/github.com/openshift/origin
 $ pushd $GOPATH/src/github.com/openshift/origin
 ----

data/hack/test.sh

@@ -0,0 +1,135 @@
+#!/bin/bash
+
+# This script uses the current state of the repository to build a new vagrant-openshift
+# gem, install it, and then exercise the CLI of the vagrant-openshfit plugin to test its
+# functionality. This script honors the following environment variables:
+#  - TEST_VM_NAME:    the name to use to identify the VM launched for testing
+#  - TEST_VM_SIZE:    the VM size (as the AWS instance name) to use
+#  - SKIP_INSTALL:    skips building and installing a new vagrant-openshift gem
+#  - SKIP_CLEANUP:    skips cleaning up the VMs created for tests
+#  - CLEANUP_RENAME:  cleans up instances by stopping and renaming instead of destroying them
+#  - GOPATH_OVERRIDE: uses a temporary directory for $GOPATH instead of inheriting it from the host
+#  - VERBOSE:         always show full command output, even a command succeeded
+
+set -o errexit
+set -o nounset
+set -o pipefail
+
+function cleanup_instance() {
+	pushd "${OS_ROOT}" >/dev/null 2>&1
+	if [[ -f ".vagrant-openshift.json" ]]; then
+		if [[ -n "${CLEANUP_RENAME:-}" ]]; then
+			vagrant modify-instance --stop --rename 'terminate'
+		else
+			vagrant destroy -f
+		fi
+	else
+		# we were not able to clean up the instance, but the code
+		# below will expect it to be gone and may fail later trying
+		# to re-create it due to a name conflict, so we need to
+		# fail early and loudly
+		echo "[FAILURE] Could not clean up instance, exiting"
+		exit 1
+	fi
+	rm -rf .vagrant
+	popd >/dev/null 2>&1
+}
+
+function conditional_cleanup_instance() {
+	if [[ -z "${SKIP_CLEANUP:-}" ]]; then
+		cleanup_instance
+	fi
+}
+
+# validate_version validates that the version of the package installed
+# on the remote VM is equal to the expected version provided
+function validate_version() {
+	local package=$1
+	local expected_version=$2
+	local actual_version
+	actual_version="$( vagrant ssh -c "rpm -q --queryformat='%{version}' '${package}'" )"
+	if [[ ! "${expected_version}" = "${actual_version}" ]]; then
+		echo "[FAILURE] Expected to find ${package}-${expected_version}, but got ${package}-${actual_version}."
+		return 1
+	fi
+	echo "[SUCCESS] Found ${package}-${actual_version} on the remote machine."
+}
+
+# test_vagrant runs a vagrant command and allows us to only show output from failed commands
+function test_vagrant() {
+	echo "[INFO] Testing \`vagrant $*\`"
+	if ! vagrant "$@" > /tmp/vagrant-openshift-test.log 2>&1; then
+		cat /tmp/vagrant-openshift-test.log
+		echo "[FAILURE] The command \`vagrant $*\` failed!"
+		return 1
+	elif [[ -n "${VERBOSE:-}" ]]; then
+		cat /tmp/vagrant-openshift-test.log
+	fi
+	echo "[SUCCESS] The command \`vagrant $*\` succeeded!"
+}
+
+# First, build the new vagrant-openshift gem and install the plugin on the host
+VOS_ROOT="$( cd "$( dirname "${BASH_SOURCE}" )/.."; pwd )"
+pushd "${VOS_ROOT}" >/dev/null 2>&1
+if [[ -z "${SKIP_INSTALL:-}" ]]; then
+	echo "[INFO] Building new vagrant-openshift gem and installing plugin"
+	hack/update.sh
+	vagrant plugin install vagrant-aws
+fi
+popd >/dev/null 2>&1
+
+OS_ROOT="./origin"
+if [[ -n "${GOPATH_OVERRIDE:-}" ]]; then
+	export GOPATH="${GOPATH_OVERRIDE}"
+	mkdir -p "${GOPATH}"
+	OS_ROOT="${GOPATH}/src/github.com/openshift/origin"
+fi
+
+test_vagrant origin-local-checkout --replace
+
+# Next, create a VM and run our tests in it
+pushd "${OS_ROOT}" >/dev/null 2>&1
+test_vagrant origin-init --stage="os"                                \
+                         --os="rhel7"                                \
+                         --instance-type="${TEST_VM_SIZE:-m4.large}" \
+                         "${TEST_VM_NAME:-vagrant-openshift-tests}"
+
+for _ in $(seq 0 2) ; do
+	if vagrant up --provider aws; then
+		break
+	fi
+
+	echo "[WARNING] \`vagrant up\` failed - retrying"
+	cleanup_instance
+done
+
+# We want to make sure we clean up after ourselves if this script exits unexpectedly
+trap conditional_cleanup_instance EXIT
+
+# The following steps ensure that we can build the `deps` image from the `os` base
+test_vagrant build-origin-base
+
+# Install Docker and Golang at specific versions
+test_vagrant install-golang --golang.version=1.6.3 \
+                            --repo=oso-rhui-rhel-server-releases-optional
+validate_version 'golang' '1.6.3'
+
+docker_repo='https://mirror.openshift.com/enterprise/rhel/dockerextra/x86_64/os/'
+test_vagrant install-docker --docker.version=1.12.2              \
+                            --repourl="${docker_repo}"           \
+                            --repo=oso-rhui-rhel-server-releases \
+                            --repo=oso-rhui-rhel-server-releases-optional
+validate_version 'docker' '1.12.2'
+
+test_vagrant clone-upstream-repos --clean
+test_vagrant checkout-repos
+test_vagrant build-origin-base-images
+test_vagrant install-origin-assets-base
+
+test_vagrant install-origin
+test_vagrant build-origin --images
+test_vagrant build-sti --binary-only
+
+popd  >/dev/null 2>&1
+
+echo "[SUCCESS] vagrant-openshift tests successful"

data/hack/update.sh

@@ -0,0 +1,32 @@
+#!/bin/bash
+
+# This script will attempt to build the vagrant-openshift gem
+# from the current source tree and install it locally in the
+# vagrant plugin environment.
+
+set -o errexit
+set -o nounset
+set -o pipefail
+
+VAGRANT_OPENSHIFT_ROOT="$( cd "$( dirname "${BASH_SOURCE}" )/.."; pwd )"
+pushd "${VAGRANT_OPENSHIFT_ROOT}" >/dev/null 2>&1
+
+if ! git diff-index --quiet HEAD; then
+	echo "[WARNING] Uncommited changes exist either in stage or in the working tree."
+	echo "[WARNING] Commit them to proceed in building the plugin."
+	exit 1
+fi
+
+echo "[INFO] Building vagrant-openshift gem using bundler..."
+{
+	bundle
+	bundle install
+	bundle exec rake
+} >/tmp/vagrant-origin-update.log 2>&1
+echo "[INFO] Full build and install logs placed at /tmp/vagrant-openshift-update.log"
+
+vagrant plugin install pkg/vagrant-openshift-*.gem
+
+popd >/dev/null 2>&1
+
+echo "[INFO] Successfully built and installed vagrant-openshift plugin"

data/lib/vagrant-openshift.rb

@@ -27,6 +27,7 @@ module Vagrant
     plugin_path = Pathname.new(File.expand_path("#{__FILE__}/../vagrant-openshift/"))
 
     autoload :CommandHelper, plugin_path + "helper/command_helper"
+    autoload :InstallHelper, plugin_path + "helper/install_helper"
     autoload :Constants, plugin_path + "constants"
   end
 end

data/lib/vagrant-openshift/action.rb

@@ -54,9 +54,20 @@ module Vagrant
         end
       end
 
+      def self.install_docker(options)
+        Vagrant::Action::Builder.new.tap do |b|
+          b.use InstallDocker, options
+        end
+      end
+
+      def self.install_golang(options)
+        Vagrant::Action::Builder.new.tap do |b|
+          b.use InstallGolang, options
+        end
+      end
+
       def self.install_origin(options)
         Vagrant::Action::Builder.new.tap do |b|
-          b.use YumUpdate
           b.use SetHostName
           b.use InstallOrigin
           b.use InstallOriginRhel7
@@ -135,7 +146,7 @@ module Vagrant
           end
         end
       end
-      
+
       def self.repo_sync_origin_console(options)
         Vagrant::Action::Builder.new.tap do |b|
           b.use PrepareSshConfig
@@ -146,12 +157,12 @@ module Vagrant
             end
             b.use SyncLocalRepository, :repo => 'origin-console'
             b.use CheckoutRepositories, :repo => 'origin-console'
-            if options[:build]            
+            if options[:build]
               b.use InstallOriginAssetDependencies, :restore_assets => true
-            end     
+            end
           end
         end
-      end      
+      end
 
       def self.repo_sync_origin_aggregated_logging(options)
         Vagrant::Action::Builder.new.tap do |b|
@@ -173,6 +184,34 @@ module Vagrant
         end
       end
 
+      def self.repo_sync_origin_metrics(options)
+        Vagrant::Action::Builder.new.tap do |b|
+          b.use PrepareSshConfig
+          if options[:source]
+            if options[:clean]
+              b.use Clean, options
+              b.use CloneUpstreamRepositories, options
+            end
+            b.use SyncLocalRepository, options
+            b.use CheckoutRepositories, options
+          end
+        end
+      end
+
+      def self.repo_sync_customer_diagnostics(options)
+        Vagrant::Action::Builder.new.tap do |b|
+          b.use PrepareSshConfig
+          if options[:source]
+            if options[:clean]
+              b.use Clean, options
+              b.use CloneUpstreamRepositories, options
+            end
+            b.use SyncLocalRepository, options
+            b.use CheckoutRepositories, options
+          end
+        end
+      end
+
       def self.local_origin_checkout(options)
         Vagrant::Action::Builder.new.tap do |b|
           if not options[:no_build]
@@ -190,18 +229,18 @@ module Vagrant
           b.use TestExitCode
         end
       end
-      
+
       def self.run_origin_asset_tests(options)
         Vagrant::Action::Builder.new.tap do |b|
           # UI integration tests require the api server to be running
-          b.use RunSystemctl, {:action => "start", :service => "openshift"}        
+          b.use RunSystemctl, {:action => "start", :service => "openshift"}
           b.use RunOriginAssetTests, options
           if options[:download]
             b.use DownloadArtifactsOriginConsole
           end
           b.use TestExitCode
         end
-      end      
+      end
 
       def self.run_origin_aggregated_logging_tests(options)
         Vagrant::Action::Builder.new.tap do |b|
@@ -213,6 +252,27 @@ module Vagrant
         end
       end
 
+      def self.run_origin_metrics_tests(options)
+        Vagrant::Action::Builder.new.tap do |b|
+          b.use RunOriginMetricsTests, options
+          if options[:download]
+            b.use DownloadArtifactsOriginMetrics
+          end
+          b.use TestExitCode
+        end
+      end
+
+      def self.run_customer_diagnostics_tests(options)
+        Vagrant::Action::Builder.new.tap do |b|
+          b.use RunCustomerDiagnosticsTests, options
+          if options[:download]
+            b.use DownloadArtifactsOriginMetrics
+          end
+          b.use TestExitCode
+        end
+      end
+
+
       def self.run_sti_tests(options)
         Vagrant::Action::Builder.new.tap do |b|
           b.use RunStiTests, options
@@ -240,12 +300,18 @@ module Vagrant
           b.use DownloadArtifactsOriginAggregatedLogging
         end
       end
-      
+
+      def self.download_origin_metrics_artifacts(options)
+        Vagrant::Action::Builder.new.tap do |b|
+          b.use DownloadArtifactsOriginMetrics
+        end
+      end
+
       def self.download_origin_console_artifacts(options)
         Vagrant::Action::Builder.new.tap do |b|
           b.use DownloadArtifactsOriginConsole
         end
-      end      
+      end
 
       def self.gen_template(options)
         Vagrant::Action::Builder.new.tap do |b|
@@ -310,6 +376,8 @@ module Vagrant
       autoload :SetHostName, action_root.join("set_host_name")
       autoload :YumUpdate, action_root.join("yum_update")
       autoload :InstallOriginBaseDependencies, action_root.join("install_origin_base_dependencies")
+      autoload :InstallDocker, action_root.join("install_docker")
+      autoload :InstallGolang, action_root.join("install_golang")
       autoload :InstallOriginAssetDependencies, action_root.join("install_origin_asset_dependencies")
       autoload :BuildOriginBaseImages, action_root.join("build_origin_base_images")
       autoload :PushOpenshiftImages, action_root.join("push_openshift_images")
@@ -324,17 +392,20 @@ module Vagrant
       autoload :LocalOriginCheckout, action_root.join("local_origin_checkout")
       autoload :CreateBareRepoPlaceholders, action_root.join("create_bare_repo_placeholders")
       autoload :RunOriginTests, action_root.join("run_origin_tests")
-      autoload :RunOriginAssetTests, action_root.join("run_origin_asset_tests")      
+      autoload :RunOriginAssetTests, action_root.join("run_origin_asset_tests")
       autoload :RunStiTests, action_root.join("run_sti_tests")
       autoload :RunOriginAggregatedLoggingTests, action_root.join("run_origin_aggregated_logging_tests")
+      autoload :RunOriginMetricsTests, action_root.join("run_origin_metrics_tests")
+      autoload :RunCustomerDiagnosticsTests, action_root.join("run_customer_diagnostics_tests")
       autoload :GenerateTemplate, action_root.join("generate_template")
       autoload :CreateAMI, action_root.join("create_ami")
       autoload :ModifyInstance, action_root.join("modify_instance")
       autoload :ModifyAMI, action_root.join("modify_ami")
       autoload :DownloadArtifactsOrigin, action_root.join("download_artifacts_origin")
-      autoload :DownloadArtifactsOriginConsole, action_root.join("download_artifacts_origin_console")      
+      autoload :DownloadArtifactsOriginConsole, action_root.join("download_artifacts_origin_console")
       autoload :DownloadArtifactsSti, action_root.join("download_artifacts_sti")
       autoload :DownloadArtifactsOriginAggregatedLogging, action_root.join("download_artifacts_origin_aggregated_logging")
+      autoload :DownloadArtifactsOriginMetrics, action_root.join("download_artifacts_origin_metrics")
       autoload :TestExitCode, action_root.join("test_exit_code")
       autoload :CleanNetworkSetup, action_root.join("clean_network_setup")
       autoload :RunSystemctl, action_root.join("run_systemctl")