vagrant-linode 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 512f23fdd3c5ee70ed9a4e3c49bb03225d751c62
-  data.tar.gz: 6bf4e88684a6bcfb94f182dfdef854096eefc586
+  metadata.gz: b9188fdd2aa3e774b85bab464f1b5830e4c3ed5c
+  data.tar.gz: 7d13d05b7f4ba405cc0cbf561f8db36955587fa0
 SHA512:
-  metadata.gz: 8ee6d317e49fc873b7f23c5cf47dfcc2b4a80c87556aeebfc307142bb94da6b4af86329ee116b90a08c38cbe844aee637cd8a9e90c8a7f9b360b576a1ff84788
-  data.tar.gz: 29c025f0a4dbcf30be82293d2dacae042ad53e33b015864278cc5710179add7599be813a55bee2e69bbc371bb0578039480a818ed40a86ca7794c4aae9fb9d63
+  metadata.gz: 96e2e509f49563c002ff8f8a0b6c510813fea9b5be9b175fc476f8a4b8e6d4aef5f7a65aefa9ede6104618652fa26891061f63b634abc71a832d0b4f08dcf8fa
+  data.tar.gz: aa390a2af81709249571b00dece9663ed946415cc16218fcfdb5fc8872d6f7d1b94b59b40c4634d99adf5d8b3b9a74a1dad77595aa54bd72a2bd973c713120e9

data/.rspec

@@ -1,7 +1,3 @@
---format
-doc
---order
-random
---color
---fail-fast
---backtrace
+--format doc
+--require spec_helper
+--order random

data/CHANGELOG.md

@@ -1,5 +1,7 @@
 Changelog
 =========
+v0.4.0 added support for Linode Volumes
+       added `vagrant linode volumes list` command
 v0.3.0 fixes for Vagrant 2.0.1 (now requires Ruby 2.2.0+)
        xen-only kernels are no longer available (Fixes KVM Grub options)
        rebuild command warns / quits if Linode is not powered down

data/Gemfile

@@ -1,5 +1,5 @@
 source 'https://rubygems.org'
-ruby '~> 2.2.0'
+ruby '>= 2.2.0'
 
 group :development do
   # We depend on Vagrant for development, but we don't add it as a
@@ -10,6 +10,10 @@ group :development do
   gem 'pry'
 end
 
+group :test do
+  gem 'rspec-its'
+end
+
 group :plugins do
   gemspec
 end

data/README.md

@@ -176,9 +176,27 @@ curl -X POST "https://api.linode.com/?api_action=avail.kernels" \
 
 More detail: [Linode API - Kernels](https://www.linode.com/api/utility/avail.kernels)
 
+### provider.volumes - [Volume Handling](https://www.linode.com/docs/platform/how-to-use-block-storage-with-your-linode/)
+
+The plugin can create and attach additional volumes when creating Linodes. `vagrant rebuild` calls will rebuild the VM only and reattach the volume afterwards without losing the contents.
+
+```rb
+config.vm.provider :linode do |linode|
+  linode.plan = "Linode 2048"
+  linode.volumes = [
+    {label: "extra_volume", size: 1},
+  ]
+end
+```
+
+NOTES:
+* The volume needs to be formatted and mounted inside the VM either manually or by a StackScript, etc.
+* The plugin doesn't do any volume metadata management. If a volume is renamed the next `vagrant up` call will create a new one.
+* Running `vagrant destroy` will **NOT** destroy the volumes.
+
 ### nfs.functional
 
-The sync provider, NFS, has been disabled to make rsync easier to use.  To enable NFS, 
+The sync provider, NFS, has been disabled to make rsync easier to use.  To enable NFS,
 run Vagrant with an environment variable `LINODE_NFS_FUNCTIONAL=1`.  This will require
 a bit more configuration between the Linode and the Vagrant host.
 
@@ -193,7 +211,7 @@ command:
 This command will create a new linode, setup your SSH key for authentication,
 create a new user account, and run the provisioners you have configured.
 
-The  environment variable `VAGRANT_DEFAULT_PROVIDER` can be set to `linode` to avoid sending `--provider=linode` on each `vagrant up`. 
+The  environment variable `VAGRANT_DEFAULT_PROVIDER` can be set to `linode` to avoid sending `--provider=linode` on each `vagrant up`.
 
 **Supported Commands**
 
@@ -233,6 +251,18 @@ You can now make modifications. Running `vagrant` within the Bundler
 environment will ensure that plugins installed in your Vagrant
 environment are not loaded.
 
+### Building and Publishing
+
+```
+vi lib/vagrant-linode/version.rb
+vi CHANGELOG.md
+git commit -m 'version 0.1.2' lib/vagrant-linode/version.rb CHANGELOG.md
+git tag -s v0.1.2
+git push --tags origin master
+gem build vagrant-linode.gemspec
+gem push vagrant-linode-0.1.2.gem
+```
+
 [![Join the chat at https://gitter.im/displague/vagrant-linode](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/displague/vagrant-linode?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![Code Climate](https://codeclimate.com/github/displague/vagrant-linode/badges/gpa.svg)](https://codeclimate.com/github/displague/vagrant-linode)
 [![Test Coverage](https://codeclimate.com/github/displague/vagrant-linode/badges/coverage.svg)](https://codeclimate.com/github/displague/vagrant-linode)

data/lib/vagrant-linode/actions.rb

@@ -256,6 +256,14 @@ module VagrantPlugins
         end
       end
 
+      def self.action_list_volumes
+        Vagrant::Action::Builder.new.tap do |b|
+          # b.use ConfigValidate # is this per machine?
+          b.use ConnectLinode
+          b.use ListVolumes
+        end
+      end
+
       action_root = Pathname.new(File.expand_path('../actions', __FILE__))
       autoload :ConnectLinode, action_root.join('connect_linode')
       autoload :ReadState, action_root.join('read_state')
@@ -284,6 +292,7 @@ module VagrantPlugins
       autoload :ListDistributions, action_root.join('list_distributions')
       autoload :ListKernels, action_root.join('list_kernels')
       autoload :ListDatacenters, action_root.join('list_datacenters')
+      autoload :ListVolumes, action_root.join('list_volumes')
     end
   end
 end

data/lib/vagrant-linode/actions/connect_linode.rb

@@ -1,4 +1,5 @@
 require 'log4r'
+require "vagrant-linode/client_wrapper"
 
 module VagrantPlugins
   module Linode
@@ -25,7 +26,7 @@ module VagrantPlugins
 
           @logger.info('Connecting to Linode api_url...')
 
-          linode = ::LinodeAPI::Retryable.new params
+          linode = ClientWrapper.new(::LinodeAPI::Retryable.new(params), env[:ui])
           env[:linode_api] = linode
 
           @app.call(env)

data/lib/vagrant-linode/actions/create.rb

@@ -1,6 +1,7 @@
 require 'vagrant-linode/helpers/client'
 require 'vagrant-linode/helpers/waiter'
 require 'vagrant-linode/errors'
+require 'vagrant-linode/services/volume_manager'
 
 module VagrantPlugins
   module Linode
@@ -122,21 +123,21 @@ module VagrantPlugins
             datacenterid: datacenter_id,
             paymentterm: @machine.provider_config.paymentterm || 1
           )
-          env[:ui].info I18n.t('vagrant_linode.info.created', linodeid: result['linodeid'], label: (@machine.provider_config.label or "linode#{result['linodeid']}"))
+          @machine.id = result['linodeid'].to_s
+          env[:ui].info I18n.t('vagrant_linode.info.created', linodeid: @machine.id, label: (@machine.provider_config.label or "linode#{@machine.id}"))
 
-          # @client.linode.job.list(:linodeid => result['linodeid'], :pendingonly => 1)
+          # @client.linode.job.list(:linodeid => @machine.id, :pendingonly => 1)
           # assign the machine id for reference in other commands
-          @machine.id = result['linodeid'].to_s
 
           disklist = []
 
           if stackscript_id
             disk = @client.linode.disk.createfromstackscript(
-              linodeid: result['linodeid'],
+              linodeid: @machine.id,
               stackscriptid: stackscript_id,
               stackscriptudfresponses: JSON.dump(stackscript_udf_responses),
               distributionid: distribution_id,
-              label: 'Vagrant Disk Distribution ' + distribution_id.to_s + ' Linode ' + result['linodeid'].to_s,
+              label: 'Vagrant Disk Distribution ' + distribution_id.to_s + ' Linode ' + @machine.id,
               type: 'ext4',
               size: xvda_size,
               rootsshkey: pubkey,
@@ -145,9 +146,9 @@ module VagrantPlugins
             disklist.push(disk['diskid'])
           elsif distribution_id
             disk = @client.linode.disk.createfromdistribution(
-              linodeid: result['linodeid'],
+              linodeid: @machine.id,
               distributionid: distribution_id,
-              label: 'Vagrant Disk Distribution ' + distribution_id.to_s + ' Linode ' + result['linodeid'].to_s,
+              label: 'Vagrant Disk Distribution ' + distribution_id.to_s + ' Linode ' + @machine.id,
               type: 'ext4',
               size: xvda_size,
               rootsshkey: pubkey,
@@ -156,9 +157,9 @@ module VagrantPlugins
             disklist.push(disk['diskid'])
           elsif image_id
             disk = @client.linode.disk.createfromimage(
-              linodeid: result['linodeid'],
+              linodeid: @machine.id,
               imageid: image_id,
-              label: 'Vagrant Disk Image (' + image_id.to_s + ') for ' + result['linodeid'].to_s,
+              label: 'Vagrant Disk Image (' + image_id.to_s + ') for ' + @machine.id,
               size: xvda_size,
               rootsshkey: pubkey,
               rootpass: root_pass
@@ -170,7 +171,7 @@ module VagrantPlugins
 
           if swap_size > 0
             swap = @client.linode.disk.create(
-              linodeid: result['linodeid'],
+              linodeid: @machine.id,
               label: 'Vagrant swap',
               type: 'swap',
               size: swap_size
@@ -183,8 +184,8 @@ module VagrantPlugins
           if xvdc_size > 0
             xvdc_type = @machine.provider_config.xvdc_type.is_a?(Vagrant::Config::V2::DummyConfig) ? "raw" : @machine.provider_config.xvdc_type
             xvdc = @client.linode.disk.create(
-              linodeid: result['linodeid'],
-              label: 'Vagrant Leftover Disk Linode ' + result['linodeid'].to_s,
+              linodeid: @machine.id,
+              label: 'Vagrant Leftover Disk Linode ' + @machine.id,
               type: xvdc_type,
               size: xvdc_size,
             )
@@ -194,7 +195,7 @@ module VagrantPlugins
           end
 
           config = @client.linode.config.create(
-            linodeid: result['linodeid'],
+            linodeid: @machine.id,
             label: 'Vagrant Config',
             disklist: disklist.join(','),
             kernelid: kernel_id
@@ -202,7 +203,7 @@ module VagrantPlugins
 
           # @todo: allow provisioning to set static configuration for networking
           if @machine.provider_config.private_networking
-            private_network = @client.linode.ip.addprivate linodeid: result['linodeid']
+            private_network = @client.linode.ip.addprivate linodeid: @machine.id
           end
 
           label = @machine.provider_config.label
@@ -212,16 +213,18 @@ module VagrantPlugins
           group = @machine.provider_config.group
           group = "" if @machine.provider_config.group == false
 
+          Services::VolumeManager.new(@machine, @client.volume, env[:ui]).perform
+
           result = @client.linode.update(
-            linodeid: result['linodeid'],
+            linodeid: @machine.id,
             label: label,
             lpm_displaygroup: group
           )
 
-          env[:ui].info I18n.t('vagrant_linode.info.booting', linodeid: result['linodeid'])
+          env[:ui].info I18n.t('vagrant_linode.info.booting', linodeid: @machine.id)
 
-          bootjob = @client.linode.boot linodeid: result['linodeid']
-          # sleep 1 until ! @client.linode.job.list(:linodeid => result['linodeid'], :jobid => bootjob['jobid'], :pendingonly => 1).length
+          bootjob = @client.linode.boot linodeid: @machine.id
+          # sleep 1 until ! @client.linode.job.list(:linodeid => @machine.id, :jobid => bootjob['jobid'], :pendingonly => 1).length
           wait_for_event(env, bootjob['jobid'])
 
           # refresh linode state with provider and output ip address

data/lib/vagrant-linode/actions/list_volumes.rb

@@ -0,0 +1,50 @@
+module VagrantPlugins
+  module Linode
+    module Actions
+      class ListVolumes
+        def initialize(app, _env)
+          @app = app
+        end
+
+        def call(env)
+          api = env[:linode_api]
+          logger = env[:ui]
+          machine = env[:machine]
+
+          remote_volumes = api.volume.list
+          volume_definitions = machine.provider_config.volumes
+
+          volume_definitions.each do |volume|
+            volume_label = "#{machine.name}_#{volume[:label]}"
+            remote_volume = remote_volumes.find { |v| v.label == volume_label }
+
+            if remote_volume.nil?
+              logger.info format_volume(volume_label, "does not exist")
+              next
+            end
+
+            logger.info format_volume(volume_label, volume_state(machine, remote_volume))
+          end
+
+          @app.call(env)
+        end
+
+        private
+
+        def volume_state(machine, volume)
+          if volume.linodeid.to_s == machine.id
+            "attached"
+          elsif volume.linodeid == 0
+            "detached"
+          else
+            "attached to other VM"
+          end
+        end
+
+        def format_volume(label, state)
+          "volume \"%s\": %s" % [label, state]
+        end
+      end
+    end
+  end
+end

data/lib/vagrant-linode/actions/rebuild.rb

@@ -1,6 +1,7 @@
 require 'vagrant-linode/helpers/client'
 require 'vagrant-linode/helpers/waiter'
 require 'vagrant-linode/errors'
+require 'vagrant-linode/services/volume_manager'
 
 module VagrantPlugins
   module Linode
@@ -101,7 +102,7 @@ module VagrantPlugins
             fail Errors::PlanID, plan: @machine.provider_config.planid if plan.nil?
             plan_id = @machine.provider_config.planid
           end
-          
+
           ### Disk Images
           xvda_size, swap_size, disk_sanity = @machine.provider_config.xvda_size, @machine.provider_config.swap_size, true
 
@@ -143,7 +144,7 @@ module VagrantPlugins
               jobid: job
             )
 
-            while jobStatus[0]['host_finish_dt'].nil? || jobStatus[0]['host_finish_dt'].empty? do 
+            while jobStatus[0]['host_finish_dt'].nil? || jobStatus[0]['host_finish_dt'].empty? do
               sleep(5)
               jobStatus = @client.linode.job.list(
                 linodeid: @machine.id,
@@ -238,6 +239,8 @@ module VagrantPlugins
           group = @machine.provider_config.group
           group = "" if @machine.provider_config.group == false
 
+          Services::VolumeManager.new(@machine, @client.volume, env[:ui]).perform
+
           result = @client.linode.update(
             linodeid: @machine.id,
             label: label,
@@ -276,7 +279,7 @@ module VagrantPlugins
 
           @app.call(env)
         end
-        
+
         def get_server_name
           "vagrant_linode-#{rand.to_s.split('.')[1]}"
         end

data/lib/vagrant-linode/client_wrapper.rb

@@ -0,0 +1,25 @@
+require "log4r"
+
+module VagrantPlugins
+  module Linode
+    class ClientWrapper
+      def initialize(client, logger)
+        @client = client
+        @logger = logger
+      end
+
+      def method_missing(method, *args, &block)
+        result = @client.send(method, *args, &block)
+
+        if result.is_a? LinodeAPI::Retryable
+          self.class.new(result, @logger)
+        else
+          result
+        end
+      rescue ::LinodeAPI::APIError => e
+        @logger.error e.details.inspect
+        raise
+      end
+    end
+  end
+end

data/lib/vagrant-linode/commands/list_volumes.rb

@@ -0,0 +1,20 @@
+module VagrantPlugins
+  module Linode
+    module Commands
+      class ListVolumes < Vagrant.plugin('2', :command)
+        def execute
+          opts = OptionParser.new do |o|
+            o.banner = 'Usage: vagrant linode volumes list [options]'
+          end
+
+          argv = parse_options(opts)
+          return unless argv
+
+          with_target_vms(argv) do |machine|
+            machine.action(:list_volumes)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/vagrant-linode/commands/root.rb

@@ -40,6 +40,10 @@ module VagrantPlugins
             require File.expand_path('../servers', __FILE__)
             Servers
           end
+          @subcommands.register(:volumes) do
+            require File.expand_path('../volumes', __FILE__)
+            Volumes
+          end
 
           super(argv, env)
         end

data/lib/vagrant-linode/commands/volumes.rb

@@ -0,0 +1,55 @@
+module VagrantPlugins
+  module Linode
+    module Commands
+      class Volumes < Vagrant.plugin('2', :command)
+        def initialize(argv, env)
+          @main_args, @sub_command, @sub_args = split_main_and_subcommand(argv)
+
+          @subcommands = Vagrant::Registry.new
+          @subcommands.register(:list) do
+            require File.expand_path('../list_volumes', __FILE__)
+            ListVolumes
+          end
+
+          super(argv, env)
+        end
+
+        def execute
+          if @main_args.include?('-h') || @main_args.include?('--help')
+            # Print the help for all the rackspace commands.
+            return help
+          end
+
+          command_class = @subcommands.get(@sub_command.to_sym) if @sub_command
+          return help if !command_class || !@sub_command
+          @logger.debug("Invoking command class: #{command_class} #{@sub_args.inspect}")
+
+          # Initialize and execute the command class
+          command_class.new(@sub_args, @env).execute
+        end
+
+        def help
+          opts = OptionParser.new do |opts|
+            opts.banner = 'Usage: vagrant linode volumes <subcommand> [<args>]'
+            opts.separator ''
+            opts.separator 'Available subcommands:'
+
+            # Add the available subcommands as separators in order to print them
+            # out as well.
+            keys = []
+            @subcommands.each { |key, _value| keys << key.to_s }
+
+            keys.sort.each do |key|
+              opts.separator "     #{key}"
+            end
+
+            opts.separator ''
+            opts.separator 'For help on any individual subcommand run `vagrant linode volumes <subcommand> -h`'
+          end
+
+          @env.ui.info(opts.help, prefix: false)
+        end
+      end
+    end
+  end
+end

data/lib/vagrant-linode/config.rb

@@ -26,6 +26,7 @@ module VagrantPlugins
       attr_accessor :kernel
       attr_accessor :label
       attr_accessor :group
+      attr_accessor :volumes
 
       alias_method :setup?, :setup
 
@@ -57,6 +58,7 @@ module VagrantPlugins
         @kernel             = UNSET_VALUE
         @label              = UNSET_VALUE
         @group              = UNSET_VALUE
+        @volumes            = UNSET_VALUE
       end
 
       def finalize!
@@ -90,6 +92,7 @@ module VagrantPlugins
         @kernel             = 'Latest 64 bit' if @kernel.nil? and @kernelid.nil?
         @label              = false if @label == UNSET_VALUE
         @group              = false if @group == UNSET_VALUE
+        @volumes            = [] if @volumes == UNSET_VALUE
       end
 
       def validate(machine)
@@ -134,6 +137,10 @@ module VagrantPlugins
           errors << I18n.t('vagrant_linode.config.distribution_or_image')
         end
 
+        if !@volumes.is_a? Array
+          errors << I18n.t("vagrant_linode.config.volumes")
+        end
+
         { 'Linode Provider' => errors }
       end
     end

data/lib/vagrant-linode/errors.rb

@@ -20,7 +20,7 @@ module VagrantPlugins
       class DatacenterMatch < LinodeError
         error_key(:datacenter_match)
       end
- 
+
       class ImageMatch < LinodeError
         error_key(:image_match)
       end
@@ -64,6 +64,14 @@ module VagrantPlugins
       class StackscriptUDFFormat < LinodeError
         error_key(:stackscript_udf_responses)
       end
+
+      class VolumeSizeMissing < LinodeError
+        error_key(:volume_size_missing)
+      end
+
+      class VolumeLabelMissing < LinodeError
+        error_key(:volume_label_missing)
+      end
     end
   end
 end

data/lib/vagrant-linode/services/volume_manager.rb

@@ -0,0 +1,59 @@
+require "vagrant-linode/errors"
+
+module VagrantPlugins
+  module Linode
+    module Services
+      class VolumeManager
+        def initialize(machine, api, logger)
+          @machine = machine
+          @volumes_api = api
+          @logger = logger
+        end
+
+        def perform
+          volume_definitions.each do |volume|
+            raise Errors::VolumeLabelMissing if volume[:label].to_s.empty?
+
+            volume_name = "#{@machine.name}_#{volume[:label]}"
+
+            remote_volume = remote_volumes.find { |v| v.label == volume_name }
+            if remote_volume
+              attach_volume(remote_volume)
+            else
+              create_and_attach_volume(volume_name, volume[:size])
+            end
+          end
+        end
+
+        private
+
+        def volume_definitions
+          @machine.provider_config.volumes
+        end
+
+        def remote_volumes
+          @_remote_volumes ||= @volumes_api.list
+        end
+
+        def attach_volume(volume)
+          @volumes_api.update(
+            volumeid: volume.volumeid,
+            linodeid: @machine.id
+          )
+          @logger.info "volume #{volume.label} attached"
+        end
+
+        def create_and_attach_volume(label, size)
+          raise Errors::VolumeSizeMissing unless size.to_i > 0
+
+          @volumes_api.create(
+            label: label,
+            size: size,
+            linodeid: @machine.id
+          )
+          @logger.info "volume #{label} created and attached"
+        end
+      end
+    end
+  end
+end

data/lib/vagrant-linode/version.rb

@@ -1,5 +1,5 @@
 module VagrantPlugins
   module Linode
-    VERSION = '0.3.0'
+    VERSION = '0.4.0'
   end
 end

data/locales/en.yml

@@ -52,6 +52,7 @@ en:
       kernelid_or_kernel: "Use either kernelid or kernel, not both"
       imageid_or_image: "Use either imageid or image, not both"
       distribution_or_image: "Distribution can not be specified with Image options"
+      volumes: "Volumes must be an array of disks"
     errors:
       public_key: |-
         There was an issue reading the public key at:
@@ -133,3 +134,5 @@ en:
         Supported distributions can be found at the following url - https://manager.linode.com/stackscripts
       stackscript_udf_responses: !-
         The stackscript UDF responses object provided is of the wrong type. It should be a Hash.
+      volume_size_missing: For volumes that need to be created the size has to be specified.
+      volume_label_missing: You must specify a volume label.

data/spec/spec_helper.rb

@@ -1,10 +1,10 @@
 if ENV['COVERAGE'] != 'false'
   require 'simplecov'
   require 'coveralls'
-  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
     SimpleCov::Formatter::HTMLFormatter,
     Coveralls::SimpleCov::Formatter
-  ]
+  ])
   SimpleCov.start
 
   # Normally classes are lazily loaded, so any class without a test
@@ -17,4 +17,8 @@ if ENV['COVERAGE'] != 'false'
   end
 end
 
-require 'linode'
+require 'pry'
+require 'rspec/its'
+
+I18n.load_path << 'locales/en.yml'
+I18n.reload!

data/spec/vagrant-linode/services/volume_manager_spec.rb

@@ -0,0 +1,42 @@
+require "vagrant-linode/services/volume_manager"
+
+describe VagrantPlugins::Linode::Services::VolumeManager do
+  subject { described_class.new(machine, client, logger) }
+  let(:provider_config) { double(:config, volumes: [{label: "testvolume", size: 3}]) }
+  let(:machine) { double(:machine, id: 123, name: "test", provider_config: provider_config) }
+  let(:logger) { double(:logger, info: nil) }
+  let(:remote_volumes) { [double(:volume, volumeid: 234, size: 3, label: "test_testvolume")] }
+  let(:client) { double(:api, list: remote_volumes) }
+
+  describe "#perform" do
+    context "when the volume label is not specified" do
+      let(:provider_config) { double(:config, volumes: [{size: 3}]) }
+      it "raises an error" do
+        expect { subject.perform }.to raise_error "You must specify a volume label."
+      end
+    end
+
+    context "when the remote volume does not exist" do
+      let(:remote_volumes) { [] }
+      it "creates the volume bound to the linode" do
+        expect(client).to receive(:create).with(label: "test_testvolume", size: 3, linodeid: 123)
+        subject.perform
+      end
+
+      context "when the size is not specified" do
+        let(:provider_config) { double(:config, volumes: [{label: "testvolume"}]) }
+        it "raises an error" do
+          expect { subject.perform }.to raise_error "For volumes that need to be created the size has to be specified."
+        end
+      end
+    end
+
+    context "when the remote volume exists" do
+      let(:remote_volumes) { [double(:volume, volumeid: 234, size: 3, label: "test_testvolume")] }
+      it "attaches the volume to the machine" do
+        expect(client).to receive(:update).with(volumeid: 234, linodeid: 123)
+        subject.perform
+      end
+    end
+  end
+end

data/test/Vagrantfile

@@ -2,14 +2,14 @@
 # vi: set ft=ruby :
 
 Vagrant.configure('2') do |config|
-  #config.ssh.username = 'tester'
-  config.ssh.private_key_path = '~/.ssh/id_rsa'
+  config.ssh.username = 'tester'
+  config.ssh.private_key_path = './test_id_rsa'
 
-  #config.vm.synced_folder '.', '/vagrant', disabled: true
-  config.vm.network 'forwarded_port', guest: 8080, host: 80
+  config.vm.synced_folder '.', '/vagrant', disabled: true
 
   config.vm.provider :linode do |provider, override|
     override.vm.box = 'linode'
+    override.vm.box_url = 'https://github.com/displague/vagrant-linode/raw/master/box/linode.box'
     provider.api_key = ENV['LINODE_API_KEY']
     provider.ssh_key_name = 'Test Key'
     provider.distribution = 'Debian 8'
@@ -17,7 +17,6 @@ Vagrant.configure('2') do |config|
     provider.plan = '2048'
     provider.label = 'vagrant-'+Time.new.strftime("%F%T").gsub(/[^0-9]/,'')
 
-
     # Disk Image Sizes (Optional configuration)
 
     # Main Disk Image Size
@@ -40,18 +39,17 @@ Vagrant.configure('2') do |config|
     # provider.private_networking = true
   end
 
-  #config.vm.provision :shell, path: 'scripts/provision.sh'
+  config.vm.provision :shell, path: 'scripts/provision.sh'
 
-  #config.vm.provision :chef_solo do |chef|
-  #  chef.cookbooks_path = 'cookbooks'
-  #  chef.add_recipe 'test'
-  #end
+  config.vm.provision :chef_solo do |chef|
+    chef.cookbooks_path = 'cookbooks'
+    chef.add_recipe 'test'
+  end
 
   # Linode Specific Configurations
   config.vm.define :ubuntu do |ubuntu|
     ubuntu.vm.provider :linode do |provider|
-      provider.distribution = 'Ubuntu 16.04'
-      config.vm.provision :shell, inline: 'sudo apt-get install -y apache2'
+      provider.distribution = 'Ubuntu 14.04 LTS'
 
       # Optional Settings
       provider.label = 'Vagrant-Ubuntu'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vagrant-linode
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Marques Johansson
@@ -9,62 +9,62 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-19 00:00:00.000000000 Z
+date: 2017-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: linodeapi
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.0.1
 - !ruby/object:Gem::Dependency
   name: log4r
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.5'
 description: Enables Vagrant to manage Linode linodes
@@ -75,10 +75,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
+- .gitignore
+- .rspec
+- .rubocop.yml
+- .rubocop_todo.yml
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -104,6 +104,7 @@ files:
 - lib/vagrant-linode/actions/list_kernels.rb
 - lib/vagrant-linode/actions/list_plans.rb
 - lib/vagrant-linode/actions/list_servers.rb
+- lib/vagrant-linode/actions/list_volumes.rb
 - lib/vagrant-linode/actions/message_already_active.rb
 - lib/vagrant-linode/actions/message_already_off.rb
 - lib/vagrant-linode/actions/message_not_created.rb
@@ -119,17 +120,20 @@ files:
 - lib/vagrant-linode/actions/setup_hostname.rb
 - lib/vagrant-linode/actions/setup_sudo.rb
 - lib/vagrant-linode/actions/setup_user.rb
+- lib/vagrant-linode/client_wrapper.rb
 - lib/vagrant-linode/commands/create_image.rb
 - lib/vagrant-linode/commands/datacenters.rb
 - lib/vagrant-linode/commands/distributions.rb
 - lib/vagrant-linode/commands/images.rb
 - lib/vagrant-linode/commands/kernels.rb
 - lib/vagrant-linode/commands/list_images.rb
+- lib/vagrant-linode/commands/list_volumes.rb
 - lib/vagrant-linode/commands/networks.rb
 - lib/vagrant-linode/commands/plans.rb
 - lib/vagrant-linode/commands/rebuild.rb
 - lib/vagrant-linode/commands/root.rb
 - lib/vagrant-linode/commands/servers.rb
+- lib/vagrant-linode/commands/volumes.rb
 - lib/vagrant-linode/config.rb
 - lib/vagrant-linode/errors.rb
 - lib/vagrant-linode/helpers/client.rb
@@ -137,12 +141,14 @@ files:
 - lib/vagrant-linode/helpers/waiter.rb
 - lib/vagrant-linode/plugin.rb
 - lib/vagrant-linode/provider.rb
+- lib/vagrant-linode/services/volume_manager.rb
 - lib/vagrant-linode/version.rb
 - locales/en.yml
 - spec/spec_helper.rb
 - spec/vagrant-linode/actions/list_distributions_spec.rb
 - spec/vagrant-linode/actions/list_plans_spec.rb
 - spec/vagrant-linode/config_spec.rb
+- spec/vagrant-linode/services/volume_manager_spec.rb
 - test/Vagrantfile
 - test/cookbooks/test/recipes/default.rb
 - test/scripts/provision.sh
@@ -160,17 +166,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.3
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Enables Vagrant to manage Linode linodes
@@ -179,6 +185,7 @@ test_files:
 - spec/vagrant-linode/actions/list_distributions_spec.rb
 - spec/vagrant-linode/actions/list_plans_spec.rb
 - spec/vagrant-linode/config_spec.rb
+- spec/vagrant-linode/services/volume_manager_spec.rb
 - test/Vagrantfile
 - test/cookbooks/test/recipes/default.rb
 - test/scripts/provision.sh