vagrant-libvirt 0.9.0 → 0.10.0

data/spec/unit/action/create_domain_spec/sysinfo.xml

@@ -0,0 +1,66 @@
+<domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'>
+  <name>vagrant-test_default</name>
+  <title></title>
+  <description>Source: /rootpath/Vagrantfile</description>
+  <uuid></uuid>
+  <memory>524288</memory>
+  <vcpu>1</vcpu>
+  <cpu mode='host-model'>
+    <model fallback='allow'></model>
+  </cpu>
+  <os>
+    <type>hvm</type>
+    <kernel></kernel>
+    <initrd></initrd>
+    <cmdline></cmdline>
+    <smbios mode='sysinfo'/>
+  </os>
+  <sysinfo type='smbios'>
+    <bios>
+      <entry name='vendor'>Test Vendor</entry>
+    </bios>
+    <system>
+      <entry name='manufacturer'>Test Manufacturer</entry>
+      <entry name='version'>0.1.0</entry>
+    </system>
+    <baseBoard>
+      <entry name='manufacturer'>Test Manufacturer</entry>
+    </baseBoard>
+    <chassis>
+      <entry name='manufacturer'>Test Manufacturer</entry>
+      <entry name='serial'>AABBCCDDEE</entry>
+    </chassis>
+    <oemStrings>
+      <entry>app1: string1</entry>
+      <entry>app1: string2</entry>
+      <entry>app2: string1</entry>
+      <entry>app2: string2</entry>
+    </oemStrings>
+  </sysinfo>
+  <features>
+    <acpi/>
+    <apic/>
+    <pae/>
+  </features>
+  <clock offset='utc'>
+  </clock>
+  <devices>
+    <disk type='file' device='disk'>
+      <alias name='ua-box-volume-0'/>
+      <driver name='qemu' type='qcow2' cache='default'/>
+      <source file='/var/lib/libvirt/images/vagrant-test_default.img'/>
+      <target dev='vda' bus='virtio'/>
+    </disk>
+    <serial type='pty'>
+      <target port='0'/>
+    </serial>
+    <console type='pty'>
+      <target port='0'/>
+    </console>
+    <input type='mouse' bus='ps2'/>
+    <graphics type='vnc' port='-1' autoport='yes' listen='127.0.0.1' keymap='en-us'/>
+    <video>
+      <model type='cirrus' vram='16384' heads='1'/>
+    </video>
+  </devices>
+</domain>

data/spec/unit/action/create_domain_spec/sysinfo_only_required.xml

@@ -0,0 +1,49 @@
+<domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'>
+  <name>vagrant-test_default</name>
+  <title></title>
+  <description>Source: /rootpath/Vagrantfile</description>
+  <uuid></uuid>
+  <memory>524288</memory>
+  <vcpu>1</vcpu>
+  <cpu mode='host-model'>
+    <model fallback='allow'></model>
+  </cpu>
+  <os>
+    <type>hvm</type>
+    <kernel></kernel>
+    <initrd></initrd>
+    <cmdline></cmdline>
+    <smbios mode='sysinfo'/>
+  </os>
+  <sysinfo type='smbios'>
+    <bios>
+      <entry name='vendor'>Test Vendor</entry>
+    </bios>
+  </sysinfo>
+  <features>
+    <acpi/>
+    <apic/>
+    <pae/>
+  </features>
+  <clock offset='utc'>
+  </clock>
+  <devices>
+    <disk type='file' device='disk'>
+      <alias name='ua-box-volume-0'/>
+      <driver name='qemu' type='qcow2' cache='default'/>
+      <source file='/var/lib/libvirt/images/vagrant-test_default.img'/>
+      <target dev='vda' bus='virtio'/>
+    </disk>
+    <serial type='pty'>
+      <target port='0'/>
+    </serial>
+    <console type='pty'>
+      <target port='0'/>
+    </console>
+    <input type='mouse' bus='ps2'/>
+    <graphics type='vnc' port='-1' autoport='yes' listen='127.0.0.1' keymap='en-us'/>
+    <video>
+      <model type='cirrus' vram='16384' heads='1'/>
+    </video>
+  </devices>
+</domain>

data/spec/unit/action/create_domain_spec.rb

@@ -152,6 +152,88 @@ describe VagrantPlugins::ProviderLibvirt::Action::CreateDomain do
           expect(subject.call(env)).to be_nil
         end
       end
+
+      context 'with disk controller model virtio-scsi' do
+        before do
+          allow(machine.provider_config).to receive(:disk_controller_model).and_return('virtio-scsi')
+          expect(volumes).to receive(:all).with(name: 'vagrant-test_default.img').and_return([domain_volume])
+
+          env[:domain_volumes][0][:bus] = 'scsi'
+        end
+
+        it 'should add a virtio-scsi disk controller' do
+          expect(ui).to receive(:info).with(/ -- Image\(vda\):.*/)
+          expect(servers).to receive(:create) do |args|
+            expect(args[:xml]).to match(/<controller type='scsi' model='virtio-scsi' index='0'\/>/)
+          end.and_return(machine)
+
+          expect(subject.call(env)).to be_nil
+        end
+      end
+
+      context 'sysinfo' do
+        let(:domain_xml_file) { 'sysinfo.xml' }
+        let(:vagrantfile_providerconfig) do
+          <<-EOF
+          libvirt.sysinfo = {
+            'bios': {
+              'vendor': 'Test Vendor',
+              'version': '',
+            },
+            'system': {
+              'manufacturer': 'Test Manufacturer',
+              'version': '0.1.0',
+              'serial': '',
+            },
+            'base board': {
+              'manufacturer': 'Test Manufacturer',
+              'version': '',
+            },
+            'chassis': {
+              'manufacturer': 'Test Manufacturer',
+              'serial': 'AABBCCDDEE',
+              'asset': '',
+            },
+            'oem strings': [
+              'app1: string1',
+              'app1: string2',
+              'app2: string1',
+              'app2: string2',
+              '',
+              '',
+            ],
+          }
+          EOF
+        end
+
+        it 'should populate sysinfo as expected' do
+          expect(servers).to receive(:create).with(xml: domain_xml).and_return(machine)
+
+          expect(subject.call(env)).to be_nil
+        end
+
+        context 'with block of empty entries' do
+          let(:domain_xml_file) { 'sysinfo_only_required.xml' }
+          let(:vagrantfile_providerconfig) do
+            <<-EOF
+            libvirt.sysinfo = {
+              'bios': {
+                'vendor': 'Test Vendor',
+              },
+              'system': {
+                'serial': '',
+              },
+            }
+            EOF
+          end
+
+          it 'should skip outputting the surrounding tags' do
+            expect(servers).to receive(:create).with(xml: domain_xml).and_return(machine)
+
+            expect(subject.call(env)).to be_nil
+          end
+        end
+      end
     end
 
     context 'connection => qemu:///session' do

data/spec/unit/action/forward_ports_spec.rb

@@ -195,7 +195,6 @@ describe VagrantPlugins::ProviderLibvirt::Action::ClearForwardedPorts do
         end
       end
       it 'should terminate each of the processes' do
-        expect(logger).to receive(:info).with(no_args) # don't know how to test translations from vagrant
         expect(subject).to receive(:ssh_pid?).with("10001").and_return(true)
         expect(subject).to receive(:ssh_pid?).with("10002").and_return(true)
         expect(logger).to receive(:debug).with(/Killing pid/).twice()

data/spec/unit/action/handle_box_image_spec.rb

@@ -104,7 +104,7 @@ describe VagrantPlugins::ProviderLibvirt::Action::HandleBoxImage do
 
         it 'should use the box file timestamp' do
           expect(ui).to receive(:warn).with(
-            "No verison detected for test, using timestamp to watch for modifications. Consider\n" +
+            "No version detected for test, using timestamp to watch for modifications. Consider\n" +
             "generating a local metadata for the box with a version to allow better handling.\n" +
             'See https://www.vagrantup.com/docs/boxes/format#box-metadata for further details.'
           )
@@ -125,6 +125,23 @@ describe VagrantPlugins::ProviderLibvirt::Action::HandleBoxImage do
         end
       end
 
+      context 'when box version set to 0' do
+        let(:box_mtime) { Time.now }
+
+        before do
+          expect(env[:machine]).to receive_message_chain("box.version") { '0' }
+          expect(File).to receive(:mtime).and_return(box_mtime)
+        end
+
+        it 'should use the box file timestamp' do
+          expect(ui).to receive(:warn).with(/No version detected for test/)
+
+          expect(subject.call(env)).to be_nil
+          expect(env[:box_volume_number]).to eq(1)
+          expect(env[:box_volumes]).to match([hash_including({:name=>"test_vagrant_box_image_0_#{box_mtime.to_i}_box.img"})])
+        end
+      end
+
       context 'When config.machine_virtual_size is set and smaller than box_virtual_size' do
         before do
           env[:machine].provider_config.machine_virtual_size = 1

data/spec/unit/action/remove_libvirt_image_spec.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'support/sharedcontext'
+
+require 'vagrant-libvirt/action/remove_libvirt_image'
+
+describe VagrantPlugins::ProviderLibvirt::Action::RemoveLibvirtImage do
+  subject { described_class.new(app, env) }
+
+  include_context 'unit'
+
+  let(:box) { instance_double(::Vagrant::Box) }
+
+  describe '#call' do
+    before do
+      env[:box_removed] = box
+      allow(ui).to receive(:info)
+    end
+
+    context 'when called with libvirt box removed' do
+      before do
+        expect(box).to receive(:provider).and_return(:libvirt)
+      end
+
+      it 'should notify the user about limited removal' do
+        expect(ui).to receive(:info).with(/Vagrant-libvirt plugin removed box/)
+        expect(subject.call(env)).to be_nil
+      end
+    end
+
+    context 'when called with any other provider box' do
+      before do
+        expect(box).to receive(:provider).and_return(:virtualbox)
+      end
+
+      it 'call the next middle ware immediately' do
+        expect(ui).to_not receive(:info).with(/Vagrant-libvirt plugin removed box/)
+        expect(subject.call(env)).to be_nil
+      end
+    end
+  end
+end

data/spec/unit/action/resolve_disk_settings_spec.rb

@@ -356,6 +356,30 @@ describe VagrantPlugins::ProviderLibvirt::Action::ResolveDiskSettings do
           ]
         )
       end
+
+      context 'when creating using pxe' do
+        before do
+          env[:domain_name] = 'vagrant-test_default'
+        end
+
+        it 'should not query for domain xml' do
+          expect(libvirt_client).to_not receive(:lookup_domain_by_uuid)
+          expect(libvirt_client).to receive(:lookup_storage_pool_by_name).and_return(libvirt_storage_pool)
+          expect(libvirt_storage_pool).to receive(:xml_desc).and_return(storage_pool_xml)
+
+          expect(subject.call(env)).to be_nil
+          expect(env[:disks]).to match(
+            [
+              hash_including(
+                device: 'vda',
+                path: 'vagrant-test_default-vda.qcow2',
+                absolute_path: '/var/lib/libvirt/images/vagrant-test_default-vda.qcow2',
+                pool: 'default'
+              ),
+            ]
+          )
+        end
+      end
     end
   end
 end

data/spec/unit/action/start_domain_spec/clock_timer_removed.xml

@@ -0,0 +1,38 @@
+<domain xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0' type=''>
+  <name/>
+  <title/>
+  <description/>
+  <uuid/>
+  <memory/>
+  <vcpu>1</vcpu>
+  <cpu mode='host-model'>
+    <model fallback='allow'/>
+  </cpu>
+  <os>
+    <type>hvm</type>
+    <kernel/>
+    <initrd/>
+    <cmdline/>
+  </os>
+  <features>
+    <acpi/>
+    <apic/>
+    <pae/>
+  </features>
+  <clock offset='utc'>
+    
+  </clock>
+  <devices>
+    <serial type='pty'>
+      <target port='0'/>
+    </serial>
+    <console type='pty'>
+      <target port='0'/>
+    </console>
+    <input bus='ps2' type='mouse'/>
+    <graphics autoport='yes' keymap='en-us' listen='127.0.0.1' port='-1' type='vnc'/>
+    <video>
+      <model heads='1' type='cirrus' vram='16384'/>
+    </video>
+  </devices>
+</domain>

data/spec/unit/action/start_domain_spec/clock_timer_rtc_tsc.xml

@@ -0,0 +1,39 @@
+<domain xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0' type=''>
+  <name/>
+  <title/>
+  <description/>
+  <uuid/>
+  <memory/>
+  <vcpu>1</vcpu>
+  <cpu mode='host-model'>
+    <model fallback='allow'/>
+  </cpu>
+  <os>
+    <type>hvm</type>
+    <kernel/>
+    <initrd/>
+    <cmdline/>
+  </os>
+  <features>
+    <acpi/>
+    <apic/>
+    <pae/>
+  </features>
+  <clock offset='utc'>
+    <timer name='rtc'/>
+    <timer name='tsc'/>
+  </clock>
+  <devices>
+    <serial type='pty'>
+      <target port='0'/>
+    </serial>
+    <console type='pty'>
+      <target port='0'/>
+    </console>
+    <input bus='ps2' type='mouse'/>
+    <graphics autoport='yes' keymap='en-us' listen='127.0.0.1' port='-1' type='vnc'/>
+    <video>
+      <model heads='1' type='cirrus' vram='16384'/>
+    </video>
+  </devices>
+</domain>

data/spec/unit/action/start_domain_spec/nvram_domain_other_setting.xml

@@ -4,11 +4,11 @@
   <description>Source: /home/test/vagrant-libvirt/Vagrantfile</description>
   <memory unit='KiB'>2097152</memory>
   <currentMemory unit='KiB'>2097152</currentMemory>
-  <vcpu placement='static'>4</vcpu>
+  <vcpu placement='static'>2</vcpu>
   <os>
     <type arch='x86_64' machine='pc-i440fx-6.0'>hvm</type>
     <loader type='pflash'>/path/to/loader/file</loader>
-    <nvram>/path/to/nvram/file</nvram>
+    <nvram>/path/to/nvram/file1</nvram>
     <boot dev='hd'/>
   </os>
   <features>

data/spec/unit/action/start_domain_spec.rb

@@ -33,8 +33,7 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
       allow(servers).to receive(:get).and_return(domain)
 
       allow(logger).to receive(:debug)
-      expect(logger).to receive(:info)
-      expect(ui).to_not receive(:error)
+      allow(logger).to receive(:info)
 
       allow(libvirt_domain).to receive(:xml_desc).and_return(domain_xml)
 
@@ -43,23 +42,53 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
     end
 
     it 'should execute without changing' do
-      expect(libvirt_domain).to_not receive(:undefine)
+      expect(ui).to_not receive(:error)
+      expect(libvirt_client).to_not receive(:define_domain_xml)
       expect(libvirt_domain).to receive(:autostart=)
       expect(domain).to receive(:start)
 
       expect(subject.call(env)).to be_nil
     end
 
-    context 'when previously running default config' do
-      let(:test_file) { 'existing.xml' }
+    context 'when any setting changed' do
+      let(:vagrantfile_providerconfig) do
+        <<-EOF
+        libvirt.cpus = 2
+        EOF
+      end
+
+      let(:updated_domain_xml) {
+        new_xml = domain_xml.dup
+        new_xml['<vcpu>1</vcpu>'] = '<vcpu>2</vcpu>'
+        new_xml
+      }
 
-      it 'should execute without changing' do
-        expect(libvirt_domain).to_not receive(:undefine)
+      it 'should update the domain' do
+        expect(ui).to_not receive(:error)
         expect(libvirt_domain).to receive(:autostart=)
+        expect(connection).to receive(:define_domain).and_return(libvirt_domain)
+        expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml, updated_domain_xml)
         expect(domain).to receive(:start)
 
         expect(subject.call(env)).to be_nil
       end
+
+      context 'when there is an error during update' do
+        it 'should skip attempting to start' do
+          expect(ui).to receive(:error)
+          expect(connection).to receive(:define_domain).and_raise(::Libvirt::Error)
+
+          expect { subject.call(env) }.to raise_error(VagrantPlugins::ProviderLibvirt::Errors::VagrantLibvirtError)
+        end
+      end
+
+      context 'when there is an interrupt' do
+        it 'should skip attempting to start' do
+          expect(connection).to receive(:define_domain).and_raise(Interrupt)
+
+          expect { subject.call(env) }.to raise_error(Interrupt)
+        end
+      end
     end
 
     context 'nvram' do
@@ -73,9 +102,10 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
         let(:test_file) { 'existing.xml' }
         let(:updated_test_file) { 'existing_added_nvram.xml' }
 
-        it 'should undefine without passing flags' do
-          expect(libvirt_domain).to receive(:undefine).with(0)
-          expect(servers).to receive(:create).with(xml: updated_domain_xml)
+        it 'should add the nvram element' do
+          expect(ui).to_not receive(:error)
+          expect(connection).to receive(:define_domain).with(updated_domain_xml).and_return(libvirt_domain)
+          expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml, updated_domain_xml)
           expect(libvirt_domain).to receive(:autostart=)
           expect(domain).to receive(:start)
 
@@ -87,17 +117,16 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
         let(:vagrantfile_providerconfig) do
           <<-EOF
           libvirt.loader = "/path/to/loader/file"
-          libvirt.nvram = "/path/to/nvram/file"
-          # change another setting to trigger the undefine/create
-          libvirt.cpus = 4
+          libvirt.nvram = "/path/to/nvram/file1"
           EOF
         end
         let(:test_file) { 'nvram_domain.xml' }
         let(:updated_test_file) { 'nvram_domain_other_setting.xml' }
 
-        it 'should set the flag to keep nvram' do
-          expect(libvirt_domain).to receive(:undefine).with(VagrantPlugins::ProviderLibvirt::Util::DomainFlags::VIR_DOMAIN_UNDEFINE_KEEP_NVRAM)
-          expect(servers).to receive(:create).with(xml: updated_domain_xml)
+        it 'should keep the XML element' do
+          expect(ui).to_not receive(:error)
+          expect(connection).to receive(:define_domain).with(updated_domain_xml).and_return(libvirt_domain)
+          expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml, updated_domain_xml)
           expect(libvirt_domain).to receive(:autostart=)
           expect(domain).to receive(:start)
 
@@ -108,9 +137,10 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
           let(:vagrantfile_providerconfig) { }
           let(:updated_test_file) { 'nvram_domain_removed.xml' }
 
-          it 'should set the flag to remove nvram' do
-            expect(libvirt_domain).to receive(:undefine).with(VagrantPlugins::ProviderLibvirt::Util::DomainFlags::VIR_DOMAIN_UNDEFINE_NVRAM)
-            expect(servers).to receive(:create).with(xml: updated_domain_xml)
+          it 'should delete the XML element' do
+            expect(ui).to_not receive(:error)
+            expect(connection).to receive(:define_domain).with(updated_domain_xml).and_return(libvirt_domain)
+            expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml, updated_domain_xml)
             expect(libvirt_domain).to receive(:autostart=)
             expect(domain).to receive(:start)
 
@@ -132,9 +162,10 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
         end
 
         it 'should modify the domain tpm_path' do
-          expect(libvirt_domain).to receive(:undefine)
+          expect(ui).to_not receive(:error)
           expect(logger).to receive(:debug).with('tpm config changed')
-          expect(servers).to receive(:create).with(xml: updated_domain_xml)
+          expect(connection).to receive(:define_domain).with(updated_domain_xml).and_return(libvirt_domain)
+          expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml, updated_domain_xml)
           expect(libvirt_domain).to receive(:autostart=)
           expect(domain).to receive(:start)
 
@@ -153,9 +184,10 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
         end
 
         it 'should modify the domain tpm_path' do
-          expect(libvirt_domain).to receive(:undefine)
+          expect(ui).to_not receive(:error)
           expect(logger).to receive(:debug).with('tpm config changed')
-          expect(servers).to receive(:create).with(xml: updated_domain_xml)
+          expect(connection).to receive(:define_domain).with(updated_domain_xml).and_return(libvirt_domain)
+          expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml, updated_domain_xml)
           expect(libvirt_domain).to receive(:autostart=)
           expect(domain).to receive(:start)
 
@@ -175,6 +207,7 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
         end
 
         it 'should execute without changing' do
+          expect(ui).to_not receive(:error)
           expect(libvirt_domain).to receive(:autostart=)
           expect(domain).to receive(:start)
 
@@ -194,6 +227,7 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
         end
 
         it 'should execute without changing' do
+          expect(ui).to_not receive(:error)
           expect(libvirt_domain).to receive(:autostart=)
           expect(domain).to receive(:start)
 
@@ -213,9 +247,10 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
         end
 
         it 'should modify the domain' do
-          expect(libvirt_domain).to receive(:undefine)
+          expect(ui).to_not receive(:error)
           expect(logger).to receive(:debug).with('tpm config changed')
-          expect(servers).to receive(:create).with(xml: updated_domain_xml)
+          expect(connection).to receive(:define_domain).with(updated_domain_xml).and_return(libvirt_domain)
+          expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml, updated_domain_xml)
           expect(libvirt_domain).to receive(:autostart=)
           expect(domain).to receive(:start)
 
@@ -235,8 +270,9 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
         end
 
         it 'should not modify the domain' do
+          expect(ui).to_not receive(:error)
           expect(logger).to_not receive(:debug).with('clock timers config changed')
-          expect(servers).to_not receive(:create)
+          expect(connection).to_not receive(:define_domain)
           expect(libvirt_domain).to receive(:autostart=)
           expect(domain).to receive(:start)
 
@@ -252,10 +288,13 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
           EOF
         end
 
+        let(:updated_test_file) { 'clock_timer_rtc_tsc.xml' }
+
         it 'should modify the domain' do
-          expect(libvirt_domain).to receive(:undefine)
+          expect(ui).to_not receive(:error)
           expect(logger).to receive(:debug).with('clock timers config changed')
-          expect(servers).to receive(:create).with(xml: match(/<clock offset='utc'>\s*<timer name='rtc'\/>\s*<timer name='tsc'\/>\s*<\/clock>/))
+          expect(connection).to receive(:define_domain).with(match(/<clock offset='utc'>\s*<timer name='rtc'\/>\s*<timer name='tsc'\/>\s*<\/clock>/)).and_return(libvirt_domain)
+          expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml, updated_domain_xml)
           expect(libvirt_domain).to receive(:autostart=)
           expect(domain).to receive(:start)
 
@@ -264,10 +303,13 @@ describe VagrantPlugins::ProviderLibvirt::Action::StartDomain do
       end
 
       context 'timers removed' do
+        let(:updated_test_file) { 'clock_timer_removed.xml' }
+
         it 'should modify the domain' do
-          expect(libvirt_domain).to receive(:undefine)
+          expect(ui).to_not receive(:error)
           expect(logger).to receive(:debug).with('clock timers config changed')
-          expect(servers).to receive(:create).with(xml: match(/<clock offset='utc'>\s*<\/clock>/))
+          expect(connection).to receive(:define_domain).with(match(/<clock offset='utc'>\s*<\/clock>/)).and_return(libvirt_domain)
+          expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml, updated_domain_xml)
           expect(libvirt_domain).to receive(:autostart=)
           expect(domain).to receive(:start)