vagrant-libvirt 0.8.2 → 0.10.1

data/spec/unit/action/resolve_disk_settings_spec.rb

@@ -0,0 +1,385 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+require 'fog/libvirt/models/compute/volume'
+
+require 'vagrant-libvirt/action/resolve_disk_settings'
+
+describe VagrantPlugins::ProviderLibvirt::Action::ResolveDiskSettings do
+  subject { described_class.new(app, env) }
+
+  include_context 'unit'
+  include_context 'libvirt'
+
+  let(:servers) { double('servers') }
+  let(:volumes) { double('volumes') }
+  let(:domain_volume) { instance_double(::Fog::Libvirt::Compute::Volume) }
+  let(:libvirt_storage_pool) { double('storage_pool') }
+
+  let(:domain_xml) { File.read(File.join(File.dirname(__FILE__), File.basename(__FILE__, '.rb'), domain_xml_file)) }
+  let(:storage_pool_xml) do
+    File.read(File.join(File.dirname(__FILE__), File.basename(__FILE__, '.rb'), storage_pool_xml_file))
+  end
+
+  before do
+    allow(logger).to receive(:info)
+    allow(logger).to receive(:debug)
+  end
+
+  describe '#call' do
+    before do
+      allow(connection).to receive(:volumes).and_return(volumes)
+      allow(volumes).to receive(:all).and_return([domain_volume])
+      allow(domain_volume).to receive(:pool_name).and_return('default')
+      allow(domain_volume).to receive(:path).and_return('/var/lib/libvirt/images/vagrant-test_default.img')
+    end
+
+    context 'when vm box is in use' do
+      context 'when box metadata is available' do
+        let(:box_volumes) do
+          [
+            {
+              path: '/test/box.img',
+              name: 'test_vagrant_box_image_1.1.1_box.img',
+            },
+          ]
+        end
+
+        before do
+          env[:domain_name] = 'vagrant-test_default'
+          env[:box_volumes] = box_volumes
+        end
+
+        it 'should populate domain volume' do
+          expect(subject.call(env)).to be_nil
+          expect(env[:domain_volumes]).to match(
+            [
+              hash_including(
+                device: 'vda',
+                absolute_path: '/var/lib/libvirt/images/vagrant-test_default.img'
+              ),
+            ]
+          )
+        end
+
+        context 'when additional storage specified' do
+          let(:vagrantfile_providerconfig) do
+            <<-EOF
+              libvirt.storage :file, :size => '20G'
+            EOF
+          end
+
+          it 'should use the next device for storage' do
+            expect(subject.call(env)).to be_nil
+            expect(env[:disks]).to match(
+              [
+                hash_including(
+                  device: 'vdb',
+                  absolute_path: '/var/lib/libvirt/images/vagrant-test_default-vdb.qcow2'
+                ),
+              ]
+            )
+          end
+        end
+
+        context 'when custom disk device setting' do
+          before do
+            machine.provider_config.disk_device = 'sda'
+          end
+
+          it 'should set the domain device' do
+            expect(subject.call(env)).to be_nil
+            expect(env[:domain_volumes]).to match(
+              [
+                hash_including(
+                  device: 'sda',
+                  absolute_path: '/var/lib/libvirt/images/vagrant-test_default.img'
+                ),
+              ]
+            )
+          end
+
+          context 'when additional storage specified' do
+            let(:vagrantfile_providerconfig) do
+              <<-EOF
+                libvirt.storage :file, :size => '20G'
+              EOF
+            end
+
+            it 'should use the next custom disk device for storage' do
+              expect(subject.call(env)).to be_nil
+              expect(env[:disks]).to match(
+                [
+                  hash_including(
+                    device: 'sdb',
+                    absolute_path: '/var/lib/libvirt/images/vagrant-test_default-sdb.qcow2'
+                  ),
+                ]
+              )
+            end
+          end
+        end
+
+        context 'when multiple box volumes' do
+          let(:box_volumes) do
+            [
+              {
+                path: '/test/box.img',
+                name: 'test_vagrant_box_image_1.1.1_box.img',
+              },
+              {
+                path: '/test/box_2.img',
+                name: 'test_vagrant_box_image_1.1.1_box_2.img',
+              },
+            ]
+          end
+          it 'should populate all domain volumes' do
+            expect(subject.call(env)).to be_nil
+            expect(env[:domain_volumes]).to match(
+              [
+                hash_including(
+                  device: 'vda',
+                  absolute_path: '/var/lib/libvirt/images/vagrant-test_default.img'
+                ),
+                hash_including(
+                  device: 'vdb',
+                  absolute_path: '/var/lib/libvirt/images/vagrant-test_default.img'
+                ),
+              ]
+            )
+          end
+
+          context 'when additional storage specified' do
+            let(:vagrantfile_providerconfig) do
+              <<-EOF
+                libvirt.storage :file, :size => '20G'
+              EOF
+            end
+
+            it 'should use the next device for storage' do
+              expect(subject.call(env)).to be_nil
+              expect(env[:disks]).to match(
+                [
+                  hash_including(
+                    device: 'vdc',
+                    absolute_path: '/var/lib/libvirt/images/vagrant-test_default-vdc.qcow2'
+                  ),
+                ]
+              )
+            end
+          end
+        end
+      end
+
+      context 'when box metadata is not available' do
+        let(:domain_xml_file) { 'default_domain.xml' }
+
+        before do
+          expect(libvirt_client).to receive(:lookup_domain_by_uuid).and_return(libvirt_domain)
+          expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml)
+        end
+
+        it 'should query the domain xml' do
+          expect(subject.call(env)).to be_nil
+          expect(env[:domain_volumes]).to match(
+            [
+              hash_including(
+                device: 'vda',
+                absolute_path: '/var/lib/libvirt/images/vagrant-test_default.img'
+              ),
+            ]
+          )
+        end
+
+        context 'when multiple volumes in domain config' do
+          let(:domain_xml_file) { 'multi_volume_box.xml' }
+
+          it 'should populate domain volumes with devices' do
+            expect(subject.call(env)).to be_nil
+            expect(env[:domain_volumes]).to match(
+              [
+                hash_including(
+                  device: 'vda',
+                  absolute_path: '/var/lib/libvirt/images/vagrant-test_default.img'
+                ),
+                hash_including(
+                  device: 'vdb',
+                  absolute_path: '/var/lib/libvirt/images/vagrant-test_default_1.img'
+                ),
+                hash_including(
+                  device: 'vdc',
+                  absolute_path: '/var/lib/libvirt/images/vagrant-test_default_2.img'
+                ),
+              ]
+            )
+          end
+
+          context 'when additional storage in domain config' do
+            let(:domain_xml_file) { 'multi_volume_box_additional_storage.xml' }
+            let(:vagrantfile_providerconfig) do
+              <<-EOF
+                libvirt.storage :file, :size => '20G'
+                libvirt.storage :file, :size => '20G'
+              EOF
+            end
+
+            it 'should populate disks with devices' do
+              expect(subject.call(env)).to be_nil
+              expect(env[:disks]).to match(
+                [
+                  hash_including(
+                    device: 'vdd',
+                    absolute_path: '/var/lib/libvirt/images/vagrant-test_default-vdd.qcow2'
+                  ),
+                  hash_including(
+                    device: 'vde',
+                    absolute_path: '/var/lib/libvirt/images/vagrant-test_default-vde.qcow2'
+                  ),
+                ]
+              )
+            end
+          end
+        end
+
+        context 'when no aliases available' do
+          let(:domain_xml_file) { 'default_no_aliases.xml' }
+
+          it 'should assume a single box volume' do
+            expect(subject.call(env)).to be_nil
+            expect(env[:domain_volumes]).to match(
+              [
+                hash_including(
+                  device: 'vda',
+                  absolute_path: '/var/lib/libvirt/images/vagrant-test_default.img'
+                ),
+              ]
+            )
+          end
+
+          context 'when additional storage and a custom disk device attached' do
+            let(:domain_xml_file) { 'multi_volume_box_additional_and_custom_no_aliases.xml' }
+            let(:vagrantfile_providerconfig) do
+              <<-EOF
+                libvirt.storage :file, :size => '20G'
+                libvirt.storage :file, :size => '20G'
+              EOF
+            end
+
+            it 'should detect the domain volumes and disks while ignoring the last one' do
+              expect(subject.call(env)).to be_nil
+              expect(env[:domain_volumes]).to match(
+                [
+                  hash_including(
+                    device: 'vda',
+                    absolute_path: '/var/lib/libvirt/images/vagrant-test_default.img'
+                  ),
+                  hash_including(
+                    device: 'vdb',
+                    absolute_path: '/var/lib/libvirt/images/vagrant-test_default_1.img'
+                  ),
+                  hash_including(
+                    device: 'vdc',
+                    absolute_path: '/var/lib/libvirt/images/vagrant-test_default_2.img'
+                  ),
+                ]
+              )
+              expect(env[:disks]).to match(
+                [
+                  hash_including(
+                    device: 'vdd',
+                    absolute_path: '/var/lib/libvirt/images/vagrant-test_default-vdd.qcow2'
+                  ),
+                  hash_including(
+                    device: 'vde',
+                    absolute_path: '/var/lib/libvirt/images/vagrant-test_default-vde.qcow2'
+                  ),
+                ]
+              )
+            end
+          end
+        end
+      end
+
+      context 'no default pool' do
+        let(:domain_xml_file) { 'default_domain.xml' }
+        let(:vagrantfile) do
+          <<-EOF
+          Vagrant.configure('2') do |config|
+            config.vm.define :test
+          end
+          EOF
+        end
+
+        it 'should raise an exception' do
+          expect(libvirt_client).to receive(:lookup_domain_by_uuid).and_return(libvirt_domain)
+          expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml)
+          expect(libvirt_client).to receive(:lookup_storage_pool_by_name).and_return(nil)
+
+          expect { subject.call(env) }.to raise_error(VagrantPlugins::ProviderLibvirt::Errors::NoStoragePool)
+        end
+      end
+    end
+
+    context 'when no box defined' do
+      let(:domain_xml_file) { 'default_domain.xml' }
+      let(:storage_pool_xml_file) { 'default_system_storage_pool.xml' }
+      let(:vagrantfile) do
+        <<-EOF
+        Vagrant.configure('2') do |config|
+          config.vm.define :test
+          config.vm.provider :libvirt do |libvirt|
+            libvirt.storage :file, :size => '20G'
+          end
+        end
+        EOF
+      end
+
+      it 'should query for domain name and storage pool path' do
+        expect(libvirt_client).to receive(:lookup_domain_by_uuid).and_return(libvirt_domain)
+        expect(libvirt_domain).to receive(:xml_desc).and_return(domain_xml)
+        expect(libvirt_client).to receive(:lookup_storage_pool_by_name).and_return(libvirt_storage_pool)
+        expect(libvirt_storage_pool).to receive(:xml_desc).and_return(storage_pool_xml)
+
+        expect(subject.call(env)).to be_nil
+        expect(env[:disks]).to match(
+          [
+            hash_including(
+              device: 'vda',
+              cache: 'default',
+              bus: 'virtio',
+              path: 'vagrant-test_default-vda.qcow2',
+              absolute_path: '/var/lib/libvirt/images/vagrant-test_default-vda.qcow2',
+              size: '20G',
+              pool: 'default'
+            ),
+          ]
+        )
+      end
+
+      context 'when creating using pxe' do
+        before do
+          env[:domain_name] = 'vagrant-test_default'
+        end
+
+        it 'should not query for domain xml' do
+          expect(libvirt_client).to_not receive(:lookup_domain_by_uuid)
+          expect(libvirt_client).to receive(:lookup_storage_pool_by_name).and_return(libvirt_storage_pool)
+          expect(libvirt_storage_pool).to receive(:xml_desc).and_return(storage_pool_xml)
+
+          expect(subject.call(env)).to be_nil
+          expect(env[:disks]).to match(
+            [
+              hash_including(
+                device: 'vda',
+                path: 'vagrant-test_default-vda.qcow2',
+                absolute_path: '/var/lib/libvirt/images/vagrant-test_default-vda.qcow2',
+                pool: 'default'
+              ),
+            ]
+          )
+        end
+      end
+    end
+  end
+end

data/spec/unit/action/start_domain_spec/clock_timer_removed.xml

@@ -0,0 +1,38 @@
+<domain xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0' type=''>
+  <name/>
+  <title/>
+  <description/>
+  <uuid/>
+  <memory/>
+  <vcpu>1</vcpu>
+  <cpu mode='host-model'>
+    <model fallback='allow'/>
+  </cpu>
+  <os>
+    <type>hvm</type>
+    <kernel/>
+    <initrd/>
+    <cmdline/>
+  </os>
+  <features>
+    <acpi/>
+    <apic/>
+    <pae/>
+  </features>
+  <clock offset='utc'>
+    
+  </clock>
+  <devices>
+    <serial type='pty'>
+      <target port='0'/>
+    </serial>
+    <console type='pty'>
+      <target port='0'/>
+    </console>
+    <input bus='ps2' type='mouse'/>
+    <graphics autoport='yes' keymap='en-us' listen='127.0.0.1' port='-1' type='vnc'/>
+    <video>
+      <model heads='1' type='cirrus' vram='16384'/>
+    </video>
+  </devices>
+</domain>

data/spec/unit/action/start_domain_spec/clock_timer_rtc_tsc.xml

@@ -0,0 +1,39 @@
+<domain xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0' type=''>
+  <name/>
+  <title/>
+  <description/>
+  <uuid/>
+  <memory/>
+  <vcpu>1</vcpu>
+  <cpu mode='host-model'>
+    <model fallback='allow'/>
+  </cpu>
+  <os>
+    <type>hvm</type>
+    <kernel/>
+    <initrd/>
+    <cmdline/>
+  </os>
+  <features>
+    <acpi/>
+    <apic/>
+    <pae/>
+  </features>
+  <clock offset='utc'>
+    <timer name='rtc'/>
+    <timer name='tsc'/>
+  </clock>
+  <devices>
+    <serial type='pty'>
+      <target port='0'/>
+    </serial>
+    <console type='pty'>
+      <target port='0'/>
+    </console>
+    <input bus='ps2' type='mouse'/>
+    <graphics autoport='yes' keymap='en-us' listen='127.0.0.1' port='-1' type='vnc'/>
+    <video>
+      <model heads='1' type='cirrus' vram='16384'/>
+    </video>
+  </devices>
+</domain>

data/spec/unit/action/start_domain_spec/existing_added_nvram.xml

@@ -0,0 +1,62 @@
+<domain type='qemu'>
+  <name>vagrant-libvirt_default</name>
+  <uuid>881a931b-0110-4d10-81aa-47a1a19f5726</uuid>
+  <description>Source: /home/test/vagrant-libvirt/Vagrantfile</description>
+  <memory unit='KiB'>2097152</memory>
+  <currentMemory unit='KiB'>2097152</currentMemory>
+  <vcpu placement='static'>2</vcpu>
+  <os>
+    <type arch='x86_64' machine='pc-i440fx-6.0'>hvm</type><loader type='pflash'>/path/to/loader/file</loader><nvram>/path/to/nvram/file</nvram>
+    <boot dev='hd'/>
+  </os>
+  <features>
+    <acpi/>
+    <apic/>
+    <pae/>
+  </features>
+  <cpu check='partial' mode='host-model'/>
+  <clock offset='utc'/>
+  <on_poweroff>destroy</on_poweroff>
+  <on_reboot>restart</on_reboot>
+  <on_crash>destroy</on_crash>
+  <devices>
+    <emulator>/usr/bin/qemu-system-x86_64</emulator>
+    <disk device='disk' type='file'>
+      <driver name='qemu' type='qcow2'/>
+      <source file='/var/lib/libvirt/images/vagrant-libvirt_default.img'/>
+      <target bus='virtio' dev='vda'/>
+      <address bus='0x00' domain='0x0000' function='0x0' slot='0x03' type='pci'/>
+    </disk>
+    <controller index='0' model='piix3-uhci' type='usb'>
+      <address bus='0x00' domain='0x0000' function='0x2' slot='0x01' type='pci'/>
+    </controller>
+    <controller index='0' model='pci-root' type='pci'/>
+    <interface type='network'>
+      <mac address='52:54:00:7d:14:0e'/>
+      <source network='vagrant-libvirt'/>
+      <model type='virtio'/>
+      <address bus='0x00' domain='0x0000' function='0x0' slot='0x05' type='pci'/>
+    </interface>
+    <serial type='pty'>
+      <target port='0' type='isa-serial'>
+        <model name='isa-serial'/>
+      </target>
+    </serial>
+    <console type='pty'>
+      <target port='0' type='serial'/>
+    </console>
+    <input bus='ps2' type='mouse'/>
+    <input bus='ps2' type='keyboard'/>
+    <graphics autoport='yes' keymap='en-us' listen='127.0.0.1' port='-1' type='vnc'>
+      <listen address='127.0.0.1' type='address'/>
+    </graphics>
+    <audio id='1' type='none'/>
+    <video>
+      <model heads='1' primary='yes' type='cirrus' vram='16384'/>
+      <address bus='0x00' domain='0x0000' function='0x0' slot='0x02' type='pci'/>
+    </video>
+    <memballoon model='virtio'>
+      <address bus='0x00' domain='0x0000' function='0x0' slot='0x04' type='pci'/>
+    </memballoon>
+  </devices>
+</domain>

data/spec/unit/action/start_domain_spec/nvram_domain.xml

@@ -0,0 +1,64 @@
+<domain type='qemu'>
+  <name>vagrant-libvirt_default</name>
+  <uuid>881a931b-0110-4d10-81aa-47a1a19f5726</uuid>
+  <description>Source: /home/test/vagrant-libvirt/Vagrantfile</description>
+  <memory unit='KiB'>2097152</memory>
+  <currentMemory unit='KiB'>2097152</currentMemory>
+  <vcpu placement='static'>2</vcpu>
+  <os>
+    <type arch='x86_64' machine='pc-i440fx-6.0'>hvm</type>
+    <loader type='pflash'>/path/to/loader/file</loader>
+    <nvram>/path/to/nvram/file</nvram>
+    <boot dev='hd'/>
+  </os>
+  <features>
+    <acpi/>
+    <apic/>
+    <pae/>
+  </features>
+  <cpu mode='host-model' check='partial'/>
+  <clock offset='utc'/>
+  <on_poweroff>destroy</on_poweroff>
+  <on_reboot>restart</on_reboot>
+  <on_crash>destroy</on_crash>
+  <devices>
+    <emulator>/usr/bin/qemu-system-x86_64</emulator>
+    <disk type='file' device='disk'>
+      <driver name='qemu' type='qcow2'/>
+      <source file='/var/lib/libvirt/images/vagrant-libvirt_default.img'/>
+      <target dev='vda' bus='virtio'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
+    </disk>
+    <controller type='usb' index='0' model='piix3-uhci'>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/>
+    </controller>
+    <controller type='pci' index='0' model='pci-root'/>
+    <interface type='network'>
+      <mac address='52:54:00:7d:14:0e'/>
+      <source network='vagrant-libvirt'/>
+      <model type='virtio'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
+    </interface>
+    <serial type='pty'>
+      <target type='isa-serial' port='0'>
+        <model name='isa-serial'/>
+      </target>
+    </serial>
+    <console type='pty'>
+      <target type='serial' port='0'/>
+    </console>
+    <input type='mouse' bus='ps2'/>
+    <input type='keyboard' bus='ps2'/>
+    <graphics type='vnc' port='-1' autoport='yes' listen='127.0.0.1' keymap='en-us'>
+      <listen type='address' address='127.0.0.1'/>
+    </graphics>
+    <audio id='1' type='none'/>
+    <video>
+      <model type='cirrus' vram='16384' heads='1' primary='yes'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
+    </video>
+    <memballoon model='virtio'>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
+    </memballoon>
+  </devices>
+</domain>

data/spec/unit/action/start_domain_spec/nvram_domain_other_setting.xml

@@ -0,0 +1,64 @@
+<domain type='qemu'>
+  <name>vagrant-libvirt_default</name>
+  <uuid>881a931b-0110-4d10-81aa-47a1a19f5726</uuid>
+  <description>Source: /home/test/vagrant-libvirt/Vagrantfile</description>
+  <memory unit='KiB'>2097152</memory>
+  <currentMemory unit='KiB'>2097152</currentMemory>
+  <vcpu placement='static'>2</vcpu>
+  <os>
+    <type arch='x86_64' machine='pc-i440fx-6.0'>hvm</type>
+    <loader type='pflash'>/path/to/loader/file</loader>
+    <nvram>/path/to/nvram/file1</nvram>
+    <boot dev='hd'/>
+  </os>
+  <features>
+    <acpi/>
+    <apic/>
+    <pae/>
+  </features>
+  <cpu check='partial' mode='host-model'/>
+  <clock offset='utc'/>
+  <on_poweroff>destroy</on_poweroff>
+  <on_reboot>restart</on_reboot>
+  <on_crash>destroy</on_crash>
+  <devices>
+    <emulator>/usr/bin/qemu-system-x86_64</emulator>
+    <disk device='disk' type='file'>
+      <driver name='qemu' type='qcow2'/>
+      <source file='/var/lib/libvirt/images/vagrant-libvirt_default.img'/>
+      <target bus='virtio' dev='vda'/>
+      <address bus='0x00' domain='0x0000' function='0x0' slot='0x03' type='pci'/>
+    </disk>
+    <controller index='0' model='piix3-uhci' type='usb'>
+      <address bus='0x00' domain='0x0000' function='0x2' slot='0x01' type='pci'/>
+    </controller>
+    <controller index='0' model='pci-root' type='pci'/>
+    <interface type='network'>
+      <mac address='52:54:00:7d:14:0e'/>
+      <source network='vagrant-libvirt'/>
+      <model type='virtio'/>
+      <address bus='0x00' domain='0x0000' function='0x0' slot='0x05' type='pci'/>
+    </interface>
+    <serial type='pty'>
+      <target port='0' type='isa-serial'>
+        <model name='isa-serial'/>
+      </target>
+    </serial>
+    <console type='pty'>
+      <target port='0' type='serial'/>
+    </console>
+    <input bus='ps2' type='mouse'/>
+    <input bus='ps2' type='keyboard'/>
+    <graphics autoport='yes' keymap='en-us' listen='127.0.0.1' port='-1' type='vnc'>
+      <listen address='127.0.0.1' type='address'/>
+    </graphics>
+    <audio id='1' type='none'/>
+    <video>
+      <model heads='1' primary='yes' type='cirrus' vram='16384'/>
+      <address bus='0x00' domain='0x0000' function='0x0' slot='0x02' type='pci'/>
+    </video>
+    <memballoon model='virtio'>
+      <address bus='0x00' domain='0x0000' function='0x0' slot='0x04' type='pci'/>
+    </memballoon>
+  </devices>
+</domain>