vagrant-kvm 0.1.4 → 0.1.5

data/lib/vagrant-kvm/version.rb

@@ -1,5 +1,5 @@
 module VagrantPlugins
   module ProviderKvm
-    VERSION = "0.1.4"
+    VERSION = "0.1.5"
   end
 end

data/locales/en.yml

@@ -10,3 +10,11 @@ en:
       kvm_invalid_version: |-
         Invalid Kvm version detected: %{actual}, but a version %{required} is
         required.
+      kvm_no_qemu_binary: |-
+        Executable binary of qemu could not be found. Please re-examine %{cause}.
+      kvm_fail_image_conversion: |-
+        Failed to convert image to specified format.
+      kvm_failed_command: |-
+        System command %{cmd} returned with error code %{res}.
+      kvm_bad_box_format: |-
+        Unsupported box format.

data/locales/ja.yml

@@ -0,0 +1,14 @@
+en:
+  vagrant_kvm:
+    test_message: |-
+      これはテストメッセージです。
+    errors:
+      kvm_no_connection: |-
+        KVMにLibvirt経由で接続できません。カーネルモジュールの
+	 'kvm' 及び、'kvm-intel'か'kvm-amd'が正しくインストールされ、(debian/ubuntuの場合)あなたのユーザIDが
+	 libvirtグループに属しているか、確認してください。 
+      kvm_invalid_version: |-
+        不適切なKVMのバージョンが検出されました：バージョン %{actual} が検出されましたが、%{required} 
+        が必要です。
+      kvm_no_qemu_binary: |-
+        Qemuの実行バイナリが見つかりません。%{cause}を確認してください。

data/spec/acceptance/vagrant-kvm_spec.rb

@@ -0,0 +1,80 @@
+require 'spec_helper'
+
+describe 'vagrant-kvm' do
+  before(:all) do
+    create_vagrantfile
+  end
+
+  before(:all) do
+    @old_domains = libvirt.domains.count
+    @old_pool_files = pool_files.count
+  end
+
+  describe 'up' do
+    before(:all) do
+      vagrant_up
+    end
+
+    after(:all) do
+      vagrant_destroy
+    end
+
+    it'creates new libvirt domain' do
+      (libvirt.domains.count - @old_domains).should == 1
+    end
+
+    it 'starts created libvirt domain' do
+      expect(libvirt.domain).to be_active
+    end
+
+    it 'creates disk image file' do
+      (pool_files.count - @old_pool_files).should == 1
+    end
+
+    it 'creates new pool' do
+      expect(libvirt.storage_pools).to include('vagrant')
+    end
+
+    it 'creates new network' do
+      expect(libvirt.networks).to include('vagrant')
+    end
+  end
+
+  describe 'down' do
+    before(:all) do
+      vagrant_up
+      vagrant_halt
+    end
+
+    after(:all) do
+      vagrant_destroy
+    end
+
+    it 'shutdowns domain' do
+      expect(libvirt.domain).not_to be_active
+    end
+  end
+
+  describe 'destroy' do
+    before(:all) do
+      vagrant_up
+      vagrant_destroy
+    end
+
+    it 'undefines domain' do
+      libvirt.domains.count.should == @old_domains
+    end
+
+    it 'removes disk image file' do
+      expect(pool_files).to be_empty
+    end
+
+    it 'does not undefine storage pool' do
+      expect(libvirt.storage_pools).to include('vagrant')
+    end
+
+    it 'does not undefine new network' do
+      expect(libvirt.networks).to include('vagrant')
+    end
+  end
+end

data/spec/fedora/10.virt.rules

@@ -0,0 +1,10 @@
+polkit.addRule(function(action, subject) {
+  polkit.log("action=" + action);
+  polkit.log("subject=" + subject);
+  var now = new Date();
+  polkit.log("now=" + now)
+  if ((action.id == "org.libvirt.unix.manage" || action.id == "org.libvirt.unix.monitor") && subject.isInGroup("virt")) {
+    return polkit.Result.YES;
+  }
+  return null;
+});

data/spec/fedora/50-vagrant-libvirt-access.pkla

@@ -0,0 +1,6 @@
+[libvirt Management Access]
+Identity=unix-group:virt
+Action=org.libvirt.unix.manage;org.libvirt.unix.monitor
+ResultAny=yes
+ResultInactive=yes
+ResultActive=yes

data/spec/spec_helper.rb

@@ -0,0 +1,30 @@
+require 'vagrant-kvm'
+require 'support/libvirt_helper'
+require 'support/vagrant_kvm_helper'
+require 'pry'
+
+def libvirt
+  @libvirt ||= LibvirtHelper.new
+end
+
+RSpec.configure do |spec|
+  spec.include VagrantKvmHelper
+
+  spec.before(:all) do
+
+    # make sure everything is run in tmp
+    Dir.chdir '/tmp'
+  end
+
+  spec.after(:all) do
+    libvirt.connection.close
+  end
+
+  at_exit do
+    File.delete('Vagrantfile') if File.exists?('Vagrantfile')
+  end
+end
+
+def test_file(path)
+  File.join(File.dirname(__FILE__), "test_files", path)
+end

data/spec/support/libvirt_helper.rb

@@ -0,0 +1,37 @@
+require 'libvirt'
+
+class LibvirtHelper
+
+  attr_reader :connection
+
+  def initialize
+    @connection = Libvirt.open('qemu:///system')
+  end
+
+  def domains
+    # list_domains returns IDs of active domains
+    # list_defined_domains returns names of inactive domains
+    @connection.list_domains + @connection.list_defined_domains
+  end
+
+  def domain
+    domain = domains.first
+    case domain
+    when Integer
+      @connection.lookup_domain_by_id(domain)
+    when String
+      @connection.lookup_domain_by_name(domain)
+    else
+      raise "Cannot find domain!"
+    end
+  end
+
+  def storage_pools
+    @connection.list_storage_pools
+  end
+
+  def networks
+    @connection.list_networks
+  end
+
+end # LibvirtHelper

data/spec/support/vagrant_kvm_helper.rb

@@ -0,0 +1,39 @@
+module VagrantKvmHelper
+
+  def create_vagrantfile
+    File.open('Vagrantfile', 'w') do |file|
+      file.write <<-RUBY
+        Vagrant.require_plugin 'vagrant-kvm'
+
+        Vagrant.configure('2') do |config|
+          config.vm.box = 'vagrant-kvm-specs'
+          config.vm.network :private_network, ip: '192.168.50.2'
+        end
+      RUBY
+    end
+  end
+
+  def vagrant_up
+    silent_exec('bundle exec vagrant up --provider=kvm')
+  end
+
+  def vagrant_halt
+    silent_exec('bundle exec vagrant halt')
+  end
+
+  def vagrant_destroy
+    silent_exec('bundle exec vagrant destroy -f')
+  end
+
+  def pool_files
+    Dir["/home/#{ENV['USER']}/.vagrant.d/tmp/storage-pool/*"]
+  end
+
+  private
+
+  def silent_exec(cmd)
+    cmd << ' 2>&1' unless !!ENV['DEBUG']
+    `#{cmd}`
+  end
+
+end # VagrantKvmHelper

data/spec/test_files/box.xml

@@ -0,0 +1,74 @@
+<domain type='kvm' id='37'>
+  <name>winxp_base</name>
+  <memory unit='KiB'>524288</memory>
+  <currentMemory unit='KiB'>524288</currentMemory>
+  <vcpu placement='static'>1</vcpu>
+  <os>
+    <type arch='x86_64' machine='pc-1.2'>hvm</type>
+    <boot dev='hd'/>
+  </os>
+  <features>
+    <acpi/>
+    <apic/>
+    <pae/>
+  </features>
+  <clock offset='utc'/>
+  <on_poweroff>destroy</on_poweroff>
+  <on_reboot>restart</on_reboot>
+  <on_crash>restart</on_crash>
+  <devices>
+    <emulator>/usr/bin/kvm</emulator>
+    <disk type='file' device='disk'>
+      <driver name='qemu' type='qcow2'/>
+      <source file='winxp.qcow2'/>
+      <target dev='vda' bus='virtio'/>
+      <alias name='virtio-disk0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
+    </disk>
+    <controller type='usb' index='0'>
+      <alias name='usb0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/>
+    </controller>
+    <controller type='virtio-serial' index='0'>
+      <alias name='virtio-serial0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
+    </controller>
+    <interface type='network'>
+      <mac address='08:00:27:30:3b:ea'/>
+      <source network='vagrant'/>
+      <target dev='vnet0'/>
+      <model type='virtio'/>
+      <alias name='net0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
+    </interface>
+    <serial type='pty'>
+      <source path='/dev/pts/1'/>
+      <target port='0'/>
+      <alias name='serial0'/>
+    </serial>
+    <console type='pty' tty='/dev/pts/1'>
+      <source path='/dev/pts/1'/>
+      <target type='serial' port='0'/>
+      <alias name='serial0'/>
+    </console>
+    <input type='mouse' bus='ps2'/>
+    <graphics type='vnc' port='5900' autoport='no' listen='0.0.0.0'>
+      <listen type='address' address='0.0.0.0'/>
+    </graphics>
+    <sound model='ich6'>
+      <alias name='sound0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
+    </sound>
+    <video>
+      <model type='cirrus' vram='9216' heads='1'/>
+      <alias name='video0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
+    </video>
+    <memballoon model='virtio'>
+      <alias name='balloon0'/>
+      <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
+    </memballoon>
+  </devices>
+  <seclabel type='none'/>
+</domain>
+

data/spec/vagrant-kvm/config_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+require "vagrant-kvm/config"
+
+describe  VagrantPlugins::ProviderKvm::Config do
+  describe "#machine_type" do
+    it "defaults to pc-1.2" do
+      should_default(:machine_type, "pc-1.2")
+    end
+  end
+
+  describe "#vnc_port" do
+    it "defaults to -1" do
+      should_default(:vnc_port, -1)
+    end
+  end
+
+  describe "#vnc_password" do
+    it "defaults to nil" do
+      should_default(:vnc_password, nil)
+    end
+  end
+
+  describe "#network_model" do
+    it "defaults to 'virtio'" do
+      should_default(:network_model, 'virtio')
+    end
+  end
+
+  describe "#video_model" do
+    it "defaults to 'virtio'" do
+      should_default(:video_model, 'cirrus')
+    end
+  end
+
+  describe "#image_mode" do
+    it "sets image_backing to false if clone" do
+      subject.image_mode = 'clone'
+      subject.finalize!
+      subject.image_backing.should be_false
+    end
+
+    it "sets image_backing to true if cow" do
+      subject.image_mode = 'cow'
+      subject.finalize!
+      subject.image_backing.should be_true
+    end
+  end
+
+  private
+  def should_default(field, default_value)
+    instance = described_class.new
+    instance.send(field).should == described_class::UNSET_VALUE
+    instance.finalize!
+    instance.send(field).should == default_value
+  end
+end

data/spec/vagrant-kvm/driver/driver_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+module VagrantPlugins
+  module ProviderKvm
+    module Driver
+      describe Driver do
+        let(:xml) { test_file "box.xml" }
+        let(:volume_name) { "" }
+
+        before do
+          described_class.any_instance.stub(:load_kvm_module!) { true }
+        end
+
+        describe "#import" do
+          # FIXME All of these required stubs are a symptom of bad design in the
+          # driver class. 
+          let(:volume) { double(path: "foo") }
+          let(:pool) { double(refresh: nil, lookup_volume_by_name: volume) }
+          let(:domain) { double(uuid: "abc") }
+          let(:conn) { double(version: 1000000000, 
+                              lookup_storage_pool_by_name: pool, 
+                              define_domain_xml: domain) }
+          subject do
+            described_class.new(nil, conn)
+          end
+
+          it "does not raise exception" do
+            expect do
+              subject.import(xml, volume_name)
+            end.to_not raise_exception
+          end
+        end
+      end
+    end
+  end
+end

data/spec/vagrant-kvm/errors_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+module VagrantPlugins::ProviderKvm::Errors
+  describe VagrantPlugins::ProviderKvm::Errors do
+    it "has translations for all errors" do
+      # Load the translations
+      VagrantPlugins::ProviderKvm::Plugin.setup_i18n
+
+      descendants = ObjectSpace.each_object(Class).select { |klass| klass < VagrantKVMError }
+
+      all_interpolations = {
+        required: "",
+        cause: "",
+        actual: "",
+        cmd: "",
+        res: "",
+      }
+
+      descendants.each do |klass|
+        msg = klass.new(all_interpolations).message
+        msg.should_not include("translation missing")
+      end
+    end
+  end
+end

data/spec/vagrant-kvm/util/network_definition_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe VagrantPlugins::ProviderKvm::Util::NetworkDefinition do
+  let(:name) { 'vagrant' }
+  let(:xml) do
+    <<-XML
+      <network connections='1'>
+        <name>vagrant</name>
+        <uuid>0b9deaff-7665-d129-02e9-0f0a74054f87</uuid>
+        <forward mode='nat'/>
+        <bridge name='virbr1' stp='on' delay='0' />
+        <mac address='52:54:00:DE:20:0C'/>
+        <domain name='vagrant.local'/>
+        <ip address='192.168.123.1' netmask='255.255.255.0'>
+          <dhcp>
+            <range start='192.168.123.100' end='192.168.123.200' />
+            <host mac='00:69:0d:c2:52:f7' name='default' ip='192.168.123.10' />
+          </dhcp>
+        </ip>
+      </network>
+    XML
+  end
+
+  let(:definition) { described_class.new(name, xml) }
+  subject { definition }
+
+  it "should set the attributes properly" do
+    subject.get(:forward).should == 'nat'
+    subject.get(:domain_name).should == 'vagrant.local'
+    subject.get(:base_ip).should == '192.168.123.1'
+    subject.get(:netmask).should == '255.255.255.0'
+    subject.get(:range).should == { :start => "192.168.123.100", :end => "192.168.123.200"}
+    subject.get(:hosts).should == [ {
+      :mac => '00:69:0d:c2:52:f7',
+      :name => 'default',
+      :ip => '192.168.123.10',
+    }]
+  end
+
+  
+  describe "#==" do
+    it "returns true if and only if all attributes are equal" do
+      def1 = described_class.new(name, xml)
+      def2 = described_class.new(name, xml)
+
+      def1.should == def2
+
+      def2.set(:netmask, '255.255.0.0')
+      def1.should_not == def2
+    end
+  end
+
+  describe "#as_xml" do
+    it "should be symetrical" do
+      def1 = described_class.new(name, subject.as_xml)
+      subject.should == def1
+      subject.as_xml.should == def1.as_xml
+    end
+  end
+end