vagrant-cloudstack 1.3.0 → 1.4.0

data/lib/vagrant-cloudstack/util/timer.rb

@@ -1,17 +1,17 @@
-module VagrantPlugins
-  module Cloudstack
-    module Util
-      class Timer
-        # A basic utility method that times the execution of the given
-        # block and returns it.
-        def self.time
-          start_time = Time.now.to_f
-          yield
-          end_time = Time.now.to_f
-
-          end_time - start_time
-        end
-      end
-    end
-  end
-end
+module VagrantPlugins
+  module Cloudstack
+    module Util
+      class Timer
+        # A basic utility method that times the execution of the given
+        # block and returns it.
+        def self.time
+          start_time = Time.now.to_f
+          yield
+          end_time = Time.now.to_f
+
+          end_time - start_time
+        end
+      end
+    end
+  end
+end

data/lib/vagrant-cloudstack/version.rb

@@ -1,5 +1,5 @@
-module VagrantPlugins
-  module Cloudstack
-    VERSION = '1.3.0'
-  end
-end
+module VagrantPlugins
+  module Cloudstack
+    VERSION = '1.4.0'
+  end
+end

data/lib/vagrant-cloudstack.rb

@@ -1,17 +1,17 @@
-require "pathname"
-require "vagrant-cloudstack/plugin"
-
-module VagrantPlugins
-  module Cloudstack
-    lib_path = Pathname.new(File.expand_path("../vagrant-cloudstack", __FILE__))
-    autoload :Action, lib_path.join("action")
-    autoload :Errors, lib_path.join("errors")
-
-    # This returns the path to the source of this plugin.
-    #
-    # @return [Pathname]
-    def self.source_root
-      @source_root ||= Pathname.new(File.expand_path("../../", __FILE__))
-    end
-  end
-end
+require "pathname"
+require "vagrant-cloudstack/plugin"
+
+module VagrantPlugins
+  module Cloudstack
+    lib_path = Pathname.new(File.expand_path("../vagrant-cloudstack", __FILE__))
+    autoload :Action, lib_path.join("action")
+    autoload :Errors, lib_path.join("errors")
+
+    # This returns the path to the source of this plugin.
+    #
+    # @return [Pathname]
+    def self.source_root
+      @source_root ||= Pathname.new(File.expand_path("../../", __FILE__))
+    end
+  end
+end

data/locales/en.yml

@@ -1,123 +1,131 @@
-en:
-  vagrant_cloudstack:
-    already_status: |-
-      The machine is already %{status}.
-    basic_network: |-
-      Network name or id defined but zone %{zone_name} is of network type 'Basic'
-      Network name or id will be ignored
-    launching_instance: |-
-      Launching an instance with the following settings...
-    launch_no_keypair_no_sshkey: |-
-      No keypair or ssh_key specified to launch your instance with.
-      Generating a temporary keypair for this instance...
-    launch_vpc_warning: |-
-      Warning! You're launching this instance into a VPC without an
-      elastic IP. Please verify you're properly connected to a VPN so
-      you can access this machine, otherwise Vagrant will not be able
-      to SSH into it.
-    not_created: |-
-      Instance is not created. Please run `vagrant up` first.
-    ready: |-
-      Machine is booted and ready for use!
-    rsync_not_found_warning: |-
-      Warning! Folder sync disabled because the rsync binary is missing.
-      Make sure rsync is installed and the binary can be found in the PATH.
-    rsync_folder: |-
-      Rsyncing folder: %{hostpath} => %{guestpath}
-    security_groups_disabled: |-
-      Security groups defined but not supported in the zone %{zone_name}
-      Defined security groups will be ignored
-    ssh_key_pair_creating: |-
-      Creating an SSH keypair in CloudStack...
-    ssh_key_pair_removing: |-
-      Deleting the SSH keypair in CloudStack...
-    ssh_key_pair_no_success_removing: |-
-      Removing SSH keypair returned unsuccesful (keypair name: %{name})
-    starting: |-
-      Starting the instance...
-    stopping: |-
-      Stopping the instance...
-    terminating: |-
-      Terminating the instance...
-    waiting_for_ready: |-
-      Waiting for instance to become "ready"...
-    waiting_for_communicator: |-
-      Waiting for %{communicator} to become available...
-    enabling_static_nat: |-
-      Enabling Static NAT for this instance ...
-    disabling_static_nat: |-
-      Disabling Static NAT ...
-    creating_port_forwarding_rule: |-
-      Creating a port forwarding rule for this instance ...
-    deleting_port_forwarding_rule: |-
-      Deleting the port forwarding rule ...
-    creating_firewall_rule: |-
-      Creating a firewall rule ...
-    deleting_firewall_rule: |-
-      Deleting the firewall rule ...
-    warn_networks: |-
-      Warning! The Cloudstack provider doesn't support any of the Vagrant
-      high-level network configurations (`config.vm.network`). They
-      will be silently ignored.
-    will_not_destroy: |-
-      The instance '%{name}' will not be destroyed, since the confirmation
-      was declined.
-    no_instance_found : |-
-      No instance found, already destroyed?
-
-    config:
-      api_key_required: |-
-        An access key ID must be specified via "api_key"
-      template_id_required: |-
-        A template_id  must be configured via "template_id"
-      secret_key_missing: |-
-        The specified secret key for Cloudstack could not be found
-
-    errors:
-      fog_error: |-
-        There was an error talking to Cloudstack. The error message is shown
-        below:
-
-        %{message}
-      instance_ready_timeout: |-
-        The instance never became "ready" in Cloudstack. The timeout currently
-        set waiting for the instance to become ready is %{timeout} seconds.
-        Please verify that the machine properly boots. If you need more time
-        set the `instance_ready_timeout` configuration on the Cloudstack provider.
-      rsync_error: |-
-        There was an error when attemping to rsync a share folder.
-        Please inspect the error message below for more info.
-
-        Host path: %{hostpath}
-        Guest path: %{guestpath}
-        Error: %{stderr}
-      user_data_error: |-
-        The base64 encoded user data length (%{userdataLength}) is greater than 2048.
-
-    states:
-      short_not_created: |-
-        not created
-      long_not_created: |-
-        The instance is not created. Run `vagrant up` to create it.
-
-      short_starting: |-
-        starting
-      long_starting: |-
-        The instance is starting.
-
-      short_stopped: |-
-        stopped
-      long_stopped: |-
-        The instance is stopped. Run `vagrant up` to start it.
-
-      short_stopping: |-
-        stopping
-      long_stopping: |-
-        The instance is stopping. Wait until is completely stopped to 
-        run `vagrant up` and start it.
-
-      short_running: |-
-        running
-      long_running: |-
-        The instance is running. To stop this machine, you can run
-        `vagrant halt`. To destroy the machine, you can run `vagrant destroy`.
+en:
+  vagrant_cloudstack:
+    already_status: |-
+      The machine is already %{status}.
+    basic_network: |-
+      Network name or id defined but zone %{zone_name} is of network type 'Basic'
+      Network name or id will be ignored
+    launching_instance: |-
+      Launching an instance with the following settings...
+    launch_no_keypair_no_sshkey: |-
+      No keypair or ssh_key specified to launch your instance with.
+      Generating a temporary keypair for this instance...
+    launch_vpc_warning: |-
+      Warning! You're launching this instance into a VPC without an
+      elastic IP. Please verify you're properly connected to a VPN so
+      you can access this machine, otherwise Vagrant will not be able
+      to SSH into it.
+    not_created: |-
+      Instance is not created. Please run `vagrant up` first.
+    ready: |-
+      Machine is booted and ready for use!
+    rsync_not_found_warning: |-
+      Warning! Folder sync disabled because the rsync binary is missing.
+      Make sure rsync is installed and the binary can be found in the PATH.
+    rsync_folder: |-
+      Rsyncing folder: %{hostpath} => %{guestpath}
+    security_groups_disabled: |-
+      Security groups defined but not supported in the zone %{zone_name}
+      Defined security groups will be ignored
+    ssh_key_pair_creating: |-
+      Creating an SSH keypair in CloudStack...
+    ssh_key_pair_removing: |-
+      Deleting the SSH keypair in CloudStack...
+    ssh_key_pair_no_success_removing: |-
+      Removing SSH keypair returned unsuccesful (keypair name: %{name})
+    starting: |-
+      Starting the instance...
+    stopping: |-
+      Stopping the instance...
+    terminating: |-
+      Terminating the instance...
+    terminateinstance_done: |-
+      Done removing resources
+    waiting_for_ready: |-
+      Waiting for instance to become "ready"...
+    waiting_for_communicator: |-
+      Waiting for %{communicator} to become available...
+    enabling_static_nat: |-
+      Enabling Static NAT for this instance ...
+    disabling_static_nat: |-
+      Disabling Static NAT ...
+    creating_port_forwarding_rule: |-
+      Creating a port forwarding rule for this instance ...
+    deleting_port_forwarding_rule: |-
+      Deleting the port forwarding rule ...
+    deleting_volumes: |-
+      Deleting additional volumes ...
+    delete_volume_failed: |-
+       -- Failed to delete volume: %{volume_id}
+    detach_volume_failed: |-
+       -- Failed to detach volume: %{message}
+    creating_firewall_rule: |-
+      Creating a firewall rule ...
+    deleting_firewall_rule: |-
+      Deleting the firewall rule ...
+    warn_networks: |-
+      Warning! The Cloudstack provider doesn't support any of the Vagrant
+      high-level network configurations (`config.vm.network`). They
+      will be silently ignored.
+    will_not_destroy: |-
+      The instance '%{name}' will not be destroyed, since the confirmation
+      was declined.
+    no_instance_found : |-
+      No instance found, already destroyed?
+
+    config:
+      api_key_required: |-
+        An access key ID must be specified via "api_key"
+      template_id_required: |-
+        A template_id  must be configured via "template_id"
+      secret_key_missing: |-
+        The specified secret key for Cloudstack could not be found
+
+    errors:
+      fog_error: |-
+        There was an error talking to Cloudstack. The error message is shown
+        below:
+
+        %{message}
+      instance_ready_timeout: |-
+        The instance never became "ready" in Cloudstack. The timeout currently
+        set waiting for the instance to become ready is %{timeout} seconds.
+        Please verify that the machine properly boots. If you need more time
+        set the `instance_ready_timeout` configuration on the Cloudstack provider.
+      rsync_error: |-
+        There was an error when attemping to rsync a share folder.
+        Please inspect the error message below for more info.
+
+        Host path: %{hostpath}
+        Guest path: %{guestpath}
+        Error: %{stderr}
+      user_data_error: |-
+        The base64 encoded user data length (%{userdataLength}) is greater than 2048.
+
+    states:
+      short_not_created: |-
+        not created
+      long_not_created: |-
+        The instance is not created. Run `vagrant up` to create it.
+
+      short_starting: |-
+        starting
+      long_starting: |-
+        The instance is starting.
+
+      short_stopped: |-
+        stopped
+      long_stopped: |-
+        The instance is stopped. Run `vagrant up` to start it.
+
+      short_stopping: |-
+        stopping
+      long_stopping: |-
+        The instance is stopping. Wait until is completely stopped to 
+        run `vagrant up` and start it.
+
+      short_running: |-
+        running
+      long_running: |-
+        The instance is running. To stop this machine, you can run
+        `vagrant halt`. To destroy the machine, you can run `vagrant destroy`.

data/spec/spec_helper.rb

@@ -1,6 +1,8 @@
-require 'simplecov'
-require 'coveralls'
-require 'rspec/its'
-
-SimpleCov.start
-Coveralls.wear!
+require 'simplecov'
+require 'coveralls'
+require 'rspec/its'
+
+Dir["#{__dir__}/vagrant-cloudstack/support/**/*.rb"].each { |f| require f }
+
+SimpleCov.start
+Coveralls.wear!

data/spec/vagrant-cloudstack/action/read_ssh_info_spec.rb

@@ -0,0 +1,80 @@
+require 'spec_helper'
+require 'vagrant-cloudstack/action/read_ssh_info'
+require 'vagrant-cloudstack/config'
+
+describe VagrantPlugins::Cloudstack::Action::ReadSSHInfo do
+  let(:action) { VagrantPlugins::Cloudstack::Action::ReadSSHInfo.new(nil, nil) }
+
+  describe "#fetch_nic_ip_address" do
+    subject { action.fetch_nic_ip_address(nics, domain_config) }
+
+    let(:nics) do
+      [
+        { "networkid" => "networkid1", "networkname" => "networkname1", "ipaddress" => "127.0.0.1" },
+        { "networkid" => "networkid2", "networkname" => "networkname2", "ipaddress" => "127.0.0.2" },
+        { "networkid" => "networkid3", "networkname" => "networkname3", "ipaddress" => "127.0.0.3" },
+      ]
+    end
+
+    let(:ssh_network_id)   { Vagrant::Plugin::V2::Config::UNSET_VALUE }
+    let(:ssh_network_name) { Vagrant::Plugin::V2::Config::UNSET_VALUE }
+
+    let(:domain_config) do
+      config = VagrantPlugins::Cloudstack::Config.new
+      config.domain_config :cloudstack do |cloudstack|
+        cloudstack.ssh_network_id   = ssh_network_id
+        cloudstack.ssh_network_name = ssh_network_name
+      end
+      config.finalize!
+      config.get_domain_config(:cloudstack)
+    end
+
+    context "without neither ssh_network_id and ssh_network_name" do
+      it { should eq "127.0.0.1" }
+    end
+
+    context "with ssh_network_id" do
+      context "when exists in nics" do
+        let(:ssh_network_id) { "networkid2" }
+
+        it { should eq "127.0.0.2" }
+      end
+
+      context "when not exists in nics" do
+        let(:ssh_network_id) { "unknown" }
+
+        it { should eq "127.0.0.1" }
+      end
+    end
+
+    context "with ssh_network_id" do
+      context "when exists in nics" do
+        let(:ssh_network_name) { "networkname3" }
+
+        it { should eq "127.0.0.3" }
+      end
+
+      context "when not exists in nics" do
+        let(:ssh_network_name) { "unknown" }
+
+        it { should eq "127.0.0.1" }
+      end
+    end
+
+    context "with both ssh_network_id and ssh_network_name" do
+      context "when exists in nics" do
+        let(:ssh_network_id)   { "networkid2" }
+        let(:ssh_network_name) { "networkname3" }
+
+        it { should eq "127.0.0.2" }
+      end
+
+      context "when not exists in nics" do
+        let(:ssh_network_id)   { "unknown" }
+        let(:ssh_network_name) { "unknown" }
+
+        it { should eq "127.0.0.1" }
+      end
+    end
+  end
+end

data/spec/vagrant-cloudstack/config_spec.rb

@@ -1,355 +1,355 @@
-require "spec_helper"
-require "vagrant-cloudstack/config"
-
-describe VagrantPlugins::Cloudstack::Config do
-  let(:instance) { described_class.new }
-
-  # Ensure tests are not affected by Cloudstack credential environment variables
-  before :each do
-    ENV.stub(:[] => nil)
-  end
-
-  describe "defaults" do
-    subject do
-      instance.tap do |o|
-        o.finalize!
-      end
-    end
-
-    its("host")                   { should be_nil  }
-    its("path")                   { should be_nil  }
-    its("port")                   { should be_nil  }
-    its("scheme")                 { should be_nil  }
-    its("api_key")                { should be_nil  }
-    its("secret_key")             { should be_nil  }
-    its("instance_ready_timeout") { should == 120  }
-    its("domain_id")              { should be_nil  }
-    its("network_id")             { should be_nil  }
-    its("project_id")             { should be_nil  }
-    its("service_offering_id")    { should be_nil  }
-    its("disk_offering_id")       { should be_nil  }
-    its("template_id")            { should be_nil  }
-    its("zone_id")                { should be_nil  }
-    its("keypair")                { should be_nil  }
-    its("static_nat")             { should == []   }
-    its("pf_ip_address_id")       { should be_nil  }
-    its("pf_ip_address")          { should be_nil  }
-    its("pf_public_port")         { should be_nil  }
-    its("pf_public_rdp_port")     { should be_nil  }
-    its("pf_private_rdp_port")    { should == 3389 }
-    its("pf_public_port_randomrange") { should == {:start=>49160, :end=>49200} }
-    its("pf_private_port")        { should be_nil  }
-    its("pf_open_firewall")       { should == true }
-    its("pf_trusted_networks")    { should be_nil  }
-    its("port_forwarding_rules")  { should == []   }
-    its("firewall_rules")         { should == []   }
-    its("security_group_ids")     { should == []   }
-    its("display_name")           { should be_nil  }
-    its("group")                  { should be_nil  }
-    its("security_group_names")   { should == []   }
-    its("security_groups")        { should == []   }
-    its("user_data")              { should be_nil  }
-    its("ssh_key")                { should be_nil  }
-    its("ssh_user")               { should be_nil  }
-    its("vm_user")                { should be_nil  }
-    its("vm_password")            { should be_nil  }
-    its("private_ip_address")     { should be_nil  }
-    its("expunge_on_destroy")     { should == false  }
-  end
-
-  describe "getting credentials from environment" do
-    context "without CloudStack credential environment variables" do
-      subject do
-        instance.tap do |o|
-          o.finalize!
-        end
-      end
-
-      its("api_key")    { should be_nil }
-      its("secret_key") { should be_nil }
-    end
-
-    context "with CloudStack credential variables" do
-      before :each do
-        ENV.stub(:[]).with("CLOUDSTACK_API_KEY").and_return("api_key")
-        ENV.stub(:[]).with("CLOUDSTACK_SECRET_KEY").and_return("secret_key")
-      end
-
-      subject do
-        instance.tap do |o|
-          o.finalize!
-        end
-      end
-
-      its("api_key")    { should == "api_key" }
-      its("secret_key") { should == "secret_key" }
-    end
-  end
-
-  describe "overriding defaults" do
-    # I typically don't meta-program in tests, but this is a very
-    # simple boilerplate test, so I cut corners here. It just sets
-    # each of these attributes to "foo" in isolation, and reads the value
-    # and asserts the proper result comes back out.
-    [:api_key, :template_id, :zone_id, :instance_ready_timeout,
-      :service_offering_id, :disk_offering_id, :api_key,
-      :secret_key, :network_id, :user_data].each do |attribute|
-
-      it "should not default #{attribute} if overridden" do
-        instance.send("#{attribute}=".to_sym, "foo")
-        instance.finalize!
-        instance.send(attribute).should == "foo"
-      end
-
-    end
-
-    it 'should not default pf_open_firewall if overridden' do
-      instance.pf_open_firewall = false
-      instance.finalize!
-
-      instance.pf_open_firewall.should == false
-    end
-  end
-
-  describe "getting credentials from environment" do
-    context "without Cloudstack credential environment variables" do
-      subject do
-        instance.tap do |o|
-          o.finalize!
-        end
-      end
-
-      its("api_key")    { should be_nil }
-      its("secret_key") { should be_nil }
-    end
-
-  end
-
-  describe "domain config" do
-    let(:config_host)                   { "foo" }
-    let(:config_path)                   { "foo" }
-    let(:config_port)                   { "foo" }
-    let(:config_scheme)                 { "foo" }
-    let(:config_api_key)                { "foo" }
-    let(:config_secret_key)             { "foo" }
-    let(:config_instance_ready_timeout) { 11111 }
-    let(:config_domain_id)              { "foo" }
-    let(:config_network_id)             { "foo" }
-    let(:config_project_id)             { "foo" }
-    let(:config_service_offering_id)    { "foo" }
-    let(:config_disk_offering_id)       { "foo" }
-    let(:config_template_id)            { "foo" }
-    let(:config_zone_id)                { "foo" }
-    let(:config_keypair)                { "foo" }
-    let(:config_static_nat)             { [{:foo => "bar"}, {:bar => "foo"}] }
-    let(:config_pf_ip_address_id)       { "foo" }
-    let(:config_pf_ip_address)          { "foo" }
-    let(:config_pf_public_port_randomrange)    { {:start=>1, :end=>9} }
-    let(:config_pf_public_port)         { "foo" }
-    let(:config_pf_public_rdp_port)     { "foo" }
-    let(:config_pf_private_rdp_port)    { "foo" }
-    let(:config_pf_private_port)        { "foo" }
-    let(:config_pf_open_firewall)       { false }
-    let(:config_pf_trusted_networks)    { ["foo", "bar"] }
-    let(:config_port_forwarding_rules)  { [{:foo => "bar"}, {:bar => "foo"}] }
-    let(:config_firewall_rules)         { [{:foo => "bar"}, {:bar => "foo"}] }
-    let(:config_security_group_ids)     { ["foo", "bar"] }
-    let(:config_display_name)           { "foo" }
-    let(:config_group)                  { "foo" }
-    let(:config_security_group_names)   { ["foo", "bar"] }
-    let(:config_security_groups)        { [{:foo => "bar"}, {:bar => "foo"}] }
-    let(:config_ssh_key)                { "./foo.pem" }
-    let(:config_ssh_user)               { "foo" }
-    let(:config_vm_user)                { "foo" }
-    let(:config_vm_password)            { "foo" }
-    let(:config_private_ip_address)     { "foo" }
-    let(:config_expunge_on_destroy)     { "foo" }
-
-    def set_test_values(instance)
-      instance.host                   = config_host
-      instance.path                   = config_path
-      instance.port                   = config_port
-      instance.scheme                 = config_scheme
-      instance.api_key                = config_api_key
-      instance.secret_key             = config_secret_key
-      instance.instance_ready_timeout = config_instance_ready_timeout
-      instance.domain_id              = config_domain_id
-      instance.network_id             = config_network_id
-      instance.project_id             = config_project_id
-      instance.service_offering_id    = config_service_offering_id
-      instance.disk_offering_id       = config_disk_offering_id
-      instance.template_id            = config_template_id
-      instance.zone_id                = config_zone_id
-      instance.keypair                = config_keypair
-      instance.static_nat             = config_static_nat
-      instance.pf_ip_address_id       = config_pf_ip_address_id
-      instance.pf_public_port_randomrange = config_pf_public_port_randomrange
-      instance.pf_ip_address          = config_pf_ip_address
-      instance.pf_public_port         = config_pf_public_port
-      instance.pf_public_rdp_port     = config_pf_public_rdp_port
-      instance.pf_private_rdp_port    = config_pf_private_rdp_port
-      instance.pf_private_port        = config_pf_private_port
-      instance.pf_open_firewall       = config_pf_open_firewall
-      instance.pf_trusted_networks    = config_pf_trusted_networks
-      instance.port_forwarding_rules  = config_port_forwarding_rules
-      instance.firewall_rules         = config_firewall_rules
-      instance.security_group_ids     = config_security_group_ids
-      instance.display_name           = config_display_name
-      instance.group                  = config_group
-      instance.security_group_names   = config_security_group_names
-      instance.security_groups        = config_security_groups
-      instance.ssh_key                = config_ssh_key
-      instance.ssh_user               = config_ssh_user
-      instance.vm_user                = config_vm_user
-      instance.vm_password            = config_vm_password
-      instance.private_ip_address     = config_private_ip_address
-      instance.expunge_on_destroy     = config_expunge_on_destroy
-    end
-
-    it "should raise an exception if not finalized" do
-      expect { instance.get_domain_config("default") }.
-        to raise_error
-    end
-
-    context "with no specific config set" do
-      subject do
-        # Set the values on the top-level object
-        set_test_values(instance)
-
-        # Finalize so we can get the domain config
-        instance.finalize!
-
-        # Get a lower level domain
-        instance.get_domain_config("default")
-      end
-
-      its("host")                   { should == config_host }
-      its("path")                   { should == config_path }
-      its("port")                   { should == config_port }
-      its("scheme")                 { should == config_scheme }
-      its("api_key")                { should == config_api_key }
-      its("secret_key")             { should == config_secret_key }
-      its("instance_ready_timeout") { should == config_instance_ready_timeout }
-      its("domain_id")              { should == config_domain_id }
-      its("network_id")             { should == config_network_id }
-      its("project_id")             { should == config_project_id }
-      its("service_offering_id")    { should == config_service_offering_id }
-      its("disk_offering_id")       { should == config_disk_offering_id }
-      its("template_id")            { should == config_template_id }
-      its("zone_id")                { should == config_zone_id }
-      its("keypair")                { should == config_keypair }
-      its("static_nat")             { should == config_static_nat }
-      its("pf_ip_address_id")       { should == config_pf_ip_address_id }
-      its("pf_ip_address")          { should == config_pf_ip_address }
-      its("pf_public_port")         { should == config_pf_public_port }
-      its("pf_public_rdp_port")     { should == config_pf_public_rdp_port }
-      its("pf_private_rdp_port")    { should == config_pf_private_rdp_port }
-      its("pf_public_port_randomrange") { should == config_pf_public_port_randomrange}
-      its("pf_private_port")        { should == config_pf_private_port }
-      its("pf_trusted_networks")    { should == config_pf_trusted_networks}
-      its("pf_open_firewall")       { should == config_pf_open_firewall }
-      its("port_forwarding_rules")  { should == config_port_forwarding_rules }
-      its("firewall_rules")         { should == config_firewall_rules }
-      its("security_group_ids")     { should == config_security_group_ids }
-      its("display_name")           { should == config_display_name }
-      its("group")                  { should == config_group }
-      its("security_group_names")   { should == config_security_group_names }
-      its("security_groups")        { should == config_security_groups }
-      its("ssh_key")                { should == config_ssh_key }
-      its("ssh_user")               { should == config_ssh_user }
-      its("vm_user")                { should == config_vm_user }
-      its("vm_password")            { should == config_vm_password }
-      its("private_ip_address")     { should == config_private_ip_address }
-      its("expunge_on_destroy")     { should == config_expunge_on_destroy }
-    end
-
-    context "with a specific config set" do
-      let(:domain_name) { "hashi-domain" }
-
-      subject do
-        # Set the values on a specific domain
-        instance.domain_config domain_name do |config|
-          set_test_values(config)
-        end
-
-        # Finalize so we can get the domain config
-        instance.finalize!
-
-        # Get the domain
-        instance.get_domain_config(domain_name)
-      end
-
-      its("host")                   { should == config_host }
-      its("path")                   { should == config_path }
-      its("port")                   { should == config_port }
-      its("scheme")                 { should == config_scheme }
-      its("api_key")                { should == config_api_key }
-      its("secret_key")             { should == config_secret_key }
-      its("instance_ready_timeout") { should == config_instance_ready_timeout }
-      its("domain_id")              { should == config_domain_id }
-      its("network_id")             { should == config_network_id }
-      its("project_id")             { should == config_project_id }
-      its("service_offering_id")    { should == config_service_offering_id }
-      its("disk_offering_id")       { should == config_disk_offering_id }
-      its("template_id")            { should == config_template_id }
-      its("zone_id")                { should == config_zone_id }
-      its("keypair")                { should == config_keypair }
-      its("static_nat")             { should == config_static_nat }
-      its("pf_ip_address_id")       { should == config_pf_ip_address_id }
-      its("pf_ip_address")          { should == config_pf_ip_address }
-      its("pf_public_port")         { should == config_pf_public_port }
-      its("pf_public_rdp_port")     { should == config_pf_public_rdp_port }
-      its("pf_private_rdp_port")    { should == config_pf_private_rdp_port }
-      its("pf_public_port_randomrange") { should == config_pf_public_port_randomrange}
-      its("pf_private_port")        { should == config_pf_private_port }
-      its("pf_open_firewall")       { should == config_pf_open_firewall }
-      its("pf_trusted_networks")    { should == config_pf_trusted_networks}
-      its("port_forwarding_rules")  { should == config_port_forwarding_rules }
-      its("firewall_rules")         { should == config_firewall_rules }
-      its("security_group_ids")     { should == config_security_group_ids }
-      its("display_name")           { should == config_display_name }
-      its("group")                  { should == config_group }
-      its("security_group_names")   { should == config_security_group_names }
-      its("security_groups")        { should == config_security_groups }
-      its("ssh_key")                { should == config_ssh_key }
-      its("ssh_user")               { should == config_ssh_user }
-      its("vm_user")                { should == config_vm_user }
-      its("vm_password")            { should == config_vm_password }
-      its("private_ip_address")     { should == config_private_ip_address }
-      its("expunge_on_destroy")     { should == config_expunge_on_destroy }
-    end
-
-    describe "inheritance of parent config" do
-      let(:domain_name) { "hashi-domain" }
-
-      subject do
-        # Set the values on a specific domain
-        instance.domain_config domain_name do |config|
-          config.template_id = "child"
-        end
-
-        # Set some top-level values
-        instance.api_key     = "parent"
-        instance.template_id = "parent"
-
-        # Finalize and get the domain
-        instance.finalize!
-        instance.get_domain_config(domain_name)
-      end
-
-      its("api_key")     { should == "parent" }
-      its("template_id") { should == "child" }
-    end
-
-    describe "shortcut configuration" do
-      subject do
-        # Use the shortcut configuration to set some values
-        instance.domain_config "Domain1", :template_id => "child"
-        instance.finalize!
-        instance.get_domain_config("Domain1")
-      end
-
-      its("template_id") { should == "child" }
-    end
-  end
-end
+require "spec_helper"
+require "vagrant-cloudstack/config"
+
+describe VagrantPlugins::Cloudstack::Config do
+  let(:instance) { described_class.new }
+
+  # Ensure tests are not affected by Cloudstack credential environment variables
+  before :each do
+    ENV.stub(:[] => nil)
+  end
+
+  describe "defaults" do
+    subject do
+      instance.tap do |o|
+        o.finalize!
+      end
+    end
+
+    its("host")                   { should be_nil  }
+    its("path")                   { should be_nil  }
+    its("port")                   { should be_nil  }
+    its("scheme")                 { should be_nil  }
+    its("api_key")                { should be_nil  }
+    its("secret_key")             { should be_nil  }
+    its("instance_ready_timeout") { should == 120  }
+    its("domain_id")              { should be_nil  }
+    its("network_id")             { should be_nil  }
+    its("project_id")             { should be_nil  }
+    its("service_offering_id")    { should be_nil  }
+    its("disk_offering_id")       { should be_nil  }
+    its("template_id")            { should be_nil  }
+    its("zone_id")                { should be_nil  }
+    its("keypair")                { should be_nil  }
+    its("static_nat")             { should == []   }
+    its("pf_ip_address_id")       { should be_nil  }
+    its("pf_ip_address")          { should be_nil  }
+    its("pf_public_port")         { should be_nil  }
+    its("pf_public_rdp_port")     { should be_nil  }
+    its("pf_private_rdp_port")    { should == 3389 }
+    its("pf_public_port_randomrange") { should == {:start=>49160, :end=>49200} }
+    its("pf_private_port")        { should be_nil  }
+    its("pf_open_firewall")       { should == true }
+    its("pf_trusted_networks")    { should be_nil  }
+    its("port_forwarding_rules")  { should == []   }
+    its("firewall_rules")         { should == []   }
+    its("security_group_ids")     { should == []   }
+    its("display_name")           { should be_nil  }
+    its("group")                  { should be_nil  }
+    its("security_group_names")   { should == []   }
+    its("security_groups")        { should == []   }
+    its("user_data")              { should be_nil  }
+    its("ssh_key")                { should be_nil  }
+    its("ssh_user")               { should be_nil  }
+    its("vm_user")                { should be_nil  }
+    its("vm_password")            { should be_nil  }
+    its("private_ip_address")     { should be_nil  }
+    its("expunge_on_destroy")     { should == false  }
+  end
+
+  describe "getting credentials from environment" do
+    context "without CloudStack credential environment variables" do
+      subject do
+        instance.tap do |o|
+          o.finalize!
+        end
+      end
+
+      its("api_key")    { should be_nil }
+      its("secret_key") { should be_nil }
+    end
+
+    context "with CloudStack credential variables" do
+      before :each do
+        ENV.stub(:[]).with("CLOUDSTACK_API_KEY").and_return("api_key")
+        ENV.stub(:[]).with("CLOUDSTACK_SECRET_KEY").and_return("secret_key")
+      end
+
+      subject do
+        instance.tap do |o|
+          o.finalize!
+        end
+      end
+
+      its("api_key")    { should == "api_key" }
+      its("secret_key") { should == "secret_key" }
+    end
+  end
+
+  describe "overriding defaults" do
+    # I typically don't meta-program in tests, but this is a very
+    # simple boilerplate test, so I cut corners here. It just sets
+    # each of these attributes to "foo" in isolation, and reads the value
+    # and asserts the proper result comes back out.
+    [:api_key, :template_id, :zone_id, :instance_ready_timeout,
+      :service_offering_id, :disk_offering_id, :api_key,
+      :secret_key, :network_id, :user_data].each do |attribute|
+
+      it "should not default #{attribute} if overridden" do
+        instance.send("#{attribute}=".to_sym, "foo")
+        instance.finalize!
+        instance.send(attribute).should == "foo"
+      end
+
+    end
+
+    it 'should not default pf_open_firewall if overridden' do
+      instance.pf_open_firewall = false
+      instance.finalize!
+
+      instance.pf_open_firewall.should == false
+    end
+  end
+
+  describe "getting credentials from environment" do
+    context "without Cloudstack credential environment variables" do
+      subject do
+        instance.tap do |o|
+          o.finalize!
+        end
+      end
+
+      its("api_key")    { should be_nil }
+      its("secret_key") { should be_nil }
+    end
+
+  end
+
+  describe "domain config" do
+    let(:config_host)                   { "foo" }
+    let(:config_path)                   { "foo" }
+    let(:config_port)                   { "foo" }
+    let(:config_scheme)                 { "foo" }
+    let(:config_api_key)                { "foo" }
+    let(:config_secret_key)             { "foo" }
+    let(:config_instance_ready_timeout) { 11111 }
+    let(:config_domain_id)              { "foo" }
+    let(:config_network_id)             { "foo" }
+    let(:config_project_id)             { "foo" }
+    let(:config_service_offering_id)    { "foo" }
+    let(:config_disk_offering_id)       { "foo" }
+    let(:config_template_id)            { "foo" }
+    let(:config_zone_id)                { "foo" }
+    let(:config_keypair)                { "foo" }
+    let(:config_static_nat)             { [{:foo => "bar"}, {:bar => "foo"}] }
+    let(:config_pf_ip_address_id)       { "foo" }
+    let(:config_pf_ip_address)          { "foo" }
+    let(:config_pf_public_port_randomrange)    { {:start=>1, :end=>9} }
+    let(:config_pf_public_port)         { "foo" }
+    let(:config_pf_public_rdp_port)     { "foo" }
+    let(:config_pf_private_rdp_port)    { "foo" }
+    let(:config_pf_private_port)        { "foo" }
+    let(:config_pf_open_firewall)       { false }
+    let(:config_pf_trusted_networks)    { ["foo", "bar"] }
+    let(:config_port_forwarding_rules)  { [{:foo => "bar"}, {:bar => "foo"}] }
+    let(:config_firewall_rules)         { [{:foo => "bar"}, {:bar => "foo"}] }
+    let(:config_security_group_ids)     { ["foo", "bar"] }
+    let(:config_display_name)           { "foo" }
+    let(:config_group)                  { "foo" }
+    let(:config_security_group_names)   { ["foo", "bar"] }
+    let(:config_security_groups)        { [{:foo => "bar"}, {:bar => "foo"}] }
+    let(:config_ssh_key)                { "./foo.pem" }
+    let(:config_ssh_user)               { "foo" }
+    let(:config_vm_user)                { "foo" }
+    let(:config_vm_password)            { "foo" }
+    let(:config_private_ip_address)     { "foo" }
+    let(:config_expunge_on_destroy)     { "foo" }
+
+    def set_test_values(instance)
+      instance.host                   = config_host
+      instance.path                   = config_path
+      instance.port                   = config_port
+      instance.scheme                 = config_scheme
+      instance.api_key                = config_api_key
+      instance.secret_key             = config_secret_key
+      instance.instance_ready_timeout = config_instance_ready_timeout
+      instance.domain_id              = config_domain_id
+      instance.network_id             = config_network_id
+      instance.project_id             = config_project_id
+      instance.service_offering_id    = config_service_offering_id
+      instance.disk_offering_id       = config_disk_offering_id
+      instance.template_id            = config_template_id
+      instance.zone_id                = config_zone_id
+      instance.keypair                = config_keypair
+      instance.static_nat             = config_static_nat
+      instance.pf_ip_address_id       = config_pf_ip_address_id
+      instance.pf_public_port_randomrange = config_pf_public_port_randomrange
+      instance.pf_ip_address          = config_pf_ip_address
+      instance.pf_public_port         = config_pf_public_port
+      instance.pf_public_rdp_port     = config_pf_public_rdp_port
+      instance.pf_private_rdp_port    = config_pf_private_rdp_port
+      instance.pf_private_port        = config_pf_private_port
+      instance.pf_open_firewall       = config_pf_open_firewall
+      instance.pf_trusted_networks    = config_pf_trusted_networks
+      instance.port_forwarding_rules  = config_port_forwarding_rules
+      instance.firewall_rules         = config_firewall_rules
+      instance.security_group_ids     = config_security_group_ids
+      instance.display_name           = config_display_name
+      instance.group                  = config_group
+      instance.security_group_names   = config_security_group_names
+      instance.security_groups        = config_security_groups
+      instance.ssh_key                = config_ssh_key
+      instance.ssh_user               = config_ssh_user
+      instance.vm_user                = config_vm_user
+      instance.vm_password            = config_vm_password
+      instance.private_ip_address     = config_private_ip_address
+      instance.expunge_on_destroy     = config_expunge_on_destroy
+    end
+
+    it "should raise an exception if not finalized" do
+      expect { instance.get_domain_config("default") }.
+        to raise_error
+    end
+
+    context "with no specific config set" do
+      subject do
+        # Set the values on the top-level object
+        set_test_values(instance)
+
+        # Finalize so we can get the domain config
+        instance.finalize!
+
+        # Get a lower level domain
+        instance.get_domain_config("default")
+      end
+
+      its("host")                   { should == config_host }
+      its("path")                   { should == config_path }
+      its("port")                   { should == config_port }
+      its("scheme")                 { should == config_scheme }
+      its("api_key")                { should == config_api_key }
+      its("secret_key")             { should == config_secret_key }
+      its("instance_ready_timeout") { should == config_instance_ready_timeout }
+      its("domain_id")              { should == config_domain_id }
+      its("network_id")             { should == config_network_id }
+      its("project_id")             { should == config_project_id }
+      its("service_offering_id")    { should == config_service_offering_id }
+      its("disk_offering_id")       { should == config_disk_offering_id }
+      its("template_id")            { should == config_template_id }
+      its("zone_id")                { should == config_zone_id }
+      its("keypair")                { should == config_keypair }
+      its("static_nat")             { should == config_static_nat }
+      its("pf_ip_address_id")       { should == config_pf_ip_address_id }
+      its("pf_ip_address")          { should == config_pf_ip_address }
+      its("pf_public_port")         { should == config_pf_public_port }
+      its("pf_public_rdp_port")     { should == config_pf_public_rdp_port }
+      its("pf_private_rdp_port")    { should == config_pf_private_rdp_port }
+      its("pf_public_port_randomrange") { should == config_pf_public_port_randomrange}
+      its("pf_private_port")        { should == config_pf_private_port }
+      its("pf_trusted_networks")    { should == config_pf_trusted_networks}
+      its("pf_open_firewall")       { should == config_pf_open_firewall }
+      its("port_forwarding_rules")  { should == config_port_forwarding_rules }
+      its("firewall_rules")         { should == config_firewall_rules }
+      its("security_group_ids")     { should == config_security_group_ids }
+      its("display_name")           { should == config_display_name }
+      its("group")                  { should == config_group }
+      its("security_group_names")   { should == config_security_group_names }
+      its("security_groups")        { should == config_security_groups }
+      its("ssh_key")                { should == config_ssh_key }
+      its("ssh_user")               { should == config_ssh_user }
+      its("vm_user")                { should == config_vm_user }
+      its("vm_password")            { should == config_vm_password }
+      its("private_ip_address")     { should == config_private_ip_address }
+      its("expunge_on_destroy")     { should == config_expunge_on_destroy }
+    end
+
+    context "with a specific config set" do
+      let(:domain_name) { "hashi-domain" }
+
+      subject do
+        # Set the values on a specific domain
+        instance.domain_config domain_name do |config|
+          set_test_values(config)
+        end
+
+        # Finalize so we can get the domain config
+        instance.finalize!
+
+        # Get the domain
+        instance.get_domain_config(domain_name)
+      end
+
+      its("host")                   { should == config_host }
+      its("path")                   { should == config_path }
+      its("port")                   { should == config_port }
+      its("scheme")                 { should == config_scheme }
+      its("api_key")                { should == config_api_key }
+      its("secret_key")             { should == config_secret_key }
+      its("instance_ready_timeout") { should == config_instance_ready_timeout }
+      its("domain_id")              { should == config_domain_id }
+      its("network_id")             { should == config_network_id }
+      its("project_id")             { should == config_project_id }
+      its("service_offering_id")    { should == config_service_offering_id }
+      its("disk_offering_id")       { should == config_disk_offering_id }
+      its("template_id")            { should == config_template_id }
+      its("zone_id")                { should == config_zone_id }
+      its("keypair")                { should == config_keypair }
+      its("static_nat")             { should == config_static_nat }
+      its("pf_ip_address_id")       { should == config_pf_ip_address_id }
+      its("pf_ip_address")          { should == config_pf_ip_address }
+      its("pf_public_port")         { should == config_pf_public_port }
+      its("pf_public_rdp_port")     { should == config_pf_public_rdp_port }
+      its("pf_private_rdp_port")    { should == config_pf_private_rdp_port }
+      its("pf_public_port_randomrange") { should == config_pf_public_port_randomrange}
+      its("pf_private_port")        { should == config_pf_private_port }
+      its("pf_open_firewall")       { should == config_pf_open_firewall }
+      its("pf_trusted_networks")    { should == config_pf_trusted_networks}
+      its("port_forwarding_rules")  { should == config_port_forwarding_rules }
+      its("firewall_rules")         { should == config_firewall_rules }
+      its("security_group_ids")     { should == config_security_group_ids }
+      its("display_name")           { should == config_display_name }
+      its("group")                  { should == config_group }
+      its("security_group_names")   { should == config_security_group_names }
+      its("security_groups")        { should == config_security_groups }
+      its("ssh_key")                { should == config_ssh_key }
+      its("ssh_user")               { should == config_ssh_user }
+      its("vm_user")                { should == config_vm_user }
+      its("vm_password")            { should == config_vm_password }
+      its("private_ip_address")     { should == config_private_ip_address }
+      its("expunge_on_destroy")     { should == config_expunge_on_destroy }
+    end
+
+    describe "inheritance of parent config" do
+      let(:domain_name) { "hashi-domain" }
+
+      subject do
+        # Set the values on a specific domain
+        instance.domain_config domain_name do |config|
+          config.template_id = "child"
+        end
+
+        # Set some top-level values
+        instance.api_key     = "parent"
+        instance.template_id = "parent"
+
+        # Finalize and get the domain
+        instance.finalize!
+        instance.get_domain_config(domain_name)
+      end
+
+      its("api_key")     { should == "parent" }
+      its("template_id") { should == "child" }
+    end
+
+    describe "shortcut configuration" do
+      subject do
+        # Use the shortcut configuration to set some values
+        instance.domain_config "Domain1", :template_id => "child"
+        instance.finalize!
+        instance.get_domain_config("Domain1")
+      end
+
+      its("template_id") { should == "child" }
+    end
+  end
+end