vacuum 3.0.0 → 3.4.1

data/test/helper.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+# Keep SimpleCov at top.
+require 'simplecov'
+
+SimpleCov.start do
+  add_filter '/test/'
+end
+
+require 'minitest/autorun'

data/test/integration/test_requests.rb

@@ -0,0 +1,105 @@
+# frozen_string_literal: true
+
+require 'integration_helper'
+
+module Vacuum
+  class TestRequests < IntegrationTest
+    def test_get_browse_nodes
+      requests.each do |request|
+        response = request.get_browse_nodes(browse_node_ids: ['3045'])
+        assert_equal 200, response.status
+      end
+    end
+
+    def test_get_items
+      requests.each do |request|
+        response = request.get_items(item_ids: ['B07212L4G2'])
+        assert_equal 200, response.status
+      end
+    end
+
+    RESOURCE_ALL = %w[BrowseNodeInfo.BrowseNodes
+                      BrowseNodeInfo.BrowseNodes.Ancestor
+                      BrowseNodeInfo.BrowseNodes.SalesRank
+                      BrowseNodeInfo.WebsiteSalesRank
+                      Images.Primary.Small
+                      Images.Primary.Medium
+                      Images.Primary.Large
+                      Images.Variants.Small
+                      Images.Variants.Medium
+                      Images.Variants.Large
+                      ItemInfo.ByLineInfo
+                      ItemInfo.Classifications
+                      ItemInfo.ContentInfo
+                      ItemInfo.ContentRating
+                      ItemInfo.ExternalIds
+                      ItemInfo.Features
+                      ItemInfo.ManufactureInfo
+                      ItemInfo.ProductInfo
+                      ItemInfo.TechnicalInfo
+                      ItemInfo.Title
+                      ItemInfo.TradeInInfo
+                      Offers.Listings.Availability.MaxOrderQuantity
+                      Offers.Listings.Availability.Message
+                      Offers.Listings.Availability.MinOrderQuantity
+                      Offers.Listings.Availability.Type
+                      Offers.Listings.Condition
+                      Offers.Listings.Condition.SubCondition
+                      Offers.Listings.DeliveryInfo.IsAmazonFulfilled
+                      Offers.Listings.DeliveryInfo.IsFreeShippingEligible
+                      Offers.Listings.DeliveryInfo.IsPrimeEligible
+                      Offers.Listings.IsBuyBoxWinner
+                      Offers.Listings.LoyaltyPoints.Points
+                      Offers.Listings.MerchantInfo
+                      Offers.Listings.Price
+                      Offers.Listings.ProgramEligibility.IsPrimeExclusive
+                      Offers.Listings.ProgramEligibility.IsPrimePantry
+                      Offers.Listings.Promotions
+                      Offers.Listings.SavingBasis
+                      Offers.Summaries.HighestPrice
+                      Offers.Summaries.LowestPrice
+                      Offers.Summaries.OfferCount
+                      ParentASIN].freeze
+
+    def test_get_items_with_all_resources
+      requests.each do |request|
+        response = request.get_items(item_ids: 'B07212L4G2',
+                                     resources: RESOURCE_ALL)
+        assert_equal 200, response.status
+        item = response.dig('ItemsResult', 'Items').first
+        assert item.key?('BrowseNodeInfo')
+      end
+    end
+
+    def test_get_variations
+      requests.each do |request|
+        response = request.get_variations(asin: 'B07212L4G2')
+        assert_equal 200, response.status
+      end
+    end
+
+    def test_search_items
+      requests.each do |request|
+        response = request.search_items(keywords: 'Harry Potter')
+        assert_equal 200, response.status
+      end
+    end
+
+    def test_persistent
+      request = requests.sample
+      refute request.client.persistent?
+      request.persistent
+      assert request.client.persistent?
+    end
+
+    def test_logging
+      require 'logger'
+      logdev = StringIO.new
+      logger = Logger.new(logdev)
+      request = requests.sample
+      request.use(logging: { logger: logger })
+      request.search_items(keywords: 'Harry Potter')
+      refute_empty logdev.string
+    end
+  end
+end

data/test/integration_helper.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'minitest/autorun'
+require 'helper'
 require 'vcr'
 
 require 'locales'
@@ -27,8 +27,6 @@ VCR.configure do |c|
   end
 end
 
-HTTPI.log = false
-
 module Vacuum
   class IntegrationTest < Minitest::Test
     def setup
@@ -47,7 +45,7 @@ module Vacuum
     private
 
     def requests
-      Locales.map { |credentials| Vacuum.new(credentials) }.shuffle
+      Locales.map { |credentials| Vacuum.new(**credentials) }.shuffle
     end
   end
 end

data/test/locales.yml.example

@@ -10,6 +10,14 @@
   :access_key: access_key
   :secret_key: secret_key
   :partner_tag: partner_tag
+- :marketplace: FR
+  :access_key: access_key
+  :secret_key: secret_key
+  :partner_tag: partner_tag
+- :marketplace: IT
+  :access_key: access_key
+  :secret_key: secret_key
+  :partner_tag: partner_tag
 - :marketplace: GB
   :access_key: access_key
   :secret_key: secret_key

data/test/unit/test_locale.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require 'helper'
+require 'vacuum/locale'
+
+module Vacuum
+  class TestLocale < Minitest::Test
+    def test_host
+      locale = Locale.new(:us, **credentials)
+      assert locale.host
+    end
+
+    def test_region
+      locale = Locale.new(:us, **credentials)
+      assert locale.region
+    end
+
+    def test_partner_type_default
+      locale = Locale.new(:us, **credentials)
+      assert locale.partner_type
+    end
+
+    def test_upcased_marketplace
+      Locale.new('US', **credentials) # does not raise
+    end
+
+    def test_uk
+      Locale.new(:uk, **credentials) # does not raise
+    end
+
+    def test_not_found
+      assert_raises Locale::NotFound do
+        Locale.new(:foo, **credentials)
+      end
+    end
+
+    private
+
+    def credentials
+      { access_key: '123', secret_key: '123', partner_tag: 'xyz-20' }
+    end
+  end
+end

data/test/unit/test_operation.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'helper'
+require 'vacuum/locale'
+require 'vacuum/operation'
+
+module Vacuum
+  class TestOperation < Minitest::Test
+    def setup
+      @operation = Operation.new('Action', params: { foo: 1 }, locale: locale)
+    end
+
+    def test_body
+      assert @operation.body
+    end
+
+    def test_url
+      assert @operation.url
+    end
+
+    def test_headers
+      assert @operation.headers
+    end
+
+    private
+
+    def locale
+      Locale.new(:us, access_key: '123', secret_key: '123', partner_tag: 'xyz')
+    end
+  end
+end

data/test/unit/test_request.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+require 'helper'
+require 'vacuum/request'
+
+module Vacuum
+  class TestRequest < Minitest::Test
+    def test_search_keywords
+      err = assert_raises(ArgumentError) do
+        api.search_items(keywords: ['Harry Potter'])
+      end
+
+      assert_equal ':keyword argument expects a String', err.message
+    end
+
+    def test_search_resources
+      err = assert_raises(ArgumentError) do
+        api.search_items(
+          keywords: 'Harry Potter',
+          resources: %w[Images.Primary.Large ItemInfo.ExternalIds Offer.Listings.Price]
+        )
+      end
+
+      assert_equal 'There is not such resource: Offer.Listings.Price', err.message
+    end
+
+    def test_get_items_wrong_resource
+      err = assert_raises(ArgumentError) do
+        api.get_items(
+          item_ids: :B07212L4G2,
+          resources: %w[BrowseNodeInfo.BrowseNode.SalesRank]
+        )
+      end
+
+      assert_equal 'There is not such resource: BrowseNodeInfo.BrowseNode.SalesRank', err.message
+    end
+
+    def test_get_variations_wrong_resource
+      err = assert_raises(ArgumentError) do
+        api.get_variations(asin: 'B07212L4G2', resources: %w[BrowseNodeInfo.BrowseNode.SalesRank])
+      end
+
+      assert_equal 'There is not such resource: BrowseNodeInfo.BrowseNode.SalesRank', err.message
+    end
+
+    def test_resource_not_array
+      err = assert_raises(ArgumentError) do
+        api.get_items(item_ids: :B07212L4G2, resources: 'foo')
+      end
+
+      assert_equal ':resources argument expects an Array', err.message
+    end
+
+    def api
+      @api ||= Vacuum::Request.new(marketplace: 'US',
+                                   access_key: 'key',
+                                   secret_key: 'secret',
+                                   partner_tag: 'tag')
+    end
+  end
+end

data/test/{vacuum → unit}/test_response.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'minitest/autorun'
+require 'helper'
 require 'vacuum/response'
 
 module Vacuum
@@ -11,6 +11,10 @@ module Vacuum
       @response = Response.new(mock)
     end
 
+    def test_parse
+      assert @response.parse
+    end
+
     def test_cast_to_hash
       assert_kind_of Hash, @response.to_h
     end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: vacuum
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.4.1
 platform: ruby
 authors:
 - Hakan Ensari
-autorequire: 
+- Stanislav Katkov
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-10-30 00:00:00.000000000 Z
+date: 2020-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sigv4
@@ -25,19 +26,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: httpi
+  name: http
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +81,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.17.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.17.1
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -125,6 +140,7 @@ dependencies:
 description: A wrapper to the Amazon Product Advertising API
 email:
 - me@hakanensari.com
+- sk@skylup.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -134,22 +150,25 @@ files:
 - lib/vacuum.rb
 - lib/vacuum/locale.rb
 - lib/vacuum/matcher.rb
+- lib/vacuum/operation.rb
 - lib/vacuum/request.rb
 - lib/vacuum/response.rb
 - lib/vacuum/version.rb
 - test/cassettes/vacuum.yml
+- test/helper.rb
+- test/integration/test_requests.rb
 - test/integration_helper.rb
 - test/locales.rb
-- test/locales.yml
 - test/locales.yml.example
-- test/vacuum/test_locale.rb
-- test/vacuum/test_request.rb
-- test/vacuum/test_response.rb
+- test/unit/test_locale.rb
+- test/unit/test_operation.rb
+- test/unit/test_request.rb
+- test/unit/test_response.rb
 homepage: https://github.com/hakanensari/vacuum
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -157,23 +176,25 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Amazon Product Advertising in Ruby
 test_files:
-- test/vacuum/test_request.rb
-- test/vacuum/test_response.rb
-- test/vacuum/test_locale.rb
+- test/unit/test_operation.rb
+- test/unit/test_request.rb
+- test/unit/test_locale.rb
+- test/unit/test_response.rb
+- test/helper.rb
+- test/locales.yml.example
 - test/cassettes/vacuum.yml
-- test/integration_helper.rb
 - test/locales.rb
-- test/locales.yml
-- test/locales.yml.example
+- test/integration_helper.rb
+- test/integration/test_requests.rb