vacuum 3.0.0 → 3.1.0

data/test/integration_helper.rb

@@ -27,8 +27,6 @@ VCR.configure do |c|
   end
 end
 
-HTTPI.log = false
-
 module Vacuum
   class IntegrationTest < Minitest::Test
     def setup

data/test/locales.yml

@@ -2,22 +2,22 @@
   :access_key: AKIAIWQTVHVWCQA5THXQ
   :secret_key: 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
   :partner_tag: adabo00-20
-- :marketplace: DE
-  :access_key: AKIAIRMMTDVD7JUI65HA
-  :secret_key: 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
-  :partner_tag: partly0e-21
 - :marketplace: ES
-  :access_key: AKIAIRMMTDVD7JUI65HA
-  :secret_key: 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
-  :partner_tag: partly01-21
-# - :marketplace: FR
-#   :access_key: AKIAJDNYBNMN23YBFK3A
-#   :secret_key: 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
-#   :partner_tag: adabo-21
-# - :marketplace: IT
-#   :access_key: AKIAIIJY6LYBYWTHITZQ
-#   :secret_key: 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
-#   :partner_tag: adabo0c-21
+  :access_key: AKIAJJF26BJLZLSJLFBQ
+  :secret_key: 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
+  :partner_tag: adabo00-21
+- :marketplace: DE
+  :access_key: AKIAJGN5UNM43HHV5MZA
+  :secret_key: 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
+  :partner_tag: adabo23-21
+- :marketplace: FR
+  :access_key: AKIAJDNYBNMN23YBFK3A
+  :secret_key: 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
+  :partner_tag: adabo-21
+- :marketplace: IT
+  :access_key: AKIAJVBAH4XJHK6YF46Q
+  :secret_key: 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
+  :partner_tag: adabo0c-21
 - :marketplace: GB
   :access_key: AKIAJPAXMP45DOQJPHJQ
   :secret_key: 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
@@ -25,4 +25,4 @@
 - :marketplace: US
   :access_key: AKIAIWQTVHVWCQA5THXQ
   :secret_key: VOhSIqIY1wF5selhhJYJGVnIET9k5q0J8QjTX38i
-  :partner_tag: adabo-20
+  :partner_tag:  adabo-20

data/test/locales.yml.example

@@ -10,6 +10,14 @@
   :access_key: access_key
   :secret_key: secret_key
   :partner_tag: partner_tag
+- :marketplace: FR
+  :access_key: access_key
+  :secret_key: secret_key
+  :partner_tag: partner_tag
+- :marketplace: IT
+  :access_key: access_key
+  :secret_key: secret_key
+  :partner_tag: partner_tag
 - :marketplace: GB
   :access_key: access_key
   :secret_key: secret_key

data/test/vacuum/test_locale.rb

@@ -5,31 +5,39 @@ require 'vacuum/locale'
 
 module Vacuum
   class TestLocale < Minitest::Test
-    def test_find
-      assert_kind_of Locale, Locale.find(:us)
+    def test_host
+      locale = Locale.new(:us, credentials)
+      assert locale.host
     end
 
-    def test_find_uppercase_string
-      assert_kind_of Locale, Locale.find('US')
+    def test_region
+      locale = Locale.new(:us, credentials)
+      assert locale.region
     end
 
-    def test_find_uk
-      assert_equal :gb, Locale.find('UK').code
+    def test_partner_type_default
+      locale = Locale.new(:us, credentials)
+      assert locale.partner_type
     end
 
-    def test_raise_if_not_found
+    def test_upcased_marketplace
+      Locale.new('US', credentials) # does not raise
+    end
+
+    def test_uk
+      Locale.new(:uk, credentials) # does not raise
+    end
+
+    def test_not_found
       assert_raises Locale::NotFound do
-        Locale.find('foo')
+        Locale.new(:foo, credentials)
       end
     end
 
-    def test_build_url
-      assert_equal 'https://webservices.amazon.com/paapi5/foo',
-                   Locale.find('US').build_url('Foo')
-    end
+    private
 
-    def test_marketplace
-      assert_equal 'www.amazon.com', Locale.find('US').marketplace
+    def credentials
+      { access_key: '123', secret_key: '123', partner_tag: 'xyz-20' }
     end
   end
 end

data/test/vacuum/test_operation.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'minitest/autorun'
+require 'vacuum/locale'
+require 'vacuum/operation'
+
+module Vacuum
+  class TestOperation < Minitest::Test
+    def setup
+      @operation = Operation.new('Action', params: { foo: 1 }, locale: locale)
+    end
+
+    def test_body
+      assert @operation.body
+    end
+
+    def test_url
+      assert @operation.url
+    end
+
+    def test_headers
+      assert @operation.headers
+    end
+
+    private
+
+    def locale
+      Locale.new(:us, access_key: '123', secret_key: '123', partner_tag: 'xyz')
+    end
+  end
+end

data/test/vacuum/test_request.rb

@@ -3,25 +3,25 @@
 require 'integration_helper'
 
 module Vacuum
-  class RequestTest < IntegrationTest
+  class TestRequest < IntegrationTest
     def test_get_browse_nodes
       requests.each do |request|
         response = request.get_browse_nodes(browse_node_ids: ['3045'])
-        refute response.error?
+        assert_equal 200, response.status
       end
     end
 
     def test_get_items
       requests.each do |request|
         response = request.get_items(item_ids: ['B07212L4G2'])
-        refute response.error?
+        assert_equal 200, response.status
       end
     end
 
-    def test_get_items_with_options
+    def test_get_items_with_all_resources
       requests.each do |request|
         response = request.get_items(item_ids: 'B07212L4G2',
-                                     resources: ['BrowseNodeInfo.BrowseNodes'])
+                                     resources: ALL_RESOURCES)
         item = response.dig('ItemsResult', 'Items').first
         assert item.key?('BrowseNodeInfo')
       end
@@ -30,15 +30,48 @@ module Vacuum
     def test_get_variations
       requests.each do |request|
         response = request.get_variations(asin: 'B07212L4G2')
-        refute response.error?
+        assert_equal 200, response.status
       end
     end
 
     def test_search_items
       requests.each do |request|
         response = request.search_items(keywords: 'Harry Potter')
-        refute response.error?
+        assert_equal 200, response.status
       end
     end
+
+    def test_persistent
+      request = requests.sample
+      refute request.client.persistent?
+      request.persistent
+      assert request.client.persistent?
+    end
+
+    ALL_RESOURCES =
+      %w[BrowseNodeInfo.BrowseNodes BrowseNodeInfo.BrowseNodes.Ancestor
+         BrowseNodeInfo.BrowseNodes.SalesRank BrowseNodeInfo.WebsiteSalesRank
+         Images.Primary.Small Images.Primary.Medium Images.Primary.Large
+         Images.Variants.Small Images.Variants.Medium Images.Variants.Large
+         ItemInfo.ByLineInfo ItemInfo.Classifications ItemInfo.ContentInfo
+         ItemInfo.ContentRating ItemInfo.ExternalIds ItemInfo.Features
+         ItemInfo.ManufactureInfo ItemInfo.ProductInfo ItemInfo.TechnicalInfo
+         ItemInfo.Title ItemInfo.TradeInInfo
+         Offers.Listings.Availability.MaxOrderQuantity
+         Offers.Listings.Availability.Message
+         Offers.Listings.Availability.MinOrderQuantity
+         Offers.Listings.Availability.Type Offers.Listings.Condition
+         Offers.Listings.Condition.SubCondition
+         Offers.Listings.DeliveryInfo.IsAmazonFulfilled
+         Offers.Listings.DeliveryInfo.IsFreeShippingEligible
+         Offers.Listings.DeliveryInfo.IsPrimeEligible
+         Offers.Listings.IsBuyBoxWinner Offers.Listings.LoyaltyPoints.Points
+         Offers.Listings.MerchantInfo Offers.Listings.Price
+         Offers.Listings.ProgramEligibility.IsPrimeExclusive
+         Offers.Listings.ProgramEligibility.IsPrimePantry
+         Offers.Listings.Promotions Offers.Listings.SavingBasis
+         Offers.Summaries.HighestPrice Offers.Summaries.LowestPrice
+         Offers.Summaries.OfferCount ParentASIN].freeze
+    private_constant :ALL_RESOURCES
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vacuum
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.1.0
 platform: ruby
 authors:
 - Hakan Ensari
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-30 00:00:00.000000000 Z
+date: 2019-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sigv4
@@ -25,19 +25,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: httpi
+  name: http
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -134,6 +134,7 @@ files:
 - lib/vacuum.rb
 - lib/vacuum/locale.rb
 - lib/vacuum/matcher.rb
+- lib/vacuum/operation.rb
 - lib/vacuum/request.rb
 - lib/vacuum/response.rb
 - lib/vacuum/version.rb
@@ -143,6 +144,7 @@ files:
 - test/locales.yml
 - test/locales.yml.example
 - test/vacuum/test_locale.rb
+- test/vacuum/test_operation.rb
 - test/vacuum/test_request.rb
 - test/vacuum/test_response.rb
 homepage: https://github.com/hakanensari/vacuum
@@ -169,6 +171,7 @@ signing_key:
 specification_version: 4
 summary: Amazon Product Advertising in Ruby
 test_files:
+- test/vacuum/test_operation.rb
 - test/vacuum/test_request.rb
 - test/vacuum/test_response.rb
 - test/vacuum/test_locale.rb