vacuum 2.2.0 → 3.0.0

data/test/integration_helper.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require 'minitest/autorun'
+require 'vcr'
+
+require 'locales'
+require 'vacuum'
+require 'vacuum/matcher'
+
+VCR.configure do |c|
+  c.hook_into :webmock
+  c.cassette_library_dir = 'test/cassettes'
+  c.default_cassette_options = {
+    match_requests_on: [Vacuum::Matcher],
+    record: ENV['RECORD'] ? :new_episodes : :none
+  }
+  c.before_record do |interaction|
+    interaction.ignore! if interaction.response.status.code != 200
+  end
+
+  Locales.each do |record|
+    record.each do |key, val|
+      next if key == :marketplace
+
+      c.filter_sensitive_data(key.upcase) { val }
+    end
+  end
+end
+
+HTTPI.log = false
+
+module Vacuum
+  class IntegrationTest < Minitest::Test
+    def setup
+      if ENV['LIVE']
+        VCR.turn_off!
+        WebMock.allow_net_connect!
+      else
+        VCR.insert_cassette('vacuum')
+      end
+    end
+
+    def teardown
+      VCR.eject_cassette if VCR.turned_on?
+    end
+
+    private
+
+    def requests
+      Locales.map { |credentials| Vacuum.new(credentials) }.shuffle
+    end
+  end
+end

data/test/locales.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'forwardable'
+require 'yaml'
+
+module Locales
+  class << self
+    extend Forwardable
+    include Enumerable
+
+    attr_reader :all
+
+    def_delegators :all, :each
+  end
+
+  %w[locales.yml locales.yml.example].each do |filename|
+    path = File.expand_path(filename, __dir__)
+    if File.exist?(path)
+      @all = YAML.load_file(path)
+      break
+    end
+  end
+end

data/test/locales.yml

@@ -0,0 +1,28 @@
+- :marketplace: CA
+  :access_key: AKIAIWQTVHVWCQA5THXQ
+  :secret_key: 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
+  :partner_tag: adabo00-20
+- :marketplace: DE
+  :access_key: AKIAIRMMTDVD7JUI65HA
+  :secret_key: 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
+  :partner_tag: partly0e-21
+- :marketplace: ES
+  :access_key: AKIAIRMMTDVD7JUI65HA
+  :secret_key: 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
+  :partner_tag: partly01-21
+# - :marketplace: FR
+#   :access_key: AKIAJDNYBNMN23YBFK3A
+#   :secret_key: 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
+#   :partner_tag: adabo-21
+# - :marketplace: IT
+#   :access_key: AKIAIIJY6LYBYWTHITZQ
+#   :secret_key: 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
+#   :partner_tag: adabo0c-21
+- :marketplace: GB
+  :access_key: AKIAJPAXMP45DOQJPHJQ
+  :secret_key: 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
+  :partner_tag: adabo21-21
+- :marketplace: US
+  :access_key: AKIAIWQTVHVWCQA5THXQ
+  :secret_key: VOhSIqIY1wF5selhhJYJGVnIET9k5q0J8QjTX38i
+  :partner_tag: adabo-20

data/test/locales.yml.example

@@ -0,0 +1,20 @@
+- :marketplace: CA
+  :access_key: access_key
+  :secret_key: secret_key
+  :partner_tag: partner_tag
+- :marketplace: ES
+  :access_key: access_key
+  :secret_key: secret_key
+  :partner_tag: partner_tag
+- :marketplace: DE
+  :access_key: access_key
+  :secret_key: secret_key
+  :partner_tag: partner_tag
+- :marketplace: GB
+  :access_key: access_key
+  :secret_key: secret_key
+  :partner_tag: partner_tag
+- :marketplace: US
+  :access_key: access_key
+  :secret_key: secret_key
+  :partner_tag: partner_tag

data/test/vacuum/test_locale.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'minitest/autorun'
+require 'vacuum/locale'
+
+module Vacuum
+  class TestLocale < Minitest::Test
+    def test_find
+      assert_kind_of Locale, Locale.find(:us)
+    end
+
+    def test_find_uppercase_string
+      assert_kind_of Locale, Locale.find('US')
+    end
+
+    def test_find_uk
+      assert_equal :gb, Locale.find('UK').code
+    end
+
+    def test_raise_if_not_found
+      assert_raises Locale::NotFound do
+        Locale.find('foo')
+      end
+    end
+
+    def test_build_url
+      assert_equal 'https://webservices.amazon.com/paapi5/foo',
+                   Locale.find('US').build_url('Foo')
+    end
+
+    def test_marketplace
+      assert_equal 'www.amazon.com', Locale.find('US').marketplace
+    end
+  end
+end

data/test/vacuum/test_request.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require 'integration_helper'
+
+module Vacuum
+  class RequestTest < IntegrationTest
+    def test_get_browse_nodes
+      requests.each do |request|
+        response = request.get_browse_nodes(browse_node_ids: ['3045'])
+        refute response.error?
+      end
+    end
+
+    def test_get_items
+      requests.each do |request|
+        response = request.get_items(item_ids: ['B07212L4G2'])
+        refute response.error?
+      end
+    end
+
+    def test_get_items_with_options
+      requests.each do |request|
+        response = request.get_items(item_ids: 'B07212L4G2',
+                                     resources: ['BrowseNodeInfo.BrowseNodes'])
+        item = response.dig('ItemsResult', 'Items').first
+        assert item.key?('BrowseNodeInfo')
+      end
+    end
+
+    def test_get_variations
+      requests.each do |request|
+        response = request.get_variations(asin: 'B07212L4G2')
+        refute response.error?
+      end
+    end
+
+    def test_search_items
+      requests.each do |request|
+        response = request.search_items(keywords: 'Harry Potter')
+        refute response.error?
+      end
+    end
+  end
+end

data/test/vacuum/test_response.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'minitest/autorun'
+require 'vacuum/response'
+
+module Vacuum
+  class TestResponse < Minitest::Test
+    def setup
+      mock = Minitest::Mock.new
+      mock.expect(:body, %({"ItemsResult":{"Items":[{"ASIN":"B07212L4G2"}]}}))
+      @response = Response.new(mock)
+    end
+
+    def test_cast_to_hash
+      assert_kind_of Hash, @response.to_h
+    end
+
+    def test_dig
+      assert @response.dig('ItemsResult', 'Items')
+    end
+  end
+end

metadata

@@ -1,45 +1,45 @@
 --- !ruby/object:Gem::Specification
 name: vacuum
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Hakan Ensari
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-17 00:00:00.000000000 Z
+date: 2019-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: jeff
+  name: aws-sigv4
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: multi_xml
+  name: httpi
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: vcr
+  name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -132,12 +132,19 @@ files:
 - LICENSE
 - README.md
 - lib/vacuum.rb
+- lib/vacuum/locale.rb
+- lib/vacuum/matcher.rb
 - lib/vacuum/request.rb
 - lib/vacuum/response.rb
 - lib/vacuum/version.rb
 - test/cassettes/vacuum.yml
-- test/test_integration.rb
-- test/test_unit.rb
+- test/integration_helper.rb
+- test/locales.rb
+- test/locales.yml
+- test/locales.yml.example
+- test/vacuum/test_locale.rb
+- test/vacuum/test_request.rb
+- test/vacuum/test_response.rb
 homepage: https://github.com/hakanensari/vacuum
 licenses:
 - MIT
@@ -150,7 +157,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -162,6 +169,11 @@ signing_key:
 specification_version: 4
 summary: Amazon Product Advertising in Ruby
 test_files:
-- test/test_integration.rb
+- test/vacuum/test_request.rb
+- test/vacuum/test_response.rb
+- test/vacuum/test_locale.rb
 - test/cassettes/vacuum.yml
-- test/test_unit.rb
+- test/integration_helper.rb
+- test/locales.rb
+- test/locales.yml
+- test/locales.yml.example

data/test/test_integration.rb

@@ -1,69 +0,0 @@
-# frozen_string_literal: true
-
-require 'minitest/autorun'
-require 'vcr'
-require_relative '../lib/vacuum'
-
-ENV['AWS_ACCESS_KEY_ID'] ||= 'key'
-ENV['AWS_SECRET_ACCESS_KEY'] ||= 'secret'
-
-VCR.configure do |c|
-  c.hook_into :excon
-  c.cassette_library_dir = 'test/cassettes'
-  c.default_cassette_options = {
-    match_requests_on: [VCR.request_matchers.uri_without_param(
-      'AWSAccessKeyId', 'AssociateTag', 'Signature', 'Timestamp', 'Version'
-    )],
-    record: :new_episodes
-  }
-end
-
-class TestIntegration < Minitest::Test
-  include Vacuum
-
-  def setup
-    VCR.insert_cassette('vacuum')
-  end
-
-  def teardown
-    VCR.eject_cassette
-  end
-
-  def test_happy_path
-    req = Vacuum.new
-    req.associate_tag = 'foo'
-    params = { 'SearchIndex' => 'All', 'Keywords' => 'vacuum' }
-    res = req.item_search(query: params)
-    assert res.dig('ItemSearchResponse', 'Items', 'Item')
-  end
-
-  def test_encoding_issues
-    params = { 'SearchIndex' => 'All', 'Keywords' => 'google' }
-    titles = locales.flat_map do |locale|
-      req = Vacuum.new(locale)
-      req.associate_tag = 'foo'
-      res = req.item_search(query: params)
-      items = res.dig('ItemSearchResponse', 'Items', 'Item') || []
-      items.map { |item| item['ItemAttributes']['Title'] }
-    end
-    encodings = titles.map { |t| t.encoding.name }.uniq
-
-    # Newer JRuby now appears to return both US-ASCII and UTF-8, depending on
-    # whether the string has non-ASCII characters. MRI will only return latter.
-    assert(encodings.any? { |encoding| encoding == 'UTF-8' })
-  end
-
-  def test_unauthorized_errors
-    req = Vacuum.new
-    req.associate_tag = 'foo'
-    params = { 'SearchIndex' => 'All', 'Keywords' => 'amazon' }
-    res = req.item_search(query: params)
-    assert_equal 'InvalidClientTokenId', res.dig('ItemSearchErrorResponse', 'Error', 'Code')
-  end
-
-  private
-
-  def locales
-    Request::HOSTS.keys
-  end
-end

data/test/test_unit.rb

@@ -1,106 +0,0 @@
-# frozen_string_literal: true
-
-require 'minitest/autorun'
-require_relative '../lib/vacuum'
-
-class TestVacuum < Minitest::Test
-  include Vacuum
-
-  def setup
-    @req = Request.new
-  end
-
-  def teardown
-    Excon.stubs.clear
-  end
-
-  def test_requires_valid_locale
-    assert_raises(Request::BadLocale) { Request.new('foo') }
-  end
-
-  def test_defaults_to_us_endpoint
-    assert_equal 'http://webservices.amazon.com/onca/xml', @req.aws_endpoint
-  end
-
-  def test_defaults_to_latest_api_version
-    assert_equal Request::LATEST_VERSION, @req.version
-  end
-
-  def test_accepts_uk_as_locale
-    Request.new('UK')
-  end
-
-  def test_accepts_mx_as_locale
-    Request.new('MX')
-  end
-
-  def test_fetches_parsable_response
-    Excon.stub({}, body: '<foo/>')
-    res = @req.item_lookup({}, mock: true)
-    refute_empty res.parse
-  end
-
-  def test_alternative_query_syntax
-    Excon.stub({}, body: '<foo/>')
-    res = @req.item_lookup(query: {}, mock: true)
-    refute_empty res.parse
-  end
-
-  def test_force_encodes_body
-    res = Object.new
-    def res.body
-      (+'').force_encoding(Encoding::ASCII_8BIT)
-    end
-    assert_equal 'UTF-8', Response.new(res).body.encoding.name
-  end
-
-  def test_sets_custom_parser_on_class_level
-    original_parser = Response.parser
-    Excon.stub({}, body: '<foo/>')
-    parser = MiniTest::Mock.new
-    parser.expect(:parse, '123', ['<foo/>'])
-    Response.parser = parser
-    res = @req.item_lookup(query: {}, mock: true)
-    assert_equal '123', res.parse
-    Response.parser = original_parser # clean up
-  end
-
-  def test_sets_custom_parser_on_instance_level
-    Excon.stub({}, body: '<foo/>')
-    res = @req.item_lookup(query: {}, mock: true)
-    parser = MiniTest::Mock.new
-    parser.expect(:parse, '123', ['<foo/>'])
-    res.parser = parser
-    assert_equal '123', res.parse
-  end
-
-  def test_casts_to_hash
-    Excon.stub({}, body: '<foo/>')
-    parser = MiniTest::Mock.new
-    res = @req.item_lookup(query: {}, mock: true)
-    assert_kind_of Hash, res.to_h
-    res.parser = parser
-    assert_kind_of Hash, res.to_h
-  end
-
-  def test_digs
-    Excon.stub({}, body: '<foo><bar>baz</bar></foo>')
-    parser = MiniTest::Mock.new
-    res = @req.item_lookup(query: {}, mock: true)
-    assert_equal 'baz', res.dig('foo', 'bar')
-    res.parser = parser
-    assert_equal 'baz', res.dig('foo', 'bar')
-  end
-
-  def test_handles_authorisation_errors
-    Excon.stub({}, status: 400)
-    res = @req.item_lookup(query: {}, mock: true)
-    assert_equal 400, res.status
-    assert_raises Excon::Error::BadRequest do
-      @req.item_lookup(query: {}, expects: 200, mock: true)
-    end
-    Excon.stub({}, status: 403)
-    res = @req.item_lookup(query: {}, mock: true)
-    assert_equal 403, res.status
-  end
-end