va 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 71852c4aa71d300422814133cf073f6ddef674f3
-  data.tar.gz: 98f5f50bf80557f9e76a2f401845c0754700a39f
+  metadata.gz: 8d0577caf4e3a47e684b5ed50a7eadd0062dba64
+  data.tar.gz: da3184c2e7a499d83578d5a7050c172e39f721a7
 SHA512:
-  metadata.gz: dbf0f57ab08834eed1ed195ffc4696f332b5f43bc4290e51466b133e99c69ffc158decc1b14ffebd6f3e86bf1da921ec6e562d07c128df62e25a24fd1071f071
-  data.tar.gz: 2ff88a638807598c7e219fc02e0e38f96d827d6cb6a5bc44dd5103db29a68144f65671353f5c85c14b568c880084d0f9ef8d12572d7a4991a4c453273613c0e8
+  metadata.gz: 1359705669b65f6cf9bffd1141831bda43cceb6321e712496e1918e5ab439caf8fa1eb338fcfa98f6abb6e047d50ea45a93284f0a64502b15a137b142ef1ceb8
+  data.tar.gz: 68c1affaa6458dffa190234a90e595b932a2350a287aa2cb8f49df19d84449fc6939b9f685e1e0084b9ba894d28c27b3ea4d160d40b969353cfa8fe71cb37ebe

data/Rakefile

@@ -1,12 +1,4 @@
 require "bundler/gem_tasks"
 
-task :test do
-  arg_files = ENV["FILES"] && ENV["FILES"].split(/[\s,]+/)
-  all_files = Rake::FileList["./spec/**/*_spec.rb"]
-  files = arg_files || all_files
-  puts "\nRuning tests for: #{ files.join(" ") }\n\n"
-
-  system *["matest"].concat(files)
-end
-
+require "matest/spec_tasks"
 task :default => :test

data/lib/va.rb

@@ -9,7 +9,11 @@ module Va
       @attributes ||= self.class.defaults.dup
       args.each do |k, v|
         key = k.to_sym
-        @attributes[key] = v if self.class.keys.include?(key)
+        if self.class.keys.include?(key)
+          @attributes[key] = v
+        elsif ! self.class.ignore_unauthorized_attributes?
+          raise UnauthorizedAttribute.new(key, self)
+        end
       end
       @errors = {}
       @valid = validate
@@ -33,6 +37,14 @@ module Va
       @valid
     end
 
+    def self.ignore_unauthorized_attributes
+      @__ignore_unauthorized_attributes__ = true
+    end
+
+    def self.ignore_unauthorized_attributes?
+      !! @__ignore_unauthorized_attributes__
+    end
+
     private
     def self.validations
       @validations ||= []
@@ -62,7 +74,7 @@ module Va
 
     def self.validate_not_nil(*attrs)
       validate_multiple(*attrs) do |attr|
-          attr != nil
+        attr != nil
       end
     end
 
@@ -92,5 +104,12 @@ module Va
     end
   end
   class UnknownAttribute < Exception; end
+  class UnauthorizedAttribute < Exception
+    def initialize(attr, validator)
+      msg = "Unauthorized attribute for '#{validator.class}': '#{attr}'"
+      super(msg)
+    end
+  end
   class NotSpecified ; end
+  
 end

data/lib/va/string_validations.rb

@@ -3,7 +3,13 @@ module StringValidations
 
     def validate_string(*attrs)
       validate_multiple(*attrs) do |attr|
-          attr.is_a?(String) || attr.nil?
+        attr.is_a?(String) || attr.nil?
+      end
+    end
+
+    def validate_string_not_empty(*attrs)
+      validate_multiple(*attrs) do |attr|
+        attr.is_a?(String) && !attr.empty?
       end
     end
 

data/lib/va/version.rb

@@ -1,3 +1,3 @@
 module Va
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

data/spec/spec_helper.rb

@@ -1,2 +1,6 @@
 $:.unshift(File.expand_path("../lib/", __dir__))
 require "va"
+
+Matest.configure do |config|
+  config.use_color
+end

data/spec/string_validations_spec.rb

@@ -7,7 +7,7 @@ scope "string validations" do
     class Person < Va::Validator
       include StringValidations
       attribute :name
-      
+
       validate_string(:name)
     end
 
@@ -26,4 +26,23 @@ scope "string validations" do
       @p.valid?
     end
   end
+
+  scope "string is not empty" do
+    class Person < Va::Validator
+      include StringValidations
+      attribute :name
+
+      validate_string_not_empty(:name)
+    end
+
+    spec "not empty" do
+      @p = Person.new(name: "Fede")
+      @p.valid?
+    end
+
+    spec "empty" do
+      @p = Person.new(name: "")
+      ! @p.valid?
+    end
+  end
 end

data/spec/va_spec.rb

@@ -9,8 +9,8 @@ scope do
   scope "init" do
     let(:va) { Login.new({"email" => "fede@example.com", pass: "123456"}) }
 
-    it { va.email == "fede@example.com" }
-    it { va.pass == "123456" }
+    spec { va.email == "fede@example.com" }
+    spec { va.pass == "123456" }
   end
 
   scope "#attributes" do
@@ -23,11 +23,6 @@ scope do
       @va = Login.new(email: "fede@example.com")
       @va.attributes == { email: "fede@example.com" }
     end
-
-    spec "spureous" do
-      @attributes = Login.new(email: "fede@example.com", i_dont_belong_here: "HELLO!").attributes
-      @attributes == { email: "fede@example.com" }
-    end
   end
 end
 
@@ -77,7 +72,7 @@ scope "custom validations" do
 
   scope "can't validate" do
     spec "invalid arguments" do
-      begin
+      @ex = capture_exception(Va::UnknownAttribute) do
         class FaceLidator < Va::Validator
           attribute :face
 
@@ -85,10 +80,66 @@ scope "custom validations" do
             true
           end
         end
-      rescue Object => e
-        e.class == Va::UnknownAttribute
+
+        presenter.to_whatever
       end
+
+      @ex.is_a?(Va::UnknownAttribute)
+    end
+  end
+end
+
+scope "raising UnauthorizedAttribute on initialization" do
+  class NonRaiser < Va::Validator
+    ignore_unauthorized_attributes
+    attribute :yes
+  end
+
+  class Raiser < Va::Validator
+    attribute :yes
+  end
+
+  spec "raising when passing one attribute" do
+    @ex = capture_exception(Va::UnauthorizedAttribute) do
+      @va = Raiser.new(no: :something)
+    end
+
+    @ex.is_a?(Va::UnauthorizedAttribute)
+  end
+
+  spec "raising when passing more than one attribute" do
+    @ex = capture_exception(Va::UnauthorizedAttribute) do
+      @va = Raiser.new(yes: :something, no: :something_else)
+    end
+
+    @ex.is_a?(Va::UnauthorizedAttribute)
+  end
+
+  spec "names the attribute name on the message" do
+    @ex = capture_exception(Va::UnauthorizedAttribute) do
+      @va = Raiser.new(attr_name: :something_else)
     end
+
+    !! (@ex.message =~ /'attr_name'/)
+  end
+
+  spec "names the validator name on the message" do
+    @ex = capture_exception(Va::UnauthorizedAttribute) do
+      @va = Raiser.new(attr_name: :something_else)
+    end
+
+    !! (@ex.message =~ /'Raiser'/)
+  end
+
+  spec "not raising when passing one attribute" do
+    @va = NonRaiser.new(no: :something)
+    @va.valid?
+  end
+
+  spec "raising when passing more than one attribute" do
+    @va = NonRaiser.new(yes: :something, no: :something_else)
+
+    @va.valid?
   end
 end
 
@@ -111,14 +162,13 @@ scope "validate multiple" do
     @va = Name.new(first: "", last: "")
     ! @va.valid?
   end
-  
+
   spec "one failing" do
     @va = Name.new(first: "Federico", last: "")
     ! @va.valid?
   end
 end
 
-
 scope "default values" do
   class MyDefaults < Va::Validator
     attribute :name, default: "N/A"

data/va.gemspec

@@ -21,5 +21,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
 
-  spec.add_development_dependency "matest", "~> 1.1.3"
+  spec.add_development_dependency "matest", "~> 1.6.9"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: va
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Federico Iachetti
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-04 00:00:00.000000000 Z
+date: 2015-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.3
+        version: 1.6.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.3
+        version: 1.6.9
 description: Minimalistic framework agnostic Validator.
 email:
 - iachetti.federico@gmail.com
@@ -95,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Minimalistic framework agnostic Validator.