v8eval 0.2.3 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5bc796827b31875adb19bac6160324a239cc8183
-  data.tar.gz: f9ca3808367a62bc6fd3faeebcdceec9ae162d49
+SHA256:
+  metadata.gz: 38af0f6fe5626a1d4085a15e351c3a2ca9ab95dd339e64544395a65fbc8257a7
+  data.tar.gz: 0c40757c5d114ca97016305f76d1f15f6588c851ff4cbb159051c7ffc39b9286
 SHA512:
-  metadata.gz: adbeb2fcbec1a4efc82896284670625bb10b3feb8637324014e2807b45452c1adb55cb0d7e7367c7778941224160a863c7b3d60ca8609389479fdfe0cc3a04b3
-  data.tar.gz: 31330901707a0c19eb9c4761825883ace6feebad783ef7274bc7b096b9b524c8754297a467e39efdac01c0c4675baf14cc2755c5f2edced82f509f272e0d9ed6
+  metadata.gz: 9c6288b4e68243dda6b9e8864c652d1dfc52e53e1732aed94f4edfc80f9a129d272bec410ff08698e647bf8344a69cf4d97f11a137179e754809149dd8d6b7ff
+  data.tar.gz: 5da63b2067f21399151e798c27a55e398d7b8818d25fae7c04f97e807e0c19c377046665d8d31dd4f16bbce7760bcdfee1307048e4e99c41ade5b4b2bf521e30

data/CMakeLists.txt

@@ -11,33 +11,29 @@ endif(COMMAND cmake_policy)
 include_directories(
     v8
     v8/include
-    v8/third_party/icu/source/i18n
-    v8/third_party/icu/source/common
-    uv/include
     src
-    test/googletest/googletest/include
+    v8/third_party/googletest/src/googletest/include
 )
 
-if(APPLE)
-    link_directories(
-        v8/out/x64.release
-    )
-endif(APPLE)
+set(v8eval-linkdirs
+    v8/out.gn/x64.release/obj
+    v8/out.gn/x64.release/obj/third_party/googletest
+)
 
 if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
-    link_directories(
-        v8/out/x64.release/obj.target/tools/gyp
-        v8/out/x64.release/obj.target/third_party/icu
+    set(v8eval-linkdirs
+        ${v8eval-linkdirs}
+        v8/out.gn/x64.release/obj/buildtools/third_party/libc++
+        v8/out.gn/x64.release/obj/buildtools/third_party/libc++abi
     )
 endif(CMAKE_SYSTEM_NAME STREQUAL "Linux")
 
 link_directories(
-    uv/.libs/
+    ${v8eval-linkdirs}
 )
 
 add_library(v8eval STATIC
     src/v8eval.cxx
-    src/dbgsrv.cxx
 )
 
 add_library(v8eval_go STATIC
@@ -54,7 +50,6 @@ add_library(v8eval_ruby STATIC
 
 set(v8eval-cflags
     -Wall
-    -Wendif-labels
     -Werror
     -Wno-missing-field-initializers
     -Wno-unused-parameter
@@ -64,13 +59,28 @@ set(v8eval-cflags
     -fno-rtti
     -fno-strict-aliasing
     -fno-threadsafe-statics
-    -fstrict-aliasing
     -fvisibility=hidden
     -fvisibility-inlines-hidden
     -gdwarf-2
-    -std=c++11
+    -std=c++14
 )
 
+if(APPLE)
+    set(v8eval-cflags
+        ${v8eval-cflags}
+        -stdlib=libc++
+    )
+endif(APPLE)
+
+if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
+    set(v8eval-cflags
+        ${v8eval-cflags}
+        -nostdinc++
+        -isystem ${CMAKE_CURRENT_SOURCE_DIR}/v8/buildtools/third_party/libc++/trunk/include
+        -isystem ${CMAKE_CURRENT_SOURCE_DIR}/v8/buildtools/third_party/libc++abi/trunk/include
+    )
+endif(CMAKE_SYSTEM_NAME STREQUAL "Linux")
+
 string(REPLACE ";" " " v8eval-cflags "${v8eval-cflags}")
 
 set_target_properties(v8eval PROPERTIES

data/README.md

@@ -2,11 +2,11 @@
 
 [![PyPI version](https://badge.fury.io/py/v8eval.svg)](http://badge.fury.io/py/v8eval)
 [![Gem Version](https://badge.fury.io/rb/v8eval.svg)](https://badge.fury.io/rb/v8eval)
-[![GoDoc](https://godoc.org/github.com/sony/v8eval/go/v8eval?status.png)](http://godoc.org/github.com/sony/v8eval/go/v8eval)
+[![GoDoc](https://godoc.org/github.com/sony/v8eval/go/v8eval?status.svg)](http://godoc.org/github.com/sony/v8eval/go/v8eval)
 
 Multi-language bindings to JavaScript engine V8.
 
-Currently v8eval provides Go, Python and Ruby bindings to the latest V8 5.1 and supports Linux and Mac OS X.
+Currently v8eval provides Go, Python and Ruby bindings to the latest V8 7.1 and supports Linux and Mac OS X.
 v8eval uses SWIG and can be extended easily for other languages.
 
 ## Pre-installation
@@ -25,9 +25,17 @@ The installation takes several tens of minutes due to V8 build.
 
 #### Go
 
+v8eval requires Go 1.10 or later.
+
+```
+git clone https://github.com/sony/v8eval.git ${GOPATH}/src/github.com/sony/v8eval
+${GOPATH}/src/github.com/sony/v8eval/go/build.sh install
+```
+
+In the case of Linux, you need to build your Go program with `build.sh`:
+
 ```
-git clone https://github.com/sony/v8eval.git $GOPATH/src/github.com/sony/v8eval
-$GOPATH/src/github.com/sony/v8eval/go/build.sh install
+${GOPATH}/src/github.com/sony/v8eval/go/build.sh go build
 ```
 
 #### Python

data/build.sh

@@ -1,109 +1,123 @@
 #!/bin/sh
 
-V8EVAL_ROOT=`cd $(dirname $0) && pwd`
+V8EVAL_ROOT=`cd $(dirname ${0}) && pwd`
 
 PLATFORM=`uname`
-if [ $PLATFORM = "Linux" ] ; then
-  NUM_CPU_CORES=`cat /proc/cpuinfo | grep cores | grep -o '[0-9]\+'`
-
-  export CC=$V8EVAL_ROOT/v8/third_party/llvm-build/Release+Asserts/bin/clang
-  export CXX=$V8EVAL_ROOT/v8/third_party/llvm-build/Release+Asserts/bin/clang++
-elif [ $PLATFORM = "Darwin" ]; then
-  NUM_CPU_CORES=`sysctl -n hw.ncpu`
-
-  export CC=`which clang`
-  export CXX=`which clang++`
-  export CPP="`which clang` -E"
-  export LINK="`which clang++`"
-  export CC_host=`which clang`
-  export CXX_host=`which clang++`
-  export CPP_host="`which clang` -E"
-  export LINK_host=`which clang++`
-  export GYP_DEFINES="clang=1 mac_deployment_target=10.10"
-else
+if [ ! ${PLATFORM} = "Linux" -a ! ${PLATFORM} = "Darwin" ]; then
   echo "unsupported platform: ${PLATFORM}"
   exit 1
 fi
 
-install_depot_tools() {
-  export PATH=$V8EVAL_ROOT/depot_tools:$PATH
-  if [ -d $V8EVAL_ROOT/depot_tools ]; then
-    return 0
-  fi
+export CC=${V8EVAL_ROOT}/v8/third_party/llvm-build/Release+Asserts/bin/clang
+export CXX=${V8EVAL_ROOT}/v8/third_party/llvm-build/Release+Asserts/bin/clang++
 
-  cd $V8EVAL_ROOT
-  git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
-}
+if [ ${PLATFORM} = "Linux" ]; then
+  export PATH=${V8EVAL_ROOT}/v8/third_party/binutils/Linux_x64/Release/bin:${PATH}
+fi
 
-install_googletest() {
-  if [ -d $V8EVAL_ROOT/test/googletest ]; then
+install_depot_tools() {
+  export PATH=${V8EVAL_ROOT}/depot_tools:${PATH}
+  if [ -d ${V8EVAL_ROOT}/depot_tools ]; then
     return 0
   fi
 
-  cd $V8EVAL_ROOT/test
-  git clone https://github.com/google/googletest.git
-  git checkout release-1.7.0
+  cd ${V8EVAL_ROOT}
+  git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
 }
 
 install_v8() {
-  if [ -d $V8EVAL_ROOT/v8 ]; then
+  if [ -d ${V8EVAL_ROOT}/v8 ]; then
     return 0
   fi
 
-  cd $V8EVAL_ROOT
+  cd ${V8EVAL_ROOT}
   fetch v8
   cd v8
-  git checkout 5.1.117
-  CFLAGS="-fPIC" CXXFLAGS="-fPIC" make x64.release -j$NUM_CPU_CORES V=1
+  git checkout 7.1.177
+  gclient sync
+  if [ ${PLATFORM} = "Linux" ]; then
+    ./build/install-build-deps.sh
+  fi
+  tools/dev/v8gen.py x64.release -- v8_use_snapshot=false v8_enable_i18n_support=false
+  ninja -v -C out.gn/x64.release
 }
 
-install_libuv() {
-  if [ -d $V8EVAL_ROOT/uv ]; then
+archive_lib() {
+  if [ -f ${1}/lib${2}.a ]; then
     return 0
   fi
 
-  cd $V8EVAL_ROOT
-  git clone https://github.com/libuv/libuv.git uv
-  cd uv
-  git checkout v1.7.5
-  sh autogen.sh
-  ./configure --with-pic --disable-shared
-  make V=1
+  if [ `echo ${2} | cut -c 1-3` = "lib" ]; then
+    ar cr ${1}/${2}.a ${1}/${2}/*.o
+  else
+    ar cr ${1}/lib${2}.a ${1}/${2}/*.o
+  fi
+}
+
+V8_OUT=${V8EVAL_ROOT}/v8/out.gn/x64.release/obj
+
+archive_v8() {
+  archive_lib ${V8_OUT} v8_base
+  archive_lib ${V8_OUT} v8_libsampler
+  archive_lib ${V8_OUT} v8_init
+  archive_lib ${V8_OUT} v8_initializers
+  archive_lib ${V8_OUT} v8_nosnapshot
+  archive_lib ${V8_OUT} torque_generated_initializers
+}
+
+archive_libcxx() {
+  archive_lib ${V8_OUT}/buildtools/third_party/libc++ libc++
+}
+
+archive_libcxxabi() {
+  archive_lib ${V8_OUT}/buildtools/third_party/libc++abi libc++abi
+}
+
+archive_googletest() {
+  archive_lib ${V8_OUT}/third_party/googletest gtest
+  archive_lib ${V8_OUT}/third_party/googletest gtest_main
 }
 
 build() {
   install_depot_tools
   install_v8
-  install_libuv
+  archive_v8
+  if [ ${PLATFORM} = "Linux" ]; then
+    archive_libcxx
+    archive_libcxxabi
+  fi
 
-  cd $V8EVAL_ROOT
+  cd ${V8EVAL_ROOT}
   mkdir -p build
   cd build
   cmake -DCMAKE_BUILD_TYPE=Release -DV8EVAL_TEST=OFF ..
   make VERBOSE=1
+
+  cd ${V8EVAL_ROOT}
+  rm -rf old_v8_tools_luci-go.git
 }
 
 docs() {
-  cd $V8EVAL_ROOT/docs
+  cd ${V8EVAL_ROOT}/docs
   rm -rf ./html
   doxygen
 }
 
 test() {
   build
-  install_googletest
+  archive_googletest
 
-  cd $V8EVAL_ROOT/build
+  cd ${V8EVAL_ROOT}/build
   cmake -DCMAKE_BUILD_TYPE=Release -DV8EVAL_TEST=ON ..
   make VERBOSE=1
   ./test/v8eval-test
 }
 
-# dispatch subcommand
-SUBCOMMAND="$1";
-case "${SUBCOMMAND}" in
-  ""       ) build ;;
-  "docs"   ) docs ;;
-  "test"   ) test ;;
-  *        ) echo "unknown subcommand: ${SUBCOMMAND}"; exit 1 ;;
+# dispatch subcommands
+SUBCOMMAND=${1}
+case ${SUBCOMMAND} in
+  ""     ) build ;;
+  "docs" ) docs ;;
+  "test" ) test ;;
+  *      ) echo "unknown subcommand: ${SUBCOMMAND}"; exit 1 ;;
 esac

data/ruby/Gemfile

@@ -2,5 +2,5 @@
 source 'https://rubygems.org'
 
 gem 'rspec', '~> 3.0'
-gem 'rake', '~> 10.4.2'
-gem 'yard', '~> 0.8.7.6'
+gem 'rake', '>= 12.3.3'
+gem 'yard', '>= 0.9.11'

data/ruby/build.sh

@@ -1,21 +1,21 @@
 #!/bin/sh
 
-V8EVAL_ROOT=`cd $(dirname $0)/.. && pwd`
+V8EVAL_ROOT=`cd $(dirname ${0})/.. && pwd`
 
 build() {
-  cd $V8EVAL_ROOT/ruby
+  cd ${V8EVAL_ROOT}/ruby
   rake prepare_build
   rake build_ext
 }
 
 install() {
-  cd $V8EVAL_ROOT
+  cd ${V8EVAL_ROOT}
   gem build v8eval.gemspec
   gem install v8eval-*.gem
 }
 
 docs() {
-  cd $V8EVAL_ROOT/ruby
+  cd ${V8EVAL_ROOT}/ruby
   rm -rf ./doc
   mkdir ./doc
   yardoc --main ../README.md lib/v8eval.rb
@@ -24,16 +24,16 @@ docs() {
 test() {
   build
 
-  gem install bundle
-  cd $V8EVAL_ROOT/ruby
+  gem install bundler -v 1.14.5
+  cd ${V8EVAL_ROOT}/ruby
   bundle install
 
-  rspec --init
-  rspec
+  bundle exec rspec --init
+  bundle exec rspec
 }
 
 # dispatch subcommand
-SUBCOMMAND="$1";
+SUBCOMMAND="${1}";
 case "${SUBCOMMAND}" in
   ""        ) build ;;
   "install" ) install ;;

data/ruby/ext/v8eval/extconf.rb

@@ -6,7 +6,6 @@ require_relative '../../lib/setup/extension_builder'
 # set path variables
 v8eval_root = File.expand_path('../../..', Dir.pwd)
 v8_dir = v8eval_root + '/v8'
-uv_dir = v8eval_root + '/uv'
 
 # make instance of BuildTool class
 tool = BuildTool.new(v8eval_root)
@@ -23,33 +22,45 @@ INCLUDEDIR  = RbConfig::CONFIG['includedir']
 header_dirs = [
   v8_dir,
   v8_dir + '/include',
-  uv_dir + '/include',
   INCLUDEDIR
 ]
 
 lib_dirs = [
   v8eval_root + '/build',
-  uv_dir + '/.libs',
+  v8_dir + '/out.gn/x64.release/obj',
   LIBDIR
 ]
 
-if RUBY_PLATFORM =~ /darwin/
+if RUBY_PLATFORM =~ /linux/
   lib_dirs += [
-    v8_dir + '/out/x64.release'
-  ]
-elsif RUBY_PLATFORM =~ /linux/
-  lib_dirs += [
-    v8_dir + '/out/x64.release/obj.target/tools/gyp',
-    v8_dir + '/out/x64.release/obj.target/third_party/icu'
+    v8_dir + '/out.gn/x64.release/obj/buildtools/third_party/libc++',
+    v8_dir + '/out.gn/x64.release/obj/buildtools/third_party/libc++abi'
   ]
+end
 
+dir_config('', header_dirs, lib_dirs)
+
+if RUBY_PLATFORM =~ /linux/
   RbConfig::MAKEFILE_CONFIG['CC'] = v8_dir + '/third_party/llvm-build/Release+Asserts/bin/clang'
   RbConfig::MAKEFILE_CONFIG['CXX'] = v8_dir + '/third_party/llvm-build/Release+Asserts/bin/clang++'
 end
 
-dir_config('', header_dirs, lib_dirs)
+$LDFLAGS << ' -lv8eval' +
+  ' -lv8eval_ruby' +
+  ' -lv8_libplatform' +
+  ' -lv8_base' +
+  ' -lv8_libbase' +
+  ' -lv8_libsampler' +
+  ' -lv8_init' +
+  ' -lv8_initializers' +
+  ' -lv8_nosnapshot' +
+  ' -ltorque_generated_initializers'
+$CPPFLAGS << ' -O3 -std=c++14 -stdlib=libc++'
 
-$LDFLAGS << ' -lv8eval -lv8eval_ruby -lv8_libplatform -lv8_base -lv8_libbase -lv8_nosnapshot -licui18n -licuuc -licudata -luv'
-$CPPFLAGS << ' -g -O3 -std=c++11'
+if RUBY_PLATFORM =~ /linux/
+  $LDFLAGS << ' -lrt -lc++ -lc++abi'
+  $CPPFLAGS << ' -isystem' + v8_dir + '/buildtools/third_party/libc++/trunk/include' +
+               ' -isystem' + v8_dir + '/buildtools/third_party/libc++abi/trunk/include'
+end
 
 create_makefile('v8eval/v8eval')

data/ruby/lib/v8eval.rb

@@ -58,22 +58,6 @@ module V8Eval
         end
       end
     end
-
-    # Starts a debug server associated with the V8 instance.
-    # @param [Integer] port TCP/IP port the server will listen, at localhost.
-    # @return nil.
-    # @raise [TypeError] If port is not an int.
-    # @raise [V8Error] If failing to start the debug server.
-    def enable_debugger(port)
-      fail TypeError, 'port not integer' unless port.is_a?(Integer)
-      fail V8Error, 'failed to start debug server' unless @v8.enable_debugger(port)
-    end
-
-    # Stops the debug server, if running.
-    # @return nil.
-    def disable_debugger
-      @v8.disable_debugger
-    end
   end
 end