uw_sws 2.2.1 → 2.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8280c4c4d7c53d4b8db2172da8bd54ae9dc07035
-  data.tar.gz: f7488e1380e67b50c415eb94f842c1533975c166
+  metadata.gz: ecc91f5222c15c8b995a44fa3f5a7a91aa0b69ed
+  data.tar.gz: 415acff531dd1fa7d7db4b09f768291d50cbdd32
 SHA512:
-  metadata.gz: 1dadb6e89c3d0deb4a93769f259f255c4a0bcece0b8fd2c852c2b127393927e7752b67c7cadea0bda17a2d974b4813e9d7a809612fb0abafbd8da82063f98778
-  data.tar.gz: 0c844e73b897aac7046cb5c085fb1e9f6ff97500114fff1f83d4c5a345b258f434ed9f49291d30cc56722944e1a45ff44fc1473952eb00bff242b401f85a2e20
+  metadata.gz: 95dc7bb33ccf0019262442864c47491e6c52d048256f2d1d000f541228f31a11d39a7eecab5585a36b9d1a610cce0d6393de1f62441ad0d632b2999b729e2597
+  data.tar.gz: 2908edda9c2fd567cf8859cafb7d7383485217738ab43dd303596999d0425829e1eda92612c064665ebf889b768ab4661e54ae234f0a3f3cef1e6b1c67005eda

data/lib/uw_sws.rb

@@ -182,7 +182,7 @@ class UwSws
 
   def parse(url)
     data = request "#{@base}#{url}"
-    return nil unless !data.nil?
+    return nil unless !data.to_s.empty?
     data = clean data
 
     @last = JSON.parse data
@@ -212,6 +212,8 @@ class UwSws
           @logger.warn("#{url} - #{response.to_s}")
         elsif response.code == 404 && !@throw_404
           @logger.warn("#{url} - 404")
+          # hacky way to cache a 404 vs. saving the html the server sends back
+          set_cache("", cache_path)
         else
           raise "Errors for #{url}\n#{response.to_s}"
         end

data/lib/uw_sws/version.rb

@@ -1,3 +1,3 @@
 module UwSws
-  VERSION = "2.2.1"
+  VERSION = "2.2.2"
 end

data/test/test_endpoints.rb

@@ -20,8 +20,12 @@ describe UwSws do
     key    = config["key"]
     # url    = "https://wseval.s.uw.edu/student/v5/"
     @regid = "9136CCB8F66711D5BE060004AC494FFE"
-    @uw    = UwSws.new(cert: cert, key: key, throw_HEPPS: false,
-                       logger: log, use_cache: true)
+    @uw    = UwSws.new(cert: cert, 
+                       key: key, 
+                       throw_HEPPS: false,
+                       throw_404: false,
+                       logger: log, 
+                       use_cache: true)
   end
 
   describe "when getting test scores for a specific type " do
@@ -38,6 +42,14 @@ describe UwSws do
     end
   end
 
+  describe "when getting all test scores for invalid regid " do
+    it "it must not error" do
+      # this is not a valid regid, so result should be nil and not 404
+      tests = @uw.tests("9136CCB8F66711D5BE060004AC494FFF")
+      tests.must_be_nil
+    end
+  end
+
   describe "when getting term " do
     it "it must not be nil" do
       @uw.term(2013, :summer)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: uw_sws
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
 platform: ruby
 authors:
 - Nogbit