uuid_associations-active_record 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e1538fc45bf664d391c0a3b2b335247bdf0a66cc1f9133d3936000850175e9c
-  data.tar.gz: '092c5dad84a0a0ae487ecc61516b43b7d0b0e19fe7e3a2805f1811602dbbd5ee'
+  metadata.gz: 7bd48c49180664455d830bf4877bab4a57001cba97d710d0ec104753c71a456c
+  data.tar.gz: e6259cc8ef51b92bc456b00cf89839c088823567afc8de1d605440c85e79b5d7
 SHA512:
-  metadata.gz: 40acb305ecca02b540d97161942ef0bcf9161b1b5b07c4160df0adcb76a039e576da7a3afe53882bcb7501684b394170137f0c5df54df3eecf04fddf61ab7726
-  data.tar.gz: f064f70789721a9b789a76f096098548fa409ac69f63b818d8a232b3112a4ee58d524a72e2b7611c3a862596a7b22a17eb556655154cee828319aa7adbf59490
+  metadata.gz: 8e94d8ffa58e122b70e09f60b9031de98510cb9452fa4b98a11f5b8225cb7474e995eb8dd1cff8e40efbf43ea05ac4e45b34a8211ae9a28f749352f16a61764e
+  data.tar.gz: 510166b160fc1c19ce2ac78215d92169246f64e41c335583e905110f5ed3aa205101aea8f308bb65105a6643f162b84b2d31ffe107d4a9e66310e1dd32dd41d0

data/README.md

@@ -218,14 +218,13 @@ Here are some things to take into account:
 1. If the nested model (Comment in the example) does not have a column named `uuid`, the gem will take no action, will
 just preserve the original behavior.
 1. If the hash has both the `:id` and `:uuid` keys, the record will be fetched by `id`, and `uuid` will be passed as an attribute.
-1. When the hash has a `:uuid` key and no record is found for that key, a new record will be created using that UUID
-(this will change to raise a not found error instead).
+1. When the hash has a `:uuid` key and no record is found for that key, an `ActiveRecord::RecordNotFound` error will be raised.
 
 ## Future Work
 
 1. Not commonly used by me, but testing and adding these methods to a `has_one` relationship.
-1. Raise not found error if the array of UUIDs is bigger that the array
-of IDs fetched with the `where` statement (ActiveRecord's behavior).
+1. Raise not found error if the array of UUIDs is bigger that the array of IDs fetched with the `where` statement (ActiveRecord's behavior).
+1. Allow `accepts_nested_attributes_for` to take a configuration to allow the creation of new records if not found by UUID.
 
 ## Development
 

data/lib/uuid_associations/active_record/nested_attributes/uuid_finder.rb

@@ -26,11 +26,13 @@ module UuidAssociations
 
             record = found_records.find { |found_record| found_record.uuid == uuid }
 
-            collection << if record.blank?
-              attributes
-            else
-              attributes.merge(id: record.id)
+            if record.blank?
+              raise ::ActiveRecord::RecordNotFound.new(
+                "Couldn't find #{association_klass.name} with UUID=#{uuid}", association_klass, :id, uuid
+              )
             end
+
+            collection << attributes.merge(id: record.id)
           end
 
           to_keep + replaced

data/lib/uuid_associations/active_record/version.rb

@@ -1,5 +1,5 @@
 module UuidAssociations
   module ActiveRecord
-    VERSION = '0.2.0'.freeze
+    VERSION = '0.3.0'.freeze
   end
 end

data/spec/integration/nested_attributes/collection_spec.rb

@@ -10,20 +10,19 @@ RSpec.describe 'nested attributes for collection' do
   end
 
   context 'when creating a new record' do
-    it 'creates nested resources when not existing UUID is passed' do
+    let(:uuid) { SecureRandom.uuid }
+
+    it 'raises an expception if no record is found with the specified UUID' do
       expect do
         Post.create!(
           uuid: SecureRandom.uuid,
           content: 'post',
           comments_attributes: [
             body: 'New comment',
-            uuid: SecureRandom.uuid
+            uuid: uuid
           ]
         )
-      end.to change(Post, :count).from(0).to(1)
-         .and change(Comment, :count).from(0).to(1)
-
-      expect(Post.first.comments.count).to eq(1)
+      end.to raise_error(ActiveRecord::RecordNotFound, "Couldn't find Comment with UUID=#{uuid}")
     end
 
     it 'creates nested resources when no UUID or ID is passed' do

data/spec/unit/uuid_associations/active_record/nested_attributes/uuid_finder_spec.rb

@@ -17,7 +17,9 @@ RSpec.describe UuidAssociations::ActiveRecord::NestedAttributes::UuidFinder do
         context 'when record with specified UUID does not exist on the sytem' do
           let(:attribute_collection) { [{ uuid: SecureRandom.uuid, body: 'new comment :/' }] }
 
-          it { is_expected.to match_array(attribute_collection) }
+          it 'raises a not found error' do
+            expect { subject }.to raise_error(ActiveRecord::RecordNotFound)
+          end
         end
       end
 
@@ -47,7 +49,9 @@ RSpec.describe UuidAssociations::ActiveRecord::NestedAttributes::UuidFinder do
         context 'when record with specified UUID does not exist on the sytem' do
           let(:attribute_collection) { { first: { uuid: SecureRandom.uuid, body: 'new comment :/' } } }
 
-          it { is_expected.to match_array(attribute_collection.values) }
+          it 'raises a not found error' do
+            expect { subject }.to raise_error(ActiveRecord::RecordNotFound)
+          end
         end
       end
 

data/uuid_associations-active_record.gemspec

@@ -12,6 +12,9 @@ Gem::Specification.new do |spec|
   spec.description   = 'Adds association_uuids= method on has_many and has_and_belongs_to_many associations'
   spec.homepage      = 'https://github.com/mcelicalderon/uuid_associations-active_record'
   spec.license       = 'MIT'
+  spec.metadata      = {
+    'source_code_uri' => 'https://github.com/mcelicalderon/uuid_associations-active_record'
+  }
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.test_files    = spec.files.grep(%r{^spec\/})

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: uuid_associations-active_record
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Mario Celi
@@ -165,7 +165,8 @@ files:
 homepage: https://github.com/mcelicalderon/uuid_associations-active_record
 licenses:
 - MIT
-metadata: {}
+metadata:
+  source_code_uri: https://github.com/mcelicalderon/uuid_associations-active_record
 post_install_message: 
 rdoc_options: []
 require_paths: