utf8_enforcer_workaround 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: b10c881a91a814ae2b568ea36cd53da77e366c176d51a0982cfab8567f3a0c0e
-  data.tar.gz: 5435f738c2094bea01b69ec19327691ac2b7d00bbc7a17b36cc0379e96242d96
+SHA1:
+  metadata.gz: f591c62a4e63bc4f40ba41248f866c7175d8d331
+  data.tar.gz: 294d1bfe9df4a898a055aaba79869229874de341
 SHA512:
-  metadata.gz: bcd38ab16068c6d58e1f09337346d1dea4f95269848d0690ddf160a06fdb2ed3fc9c27040e63dbd1de1b2113e6d9e64143f7f38b1ce94c8a38aa3f649ae9d62e
-  data.tar.gz: b1afd3877f8713e6e7327dfe9f0ee0039693cc0bb74381e511904d0bc9c3fe42cd88c4415d449256a90abcea5f36652423802168d72d4e3fe9649a6f80f1ca1a
+  metadata.gz: 74f17d0c3ec3742c112557ef00ac1c1e815fb04a316efcd7e3f07ea466548956ebe3cf100a357c4ed6f2395169e62557a737249056d58f46be225b9e24ffa296
+  data.tar.gz: 4e96fbdbab56875970093d25881260e90fa539648edb7aefc66fd5f36b26ec18841461843b4fa4a16d39a9e065290507f27557acf25ad2429a9d691f969fa3a4

data/.travis.yml

@@ -23,20 +23,12 @@ matrix:
     gemfile: gemfiles/rails5.1.gemfile
   - rvm: 1.9.3
     gemfile: gemfiles/rails5.2.gemfile
-  - rvm: 1.9.3
-    gemfile: gemfiles/rails6.0.gemfile
   - rvm: 2.1.10
     gemfile: gemfiles/rails5.0.gemfile
   - rvm: 2.1.10
     gemfile: gemfiles/rails5.1.gemfile
   - rvm: 2.1.10
     gemfile: gemfiles/rails5.2.gemfile
-  - rvm: 2.1.10
-    gemfile: gemfiles/rails6.0.gemfile
-  - rvm: 2.2.10
-    gemfile: gemfiles/rails6.0.gemfile
-  - rvm: 2.3.8
-    gemfile: gemfiles/rails6.0.gemfile
   - rvm: 2.4.9
     gemfile: gemfiles/rails4.0.gemfile # https://github.com/rails/rails/issues/25125
   - rvm: 2.4.9

data/Appraisals

@@ -50,11 +50,3 @@ appraise "rails5.2" do
   gem 'rspec'
   gem 'bootsnap', '~> 1.0', require: false
 end
-
-# appraise "rails6.0" do
-#   gem "rails", "~> 6.0.0"
-#   gem "sqlite3", '~> 1.4.0'
-#   gem 'capybara'
-#   gem 'rspec'
-#   gem 'bootsnap', '~> 1.0', require: false
-# end

data/README.md

@@ -1,13 +1,13 @@
 Utf8EnforcerWorkaround
 ======================
-
+[![Gem Version](https://badge.fury.io/rb/utf8_enforcer_workaround.svg)](https://badge.fury.io/rb/utf8_enforcer_workaround)
 [![Build Status](https://secure.travis-ci.org/softace/utf8_enforcer_workaround.png)](http://travis-ci.org/softace/utf8_enforcer_workaround)
 [![Dependency Status](https://gemnasium.com/softace/utf8_enforcer_workaround.png)](https://gemnasium.com/softace/utf8_enforcer_workaround)
 [![Code Climate](https://codeclimate.com/github/softace/utf8_enforcer_workaround.png)](https://codeclimate.com/github/softace/utf8_enforcer_workaround)
 
-Make utf8 enforcer tag to be applied only for non-standards-complying
-browsers.
+For Rails version < 6 Rails inserts a hidden form input element to make IE 8 and older use UTF8. This gem makes the utf8 enforcer element to be applied only for non-standards-complying browsers.
 
+For Rails 6 the default behaviour does not bloat forms with IE8- specific issues, so this gem is no longer relevant for Rails 6 and forward.
 
 Requirements
 ------------
@@ -20,6 +20,8 @@ Requirements
 * Rails 4.x
 * Rails 5.x
 
+From Rails 6.0.0 the default behaviour is *not* to have a hidden tag to enforce utf8 for IE 8 or older, see (https://github.com/rails/rails/commit/96eeea538c9c5b7b60d6f8baed2e86a9e2a920c9). So this gem is not relevant for Rails 6 and upwards.
+
 Installation
 ------------
 
@@ -61,6 +63,20 @@ bundle exec appraisal install
 bundle exec appraisal rake
 ```
 
+Releasing
+---------
+
+Update `lib/utf8_enforcer_workaround/version.rb` and commit.
+Then
+
+```
+git tag v<version>
+git tag push --tags
+gem build utf8_enforcer_workaround.gemspec
+gem push utf8_enforcer_workaround-<version>.gem
+```
+
+
 
 Contributing
 ------------

data/features/compliant_browser.feature

@@ -7,7 +7,14 @@ Feature: Default browsers does not see a utf8 param.
     And I run a migration
 
   Scenario: 
-    Given I start the rails application
+    Given I write to "app/controllers/application_controller.rb" with:
+    """
+    class ApplicationController < ActionController::Base
+      protect_from_forgery
+      utf8_enforcer_workaround
+    end
+    """
+    And I start the rails application
     And I use a compliant browser
     When I go to the new user page
     Then there is no utf8 input tag

data/features/support/rails.rb

@@ -37,7 +37,7 @@ module RailsCommandHelpers
     when /^3/ then "rails new #{name} --skip-sprockets --skip-javascript"
     when /^4/ then "rails new #{name} --skip-sprockets --skip-javascript"
     when /^5/ then "rails new #{name} --skip-sprockets --skip-javascript"
-    else raise "No support for #{framework_version} yet, please open a FR on https://github.com/softace/utf8_enforcer_workaround/issues"
+    else raise "No support for rails #{framework_version}"
     end
   end
 
@@ -47,7 +47,7 @@ module RailsCommandHelpers
     when /^3/ then "script/rails generate"
     when /^4/ then "rails generate"
     when /^5/ then "rails generate"
-    else raise "No support for #{framework_version} yet, please open a FR on https://github.com/softace/utf8_enforcer_workaround/issues"
+    else raise "No support for rails #{framework_version}"
     end
   end
 
@@ -57,7 +57,7 @@ module RailsCommandHelpers
     when /^3/ then "script/rails runner"
     when /^4/ then "rails runner"
     when /^5/ then "rails runner"
-    else raise "No support for #{framework_version} yet, please open a FR on https://github.com/softace/utf8_enforcer_workaround/issues"
+    else raise "No support for rails #{framework_version}"
     end
   end
 end

data/lib/utf8_enforcer_workaround/action_controller/base.rb

@@ -4,16 +4,13 @@ module Utf8EnforcerWorkaround
   module ActionController
     module Base
       extend ActiveSupport::Concern
+
       module ClassMethods
         def utf8_enforcer_workaround
-          if ActionPack::VERSION::STRING < "5.0.0"
-            before_filter do
-              @utf8_enforcer_tag_enabled = browser.ie?
-            end
-          elsif ActionPack::VERSION::STRING >= "5.0.0"
-            before_action do
-              @utf8_enforcer_tag_enabled = browser.ie?
-            end
+          if ActionPack::VERSION::STRING < "4.0.0"
+            before_filter { @utf8_enforcer_tag_enabled = browser.ie? }
+          elsif ActionPack::VERSION::STRING >= "4.0.0"
+            before_action { @utf8_enforcer_tag_enabled = browser.ie? }
           end
         end
       end

data/lib/utf8_enforcer_workaround/action_view/helpers/form_tag_helper.rb

@@ -5,11 +5,7 @@ module Utf8EnforcerWorkaround
     module Helpers
       module FormTagHelper
         def utf8_enforcer_tag_with_tag_removed
-          if @utf8_enforcer_tag_enabled
-            utf8_enforcer_tag_without_tag_removed
-          else
-            "".html_safe
-          end
+          @utf8_enforcer_tag_enabled ? utf8_enforcer_tag_without_tag_removed : "".html_safe
         end
       end
     end
@@ -18,6 +14,7 @@ end
 
 ActionView::Helpers::FormTagHelper.class_eval do
   include Utf8EnforcerWorkaround::ActionView::Helpers::FormTagHelper
+
   alias_method :utf8_enforcer_tag_without_tag_removed, :utf8_enforcer_tag
   alias_method :utf8_enforcer_tag, :utf8_enforcer_tag_with_tag_removed
 end

data/lib/utf8_enforcer_workaround/version.rb

@@ -1,3 +1,3 @@
 module Utf8EnforcerWorkaround
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: utf8_enforcer_workaround
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Jarl Friis
@@ -28,22 +28,22 @@ dependencies:
   name: browser
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.1.0
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.1.0
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -210,7 +210,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubyforge_project: utf8_enforcer_workaround
+rubygems_version: 2.6.14.4
 signing_key: 
 specification_version: 4
 summary: Make utf8_enforcer to be applied only for non-standards-complying browsers.