usps_flags 0.3.26 → 0.4.0

data/spec/usps_flags/core_spec.rb

@@ -1,25 +1,27 @@
+# frozen_string_literal: false
+
 require 'spec_helper'
 
 describe USPSFlags::Core do
-  describe "trident_spec" do
-    ["Field", "Specification Heading Information", "Short Trident", "Delta Trident", "Circle Trident", "Long Trident"].each do |section|
+  describe 'trident_spec' do
+    ['Field', 'Specification Heading Information', 'Short Trident', 'Delta Trident', 'Circle Trident', 'Long Trident'].each do |section|
       it "should contain the #{section} section" do
         expect(USPSFlags::Core.trident_spec).to include("<!-- #{section} -->")
       end
     end
   end
 
-  describe "headers" do
-    ["?xml ", "!DOCTYPE", "svg ", "metadata"].each do |tag|
+  describe 'headers' do
+    ['?xml ', '!DOCTYPE', 'svg ', 'metadata'].each do |tag|
       it "should contain the #{tag} tag" do
         expect(USPSFlags::Core.headers).to include("<#{tag}")
       end
     end
   end
 
-  describe "footer" do
-    it "should contain the closing tag" do
-      expect(USPSFlags::Core.footer).to include("</svg>")
+  describe 'footer' do
+    it 'should contain the closing tag' do
+      expect(USPSFlags::Core.footer).to include('</svg>')
     end
   end
 
@@ -30,8 +32,8 @@ describe USPSFlags::Core do
     @blue = USPSFlags::Config::BLUE
   end
 
-  describe "field" do
-    it "should correctly generate the basic field" do
+  describe 'field' do
+    it 'should correctly generate the basic field' do
       expect(USPSFlags::Core.field).to eql(
         <<~SVG
           <path d="M 0 0
@@ -39,13 +41,12 @@ describe USPSFlags::Core do
             l 0 #{@hoist}
             l -#{@fly} 0
             l 0 -#{@hoist}
-          " fill="#FFFFFF" stroke="#000000" stroke-width="#{USPSFlags::Config::BASE_FLY/600}" />
+          " fill="#FFFFFF" stroke="#000000" stroke-width="#{USPSFlags::Config::BASE_FLY / 600}" />
         SVG
       )
     end
 
-    it "should correctly generate the red field" do
-      
+    it 'should correctly generate the red field' do
       expect(USPSFlags::Core.field(color: :red)).to eql(
         <<~SVG
           <path d="M 0 0
@@ -58,78 +59,78 @@ describe USPSFlags::Core do
       )
     end
 
-    it "should correctly generate the swallowtail field" do
+    it 'should correctly generate the swallowtail field' do
       expect(USPSFlags::Core.field(style: :swallowtail)).to eql(
         <<~SVG
           <path d="M 2 1
-            l #{@fly} #{@hoist/6}
-            l -#{@fly/5} #{@hoist/3}
-            l #{@fly/5} #{@hoist/3}
-            l -#{@fly} #{@hoist/6} z
-          " fill="#FFFFFF" stroke="#000000" stroke-width="#{USPSFlags::Config::BASE_FLY/600}" />
+            l #{@fly} #{@hoist / 6}
+            l -#{@fly / 5} #{@hoist / 3}
+            l #{@fly / 5} #{@hoist / 3}
+            l -#{@fly} #{@hoist / 6} z
+          " fill="#FFFFFF" stroke="#000000" stroke-width="#{USPSFlags::Config::BASE_FLY / 600}" />
         SVG
       )
     end
 
-    it "should correctly generate the blue past field" do
+    it 'should correctly generate the blue past field' do
       expect(USPSFlags::Core.field(style: :past, color: :blue)).to eql(
         <<~SVG
           <g transform="translate(2, 1)">
             <path d="M 0 5
-              l #{@fly/2} #{@hoist*1/12}
-              l 0 #{@hoist*10/12}
-              l -#{@fly/2} #{@hoist*1/12}
+              l #{@fly / 2} #{@hoist * 1 / 12}
+              l 0 #{@hoist * 10 / 12}
+              l -#{@fly / 2} #{@hoist * 1 / 12}
             " fill="#{@blue}" />
-            <path d="M #{@fly/2} #{@hoist*1/12}
-              l #{@fly/4} #{@hoist*1/24}
-              l 0 #{@hoist*9/12}
-              l -#{@fly/4} #{@hoist*1/24}
+            <path d="M #{@fly / 2} #{@hoist * 1 / 12}
+              l #{@fly / 4} #{@hoist * 1 / 24}
+              l 0 #{@hoist * 9 / 12}
+              l -#{@fly / 4} #{@hoist * 1 / 24}
             " fill="#FFFFFF" />
-            <path d="M #{@fly*3/4} #{@hoist*3/24}
-              l #{@fly/4} #{@hoist*1/24}
-              l -#{@fly/5} #{@hoist/3}
-              l #{@fly/5} #{@hoist/3}
-              l -#{@fly/4} #{@hoist*1/24}
+            <path d="M #{@fly * 3 / 4} #{@hoist * 3 / 24}
+              l #{@fly / 4} #{@hoist * 1 / 24}
+              l -#{@fly / 5} #{@hoist / 3}
+              l #{@fly / 5} #{@hoist / 3}
+              l -#{@fly / 4} #{@hoist * 1 / 24}
             " fill="#{@red}" />
             <path d="M 0 0
-              l #{@fly} #{@hoist/6}
-              l -#{@fly/5} #{@hoist/3}
-              l #{@fly/5} #{@hoist/3}
-              l -#{@fly} #{@hoist/6} z
-            " fill="none" stroke="#000000" stroke-width="#{USPSFlags::Config::BASE_FLY/600}" />
+              l #{@fly} #{@hoist / 6}
+              l -#{@fly / 5} #{@hoist / 3}
+              l #{@fly / 5} #{@hoist / 3}
+              l -#{@fly} #{@hoist / 6} z
+            " fill="none" stroke="#000000" stroke-width="#{USPSFlags::Config::BASE_FLY / 600}" />
           </g>
         SVG
       )
     end
   end
 
-  describe "trident" do
-    it "should correctly generate a short trident" do
-      expect(USPSFlags::Core.trident(:s)).to include("<path d=\"M #{@fly/2} #{@hoist/4}\n")
+  describe 'trident' do
+    it 'should correctly generate a short trident' do
+      expect(USPSFlags::Core.trident(:s)).to include("<path d=\"M #{@fly / 2} #{@hoist / 4}\n")
     end
 
-    it "should correctly generate a delta trident" do
-      expect(USPSFlags::Core.trident(:d)).to include("<g mask=\"url(#delta-mask)\"><path d=\"M #{@fly/2} #{@hoist*3/16}\n")
+    it 'should correctly generate a delta trident' do
+      expect(USPSFlags::Core.trident(:d)).to include("<g mask=\"url(#delta-mask)\"><path d=\"M #{@fly / 2} #{@hoist * 3 / 16}\n")
     end
 
-    it "should correctly generate a circle trident" do
-      expect(USPSFlags::Core.trident(:stf)).to include("<g mask=\"url(#circle-mask-for-main-spike)\"><path d=\"M #{@fly/2} #{@hoist/8}\n")
+    it 'should correctly generate a circle trident' do
+      expect(USPSFlags::Core.trident(:stf)).to include("<g mask=\"url(#circle-mask-for-main-spike)\"><path d=\"M #{@fly / 2} #{@hoist / 8}\n")
     end
 
-    it "should correctly generate a long trident" do
-      expect(USPSFlags::Core.trident(:n)).to include("<path d=\"M #{@fly/2} #{@hoist/8}\n")
+    it 'should correctly generate a long trident' do
+      expect(USPSFlags::Core.trident(:n)).to include("<path d=\"M #{@fly / 2} #{@hoist / 8}\n")
     end
   end
 
-  describe "anchor" do
-    it "should correctly generate an anchor" do
-      expect(USPSFlags::Core.anchor).to include("<mask id=\"anchor-mask\">")
+  describe 'anchor' do
+    it 'should correctly generate an anchor' do
+      expect(USPSFlags::Core.anchor).to include('<mask id="anchor-mask">')
     end
   end
 
-  describe "lighthouse" do
-    it "should correctly generate a lighthouse" do
-      expect(USPSFlags::Core.lighthouse).to include("<mask id=\"lighthouse-mask\">")
+  describe 'lighthouse' do
+    it 'should correctly generate a lighthouse' do
+      expect(USPSFlags::Core.lighthouse).to include('<mask id="lighthouse-mask">')
     end
   end
 end

data/spec/usps_flags/generate_spec.rb

@@ -1,15 +1,17 @@
+# frozen_string_literal: false
+
 require 'spec_helper'
 
 describe USPSFlags::Generate do
-  describe "general features" do
-    it "should generate a flag with the correct size" do
-      expect(USPSFlags::Generate.svg("LtC", outfile: "")).to include(
+  describe 'general features' do
+    it 'should generate a flag with the correct size' do
+      expect(USPSFlags::Generate.svg('LtC', outfile: '')).to include(
         'width="1024" height="682" viewBox="0 0 3072 2048"'
       )
     end
 
-    it "should generate a flag with the correct field" do
-      expect(USPSFlags::Generate.svg("LtC", outfile: "")).to include(
+    it 'should generate a flag with the correct field' do
+      expect(USPSFlags::Generate.svg('LtC', outfile: '')).to include(
         <<~SVG
           <path d="M 0 0
             l 3072 0
@@ -21,102 +23,110 @@ describe USPSFlags::Generate do
       )
     end
 
-    it "should generate a flag with the correct starting position" do
-      expect(USPSFlags::Generate.svg("LtC", outfile: "")).to include("<path d=\"M 1536 512")
+    it 'should generate a flag with the correct starting position' do
+      expect(USPSFlags::Generate.svg('LtC', outfile: '')).to include('<path d="M 1536 512')
     end
 
-    it "should generate a flag with the correct trident transformations" do
-      expect(USPSFlags::Generate.svg("LtC", outfile: "")).to include("<g transform=\"translate(-512)\">")
-      expect(USPSFlags::Generate.svg("LtC", outfile: "")).to include("<g transform=\"translate(512)\">")
+    it 'should generate a flag with the correct trident transformations' do
+      expect(USPSFlags::Generate.svg('LtC', outfile: '')).to include('<g transform="translate(-512)">')
+      expect(USPSFlags::Generate.svg('LtC', outfile: '')).to include('<g transform="translate(512)">')
     end
   end
 
-  describe "officer flags" do
+  describe 'officer flags' do
     [
-      "PLTC", "PC", "PDLTC", "PDC", "PSTFC", "PRC", "PVC", "PCC",
-      "PORTCAP", "FLEETCAP", "FLT", "DAIDE", "DFLT", "NAIDE", "NFLT",
-      "LT", "1LT", "LTC", "CDR", "DLT", "D1LT", "DLTC", "DC", "STFC", "RC", "VC", "CC"
+      'PLTC', 'PC', 'PDLTC', 'PDC', 'PSTFC', 'PRC', 'PVC', 'PCC',
+      'PORTCAP', 'FLEETCAP', 'FLT', 'DAIDE', 'DFLT', 'NAIDE', 'NFLT',
+      'LT', '1LT', 'LTC', 'CDR', 'DLT', 'D1LT', 'DLTC', 'DC', 'STFC', 'RC', 'VC', 'CC'
     ].each do |flag|
       it "should generate #{flag}" do
-        expect(USPSFlags::Generate.svg(flag, outfile: "")).to include("<title>#{flag}</title>")
+        expect(USPSFlags::Generate.svg(flag, outfile: '')).to include("<title>#{flag}</title>")
       end
     end
   end
 
-  describe "pennants" do
-    it "should generate the cruise pennant" do
-      expect(USPSFlags::Generate.svg("Cruise", outfile: "")).to include("<title>Cruise Pennant</title>")
+  describe 'pennants' do
+    it 'should generate the cruise pennant' do
+      expect(USPSFlags::Generate.svg('Cruise', outfile: '')).to include('<title>Cruise Pennant</title>')
     end
 
-    it "should generate the officer-in-charge pennant" do
-      expect(USPSFlags::Generate.svg("OIC", outfile: "")).to include("<title>Officer-in-Charge Pennant</title>")
+    it 'should generate the officer-in-charge pennant' do
+      expect(USPSFlags::Generate.svg('OIC', outfile: '')).to include('<title>Officer-in-Charge Pennant</title>')
     end
   end
 
-  describe "other flags" do
-    it "should generate US" do
-      expect(USPSFlags::Generate.svg("US", outfile: "")).to include("<title>US Ensign</title>")
+  describe 'other flags' do
+    it 'should generate US' do
+      expect(USPSFlags::Generate.svg('US', outfile: '')).to include('<title>US Ensign</title>')
     end
 
-    it "should generate USPS Ensign" do
-      expect(USPSFlags::Generate.svg("Ensign", outfile: "")).to include("<title>USPS Ensign</title>")
+    it 'should generate USPS Ensign' do
+      expect(USPSFlags::Generate.svg('Ensign', outfile: '')).to include('<title>USPS Ensign</title>')
     end
 
-    it "should generate the USPS Wheel logo" do
-      expect(USPSFlags::Generate.svg("Wheel", outfile: "")).to include("<title>USPS Ensign Wheel</title>")
+    it 'should generate the USPS Wheel logo' do
+      expect(USPSFlags::Generate.svg('Wheel', outfile: '')).to include('<title>USPS Ensign Wheel</title>')
     end
   end
 
-  describe "trident specifications" do
-    it "should generate the trident specification sheet" do
-      expect(USPSFlags::Generate.spec(outfile: "")).to include("<title>USPS Trident Specifications</title>")
+  describe 'trident specifications' do
+    it 'should generate the trident specification sheet' do
+      expect(USPSFlags::Generate.spec(outfile: '')).to include('<title>USPS Trident Specifications</title>')
     end
 
-    it "should generate the trident specification sheet with a scaled border" do
-      expect(USPSFlags::Generate.spec(outfile: "", scaled_border: true)).to include("<title>USPS Trident Specifications</title>")
+    it 'should generate the trident specification sheet with a scaled border' do
+      expect(USPSFlags::Generate.spec(outfile: '', scaled_border: true)).to include('<title>USPS Trident Specifications</title>')
     end
 
-    it "should generate the trident specification sheet with a fractional field size" do
-      expect(USPSFlags::Generate.spec(outfile: "", fly: 23.5)).to include("<title>USPS Trident Specifications</title>")
+    it 'should generate the trident specification sheet with a fractional field size' do
+      expect(USPSFlags::Generate.spec(outfile: '', fly: 23.5)).to include('<title>USPS Trident Specifications</title>')
     end
   end
 
-  describe "png" do
+  describe 'png' do
     before(:each) do
-      @svg = USPSFlags::Generate.svg("LtC", outfile: "")
+      @svg = USPSFlags::Generate.svg('LtC', outfile: '')
+    end
+
+    it 'should raise PNGGenerationError without an outfile' do
+      expect { USPSFlags::Generate.png(@svg, outfile: '') }.to raise_error(USPSFlags::Errors::PNGGenerationError)
     end
 
-    it "should raise PNGGenerationError without an outfile" do
-      expect { USPSFlags::Generate.png(@svg, outfile: "") }.to raise_error(USPSFlags::Errors::PNGGenerationError)
+    it 'should contain the SVG when raising PNGGenerationError without an outfile' do
+      begin
+        USPSFlags::Generate.png(@svg, outfile: '')
+      rescue => e
+        expect(e.svg).to eql(@svg)
+      end
     end
 
-    it "should not raise PNGGenerationError when correctly configured" do
-      expect { USPSFlags::Generate.png(@svg, outfile: "lib/output/PNG/LTC.png") }.to_not raise_error(USPSFlags::Errors::PNGGenerationError)
+    it 'should not raise PNGGenerationError when correctly configured' do
+      expect { USPSFlags::Generate.png(@svg, outfile: 'lib/output/PNG/LTC.png') }.to_not raise_error(USPSFlags::Errors::PNGGenerationError)
     end
   end
 
-  describe "without an outfile set" do
-    it "should print SVG data to the console" do
-      expect(STDOUT).to receive(:puts).with(USPSFlags::Generate.svg("Lt", outfile: ""), "\n")
-      USPSFlags::Generate.svg("Lt")
+  describe 'without an outfile set' do
+    it 'should print SVG data to the console' do
+      expect(STDOUT).to receive(:puts).with(USPSFlags::Generate.svg('Lt', outfile: ''), "\n")
+      USPSFlags::Generate.svg('Lt')
     end
   end
 
-  describe "static files errors" do
-    it "should raise USPSFlags::Errors::StaticFilesGenerationError when not given any true arguments" do
+  describe 'static files errors' do
+    it 'should raise USPSFlags::Errors::StaticFilesGenerationError when not given any true arguments' do
       expect { USPSFlags::Generate.all(svg: false, png: false, zips: false, reset: false) }.to raise_error(
-        USPSFlags::Errors::StaticFilesGenerationError, "At least one argument switch must be true out of [svg, png, zips, reset]."
+        USPSFlags::Errors::StaticFilesGenerationError, 'At least one argument switch must be true out of [svg, png, zips, reset].'
       )
     end
 
-    it "should raise USPSFlags::Errors::ZipGenerationError when not given any true arguments" do
+    it 'should raise USPSFlags::Errors::ZipGenerationError when not given any true arguments' do
       expect { USPSFlags::Generate.zips(svg: false, png: false) }.to raise_error(
-        USPSFlags::Errors::ZipGenerationError, "At least one argument switch must be true out of [svg, png]."
+        USPSFlags::Errors::ZipGenerationError, 'At least one argument switch must be true out of [svg, png].'
       )
     end
   end
 
-  describe "static files generation", slow: true do
+  describe 'static files generation', slow: true do
     before(:all) do
       svg_dir = "#{USPSFlags.configuration.flags_dir}/SVG"
       png_dir = "#{USPSFlags.configuration.flags_dir}/PNG"
@@ -130,22 +140,22 @@ describe USPSFlags::Generate do
 
       USPSFlags::Generate.svg(@svg_flag, outfile: "#{svg_dir}/#{@svg_flag}.svg")
       USPSFlags::Generate.svg(@svg_ins_flag, field: false, outfile: "#{svg_dir}/insignia/#{@svg_ins_flag}.svg")
-      USPSFlags::Generate.png(USPSFlags::Generate.svg(@png_flag, outfile: ""), outfile: "#{png_dir}/#{@png_flag}.png")
-      USPSFlags::Generate.png(USPSFlags::Generate.svg(@png_ins_flag, field: false, outfile: ""), trim: true, outfile: "#{png_dir}/insignia/#{@png_ins_flag}.png")
-      USPSFlags::Generate.png(USPSFlags::Generate.svg(@thb_flag, field: false, outfile: ""), trim: true, outfile: "#{png_dir}/insignia/#{@thb_flag}.png")
-      USPSFlags::Helpers.resize_png("#{png_dir}/insignia/#{@thb_flag}.png", file: "insignia/#{@thb_flag}", size: 150, size_key: "thumb")
+      USPSFlags::Generate.png(USPSFlags::Generate.svg(@png_flag, outfile: ''), outfile: "#{png_dir}/#{@png_flag}.png")
+      USPSFlags::Generate.png(USPSFlags::Generate.svg(@png_ins_flag, field: false, outfile: ''), trim: true, outfile: "#{png_dir}/insignia/#{@png_ins_flag}.png")
+      USPSFlags::Generate.png(USPSFlags::Generate.svg(@thb_flag, field: false, outfile: ''), trim: true, outfile: "#{png_dir}/insignia/#{@thb_flag}.png")
+      USPSFlags::Helpers.resize_png("#{png_dir}/insignia/#{@thb_flag}.png", file: "insignia/#{@thb_flag}", size: 150, size_key: 'thumb')
     end
 
-    it "should not raise an error while generating all static files" do
+    it 'should not raise an error while generating all static files' do
       expect { USPSFlags::Generate.all(reset: false) }.to_not raise_error # (USPSFlags::Errors::StaticFilesGenerationError)
     end
 
-    describe "generation logs" do
+    describe 'generation logs' do
       before(:each) do
         @log_contents = ::File.read("#{USPSFlags.configuration.log_path}/flag.log")
       end
 
-      it "should have generated the correct log output" do
+      it 'should have generated the correct log output' do
         correct_log_pattern = <<~LOG
               Flag | SVG | PNG        | Run time
           ---------------------------------------
@@ -197,7 +207,7 @@ describe USPSFlags::Generate do
         expect(@log_contents).to match(correct_log_regexp)
       end
 
-      it "should not match an incorrect log output" do
+      it 'should not match an incorrect log output' do
         incorrect_log_pattern = 'PLTC \| --  \| ---------- \| .*{3,6} s'
 
         incorrect_log_regexp = Regexp.new(incorrect_log_pattern)
@@ -206,11 +216,11 @@ describe USPSFlags::Generate do
       end
     end
 
-    it "should not raise an error while clearing all static files" do
+    it 'should not raise an error while clearing all static files' do
       expect { USPSFlags::Generate.all(svg: false, png: false, zips: false, reset: true) }.to_not raise_error # (USPSFlags::Errors::StaticFilesGenerationError)
     end
 
-    it "should not raise an error while generating zip files" do
+    it 'should not raise an error while generating zip files' do
       expect { USPSFlags::Generate.zips }.to_not raise_error # (USPSFlags::Errors::ZipGenerationError)
     end
   end

data/spec/usps_flags/helpers_spec.rb

@@ -1,30 +1,32 @@
+# frozen_string_literal: false
+
 require 'spec_helper'
 
 describe USPSFlags::Helpers do
-  describe "valid_flags" do
-    it "should return an Array" do
+  describe 'valid_flags' do
+    it 'should return an Array' do
       expect(USPSFlags::Helpers.valid_flags).to be_an(Array)
     end
 
-    it "should return all officer flags but nothing else when given type :officer" do
+    it 'should return all officer flags but nothing else when given type :officer' do
       expect(USPSFlags::Helpers.valid_flags(:officer).sort).to eql(%w[
         PLTC PC PORTCAP FLEETCAP LT FLT 1LT LTC CDR PDLTC PDC DLT DAIDE
         DFLT D1LT DLTC DC PSTFC PRC PVC PCC NAIDE NFLT STFC RC VC CC
       ].sort)
     end
 
-    it "should correctly generate the grid helper" do
-      expect(USPSFlags::Helpers::Builders.grid).to include("<circle cx=\"0\" cy=\"0\" r=\"#{USPSFlags::Config::BASE_FLY/60}\" fill=\"#000000\" fill-opacity=\"0.4\" />")
+    it 'should correctly generate the grid helper' do
+      expect(USPSFlags::Helpers::Builders.grid).to include("<circle cx=\"0\" cy=\"0\" r=\"#{USPSFlags::Config::BASE_FLY / 60}\" fill=\"#000000\" fill-opacity=\"0.4\" />")
     end
 
-    it "should correctly generate the locator helper" do
-      expect(USPSFlags::Helpers::Builders.locator).to include("<rect x=\"0\" y=\"0\" width=\"#{USPSFlags::Config::BASE_FLY/30}\" height=\"#{USPSFlags::Config::BASE_FLY/30}\" fill=\"#333333\" fill-opacity=\"0.6\" />")
+    it 'should correctly generate the locator helper' do
+      expect(USPSFlags::Helpers::Builders.locator).to include("<rect x=\"0\" y=\"0\" width=\"#{USPSFlags::Config::BASE_FLY / 30}\" height=\"#{USPSFlags::Config::BASE_FLY / 30}\" fill=\"#333333\" fill-opacity=\"0.6\" />")
     end
   end
 
-  describe "resize_png" do
-    it "should raise USPSFlags::Errors::PNGConversionError with invalid parameters" do
-      expect { USPSFlags::Helpers.resize_png("path/to/image.png", size: 100, size_key: "thumb") }.to raise_error(USPSFlags::Errors::PNGConversionError)
+  describe 'resize_png' do
+    it 'should raise USPSFlags::Errors::PNGConversionError with invalid parameters' do
+      expect { USPSFlags::Helpers.resize_png('path/to/image.png', size: 100, size_key: 'thumb') }.to raise_error(USPSFlags::Errors::PNGConversionError)
     end
   end
 end