usps-imis-api 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0e1d3316b4676bae03e67aa927632ec91801a6d703c55049c1b11013a20c3e08
-  data.tar.gz: 8199c664875cc57e995d73b3a96ce03cd9de2e5460e7a451553df3bb5ca3ff84
+  metadata.gz: ea2c1c51fb9d73e9aa4dc60f4be57c72443f9d2f4e16fcd8e572af8e1b7c58e6
+  data.tar.gz: ffd74ed752fe1cfc9f0c0eaeb166e1d13bf75cf40d0b07bafaa9ce1de5b09c49
 SHA512:
-  metadata.gz: 7015ffe22161d1645959004798ed1fde3e65a66db6695dac75ae84db13177a376a37b083f74abdd9092108ba33d9d0f09fcbaaaa845d861d50af237c77c819b2
-  data.tar.gz: 940e05eeeeea390c67e207f4ace40c6befed6dbe355efdc38e3fa6d270c35f6bf5c48c3093808c505c2b26e9f452000ecd384e250451bc8263cce84d43a78238
+  metadata.gz: e3fad87c5d7fa1c3bfa8c0140304b39e7df21d5e9abdc5234a183a1175409c5f42fe8e65f8e53975b127f15004a65aa988d533ce68ed56d3867d470f28353b2b
+  data.tar.gz: 872e0e9a73136a6166a5c585c8286d106e3d81758e2eccdbc8f8a1b1fc2d845883680e54323ffbd5902f599cbcc685be611ff1edf62c917d5e42b5ec92ba79ef

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    usps-imis-api (0.8.0)
+    usps-imis-api (0.8.1)
       activesupport (~> 8.0)
 
 GEM

data/Readme.md

@@ -120,7 +120,7 @@ To fetch a specific field from member data, run e.g.:
 tot_mms = api.on('ABC_ASC_Individual_Demog').get_field('TotMMS')
 ```
 
-You can also access fields directly on the Business Object like a Hash:
+You can also access fields directly on the Business Object or Panel like a Hash:
 
 ```ruby
 tot_mms = api.on('ABC_ASC_Individual_Demog')['TotMMS']
@@ -229,9 +229,9 @@ vsc.get(1417)
 
 # All of these options are identical
 #
-vsc.get(1417, 'Quantity')
+vsc.get(1417, 'Quantity').first
 vsc.get(1417)['Quantity']
-vsc.get[1417, 'Quantity']
+vsc[1417, 'Quantity']
 vsc.get(1417).raw['Properties']['$values'].find { it['Name'] == 'Quantity' }['Value']['$value']
 vsc.get_field(1417, 'Quantity')
 
@@ -244,7 +244,7 @@ created = vsc.create(certificate: 'E136924', year: 2024, count: 42)
 ordinal = created.ordinal
 ordinal = created['Ordinal']
 ordinal = created.raw['Properties']['$values'].find { it['Name'] == 'Ordinal' }['Value']['$value']
-ordinal = created.raw['Identity']['IdentityElements']['$values'][1] # Value is duplicated here
+ordinal = created.raw['Identity']['IdentityElements']['$values'][1].to_i # Value is duplicated here
 
 vsc.update(certificate: 'E136924', year: 2024, count: 43, ordinal: ordinal)
 

data/lib/usps/imis/api.rb

@@ -54,7 +54,7 @@ module Usps
       def imis_id=(id)
         raise Errors::LockedIdError if lock_imis_id
 
-        @imis_id = id&.to_i&.to_s
+        @imis_id = id&.to_i
       end
 
       # Convert a member's certificate number into an iMIS ID number
@@ -68,7 +68,7 @@ module Usps
 
         begin
           result = query(Imis.configuration.imis_id_query_name, { certificate: })
-          @imis_id = result['Items']['$values'][0]['ID']
+          @imis_id = result['Items']['$values'][0]['ID'].to_i
         rescue StandardError
           raise Errors::NotFoundError, 'Member not found'
         end

data/lib/usps/imis/business_object.rb

@@ -120,7 +120,7 @@ module Usps
         return CGI.escape(id) unless id.nil?
         return CGI.escape("~#{api.imis_id}|#{ordinal}") if ordinal
 
-        api.imis_id
+        api.imis_id.to_s
       end
 
       # Manually assemble the matching data structure, with fields in the correct order

data/lib/usps/imis/data.rb

@@ -18,12 +18,12 @@ module Usps
 
       # Access the iMIS ID property
       #
-      def imis_id = self['ID']
+      def imis_id = self['ID'].to_i
       alias id imis_id
 
       # Access the Ordinal identifier property (if present)
       #
-      def ordinal = self['Ordinal']
+      def ordinal = self['Ordinal']&.to_i
 
       # Access an individual property value by name
       #

data/lib/usps/imis/panels/base_panel.rb

@@ -113,7 +113,7 @@ module Usps
             'EntityTypeName' => business_object,
             'IdentityElements' => {
               '$type' => identity_type,
-              '$values' => [api.imis_id, ordinal&.to_s].compact
+              '$values' => [api.imis_id.to_s, ordinal&.to_s].compact
             }
           }
         end
@@ -124,7 +124,7 @@ module Usps
             'EntityTypeName' => 'Party',
             'IdentityElements' => {
               '$type' => identity_type,
-              '$values' => [api.imis_id]
+              '$values' => [api.imis_id.to_s]
             }
           }
         end

data/lib/usps/imis/panels/education.rb

@@ -14,7 +14,7 @@ module Usps
 
         def payload(data)
           build_payload(data) do |props|
-            props.add 'ID', api.imis_id
+            props.add 'ID', api.imis_id.to_s
             props.add 'Ordinal', data[:ordinal] if data[:ordinal]
             props.add 'ABC_EDUC_THRU_DATE', data[:thru_date] || '0001-01-01T00:00:00'
             props.add 'ABC_ECertificate', data[:certificate]

data/lib/usps/imis/panels/vsc.rb

@@ -14,7 +14,7 @@ module Usps
 
         def payload(data)
           build_payload(data) do |props|
-            props.add 'ID', api.imis_id
+            props.add 'ID', api.imis_id.to_s
             props.add 'Ordinal', data[:ordinal] if data[:ordinal]
             props.add 'Source_System', 'Manual ITCom Entry'
             props.add 'ABC_ECertificate', data[:certificate]

data/lib/usps/imis/version.rb

@@ -2,6 +2,6 @@
 
 module Usps
   module Imis
-    VERSION = '0.8.0'
+    VERSION = '0.8.1'
   end
 end

data/spec/lib/usps/imis/api_spec.rb

@@ -17,13 +17,13 @@ describe Usps::Imis::Api do
     it 'stores the initial imis_id' do
       api = described_class.new(imis_id: 42)
 
-      expect(api.imis_id).to eq('42')
+      expect(api.imis_id).to eq(42)
     end
   end
 
   describe '#imis_id_for' do
     it 'gets the iMIS ID' do
-      expect(api.imis_id_for('E231625')).to eq('31092')
+      expect(api.imis_id_for('E231625')).to eq(31092)
     end
 
     context 'with a query error' do
@@ -133,7 +133,7 @@ describe Usps::Imis::Api do
       end
 
       expect(result).to be_a(Hash)
-      expect(api.imis_id).to eq('31092')
+      expect(api.imis_id).to eq(31092)
     end
 
     it 'nests on and with', :aggregate_failures do

data/spec/lib/usps/imis/data_spec.rb

@@ -24,7 +24,7 @@ describe Usps::Imis::Data do
 
   describe '#inspect' do
     it 'generates the correct inspect string' do
-      expect(data.inspect).to eq('#<Usps::Imis::Data entity_type_name="ABC_ASC_Individual_Demog" imis_id="31092">')
+      expect(data.inspect).to eq('#<Usps::Imis::Data entity_type_name="ABC_ASC_Individual_Demog" imis_id=31092>')
     end
 
     context 'with data from a Panel' do
@@ -44,7 +44,7 @@ describe Usps::Imis::Data do
 
       it 'generates the correct inspect string with an ordinal' do
         expect(data.inspect).to eq(
-          '#<Usps::Imis::Data entity_type_name="ABC_ASC_Individual_Demog" imis_id="31092" ordinal="99">'
+          '#<Usps::Imis::Data entity_type_name="ABC_ASC_Individual_Demog" imis_id=31092 ordinal=99>'
         )
       end
     end

data/spec/lib/usps/imis/mapper_spec.rb

@@ -9,7 +9,7 @@ describe Usps::Imis::Mapper do
     it 'stores the initial imis_id' do
       mapper = described_class.new(imis_id: 42)
 
-      expect(mapper.api.imis_id).to eq('42')
+      expect(mapper.api.imis_id).to eq(42)
     end
   end
 

data/spec/lib/usps/imis/panels/education_spec.rb

@@ -64,7 +64,7 @@ describe Usps::Imis::Panels::Education do
     it 'can initialize with an iMIS ID' do
       panel = described_class.new(imis_id: 6374)
 
-      expect(panel.api.imis_id).to eq('6374')
+      expect(panel.api.imis_id).to eq(6374)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: usps-imis-api
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Julian Fiander